[{"id":1763029,"web_url":"http://patchwork.ozlabs.org/comment/1763029/","msgid":"<4d820097-32bd-6f74-8f19-c13c2a1ec083@redhat.com>","list_archive_url":null,"date":"2017-09-05T07:43:48","subject":"Re: [Qemu-devel] [PATCH v6 03/29] test-qga: Kill broken and dead\n\tQGA_TEST_SIDE_EFFECTING code","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 01.09.2017 20:03, Eric Blake wrote:\n> Back when the test was introduced, in commit 62c39b307, the\n> test was set up to run qemu-ga directly on the host performing\n> the test, and defaults to limiting itself to safe commands. At\n> the time, it was envisioned that setting QGA_TEST_SIDE_EFFECTING\n> in the environment could cover a few more commands, while noting\n> the potential danger of those side effects running in the host.\n> \n> But this has NEVER been tested: if you enable the environment\n> variable, the test WILL fail. One obvious reason: if you are not\n> running as root, you'll probably get a permission failure when\n> trying to freeze the file systems, or when changing system time.\n> Less obvious: if you run the test as root (wow, you're brave), you\n> could end up hanging if the test tries to log things to a\n> temporarily frozen filesystem. But the cutest reason of all: if\n> you get past the above hurdles, the test uses invalid JSON in\n> test_qga_fstrim() (missing '' around the dictionary key 'minimum'),\n> and will thus fail an assertion in qmp_fd().\n> \n> Rather than leave this untested time-bomb in place, rip it out.\n> Hopefully, as originally envisioned, we can find an opportunity\n> to test an actual sandboxed guest where the guest-agent has\n> full permissions and will not unduly affect the host running\n> the test - if so, 'git revert' can be used if desired, for\n> salvaging any useful parts of this attempt.\n> \n> Signed-off-by: Eric Blake \n> Reviewed-by: Marc-André Lureau \n> ---\n> tests/test-qga.c | 90 --------------------------------------------------------\n> 1 file changed, 90 deletions(-)\n\nReviewed-by: Thomas Huth ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmdyg5jH7z9s83\n\tfor ;\n\tTue, 5 Sep 2017 17:44:26 +1000 (AEST)","from localhost ([::1]:57280 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dp8X1-000360-4c\n\tfor incoming@patchwork.ozlabs.org; Tue, 05 Sep 2017 03:44:23 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:55042)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dp8Wb-00035Y-L4\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 03:44:02 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dp8WW-0001vg-V3\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 03:43:57 -0400","from mx1.redhat.com ([209.132.183.28]:36952)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dp8WW-0001uZ-OS\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 03:43:52 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 714C067745\n\tfor ; Tue, 5 Sep 2017 07:43:51 +0000 (UTC)","from [10.36.116.114] (ovpn-116-114.ams2.redhat.com [10.36.116.114])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 74833812E1;\n\tTue, 5 Sep 2017 07:43:50 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 714C067745","To":"Eric Blake , qemu-devel@nongnu.org","References":"<20170901180340.30009-1-eblake@redhat.com>\n\t<20170901180340.30009-4-eblake@redhat.com>","From":"Thomas Huth ","Message-ID":"<4d820097-32bd-6f74-8f19-c13c2a1ec083@redhat.com>","Date":"Tue, 5 Sep 2017 09:43:48 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170901180340.30009-4-eblake@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tTue, 05 Sep 2017 07:43:51 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v6 03/29] test-qga: Kill broken and dead\n\tQGA_TEST_SIDE_EFFECTING code","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pbonzini@redhat.com, armbru@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]