[{"id":1778094,"web_url":"http://patchwork.ozlabs.org/comment/1778094/","msgid":"","list_archive_url":null,"date":"2017-10-01T22:31:15","subject":"Re: [PATCH 27/58] Hide internal __ioctl function [BZ #18822]","submitter":{"id":4387,"url":"http://patchwork.ozlabs.org/api/people/4387/","name":"H.J. Lu","email":"hjl.tools@gmail.com"},"content":"On 9/1/17, H.J. Lu wrote:\n> Hide internal __ioctl function to allow direct access within libc.so and\n> libc.a without using GOT nor PLT.\n>\n> __GI___ioctl is defined when sysdeps/unix/syscalls.list is used to\n> generate ioctl. Otherwise libc_hidden_def is needed explicitly.\n>\n> \t[BZ #18822]\n> \t* include/sys/ioctl.h (__ioctl): Add libc_hidden_proto.\n> \t* misc/ioctl.c (__ioctl): Add libc_hidden_def.\n> \t* sysdeps/mach/hurd/ioctl.c (__ioctl): Likewise.\n> \t* sysdeps/unix/sysv/linux/aarch64/ioctl.S (__ioctl): Likewise.\n> \t* sysdeps/unix/sysv/linux/mips/mips64/n64/ioctl.S (__ioctl):\n> \tLikewise.\n> \t* sysdeps/unix/sysv/linux/powerpc/ioctl.c (__ioctl): Likewise.\n> \t* sysdeps/unix/sysv/linux/tile/tilegx/ioctl.S (__ioctl): Likewise.\n\nTested with build-many-glibcs.py. I am checking it in.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-85214-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"LXaF+iN8\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y50Q73KnYz9t2m\n\tfor ;\n\tMon, 2 Oct 2017 09:31:27 +1100 (AEDT)","(qmail 10523 invoked by alias); 1 Oct 2017 22:31:19 -0000","(qmail 10511 invoked by uid 89); 1 Oct 2017 22:31:19 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:content-type; q=dns; s=default; b=fMbXo36\n\tfbqsI5IqzI9fqWCaogab6xqM9UZ5YMCTxc1e5Trzp89Pw03Zt1lamdjp2Cdis8R0\n\twP0JKBCSb3iOzBfiVXd/IafD+omWp3ccoNxPUCRnwP4wxD+3ZYugUrg1LvIeiC8V\n\tOt+klzZtfVwPqjfmlA/XhqjxyRVc3OU0QfGA=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:content-type; s=default; bh=HfoYxk33FlX8I\n\tjgAKd983+u8DJo=; b=LXaF+iN8MW6uumJLp1WpQnT0ss++I0i3bEHOFgPb1hu0R\n\te15WZxaIvAJKLb6evy+DJMIosf4yD6Zf1JEVw9X2lgrw4s6ppYopsDOspXIEh8fK\n\tMTYyJ1OMRUqCpd4qfb5WiVi23c4m1xkF1mczuarcqjs2o0KCBA2w+NfS9gCAkY=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-2.5 required=5.0 tests=AWL, BAYES_00,\n\tFREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM,\n\tSPF_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:871","X-HELO":"mail-oi0-f67.google.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to;\n\tbh=qKdoueiGq5UgcPnIgPKq2oBw9rYmTEPrKIspXoGFFTU=;\n\tb=d/pMvxYuhpW/CUw1IfYw6dps/0Q/shpuEy4EgA0U9XJjPEPhsu5clX5OsghUuCKTU6\n\t9o5EYDLvgPwPctabNUYaDnvqppBaxRmi0NXrEJXFQfoNOA3YK6gt/pMQWdI2kdo73UkY\n\tuvBKZX2V+VaW8av97K6DdqlrKlhZ1ddun5nhN9k5ko1054BvLO9TgxJ7ciTwzj7wMLiB\n\tBqRXsljn14XTRImVC04SgJ4oUfcCjuklk3QQ0WXJ79Mmk2wMEDoKsrNNjHXE8xVBoSLa\n\tE3mIg6M88aCrgdDGvdyFZaBfmXEqF3TkUbwGVhxTlm4W7JNDQBt0wNY/b2e+zueW/ctt\n\tuQOQ==","X-Gm-Message-State":"AMCzsaVKnYVFRWqnDU/cgpJ+wfoVF3PW/4mMFr/LnJTt8v51Iy+Ptv5A\n\ttCD7yVQEchDKGH04B5w24lYuUbm5/EJ3/ZeMv4Q=","X-Google-Smtp-Source":"AOwi7QCxbEcFwLVBpYAOIEthrRC/2cla7ja0IyZdTuubONL4GoZDlmjAryrP/oO3pAywzgkqkIdvtSuYN9Om5Mq69ME=","X-Received":"by 10.157.10.129 with SMTP id 1mr6349424otq.201.1506897076427;\n\tSun, 01 Oct 2017 15:31:16 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170901180029.9527-28-hjl.tools@gmail.com>","References":"<20170901180029.9527-1-hjl.tools@gmail.com>\n\t<20170901180029.9527-28-hjl.tools@gmail.com>","From":"\"H.J. Lu\" ","Date":"Sun, 1 Oct 2017 15:31:15 -0700","Message-ID":"","Subject":"Re: [PATCH 27/58] Hide internal __ioctl function [BZ #18822]","To":"libc-alpha@sourceware.org","Content-Type":"text/plain; charset=\"UTF-8\""}}]