[{"id":1762504,"web_url":"http://patchwork.ozlabs.org/comment/1762504/","msgid":"<381b1398-52e8-9413-d40f-ee21d5396e17@redhat.com>","list_archive_url":null,"date":"2017-09-04T08:02:05","subject":"Re: [PATCH 24/58] Hide __chmod and __mkdir [BZ #18822]","submitter":{"id":14312,"url":"http://patchwork.ozlabs.org/api/people/14312/","name":"Florian Weimer","email":"fweimer@redhat.com"},"content":"On 09/01/2017 07:59 PM, H.J. Lu wrote:\n> Hide internal __chmod and __mkdir functions to allow direct access\n> within libc.so and libc.a without using GOT nor PLT.\n> \n> \t[BZ #18822]\n> \t* include/sys/stat.h (__chmod): Add libc_hidden_proto.\n> \t(__mkdir): Likewise.\n> \t* io/chmod.c (__chmod): Add libc_hidden_def.\n> \t* io/mkdir.c (__mkdir): Likewise.\n> \t* sysdeps/mach/hurd/chmod.c (__chmod): Likewise.\n> \t* sysdeps/mach/hurd/mkdir.c (__mkdir): Likewise.\n> \t* sysdeps/unix/sysv/linux/generic/chmod.c (__chmod): Likewise.\n> \t* sysdeps/unix/sysv/linux/generic/mkdir.c (__mkdir): Likewise.\n\nLooks good to me.\n\nThanks,\nFlorian","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84154-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"R6HrvHO8\"; dkim-atps=neutral","sourceware.org; auth=none","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=fweimer@redhat.com"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xm2TY4p6Kz9sDB\n\tfor ;\n\tMon, 4 Sep 2017 18:05:37 +1000 (AEST)","(qmail 35734 invoked by alias); 4 Sep 2017 08:05:29 -0000","(qmail 99063 invoked by uid 89); 4 Sep 2017 08:02:13 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; q=dns; s=default; b=M5hD+eAHgjeqDJKk\n\tnJhRFiKVK6hc9T8hEkeyIIz1B6AV5X/F8QWw9c/0wQJGxtOjkWd06g+W66DkJqJC\n\t99nta+TX8h4lEMtOmFtMN1v6DgNqThZLwz+0VmdRsKldxE+fZnZoqB6wztKbKclY\n\tt2/BJesBmDW8F9DSmmknscNtqO4=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; s=default; bh=ai30obLgfrQvlpckO++/tT\n\t/oTRI=; b=R6HrvHO8Aco3q9SvM0ETinp8mh8IOMDz9F+H3UFjvGyzgLOIy7ltVh\n\tEYqyrH9TP3CZVPu8sOi3L9yMSN8osemfpui6qUlW8vuL5vsPLfqDdG4SnJGLfST8\n\tVmV+0A2XMysqs/EkhxQ1ujLVb3mTHLG5hMvYOosnwWGqwbYpfH3S4=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-0.9 required=5.0 tests=BAYES_00,\n\tKAM_LAZY_DOMAIN_SECURITY, RP_MATCHES_RCVD,\n\tSPF_HELO_PASS autolearn=no version=3.3.2 spammy=","X-HELO":"mx1.redhat.com","DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com B01AC81E1A","Subject":"Re: [PATCH 24/58] Hide __chmod and __mkdir [BZ #18822]","To":"\"H.J. Lu\" , libc-alpha@sourceware.org","References":"<20170901180029.9527-1-hjl.tools@gmail.com>\n\t<20170901180029.9527-25-hjl.tools@gmail.com>","From":"Florian Weimer ","Message-ID":"<381b1398-52e8-9413-d40f-ee21d5396e17@redhat.com>","Date":"Mon, 4 Sep 2017 10:02:05 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170901180029.9527-25-hjl.tools@gmail.com>","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"7bit"}}]