[{"id":1778088,"web_url":"http://patchwork.ozlabs.org/comment/1778088/","msgid":"","list_archive_url":null,"date":"2017-10-01T22:23:32","subject":"Re: [PATCH 17/58] Mark internal dirent functions with\n\tattribute_hidden [BZ #18822]","submitter":{"id":4387,"url":"http://patchwork.ozlabs.org/api/people/4387/","name":"H.J. Lu","email":"hjl.tools@gmail.com"},"content":"On 9/1/17, H.J. Lu wrote:\n> Mark internal dirent functions with attribute_hidden to allow direct\n> access within libc.so and libc.a without using GOT nor PLT. __readdir64\n> is hidden with libc_hidden_proto and libc_hidden_def since the exported\n> readdir64 is an alias of __readdir64.\n>\n> \t[BZ #18822]\n> \t* include/dirent.h (__opendir): Always add attribute_hidden.\n> \t(__fdopendir): Likewise.\n> \t(__closedir): Likewise.\n> \t(__readdir): Likewise.\n> \t(__readdir64): Add libc_hidden_proto.\n> \t* sysdeps/mach/hurd/readdir64.c (__readdir64): Add libc_hidden_def.\n> \t* sysdeps/unix/sysv/linux/i386/readdir64.c (__readdir64): Likewise.\n> \t* sysdeps/unix/sysv/linux/readdir64.c (__readdir64): Likewise.\n> \t* sysdeps/unix/sysv/linux/wordsize-64/readdir.c (__GI___readdir64):\n> \tNew alias.\n\nTested with build-many-glibcs.py. I am checking it in.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-85208-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"wfl/19Hf\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y50FD2ZhQz9t2m\n\tfor ;\n\tMon, 2 Oct 2017 09:23:44 +1100 (AEDT)","(qmail 15325 invoked by alias); 1 Oct 2017 22:23:36 -0000","(qmail 15314 invoked by uid 89); 1 Oct 2017 22:23:36 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:content-type; q=dns; s=default; b=WKeBdf5\n\t2rwgrOYf7QRVru0KJpgfnwHWmDxj5MX8IJGtl1NxkWxLoSbIjPHMKmDYE25f4v+4\n\tFoM3yMYFwTM9DLiOE20GL2/72uWd3sZIgdB2QV3gB0SYyIlc2yzqL6JThpWjH3bd\n\tV/JTRSQGNyoJISWX91j3ZvviiCQW11Rj3Vs8=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:content-type; s=default; bh=q4MSS0kE/K5DH\n\tTHwNZYtZop26oE=; b=wfl/19HfqdcXx/Ch6FrG1fNOA145SoN08FVse+Ns+PRU+\n\t/73AGvaj4xdk8jsg15kRHHmBSlSjvsf+WHpANlCQYrIyrMnxz9V0RAEswVcQYIcE\n\tgPl8nSy2r/9nxk/0E5pZmc9BS//6EHesVGP2gP1DEjzTEw6MBIRqCvg9xxZOVA=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-3.0 required=5.0 tests=AWL, BAYES_00,\n\tFREEMAIL_FROM, RCVD_IN_DNSWL_NONE,\n\tSPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:941","X-HELO":"mail-oi0-f66.google.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to;\n\tbh=upjDy7WbvHlJtBxYswoS5xl7K0Or/LRNQBglO+E+syk=;\n\tb=FMh266maoKuzK3SC0w7er9FF9AdIJ8MLtSULRbbrNgtIEX7grB5SCj/O4m/P3cYcEm\n\tdYPMYvsHW+cK3ASKZTk2jYHiJC6OWM6+pP7gRg6Fiu0OR+D8yhT0pj8k33geTd3Rv4LI\n\tgkRQ38afByApFnc7X+nekLV6NtvZe3hPH3X73qkY02zI2OvxyNHxO3iUp+y1Y3MAxBWZ\n\t/gFQM5ej7RM38R/Ae3vBSlRkPDmxGUe6hgATfAzB6tK2KIz2WVXKM345pE3LE6/HlY5v\n\tjHKY7PLh2AnH6F8kXSqyYz+UBPHdANMtewkMa59TXpQFVQReVJX+BnBsoGkom4jDNzEb\n\thbPw==","X-Gm-Message-State":"AMCzsaXMD0umg8ebttYw5NqRQkGpnF7C5i7qyxN4QQP2GEoRrHS1zGe8\n\t20geJjf900Ws5G1PzKYTjygNz++rDtAkdfP1vzw=","X-Google-Smtp-Source":"AOwi7QCjrUFvHUS2H3llmPM+d5uugcl1lffTJWZJS5kmGU3G42vvgJ36rVVFV/aqMsP2uHeH99QLK92xCQxvkIHz2M4=","X-Received":"by 10.157.33.246 with SMTP id s109mr8051392otb.50.1506896612917; \n\tSun, 01 Oct 2017 15:23:32 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170901180029.9527-18-hjl.tools@gmail.com>","References":"<20170901180029.9527-1-hjl.tools@gmail.com>\n\t<20170901180029.9527-18-hjl.tools@gmail.com>","From":"\"H.J. Lu\" ","Date":"Sun, 1 Oct 2017 15:23:32 -0700","Message-ID":"","Subject":"Re: [PATCH 17/58] Mark internal dirent functions with\n\tattribute_hidden [BZ #18822]","To":"libc-alpha@sourceware.org","Content-Type":"text/plain; charset=\"UTF-8\""}}]