[{"id":1762232,"web_url":"http://patchwork.ozlabs.org/comment/1762232/","msgid":"<21eb3240-eea3-f81c-37b4-ef820e9f9e96@redhat.com>","list_archive_url":null,"date":"2017-09-03T09:13:17","subject":"Re: [PATCH 19/58] Mark internal stdlib functions with\n\tattribute_hidden [BZ #18822]","submitter":{"id":14312,"url":"http://patchwork.ozlabs.org/api/people/14312/","name":"Florian Weimer","email":"fweimer@redhat.com"},"content":"On 09/01/2017 07:59 PM, H.J. Lu wrote:\n> \t(__qecvt_r): Likewise.\n> \t(__qfcvt_r): Likewise.\n\nI think this change makes symbols vanish from the public ABI on various\narchitectures:\n\n--- ../sysdeps/unix/sysv/linux/powerpc/powerpc64/libc.abilist\n2017-08-28 05:01:14.557643019 -0400\n+++ /home/bmg/build/glibcs/powerpc64-linux-gnu/glibc/libc.symlist\n2017-09-03 05:07:32.110128081 -0400\n@@ -1383 +1382,0 @@ GLIBC_2.3 qecvt F\n-GLIBC_2.3 qecvt_r F\n@@ -1385 +1383,0 @@ GLIBC_2.3 qfcvt F\n-GLIBC_2.3 qfcvt_r F\n@@ -2198 +2195,0 @@ GLIBC_2.4 qecvt F\n-GLIBC_2.4 qecvt_r F\n@@ -2200 +2196,0 @@ GLIBC_2.4 qfcvt F\n-GLIBC_2.4 qfcvt_r F\n\n(I assume that the patch is identical to what is on the hjl/pr18822\nbranch, which is what I used for testing.)\n\nThanks,\nFlorian","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84140-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"gV41Ibar\"; dkim-atps=neutral","sourceware.org; auth=none","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=fweimer@redhat.com"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xlS2M2Rpfz9s7f\n\tfor ;\n\tSun, 3 Sep 2017 19:13:31 +1000 (AEST)","(qmail 122596 invoked by alias); 3 Sep 2017 09:13:25 -0000","(qmail 122587 invoked by uid 89); 3 Sep 2017 09:13:24 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; q=dns; s=default; b=YtXgLeO770wLvRfO\n\tAtcVsXSfy3ZqWWNtqWgPvDXltwBOjSqmpxghgqdlhI5NIggmMFgdeOF92/YgzcWl\n\tR80IPDyeXNwGlxM4HCeg0snawQwWQtlqzY6Je3NNT7aG2TgW/ob70MaOeiz/DXhI\n\tHP/T4/aJ38VjEcNByRv8jT6EC+0=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; s=default; bh=DldjK6sP7oAj1UPRHK74Sx\n\tkkiCM=; b=gV41Ibar/BnowaubtByRYl2L5gxFyj8YaJpK9tixpA6vnE7wHXX0JK\n\tYQ2vcN+UiRw/Afn7Ih/vzy3J/37DcSO4VUrnXT2yIsPOfh4sHbQior4q4YzjLlMc\n\tVrMOWdl9MDTs0kovQ1cHxYldq8QdsW2O/2SM34BVXehCbFX53/o4Y=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-11.9 required=5.0 tests=BAYES_00, GIT_PATCH_2,\n\tGIT_PATCH_3, RP_MATCHES_RCVD,\n\tSPF_HELO_PASS autolearn=ham version=3.3.2 spammy=vanish","X-HELO":"mx1.redhat.com","DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com E70B4C0587C5","Subject":"Re: [PATCH 19/58] Mark internal stdlib functions with\n\tattribute_hidden [BZ #18822]","To":"\"H.J. Lu\" , libc-alpha@sourceware.org","References":"<20170901180029.9527-1-hjl.tools@gmail.com>\n\t<20170901180029.9527-20-hjl.tools@gmail.com>","From":"Florian Weimer ","Message-ID":"<21eb3240-eea3-f81c-37b4-ef820e9f9e96@redhat.com>","Date":"Sun, 3 Sep 2017 11:13:17 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170901180029.9527-20-hjl.tools@gmail.com>","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"7bit"}},{"id":1762334,"web_url":"http://patchwork.ozlabs.org/comment/1762334/","msgid":"","list_archive_url":null,"date":"2017-09-03T21:49:12","subject":"Re: [PATCH 19/58] Mark internal stdlib functions with\n\tattribute_hidden [BZ #18822]","submitter":{"id":4387,"url":"http://patchwork.ozlabs.org/api/people/4387/","name":"H.J. Lu","email":"hjl.tools@gmail.com"},"content":"On Sun, Sep 3, 2017 at 2:13 AM, Florian Weimer wrote:\n> On 09/01/2017 07:59 PM, H.J. Lu wrote:\n>> (__qecvt_r): Likewise.\n>> (__qfcvt_r): Likewise.\n>\n> I think this change makes symbols vanish from the public ABI on various\n> architectures:\n>\n> --- ../sysdeps/unix/sysv/linux/powerpc/powerpc64/libc.abilist\n> 2017-08-28 05:01:14.557643019 -0400\n> +++ /home/bmg/build/glibcs/powerpc64-linux-gnu/glibc/libc.symlist\n> 2017-09-03 05:07:32.110128081 -0400\n> @@ -1383 +1382,0 @@ GLIBC_2.3 qecvt F\n> -GLIBC_2.3 qecvt_r F\n> @@ -1385 +1383,0 @@ GLIBC_2.3 qfcvt F\n> -GLIBC_2.3 qfcvt_r F\n> @@ -2198 +2195,0 @@ GLIBC_2.4 qecvt F\n> -GLIBC_2.4 qecvt_r F\n> @@ -2200 +2196,0 @@ GLIBC_2.4 qfcvt F\n> -GLIBC_2.4 qfcvt_r F\n>\n> (I assume that the patch is identical to what is on the hjl/pr18822\n> branch, which is what I used for testing.)\n\nI updated hjl/pr18822 branch and there are no regressions with\nbuild-many-glibcs.py.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84150-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"RJ/mkMuK\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xlms73LbKz9sPs\n\tfor ;\n\tMon, 4 Sep 2017 07:51:38 +1000 (AEST)","(qmail 19562 invoked by alias); 3 Sep 2017 21:49:20 -0000","(qmail 19418 invoked by uid 89); 3 Sep 2017 21:49:20 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-type; q=dns; s=default; b=NRuo\n\tJ/V0oajMMsFaBMgHPnkCaLhiJMNehUqxvWOh0MilzZKHzdZC4glLO/kcDXX+8gmC\n\tdRyx/sdYQZddHctv/TF1lA536goi9rjkof2XOel/jJi8w/aVnsa14II4voaJVF2C\n\thQmXfP/7+zUI0dF6ncHsc6UGiOKSxzCLV1SpKxI=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-type; s=default; bh=AP3iyFSgBA\n\tHPOo/ur+Ux46m379o=; b=RJ/mkMuK7oVB8dsWkdcKJYD3hclKydhxOMciSdqkFn\n\tFjDjAcgcVPYkQc/EStK/ENYtDrfsEmVkCvbuyvaZ0nxN0V84mxSmIPFp8snUm4mc\n\t4kxvgU+5Hn6SDx7q652M+abMbyAtTsiTRQkZPF/rjQIx/gXFVVpA5Sk3/O5JVdmp\n\tE=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-12.0 required=5.0 tests=AWL, BAYES_00,\n\tFREEMAIL_FROM, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE,\n\tSPF_PASS autolearn=ham version=3.3.2 spammy=","X-HELO":"mail-oi0-f68.google.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=prbWvvY9QikAlsGFYURMbJD1yiyS1xkLG51bOibA2oI=;\n\tb=BhYsCIiJ6izpDaGAjmmW2EfKyc+Ozg5qgnUzztkY/0YhYZZ0xKSSs+KS0wJ1C5hLTS\n\tf7+QBXDxq+AxGIl1f52Tee4d1pyaOAVFcZMieXZMnuawXE0sbjQEsRcCBO/GMAJZ1tfr\n\tEVzP1qjJ/9/fGUT9LUTcMZP7H78SwC+7c59ZGG7/KhvWTiLjThujj596nDpsB8Xna4Xb\n\tcobD0ahhQEqetpVo90wFvqwaqChVtCiXa6rh9eEp5ESX4q/xEBjkFL+eF/DFeZv/l30/\n\t31sOq7lSD93LSe6+MpMcWNaL3NUtAKicIeJgNr0q/mKMvvGvq27017GNcTF4Wg1TmldL\n\tFw/g==","X-Gm-Message-State":"AHPjjUi2fIh0yuOOLB2d/cUf95xrBdDkJxBBSvRXgiMtc1iNdEznzTBV\n\t36eHkwbI+Z3Vqlkppm16UCsaaplQSn9j","X-Google-Smtp-Source":"ADKCNb7czFK7TQbDgSaXsnRZkZWTfzNrRduuUtLzfI6BnOgqSJCx4aYZW81VwFREweHPhhAAomy3H4Ih2Ge+IMiZsuY=","X-Received":"by 10.202.73.6 with SMTP id w6mr8805462oia.88.1504475353437; Sun,\n\t03 Sep 2017 14:49:13 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<21eb3240-eea3-f81c-37b4-ef820e9f9e96@redhat.com>","References":"<20170901180029.9527-1-hjl.tools@gmail.com>\n\t<20170901180029.9527-20-hjl.tools@gmail.com>\n\t<21eb3240-eea3-f81c-37b4-ef820e9f9e96@redhat.com>","From":"\"H.J. Lu\" ","Date":"Sun, 3 Sep 2017 14:49:12 -0700","Message-ID":"","Subject":"Re: [PATCH 19/58] Mark internal stdlib functions with\n\tattribute_hidden [BZ #18822]","To":"Florian Weimer ","Cc":"GNU C Library ","Content-Type":"text/plain; charset=\"UTF-8\""}},{"id":1778056,"web_url":"http://patchwork.ozlabs.org/comment/1778056/","msgid":"","list_archive_url":null,"date":"2017-10-01T21:10:11","subject":"Re: [PATCH 19/58] Mark internal stdlib functions with\n\tattribute_hidden [BZ #18822]","submitter":{"id":4387,"url":"http://patchwork.ozlabs.org/api/people/4387/","name":"H.J. Lu","email":"hjl.tools@gmail.com"},"content":"On 9/3/17, H.J. Lu wrote:\n> On Sun, Sep 3, 2017 at 2:13 AM, Florian Weimer wrote:\n>> On 09/01/2017 07:59 PM, H.J. Lu wrote:\n>>> (__qecvt_r): Likewise.\n>>> (__qfcvt_r): Likewise.\n>>\n>> I think this change makes symbols vanish from the public ABI on various\n>> architectures:\n>>\n>> --- ../sysdeps/unix/sysv/linux/powerpc/powerpc64/libc.abilist\n>> 2017-08-28 05:01:14.557643019 -0400\n>> +++ /home/bmg/build/glibcs/powerpc64-linux-gnu/glibc/libc.symlist\n>> 2017-09-03 05:07:32.110128081 -0400\n>> @@ -1383 +1382,0 @@ GLIBC_2.3 qecvt F\n>> -GLIBC_2.3 qecvt_r F\n>> @@ -1385 +1383,0 @@ GLIBC_2.3 qfcvt F\n>> -GLIBC_2.3 qfcvt_r F\n>> @@ -2198 +2195,0 @@ GLIBC_2.4 qecvt F\n>> -GLIBC_2.4 qecvt_r F\n>> @@ -2200 +2196,0 @@ GLIBC_2.4 qfcvt F\n>> -GLIBC_2.4 qfcvt_r F\n>>\n>> (I assume that the patch is identical to what is on the hjl/pr18822\n>> branch, which is what I used for testing.)\n>\n> I updated hjl/pr18822 branch and there are no regressions with\n> build-many-glibcs.py.\n>\n\nI am checking it in now.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-85191-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"nEmiQPZR\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y4ycb6Jk7z9t3s\n\tfor ;\n\tMon, 2 Oct 2017 08:10:23 +1100 (AEDT)","(qmail 30513 invoked by alias); 1 Oct 2017 21:10:15 -0000","(qmail 30504 invoked by uid 89); 1 Oct 2017 21:10:14 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-type; q=dns; s=default; b=gnI0\n\tVwdEpE7+AWJl24rSgEHvp8seI8EuwzDCPplkEW3rmAvPr1PmKErR6iiBdI/S7Qih\n\tnJEi8Ydrkes1tiN7Ynz6drLux+plC7roU0erTw5+hG725In1+lg1MzDU4wrqksJ9\n\tzbLm4g2JnxP8txDyASJXieNq7Vo2qPteL+3DkiE=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-type; s=default; bh=CJbE6GiNtq\n\tU+pPMZR9vI57aQ2jo=; b=nEmiQPZR1rgc+SF4XhedJGwbWSHqHD7KaRokV8gvbr\n\tSKggcsEhuK5lXjEoPEmmoUlHkeFnAVTMPaSwgkoFbhinesCBR6sfiMgnKOa8YPYD\n\tQ9hCTtQ7dTEWDhvJoO6JCy2PRka/4CeISDsI7ifxQP2B4qTQ3sfXu88+gL8QgM9A\n\tA=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-11.5 required=5.0 tests=AWL, BAYES_00,\n\tFREEMAIL_FROM, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_SORBS_SPAM,\n\tSPF_PASS autolearn=ham version=3.3.2 spammy=20170903,\n\tHx-languages-length:1124, 2017-09-03, vanish","X-HELO":"mail-oi0-f67.google.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=g960MtI0q70tNB/w22UZ+xsvksayqfij+BpDOUKJM1k=;\n\tb=oXQAhfb4X3FOahb3M84LfqwrewTaOzHeFZNr7/KpF9HJywsVM17sL6xfPWnYs4AGM8\n\txyoRpIZX8EXO0TJ5ApyYFS2Sa37QUY7XNwpLStH5LtXErOSovN6dqnkmuFybGE5jSGjw\n\tG1HwpFRMKPCuSQOIx5on7eNmhZ1mVf+m0ZpRnVnnp7fQSQFuaV3ZrgwD8P1CY8UbuAzM\n\teoPQJLsjcM7Kgp1z3VG6lKvw2lPSTHAHB/Xv3Iy2l2sKcp6uTXs+vFArDfFIcMxzEyyK\n\tT6g0v+ENld7OW1djLskNVgdX6Qc4VqSTBsKK1obIvuZUeNR1BraTUW87P02hfB/lIPBC\n\t7WPQ==","X-Gm-Message-State":"AMCzsaWURe1QYzSplyxwGPZ3KBmNtn8Q/L191McW4prpGv0VJwuRuM/u\n\ti/kjeIT9ipZSiFT6WmBg9pdpnIDZ5IxeRFe/Gyk=","X-Google-Smtp-Source":"AOwi7QD7zWWwct5fRv6fe/YqYtcAWjheR89eYeQHyEwYdDKjNPmZihebE2qAJ/X1JIsIfADXnjUM4/EjbQXuxxysllo=","X-Received":"by 10.157.33.246 with SMTP id s109mr7975426otb.50.1506892211762; \n\tSun, 01 Oct 2017 14:10:11 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<20170901180029.9527-1-hjl.tools@gmail.com>\n\t<20170901180029.9527-20-hjl.tools@gmail.com>\n\t<21eb3240-eea3-f81c-37b4-ef820e9f9e96@redhat.com>\n\t","From":"\"H.J. Lu\" ","Date":"Sun, 1 Oct 2017 14:10:11 -0700","Message-ID":"","Subject":"Re: [PATCH 19/58] Mark internal stdlib functions with\n\tattribute_hidden [BZ #18822]","To":"Florian Weimer ","Cc":"GNU C Library ","Content-Type":"text/plain; charset=\"UTF-8\""}}]