[{"id":1762192,"web_url":"http://patchwork.ozlabs.org/comment/1762192/","msgid":"<6581c880-c562-e519-cef1-077d26350410@redhat.com>","list_archive_url":null,"date":"2017-09-02T20:58:28","subject":"Re: [PATCH 18/58] Mark internal utmp functions with attribute_hidden\n\t[BZ #18822]","submitter":{"id":14312,"url":"http://patchwork.ozlabs.org/api/people/14312/","name":"Florian Weimer","email":"fweimer@redhat.com"},"content":"On 09/01/2017 07:59 PM, H.J. Lu wrote:\n> Mark internal utmp functions with attribute_hidden to allow direct\n> access within libc.so and libc.a without using GOT nor PLT.\n> \n> \t[BZ #18822]\n> \t* include/utmp.h (__updwtmp): Add attribute_hidden.\n> \t(__utmpname): Likewise.\n> \t(__getutent): Likewise.\n\nI believe this causes:\n\n/home/bmg/build/glibcs/s390-linux-gnu/glibc/login/utmpdump.o: In\nfunction `main':\n/home/bmg/build/glibcs/s390-linux-gnu/glibc-src/login/programs/utmpdump.c:93:\nundefined reference to `getutent'\ncollect2: error: ld returned 1 exit status\n\nThat's presumably due to the renaming business in\nsysdeps/unix/sysv/linux/s390/s390-32/getutent*.c\n\nThanks,\nFlorian","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84125-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"LKz7yNFd\"; dkim-atps=neutral","sourceware.org; auth=none","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=fweimer@redhat.com"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xl7kX3qJ4z9sRW\n\tfor ;\n\tSun, 3 Sep 2017 06:58:44 +1000 (AEST)","(qmail 116926 invoked by alias); 2 Sep 2017 20:58:37 -0000","(qmail 116917 invoked by uid 89); 2 Sep 2017 20:58:37 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; q=dns; s=default; b=VBFjrS1Y0Y2ur6vc\n\tmtWAY7l0uBDkSJwkPQbBd+uN+jprskjRgQ9Jdi6ClU1S2fm28GoRAKUYrD3Xqbam\n\tnOqa9QNovUW7bkY8X84JHDevp1Q7enKBukFjLhKT/k+w4vhYBdqTDP66uJ3hFSHn\n\tlk7CzEP/THmu55wjIpjKMJzOL30=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; s=default; bh=bGSEbrz4T6PvXQHUQ2Ira9\n\th3S0k=; b=LKz7yNFd4Hwer5ZJ7v+pdk8lgD4voBlweTN3C2caLNDP2LfNkbULmI\n\th4qLegzQ/n9BpF6zWjr25WO7JvJXkzwb3b22kjdqP4MiahHBFXUlnEvGlGEpagIR\n\tBJaZdX4hjRgk2o8Wg5mu7CgdG6yH4EcMM4d9EeXjec6F9OJ5tmfD0=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-0.9 required=5.0 tests=BAYES_00,\n\tKAM_LAZY_DOMAIN_SECURITY, RP_MATCHES_RCVD,\n\tSPF_HELO_PASS autolearn=no version=3.3.2 spammy=business","X-HELO":"mx1.redhat.com","DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com ECAF4859F7","Subject":"Re: [PATCH 18/58] Mark internal utmp functions with attribute_hidden\n\t[BZ #18822]","To":"\"H.J. Lu\" , libc-alpha@sourceware.org","References":"<20170901180029.9527-1-hjl.tools@gmail.com>\n\t<20170901180029.9527-19-hjl.tools@gmail.com>","From":"Florian Weimer ","Message-ID":"<6581c880-c562-e519-cef1-077d26350410@redhat.com>","Date":"Sat, 2 Sep 2017 22:58:28 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170901180029.9527-19-hjl.tools@gmail.com>","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"7bit"}},{"id":1778059,"web_url":"http://patchwork.ozlabs.org/comment/1778059/","msgid":"","list_archive_url":null,"date":"2017-10-01T21:14:29","subject":"Re: [PATCH 18/58] Mark internal utmp functions with attribute_hidden\n\t[BZ #18822]","submitter":{"id":4387,"url":"http://patchwork.ozlabs.org/api/people/4387/","name":"H.J. Lu","email":"hjl.tools@gmail.com"},"content":"On 9/2/17, Florian Weimer wrote:\n> On 09/01/2017 07:59 PM, H.J. Lu wrote:\n>> Mark internal utmp functions with attribute_hidden to allow direct\n>> access within libc.so and libc.a without using GOT nor PLT.\n>>\n>> \t[BZ #18822]\n>> \t* include/utmp.h (__updwtmp): Add attribute_hidden.\n>> \t(__utmpname): Likewise.\n>> \t(__getutent): Likewise.\n>\n> I believe this causes:\n>\n> /home/bmg/build/glibcs/s390-linux-gnu/glibc/login/utmpdump.o: In\n> function `main':\n> /home/bmg/build/glibcs/s390-linux-gnu/glibc-src/login/programs/utmpdump.c:93:\n> undefined reference to `getutent'\n> collect2: error: ld returned 1 exit status\n>\n> That's presumably due to the renaming business in\n> sysdeps/unix/sysv/linux/s390/s390-32/getutent*.c\n>\n\nHere is the updated patch. Tested with build-many-glibcs.py. OK for master?\n\nThanks.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-85192-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"NjfwfFLf\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y4yjW4hNhz9s81\n\tfor ;\n\tMon, 2 Oct 2017 08:14:39 +1100 (AEDT)","(qmail 38664 invoked by alias); 1 Oct 2017 21:14:33 -0000","(qmail 38655 invoked by uid 89); 1 Oct 2017 21:14:33 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-type; q=dns; s=default; b=WiGC\n\tZp5rSweNrDryw/1cJZ6FZJA+dWXSCLi6KVYBiv7ahrMlZ/fRTd9gzEMW5CvHkbTy\n\tNxxriIb0U0+PlpGYsQnVykWeAWeUsgcG04hrRPiXCVXEE2xvOqFhko/XlSZz/GLL\n\tJYiF2JKkvgTdwj3SszxRkR6tAsO12dWUkHCKJS0=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-type; s=default; bh=0Wv/+dImfu\n\tFEIAEy0Yc57XeOzwM=; b=NjfwfFLfWIpmpQmhg1vt1P/Xg5MyzN9iSt1jUFHcIP\n\tLxNxpRZggRkbwJ2jixx6w/SJr7OjJlmc9KmgFQQP/u8BEhSBXv9Rm3isSI5l1Bby\n\tS+Lyc8ypJO2D9oHEFv8fz8dAsAi1iyp0idEPim1DLIv2fmLLcqaRjLXS7KDcNixU\n\ts=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-25.0 required=5.0 tests=AWL, BAYES_00,\n\tFREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2,\n\tGIT_PATCH_3, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM,\n\tSPF_PASS autolearn=ham version=3.3.2 spammy=","X-HELO":"mail-oi0-f68.google.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=/OQUldwah8df4JW1uXdKLUL0rIEA8ZumBCDZ4KsRGLs=;\n\tb=VlV8hM5IWEXqINY52/mjIPbQuKbcnXK8lJpDHJRqFEvOIFCH+rCjUrMzlH7xrY9X8D\n\tLWlzVGDoHLwnEbvATUOcH0CNZOA3r5oUlaAkHLIXw615+jp5w6rvz2+FMnmjaj90b3WJ\n\tXLG0rEtVteUcXcr6Vtkgf4w1PL5mLFLqKzbsSDTX77sOg9YazF775CfZkjnHeqbPHN0m\n\t462twHeE9TvkPjpxAXV5TmrB+e92WFKq5xZ5MObUHBKf60wa8n9exPKa7gAHUhWynkpj\n\tfjhOPa95eI+10YUsrXhZgMywN5H13B2mU5C2feICoWyPA8TeGSz3qbIozCtjscDHK0ht\n\tK5cA==","X-Gm-Message-State":"AMCzsaXOlUDZwbCHoEg6YomLEvmCCv2hqz6/Keh09D7hFVRqTVyyjuuD\n\twKvUO5j5a13tVrrHxlOx7xn1F54ldsGF8vSiVG0=","X-Google-Smtp-Source":"AOwi7QCwMbeqAZPUmcV8hqIZt+DHTDlLQEjbUqcyGKmM5EZK7mDKl+j2Xwl/udTBIkT2BEcqusaAest41r0yL8jXo8A=","X-Received":"by 10.202.243.69 with SMTP id r66mr5029720oih.337.1506892469970; \n\tSun, 01 Oct 2017 14:14:29 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<6581c880-c562-e519-cef1-077d26350410@redhat.com>","References":"<20170901180029.9527-1-hjl.tools@gmail.com>\n\t<20170901180029.9527-19-hjl.tools@gmail.com>\n\t<6581c880-c562-e519-cef1-077d26350410@redhat.com>","From":"\"H.J. Lu\" ","Date":"Sun, 1 Oct 2017 14:14:29 -0700","Message-ID":"","Subject":"Re: [PATCH 18/58] Mark internal utmp functions with attribute_hidden\n\t[BZ #18822]","To":"Florian Weimer ","Cc":"libc-alpha@sourceware.org","Content-Type":"multipart/mixed; boundary=\"94eb2c0953fe637c81055a82be48\""}}]