[{"id":1763013,"web_url":"http://patchwork.ozlabs.org/comment/1763013/","msgid":"<09983e6e-9506-ca02-a8ce-b1a1773d793c@redhat.com>","list_archive_url":null,"date":"2017-09-05T07:20:50","subject":"Re: [Qemu-devel] [PATCH v6 02/29] tests: Sort .gitignore","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 01.09.2017 20:03, Eric Blake wrote:\n> It doesn't matter if things are unsorted, but finding stuff in a list\n> is easier when it is sorted. (Sorted under LC_ALL=C rules, rather than\n> en_US.UTF-8).\n> \n> Signed-off-by: Eric Blake \n> ---\n> tests/.gitignore | 30 +++++++++++++++---------------\n> 1 file changed, 15 insertions(+), 15 deletions(-)\n\nReviewed-by: Thomas Huth \n\nBTW, did you note the patch \"build-sys: generate tests/.gitignore\" from\nMarc-André ? Maybe the list can be generated automatically, too...\n\n> diff --git a/tests/.gitignore b/tests/.gitignore\n> index 64ecd6683b..8d35a58751 100644\n> --- a/tests/.gitignore\n> +++ b/tests/.gitignore\n> @@ -1,25 +1,27 @@\n> +*-test\n\n... but looking at this wildcard, I wonder if we just named most of our\ntests in a bad way. If we name the files something-test instead of\ntest-something, we maybe do not need the automatic generation from\nMarc-André (which is kind of ugly because it writes to the source\ndirectory - and this should not happen when doing out of tree builds).\n\nSo what do you think about renaming our tests, so that the above\nwildcard applies instead?\n\n Thomas\n\n> atomic_add-bench\n> benchmark-crypto-cipher\n> benchmark-crypto-hash\n> benchmark-crypto-hmac\n> check-qdict\n> -check-qnum\n> check-qjson\n> check-qlist\n> check-qnull\n> -check-qstring\n> +check-qnum\n> check-qom-interface\n> check-qom-proplist\n> -multiboot/test.out\n> +check-qstring\n> multiboot/*.elf\n> +multiboot/test.out\n> +qapi-schema/*.test.*\n> qht-bench\n> rcutorture\n> test-aio\n> test-aio-multithread\n> test-arm-mptimer\n> test-base64\n> -test-bitops\n> test-bitcnt\n> +test-bitops\n> test-blockjob\n> test-blockjob-txn\n> test-bufferiszero\n> @@ -35,18 +37,19 @@ test-crypto-ivgen\n> test-crypto-pbkdf\n> test-crypto-secret\n> test-crypto-tlscredsx509\n> -test-crypto-tlscredsx509-work/\n> test-crypto-tlscredsx509-certs/\n> +test-crypto-tlscredsx509-work/\n> test-crypto-tlssession\n> -test-crypto-tlssession-work/\n> test-crypto-tlssession-client/\n> test-crypto-tlssession-server/\n> +test-crypto-tlssession-work/\n> test-crypto-xts\n> test-cutils\n> +test-filter-mirror\n> +test-filter-redirector\n> test-hbitmap\n> test-hmp\n> test-int128\n> -test-iov\n> test-io-channel-buffer\n> test-io-channel-command\n> test-io-channel-command.fifo\n> @@ -55,27 +58,29 @@ test-io-channel-file.txt\n> test-io-channel-socket\n> test-io-channel-tls\n> test-io-task\n> +test-iov\n> test-keyval\n> test-logging\n> test-mul64\n> +test-netfilter\n> test-opts-visitor\n> test-qapi-event.[ch]\n> test-qapi-types.[ch]\n> test-qapi-util\n> test-qapi-visit.[ch]\n> test-qdev-global-props\n> -test-qemu-opts\n> test-qdist\n> +test-qemu-opts\n> test-qga\n> test-qht\n> test-qht-par\n> test-qmp-commands\n> test-qmp-commands.h\n> test-qmp-event\n> -test-qobject-input-strict\n> -test-qobject-input-visitor\n> test-qmp-introspect.[ch]\n> test-qmp-marshal.c\n> +test-qobject-input-strict\n> +test-qobject-input-visitor\n> test-qobject-output-visitor\n> test-rcu-list\n> test-replication\n> @@ -92,8 +97,3 @@ test-write-threshold\n> test-x86-cpuid\n> test-x86-cpuid-compat\n> test-xbzrle\n> -test-netfilter\n> -test-filter-mirror\n> -test-filter-redirector\n> -*-test\n> -qapi-schema/*.test.*\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmdSM1Yprz9sNq\n\tfor ;\n\tTue, 5 Sep 2017 17:21:39 +1000 (AEST)","from localhost ([::1]:57208 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dp8Az-0006f2-8q\n\tfor incoming@patchwork.ozlabs.org; Tue, 05 Sep 2017 03:21:37 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:45813)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dp8Ac-0006dD-Dt\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 03:21:19 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dp8AX-0004cJ-GK\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 03:21:14 -0400","from mx1.redhat.com ([209.132.183.28]:58656)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dp8AX-0004bh-7u\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 03:21:09 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id A3B767CE04\n\tfor ; Tue, 5 Sep 2017 07:21:07 +0000 (UTC)","from [10.36.116.114] (ovpn-116-114.ams2.redhat.com [10.36.116.114])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id C615E1177FF;\n\tTue, 5 Sep 2017 07:20:51 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com A3B767CE04","To":"Eric Blake , qemu-devel@nongnu.org","References":"<20170901180340.30009-1-eblake@redhat.com>\n\t<20170901180340.30009-3-eblake@redhat.com>","From":"Thomas Huth ","Message-ID":"<09983e6e-9506-ca02-a8ce-b1a1773d793c@redhat.com>","Date":"Tue, 5 Sep 2017 09:20:50 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170901180340.30009-3-eblake@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tTue, 05 Sep 2017 07:21:07 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v6 02/29] tests: Sort .gitignore","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pbonzini@redhat.com, armbru@redhat.com, =?utf-8?q?Marc-Andr=C3=A9_Lure?=\n\t=?utf-8?q?au?= ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1763162,"web_url":"http://patchwork.ozlabs.org/comment/1763162/","msgid":"<874lshzd2l.fsf@dusky.pond.sub.org>","list_archive_url":null,"date":"2017-09-05T09:53:22","subject":"Re: [Qemu-devel] [PATCH v6 02/29] tests: Sort .gitignore","submitter":{"id":2645,"url":"http://patchwork.ozlabs.org/api/people/2645/","name":"Markus Armbruster","email":"armbru@redhat.com"},"content":"Thomas Huth writes:\n\n> On 01.09.2017 20:03, Eric Blake wrote:\n>> It doesn't matter if things are unsorted, but finding stuff in a list\n>> is easier when it is sorted. (Sorted under LC_ALL=C rules, rather than\n>> en_US.UTF-8).\n>> \n>> Signed-off-by: Eric Blake \n>> ---\n>> tests/.gitignore | 30 +++++++++++++++---------------\n>> 1 file changed, 15 insertions(+), 15 deletions(-)\n>\n> Reviewed-by: Thomas Huth \n>\n> BTW, did you note the patch \"build-sys: generate tests/.gitignore\" from\n> Marc-André ? Maybe the list can be generated automatically, too...\n>\n>> diff --git a/tests/.gitignore b/tests/.gitignore\n>> index 64ecd6683b..8d35a58751 100644\n>> --- a/tests/.gitignore\n>> +++ b/tests/.gitignore\n>> @@ -1,25 +1,27 @@\n>> +*-test\n>\n> ... but looking at this wildcard, I wonder if we just named most of our\n> tests in a bad way. If we name the files something-test instead of\n> test-something, we maybe do not need the automatic generation from\n> Marc-André (which is kind of ugly because it writes to the source\n> directory - and this should not happen when doing out of tree builds).\n>\n> So what do you think about renaming our tests, so that the above\n> wildcard applies instead?\n\nApropos naming tests: there's an (unspoken) convention to name unit\ntests check-FOO or test-FOO and tests using libqtest FOO-test, but it's\nnot really honored anymore, probably because people creating tests\ndidn't know about it.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=armbru@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmhrZ1F8Sz9s9Y\n\tfor ;\n\tTue, 5 Sep 2017 19:54:22 +1000 (AEST)","from localhost ([::1]:57818 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpAYm-00022W-9v\n\tfor incoming@patchwork.ozlabs.org; Tue, 05 Sep 2017 05:54:20 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:60869)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpAY0-0001uQ-K2\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 05:53:37 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpAXv-0000xI-Uq\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 05:53:32 -0400","from mx1.redhat.com ([209.132.183.28]:41286)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dpAXv-0000wp-PA\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 05:53:27 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id B867F130C\n\tfor ; Tue, 5 Sep 2017 09:53:26 +0000 (UTC)","from blackfin.pond.sub.org (ovpn-116-75.ams2.redhat.com\n\t[10.36.116.75])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 5730E90D7D;\n\tTue, 5 Sep 2017 09:53:24 +0000 (UTC)","by blackfin.pond.sub.org (Postfix, from userid 1000)\n\tid D53591138645; Tue, 5 Sep 2017 11:53:22 +0200 (CEST)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com B867F130C","From":"Markus Armbruster ","To":"Thomas Huth ","References":"<20170901180340.30009-1-eblake@redhat.com>\n\t<20170901180340.30009-3-eblake@redhat.com>\n\t<09983e6e-9506-ca02-a8ce-b1a1773d793c@redhat.com>","Date":"Tue, 05 Sep 2017 11:53:22 +0200","In-Reply-To":"<09983e6e-9506-ca02-a8ce-b1a1773d793c@redhat.com> (Thomas Huth's\n\tmessage of \"Tue, 5 Sep 2017 09:20:50 +0200\")","Message-ID":"<874lshzd2l.fsf@dusky.pond.sub.org>","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tTue, 05 Sep 2017 09:53:26 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v6 02/29] tests: Sort .gitignore","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pbonzini@redhat.com, qemu-devel@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9?=\n\tLureau ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1763166,"web_url":"http://patchwork.ozlabs.org/comment/1763166/","msgid":"<1e7502ef-2798-54b1-b3dc-dec9d6fee6c0@redhat.com>","list_archive_url":null,"date":"2017-09-05T09:58:56","subject":"Re: [Qemu-devel] [PATCH v6 02/29] tests: Sort .gitignore","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 05.09.2017 11:53, Markus Armbruster wrote:\n> Thomas Huth writes:\n> \n>> On 01.09.2017 20:03, Eric Blake wrote:\n>>> It doesn't matter if things are unsorted, but finding stuff in a list\n>>> is easier when it is sorted. (Sorted under LC_ALL=C rules, rather than\n>>> en_US.UTF-8).\n>>>\n>>> Signed-off-by: Eric Blake \n>>> ---\n>>> tests/.gitignore | 30 +++++++++++++++---------------\n>>> 1 file changed, 15 insertions(+), 15 deletions(-)\n>>\n>> Reviewed-by: Thomas Huth \n>>\n>> BTW, did you note the patch \"build-sys: generate tests/.gitignore\" from\n>> Marc-André ? Maybe the list can be generated automatically, too...\n>>\n>>> diff --git a/tests/.gitignore b/tests/.gitignore\n>>> index 64ecd6683b..8d35a58751 100644\n>>> --- a/tests/.gitignore\n>>> +++ b/tests/.gitignore\n>>> @@ -1,25 +1,27 @@\n>>> +*-test\n>>\n>> ... but looking at this wildcard, I wonder if we just named most of our\n>> tests in a bad way. If we name the files something-test instead of\n>> test-something, we maybe do not need the automatic generation from\n>> Marc-André (which is kind of ugly because it writes to the source\n>> directory - and this should not happen when doing out of tree builds).\n>>\n>> So what do you think about renaming our tests, so that the above\n>> wildcard applies instead?\n> \n> Apropos naming tests: there's an (unspoken) convention to name unit\n> tests check-FOO or test-FOO and tests using libqtest FOO-test, but it's\n> not really honored anymore, probably because people creating tests\n> didn't know about it.\n\nMaybe it would help to have an entry for libqtest in MAINTAINERS with a\nwildcard for tests/*-test.c ? Then we would have at least some kind of\ndocumentation for this... (BTW: Any volunteers here for such a\nmaintainer job? ;-))\n\n Thomas","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmhzX3zfCz9s9Y\n\tfor ;\n\tTue, 5 Sep 2017 20:00:24 +1000 (AEST)","from localhost ([::1]:57848 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpAec-00076l-F6\n\tfor incoming@patchwork.ozlabs.org; Tue, 05 Sep 2017 06:00:22 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:36849)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpAdU-0006Zt-02\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 05:59:16 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpAdK-0005TD-Cx\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 05:59:12 -0400","from mx1.redhat.com ([209.132.183.28]:57130)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dpAdK-0005SM-6r\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 05:59:02 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 066B38765D\n\tfor ; Tue, 5 Sep 2017 09:59:01 +0000 (UTC)","from [10.36.116.114] (ovpn-116-114.ams2.redhat.com [10.36.116.114])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id B32A47B23C;\n\tTue, 5 Sep 2017 09:58:57 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 066B38765D","To":"Markus Armbruster ","References":"<20170901180340.30009-1-eblake@redhat.com>\n\t<20170901180340.30009-3-eblake@redhat.com>\n\t<09983e6e-9506-ca02-a8ce-b1a1773d793c@redhat.com>\n\t<874lshzd2l.fsf@dusky.pond.sub.org>","From":"Thomas Huth ","Message-ID":"<1e7502ef-2798-54b1-b3dc-dec9d6fee6c0@redhat.com>","Date":"Tue, 5 Sep 2017 11:58:56 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<874lshzd2l.fsf@dusky.pond.sub.org>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tTue, 05 Sep 2017 09:59:01 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v6 02/29] tests: Sort .gitignore","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pbonzini@redhat.com, qemu-devel@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_?=\n\t=?utf-8?q?Lureau?= ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1763175,"web_url":"http://patchwork.ozlabs.org/comment/1763175/","msgid":"<20170905101003.GD311@redhat.com>","list_archive_url":null,"date":"2017-09-05T10:10:03","subject":"Re: [Qemu-devel] [PATCH v6 02/29] tests: Sort .gitignore","submitter":{"id":2694,"url":"http://patchwork.ozlabs.org/api/people/2694/","name":"Daniel P. Berrangé","email":"berrange@redhat.com"},"content":"On Tue, Sep 05, 2017 at 11:53:22AM +0200, Markus Armbruster wrote:\n> Thomas Huth writes:\n> \n> > On 01.09.2017 20:03, Eric Blake wrote:\n> >> It doesn't matter if things are unsorted, but finding stuff in a list\n> >> is easier when it is sorted. (Sorted under LC_ALL=C rules, rather than\n> >> en_US.UTF-8).\n> >> \n> >> Signed-off-by: Eric Blake \n> >> ---\n> >> tests/.gitignore | 30 +++++++++++++++---------------\n> >> 1 file changed, 15 insertions(+), 15 deletions(-)\n> >\n> > Reviewed-by: Thomas Huth \n> >\n> > BTW, did you note the patch \"build-sys: generate tests/.gitignore\" from\n> > Marc-André ? Maybe the list can be generated automatically, too...\n> >\n> >> diff --git a/tests/.gitignore b/tests/.gitignore\n> >> index 64ecd6683b..8d35a58751 100644\n> >> --- a/tests/.gitignore\n> >> +++ b/tests/.gitignore\n> >> @@ -1,25 +1,27 @@\n> >> +*-test\n> >\n> > ... but looking at this wildcard, I wonder if we just named most of our\n> > tests in a bad way. If we name the files something-test instead of\n> > test-something, we maybe do not need the automatic generation from\n> > Marc-André (which is kind of ugly because it writes to the source\n> > directory - and this should not happen when doing out of tree builds).\n> >\n> > So what do you think about renaming our tests, so that the above\n> > wildcard applies instead?\n> \n> Apropos naming tests: there's an (unspoken) convention to name unit\n> tests check-FOO or test-FOO and tests using libqtest FOO-test, but it's\n> not really honored anymore, probably because people creating tests\n> didn't know about it.\n\n$ ls *test.c | wc -l\n67\n$ ls test*.c | wc -l\n73\n$ ls check*.c | wc -l\n8\n\nFairly even split between 'test' as a prefix vs suffix. 'check' as a\nprefix should clearly be killed as a minority pattern. Any appetite\nfor standardizing naming of everything else ?\n\nA further idea might be to actually have separate sub-directories for\nunit tests vs qtests. eg go for\n\n tests\n +- unit\n +- qtest\n +- iotests\n\nRegards,\nDaniel","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=berrange@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmjCY6H5jz9s9Y\n\tfor ;\n\tTue, 5 Sep 2017 20:10:49 +1000 (AEST)","from localhost ([::1]:57905 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpAoh-0005DJ-AA\n\tfor incoming@patchwork.ozlabs.org; Tue, 05 Sep 2017 06:10:47 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:42309)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpAoC-0005Cl-An\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 06:10:24 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpAo7-0000uF-3H\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 06:10:16 -0400","from mx1.redhat.com ([209.132.183.28]:41616)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dpAo6-0000sm-QE\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 06:10:11 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id D748A80468\n\tfor ; Tue, 5 Sep 2017 10:10:09 +0000 (UTC)","from redhat.com (unknown [10.33.36.63])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 0AF1982417;\n\tTue, 5 Sep 2017 10:10:05 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com D748A80468","Date":"Tue, 5 Sep 2017 11:10:03 +0100","From":"\"Daniel P. Berrange\" ","To":"Markus Armbruster ","Message-ID":"<20170905101003.GD311@redhat.com>","References":"<20170901180340.30009-1-eblake@redhat.com>\n\t<20170901180340.30009-3-eblake@redhat.com>\n\t<09983e6e-9506-ca02-a8ce-b1a1773d793c@redhat.com>\n\t<874lshzd2l.fsf@dusky.pond.sub.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<874lshzd2l.fsf@dusky.pond.sub.org>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tTue, 05 Sep 2017 10:10:10 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v6 02/29] tests: Sort .gitignore","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"\"Daniel P. Berrange\" ","Cc":"pbonzini@redhat.com, Thomas Huth ,\n\tqemu-devel@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9?=\n\tLureau ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1763202,"web_url":"http://patchwork.ozlabs.org/comment/1763202/","msgid":"","list_archive_url":null,"date":"2017-09-05T10:44:35","subject":"Re: [Qemu-devel] [PATCH v6 02/29] tests: Sort .gitignore","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 05.09.2017 12:10, Daniel P. Berrange wrote:\n> On Tue, Sep 05, 2017 at 11:53:22AM +0200, Markus Armbruster wrote:\n>> Thomas Huth writes:\n>>\n>>> On 01.09.2017 20:03, Eric Blake wrote:\n>>>> It doesn't matter if things are unsorted, but finding stuff in a list\n>>>> is easier when it is sorted. (Sorted under LC_ALL=C rules, rather than\n>>>> en_US.UTF-8).\n>>>>\n>>>> Signed-off-by: Eric Blake \n>>>> ---\n>>>> tests/.gitignore | 30 +++++++++++++++---------------\n>>>> 1 file changed, 15 insertions(+), 15 deletions(-)\n>>>\n>>> Reviewed-by: Thomas Huth \n>>>\n>>> BTW, did you note the patch \"build-sys: generate tests/.gitignore\" from\n>>> Marc-André ? Maybe the list can be generated automatically, too...\n>>>\n>>>> diff --git a/tests/.gitignore b/tests/.gitignore\n>>>> index 64ecd6683b..8d35a58751 100644\n>>>> --- a/tests/.gitignore\n>>>> +++ b/tests/.gitignore\n>>>> @@ -1,25 +1,27 @@\n>>>> +*-test\n>>>\n>>> ... but looking at this wildcard, I wonder if we just named most of our\n>>> tests in a bad way. If we name the files something-test instead of\n>>> test-something, we maybe do not need the automatic generation from\n>>> Marc-André (which is kind of ugly because it writes to the source\n>>> directory - and this should not happen when doing out of tree builds).\n>>>\n>>> So what do you think about renaming our tests, so that the above\n>>> wildcard applies instead?\n>>\n>> Apropos naming tests: there's an (unspoken) convention to name unit\n>> tests check-FOO or test-FOO and tests using libqtest FOO-test, but it's\n>> not really honored anymore, probably because people creating tests\n>> didn't know about it.\n> \n> $ ls *test.c | wc -l\n> 67\n> $ ls test*.c | wc -l\n> 73\n> $ ls check*.c | wc -l\n> 8\n> \n> Fairly even split between 'test' as a prefix vs suffix. 'check' as a\n> prefix should clearly be killed as a minority pattern. Any appetite\n> for standardizing naming of everything else ?\n> \n> A further idea might be to actually have separate sub-directories for\n> unit tests vs qtests. eg go for\n> \n> tests\n> +- unit\n> +- qtest\n> +- iotests\n\nThat sounds like a good idea to me, too.\n\n Thomas","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmjzY3G2bz9sNr\n\tfor ;\n\tTue, 5 Sep 2017 20:45:29 +1000 (AEST)","from localhost ([::1]:58040 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpBMF-0002Qz-IA\n\tfor incoming@patchwork.ozlabs.org; Tue, 05 Sep 2017 06:45:27 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:59316)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpBLa-0002Mz-U4\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 06:44:51 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpBLW-0001Uu-0k\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 06:44:46 -0400","from mx1.redhat.com ([209.132.183.28]:39956)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dpBLV-0001UF-Oa\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 06:44:41 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id C32B5C058EDD\n\tfor ; Tue, 5 Sep 2017 10:44:40 +0000 (UTC)","from [10.36.116.114] (ovpn-116-114.ams2.redhat.com [10.36.116.114])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 694518C3A7;\n\tTue, 5 Sep 2017 10:44:37 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com C32B5C058EDD","To":"\"Daniel P. Berrange\" ,\n\tMarkus Armbruster ","References":"<20170901180340.30009-1-eblake@redhat.com>\n\t<20170901180340.30009-3-eblake@redhat.com>\n\t<09983e6e-9506-ca02-a8ce-b1a1773d793c@redhat.com>\n\t<874lshzd2l.fsf@dusky.pond.sub.org> <20170905101003.GD311@redhat.com>","From":"Thomas Huth ","Message-ID":"","Date":"Tue, 5 Sep 2017 12:44:35 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170905101003.GD311@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]);\n\tTue, 05 Sep 2017 10:44:40 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v6 02/29] tests: Sort .gitignore","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pbonzini@redhat.com, qemu-devel@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_?=\n\t=?utf-8?q?Lureau?= ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1763396,"web_url":"http://patchwork.ozlabs.org/comment/1763396/","msgid":"<658b73e4-86fd-e272-4032-b999c5f2a859@redhat.com>","list_archive_url":null,"date":"2017-09-05T14:22:41","subject":"Re: [Qemu-devel] [PATCH v6 02/29] tests: Sort .gitignore","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 09/05/2017 05:10 AM, Daniel P. Berrange wrote:\n\n> Fairly even split between 'test' as a prefix vs suffix. 'check' as a\n> prefix should clearly be killed as a minority pattern. Any appetite\n> for standardizing naming of everything else ?\n> \n> A further idea might be to actually have separate sub-directories for\n> unit tests vs qtests. eg go for\n> \n> tests\n> +- unit\n> +- qtest\n> +- iotests\n\nI like the idea, but don't know if I want to be the one tackling it...","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmpqg5F05z9t16\n\tfor ;\n\tWed, 6 Sep 2017 00:23:59 +1000 (AEST)","from localhost ([::1]:59271 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpElh-0008UP-Sg\n\tfor incoming@patchwork.ozlabs.org; Tue, 05 Sep 2017 10:23:57 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:46066)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpEko-0008C3-8N\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 10:23:10 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpEke-0001WX-Jl\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 10:23:02 -0400","from mx1.redhat.com ([209.132.183.28]:13375)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dpEke-0001Ve-C8\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 10:22:52 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 4B469C014182\n\tfor ; Tue, 5 Sep 2017 14:22:51 +0000 (UTC)","from [10.10.120.228] (ovpn-120-228.rdu2.redhat.com [10.10.120.228])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 165EE7F08B;\n\tTue, 5 Sep 2017 14:22:41 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 4B469C014182","To":"\"Daniel P. Berrange\" ,\n\tMarkus Armbruster ","References":"<20170901180340.30009-1-eblake@redhat.com>\n\t<20170901180340.30009-3-eblake@redhat.com>\n\t<09983e6e-9506-ca02-a8ce-b1a1773d793c@redhat.com>\n\t<874lshzd2l.fsf@dusky.pond.sub.org> <20170905101003.GD311@redhat.com>","From":"Eric Blake ","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"<658b73e4-86fd-e272-4032-b999c5f2a859@redhat.com>","Date":"Tue, 5 Sep 2017 09:22:41 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170905101003.GD311@redhat.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"ANlpHG4AGr4lOq7MN27JaUSv0HraXwllM\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tTue, 05 Sep 2017 14:22:51 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH v6 02/29] tests: Sort .gitignore","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pbonzini@redhat.com, Thomas Huth ,\n\tqemu-devel@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?=\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]