[{"id":1762671,"web_url":"http://patchwork.ozlabs.org/comment/1762671/","msgid":"","list_archive_url":null,"date":"2017-09-04T14:03:42","subject":"Re: [Qemu-devel] [PATCH v6 01/29] tests: Improve .gitignore for\n\ttests/multiboot","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 01.09.2017 20:03, Eric Blake wrote:\n> Right now, tests/multiboot is not run by default during 'make check';\n> but when it is run in-tree, it was leaving some junk behind that could\n> accidentally get checked in with a careless 'git add tests'.\n> \n> Signed-off-by: Eric Blake \n> ---\n> tests/.gitignore | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/tests/.gitignore b/tests/.gitignore\n> index fed0189a5a..64ecd6683b 100644\n> --- a/tests/.gitignore\n> +++ b/tests/.gitignore\n> @@ -10,6 +10,8 @@ check-qnull\n> check-qstring\n> check-qom-interface\n> check-qom-proplist\n> +multiboot/test.out\n\nYour patch is of course a good idea ... but that test.out smells quite\nbad ... I guess it should (a) use mktemp for a better file name instead\nso that we can run this in parallel and (b) clean up the temporary file\nonce the test has been done?\n\n> +multiboot/*.elf\n> qht-bench\n> rcutorture\n> test-aio\n> \n\n Thomas","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmBY855NTz9s75\n\tfor ;\n\tTue, 5 Sep 2017 00:09:16 +1000 (AEST)","from localhost ([::1]:45116 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dos3u-0000S4-QY\n\tfor incoming@patchwork.ozlabs.org; Mon, 04 Sep 2017 10:09:14 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:49142)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1doryl-0005OM-9t\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 10:03:59 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1doryd-0005xu-N6\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 10:03:55 -0400","from mx1.redhat.com ([209.132.183.28]:44360)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1doryd-0005xC-H3\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 10:03:47 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 6981B40220\n\tfor ; Mon, 4 Sep 2017 14:03:46 +0000 (UTC)","from [10.36.116.102] (ovpn-116-102.ams2.redhat.com [10.36.116.102])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 10FA9D020D;\n\tMon, 4 Sep 2017 14:03:44 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 6981B40220","To":"Eric Blake , qemu-devel@nongnu.org","References":"<20170901180340.30009-1-eblake@redhat.com>\n\t<20170901180340.30009-2-eblake@redhat.com>","From":"Thomas Huth ","Message-ID":"","Date":"Mon, 4 Sep 2017 16:03:42 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170901180340.30009-2-eblake@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tMon, 04 Sep 2017 14:03:46 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v6 01/29] tests: Improve .gitignore for\n\ttests/multiboot","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Kevin Wolf , pbonzini@redhat.com, armbru@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1764323,"web_url":"http://patchwork.ozlabs.org/comment/1764323/","msgid":"<0d39cd85-a721-4883-573a-50d64a2d4b99@redhat.com>","list_archive_url":null,"date":"2017-09-06T19:33:08","subject":"Re: [Qemu-devel] [PATCH v6 01/29] tests: Improve .gitignore for\n\ttests/multiboot","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 09/04/2017 09:03 AM, Thomas Huth wrote:\n> On 01.09.2017 20:03, Eric Blake wrote:\n>> Right now, tests/multiboot is not run by default during 'make check';\n>> but when it is run in-tree, it was leaving some junk behind that could\n>> accidentally get checked in with a careless 'git add tests'.\n>>\n>> Signed-off-by: Eric Blake \n>> ---\n>> tests/.gitignore | 2 ++\n>> 1 file changed, 2 insertions(+)\n>>\n>> diff --git a/tests/.gitignore b/tests/.gitignore\n>> index fed0189a5a..64ecd6683b 100644\n>> --- a/tests/.gitignore\n>> +++ b/tests/.gitignore\n>> @@ -10,6 +10,8 @@ check-qnull\n>> check-qstring\n>> check-qom-interface\n>> check-qom-proplist\n>> +multiboot/test.out\n> \n> Your patch is of course a good idea ... but that test.out smells quite\n> bad ... I guess it should (a) use mktemp for a better file name instead\n> so that we can run this in parallel and (b) clean up the temporary file\n> once the test has been done?\n\nIndeed, making multiboot better, and run by default under 'make check',\nis a better task than just tweaking .gitignore, but one orthogonal\nenough to my libqtest changes that I will save this patch (and 2/29) for\nanother series (or if someone else wants to tackle it first).","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnYfm18sZz9s8J\n\tfor ;\n\tThu, 7 Sep 2017 05:33:50 +1000 (AEST)","from localhost ([::1]:37575 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpg55-0001fk-8t\n\tfor incoming@patchwork.ozlabs.org; Wed, 06 Sep 2017 15:33:47 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:42311)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpg4a-0001cP-MC\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 15:33:21 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpg4W-0003iF-EG\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 15:33:15 -0400","from mx1.redhat.com ([209.132.183.28]:56066)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dpg4W-0003hO-5R\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 15:33:12 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 379C55F7AE\n\tfor ; Wed, 6 Sep 2017 19:33:10 +0000 (UTC)","from [10.10.120.228] (ovpn-120-228.rdu2.redhat.com [10.10.120.228])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 435FA60460;\n\tWed, 6 Sep 2017 19:33:09 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 379C55F7AE","To":"Thomas Huth , qemu-devel@nongnu.org","References":"<20170901180340.30009-1-eblake@redhat.com>\n\t<20170901180340.30009-2-eblake@redhat.com>\n\t","From":"Eric Blake ","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"<0d39cd85-a721-4883-573a-50d64a2d4b99@redhat.com>","Date":"Wed, 6 Sep 2017 14:33:08 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"2I3KkuOftaVSkfg7bWWeBreMlPuihwLDm\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tWed, 06 Sep 2017 19:33:10 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH v6 01/29] tests: Improve .gitignore for\n\ttests/multiboot","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Kevin Wolf , pbonzini@redhat.com, armbru@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]