[{"id":1762226,"web_url":"http://patchwork.ozlabs.org/comment/1762226/","msgid":"<0939b71c-f05e-cfef-0499-9912bc82f49a@redhat.com>","list_archive_url":null,"date":"2017-09-03T08:21:13","subject":"Re: [PATCH 08/58] Mark __dso_handle as hidden [BZ #18822]","submitter":{"id":14312,"url":"http://patchwork.ozlabs.org/api/people/14312/","name":"Florian Weimer","email":"fweimer@redhat.com"},"content":"On 09/01/2017 07:59 PM, H.J. Lu wrote:\n> diff --git a/include/stdlib.h b/include/stdlib.h\n> index 2274790a2e..d0dcbf81c3 100644\n> --- a/include/stdlib.h\n> +++ b/include/stdlib.h\n> @@ -5,6 +5,10 @@\n>  #endif\n>  #include <stdlib/stdlib.h>\n>  \n> +/* __dso_handle is always defined by either crtbegin.o from GCC or our\n> +   dso_handle.c.  */\n> +extern void *__dso_handle __attribute__ ((visibility (\"hidden\")));\n\nThis causes conform test failures.  You need to use __visibility__ here.\n\nThanks,\nFlorian","headers":{"Return-Path":"<libc-alpha-return-84138-incoming=patchwork.ozlabs.org@sourceware.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84138-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"DESioqhE\"; dkim-atps=neutral","sourceware.org; auth=none","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=fweimer@redhat.com"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xlQtM2vbVz9s7f\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSun,  3 Sep 2017 18:21:30 +1000 (AEST)","(qmail 104242 invoked by alias); 3 Sep 2017 08:21:24 -0000","(qmail 104214 invoked by uid 89); 3 Sep 2017 08:21:23 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; q=dns; s=default; b=wP/OZMBIO4ezGp0I\n\tPLGZOeOcFMDnngMwzMgUfgWGNyfZElMoBo6HEUlLI6HAbmei7VROWcWLhHo9wkjP\n\tjKbiq2rAdJ+gRF8T9ohidu/qJAco/B2bcXC4uFMwrV4F2Wh0hfIHRhYZq2zF1fC3\n\t0y72ru+6ppnT16gJfNACP1bZDv8=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; s=default; bh=PNekHFqZ6WstLbRHUXjwmc\n\t4MfRI=; b=DESioqhEWI1kYcUpLFS7CuNJDhyzvSPvu1oEQCDs7SYoXzJoi6bOGt\n\t8Y5qhHLBYC6qInPVTDQpWL2PI8+hvVye1uDHh5m9jeDPm/LE1TiqV8pvB+tNoWve\n\tjoTi5h9Puvu8OOfI5mASIa4LEUOcejSAFFfS5tiL3U8vCgUZH0L6g=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"<libc-alpha.sourceware.org>","List-Unsubscribe":"<mailto:libc-alpha-unsubscribe-incoming=patchwork.ozlabs.org@sourceware.org>","List-Subscribe":"<mailto:libc-alpha-subscribe@sourceware.org>","List-Archive":"<http://sourceware.org/ml/libc-alpha/>","List-Post":"<mailto:libc-alpha@sourceware.org>","List-Help":"<mailto:libc-alpha-help@sourceware.org>,\n\t<http://sourceware.org/ml/#faqs>","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0,\n\tGIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RP_MATCHES_RCVD,\n\tSPF_HELO_PASS autolearn=ham version=3.3.2\n\tspammy=Hx-languages-length:551, our","X-HELO":"mx1.redhat.com","DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 78DC083F42","Subject":"Re: [PATCH 08/58] Mark __dso_handle as hidden [BZ #18822]","To":"\"H.J. Lu\" <hjl.tools@gmail.com>, libc-alpha@sourceware.org","References":"<20170901180029.9527-1-hjl.tools@gmail.com>\n\t<20170901180029.9527-9-hjl.tools@gmail.com>","From":"Florian Weimer <fweimer@redhat.com>","Message-ID":"<0939b71c-f05e-cfef-0499-9912bc82f49a@redhat.com>","Date":"Sun, 3 Sep 2017 10:21:13 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170901180029.9527-9-hjl.tools@gmail.com>","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"7bit"}},{"id":1762231,"web_url":"http://patchwork.ozlabs.org/comment/1762231/","msgid":"<72b6c789-caeb-08ba-67d2-30843d009658@redhat.com>","list_archive_url":null,"date":"2017-09-03T09:11:37","subject":"Re: [PATCH 08/58] Mark __dso_handle as hidden [BZ #18822]","submitter":{"id":14312,"url":"http://patchwork.ozlabs.org/api/people/14312/","name":"Florian Weimer","email":"fweimer@redhat.com"},"content":"On 09/03/2017 10:21 AM, Florian Weimer wrote:\n> On 09/01/2017 07:59 PM, H.J. Lu wrote:\n>> diff --git a/include/stdlib.h b/include/stdlib.h\n>> index 2274790a2e..d0dcbf81c3 100644\n>> --- a/include/stdlib.h\n>> +++ b/include/stdlib.h\n>> @@ -5,6 +5,10 @@\n>>  #endif\n>>  #include <stdlib/stdlib.h>\n>>  \n>> +/* __dso_handle is always defined by either crtbegin.o from GCC or our\n>> +   dso_handle.c.  */\n>> +extern void *__dso_handle __attribute__ ((visibility (\"hidden\")));\n> \n> This causes conform test failures.  You need to use __visibility__ here.\n\nOr alternatively, move the declaration under #ifndef _ISOMAC.  That's\nprobably the better approach because __dso_handle is not part of the\ninstalled headers.\n\nThanks,\nFlorian","headers":{"Return-Path":"<libc-alpha-return-84139-incoming=patchwork.ozlabs.org@sourceware.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84139-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"ggWRkf3c\"; dkim-atps=neutral","sourceware.org; auth=none","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=fweimer@redhat.com"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xlS0R2vmnz9s7f\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSun,  3 Sep 2017 19:11:51 +1000 (AEST)","(qmail 119469 invoked by alias); 3 Sep 2017 09:11:45 -0000","(qmail 119458 invoked by uid 89); 3 Sep 2017 09:11:45 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:from:to:references:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; q=dns; s=default; b=v9Prkot0ocieOvbn\n\tttkeT9/i88kvJsHBZxUEZUzITnx4vTPKrpPQIFxMJWnCDUCj2+rdKvGa0l1EekOz\n\tliwpYWFopjB/sDNkhdnAt0Hkf2+hoApJqyMifjuJ9jTTN3fJzSPhNgje9azah3qi\n\tE7SPdLiy8Os+RBLC7vsdgbxpb30=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:from:to:references:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; s=default; bh=Q2BWbuAgDcYLvYPRn/Dvoq\n\ty72jg=; b=ggWRkf3caQpmauG2CSW12+P7WNOdKWZbKVEqf/XNMo7IGPntGQbBCv\n\tcKn0ajnampqcsgQibFl6RZpxtO3WZmQZGLH1mLbKO8dYPS27zTi/tPx50AIp+wcP\n\tOrBmSX2MF5N9kN5X8/KfvLnEa/uUHQX+UL7U+6YqpVyuDEBAP2pOM=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"<libc-alpha.sourceware.org>","List-Unsubscribe":"<mailto:libc-alpha-unsubscribe-incoming=patchwork.ozlabs.org@sourceware.org>","List-Subscribe":"<mailto:libc-alpha-subscribe@sourceware.org>","List-Archive":"<http://sourceware.org/ml/libc-alpha/>","List-Post":"<mailto:libc-alpha@sourceware.org>","List-Help":"<mailto:libc-alpha-help@sourceware.org>,\n\t<http://sourceware.org/ml/#faqs>","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0,\n\tGIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RP_MATCHES_RCVD,\n\tSPF_HELO_PASS autolearn=ham version=3.3.2 spammy=our","X-HELO":"mx1.redhat.com","DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 29A265F73C","Subject":"Re: [PATCH 08/58] Mark __dso_handle as hidden [BZ #18822]","From":"Florian Weimer <fweimer@redhat.com>","To":"\"H.J. Lu\" <hjl.tools@gmail.com>, libc-alpha@sourceware.org","References":"<20170901180029.9527-1-hjl.tools@gmail.com>\n\t<20170901180029.9527-9-hjl.tools@gmail.com>\n\t<0939b71c-f05e-cfef-0499-9912bc82f49a@redhat.com>","Message-ID":"<72b6c789-caeb-08ba-67d2-30843d009658@redhat.com>","Date":"Sun, 3 Sep 2017 11:11:37 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<0939b71c-f05e-cfef-0499-9912bc82f49a@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"7bit"}},{"id":1762267,"web_url":"http://patchwork.ozlabs.org/comment/1762267/","msgid":"<CAMe9rOrH0+EZXUv4_drxCGDgtL91Z1cw8CxZ46oModUbO4teTQ@mail.gmail.com>","list_archive_url":null,"date":"2017-09-03T13:42:39","subject":"Re: [PATCH 08/58] Mark __dso_handle as hidden [BZ #18822]","submitter":{"id":4387,"url":"http://patchwork.ozlabs.org/api/people/4387/","name":"H.J. Lu","email":"hjl.tools@gmail.com"},"content":"On Sun, Sep 3, 2017 at 2:11 AM, Florian Weimer <fweimer@redhat.com> wrote:\n> On 09/03/2017 10:21 AM, Florian Weimer wrote:\n>> On 09/01/2017 07:59 PM, H.J. Lu wrote:\n>>> diff --git a/include/stdlib.h b/include/stdlib.h\n>>> index 2274790a2e..d0dcbf81c3 100644\n>>> --- a/include/stdlib.h\n>>> +++ b/include/stdlib.h\n>>> @@ -5,6 +5,10 @@\n>>>  #endif\n>>>  #include <stdlib/stdlib.h>\n>>>\n>>> +/* __dso_handle is always defined by either crtbegin.o from GCC or our\n>>> +   dso_handle.c.  */\n>>> +extern void *__dso_handle __attribute__ ((visibility (\"hidden\")));\n>>\n>> This causes conform test failures.  You need to use __visibility__ here.\n\nI am testing it.\n\n> Or alternatively, move the declaration under #ifndef _ISOMAC.  That's\n> probably the better approach because __dso_handle is not part of the\n> installed headers.\n>\n\nNo, we can't do that.  Some tests reference __dso_handle and _ISOMAC\nisn't defined for tests.\n\nBTW, hjl/pr18822 branch is what I am using.","headers":{"Return-Path":"<libc-alpha-return-84145-incoming=patchwork.ozlabs.org@sourceware.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84145-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"PRnXwtXk\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xlZ1975kKz9t2y\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSun,  3 Sep 2017 23:42:53 +1000 (AEST)","(qmail 2358 invoked by alias); 3 Sep 2017 13:42:47 -0000","(qmail 2338 invoked by uid 89); 3 Sep 2017 13:42:46 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-type; q=dns; s=default; b=vnJt\n\t/FW8NbARlk2EJ/ivSre7AGDE1QTPlK6OwZBKPaTxs+pHTatUnfGZWU6t918OKAtO\n\tIpZBmflajGBIdcQwly54ah6kDiroQGJHbr8p9ghRh5yeHfxxtcH2Tgox6MbQiVJh\n\t+UROUC289PC09QrNQhwg0+zZW8/f0wmAhzMVbD0=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-type; s=default; bh=ByW8AogskY\n\tK2mnNh3G/GG95fvQU=; b=PRnXwtXk4GQjxNd0urIBnVh6LZj+95jtuQ6sXQ3sod\n\tGdyV4uaFrcr51zuXWkwlNVhYZcSnP+Q1m1iIuChFxR8HCF2nbajXU5Jj7zFl83eU\n\tlDZWcvteYFkl04XL/pH22gPztyyySITXAL6tpOTX1//Va71znMMaPHO/0HmMHiAJ\n\to=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"<libc-alpha.sourceware.org>","List-Unsubscribe":"<mailto:libc-alpha-unsubscribe-incoming=patchwork.ozlabs.org@sourceware.org>","List-Subscribe":"<mailto:libc-alpha-subscribe@sourceware.org>","List-Archive":"<http://sourceware.org/ml/libc-alpha/>","List-Post":"<mailto:libc-alpha@sourceware.org>","List-Help":"<mailto:libc-alpha-help@sourceware.org>,\n\t<http://sourceware.org/ml/#faqs>","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-25.0 required=5.0 tests=AWL, BAYES_00,\n\tFREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2,\n\tGIT_PATCH_3, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM,\n\tSPF_PASS autolearn=ham version=3.3.2 spammy=our","X-HELO":"mail-oi0-f66.google.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=EIyu2+iW6DEuEyXFIiridHh87KHsv20jIxjX9suV1+U=;\n\tb=Cy9I/T+q+8r+db6BQMFJtCPvgeIgTq1b6keMJOSMmrmp3YyMzM7mXzzKtzJ6+O1U68\n\tFuJXnwmBnaIE6Oq8RgS4r24JutqRNNcMmgLfKQa+D2+dS/3Tv9DqUtr0rkmngeTs8QPe\n\tx5wz0yhDFWEUgx/H3Cc9S0D75oCn7F2sEhFl3+yuPHRkSUeFSE0dhSBLqIRgnwZVxiaY\n\tEZV87fCkCQ0+yDLBLMKU9nnLyiUj1T1bV9BCQuRoS3gOSTroxr739gnIFGEePDtFuN4w\n\tPb6HCWxUYQzrszPUaARPmV+O1PCllNXX04cdx3+5VPoFro8EIzsj/aSEksasuSgya5kO\n\tkRtQ==","X-Gm-Message-State":"AHPjjUiIImJJ/8FBnd6b9jHwk6q1HHU01swzPMUOqxOK+jd1/BBE2OPG\n\tnI+ErdvDjzigbskGgzydnRg30qRMYOK8","X-Google-Smtp-Source":"ADKCNb6bFEnAwjsOzFkf2brcXUw6k7KXSeJcOE9J9BnYjg/WfRgJiaAZG+HEbHnRFD2xgByt/SUqi9c4h/UvOfiWjkQ=","X-Received":"by 10.202.196.149 with SMTP id\n\tu143mr6254124oif.301.1504446160071; \n\tSun, 03 Sep 2017 06:42:40 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<72b6c789-caeb-08ba-67d2-30843d009658@redhat.com>","References":"<20170901180029.9527-1-hjl.tools@gmail.com>\n\t<20170901180029.9527-9-hjl.tools@gmail.com>\n\t<0939b71c-f05e-cfef-0499-9912bc82f49a@redhat.com>\n\t<72b6c789-caeb-08ba-67d2-30843d009658@redhat.com>","From":"\"H.J. Lu\" <hjl.tools@gmail.com>","Date":"Sun, 3 Sep 2017 06:42:39 -0700","Message-ID":"<CAMe9rOrH0+EZXUv4_drxCGDgtL91Z1cw8CxZ46oModUbO4teTQ@mail.gmail.com>","Subject":"Re: [PATCH 08/58] Mark __dso_handle as hidden [BZ #18822]","To":"Florian Weimer <fweimer@redhat.com>","Cc":"GNU C Library <libc-alpha@sourceware.org>","Content-Type":"text/plain; charset=\"UTF-8\""}},{"id":1762473,"web_url":"http://patchwork.ozlabs.org/comment/1762473/","msgid":"<ba44334a-ae81-59d9-1e5d-2abc76f45ba2@redhat.com>","list_archive_url":null,"date":"2017-09-04T07:22:58","subject":"Re: [PATCH 08/58] Mark __dso_handle as hidden [BZ #18822]","submitter":{"id":14312,"url":"http://patchwork.ozlabs.org/api/people/14312/","name":"Florian Weimer","email":"fweimer@redhat.com"},"content":"On 09/03/2017 03:42 PM, H.J. Lu wrote:\n> On Sun, Sep 3, 2017 at 2:11 AM, Florian Weimer <fweimer@redhat.com> wrote:\n>> On 09/03/2017 10:21 AM, Florian Weimer wrote:\n>>> On 09/01/2017 07:59 PM, H.J. Lu wrote:\n>>>> diff --git a/include/stdlib.h b/include/stdlib.h\n>>>> index 2274790a2e..d0dcbf81c3 100644\n>>>> --- a/include/stdlib.h\n>>>> +++ b/include/stdlib.h\n>>>> @@ -5,6 +5,10 @@\n>>>>  #endif\n>>>>  #include <stdlib/stdlib.h>\n>>>>\n>>>> +/* __dso_handle is always defined by either crtbegin.o from GCC or our\n>>>> +   dso_handle.c.  */\n>>>> +extern void *__dso_handle __attribute__ ((visibility (\"hidden\")));\n>>>\n>>> This causes conform test failures.  You need to use __visibility__ here.\n\n>> Or alternatively, move the declaration under #ifndef _ISOMAC.  That's\n>> probably the better approach because __dso_handle is not part of the\n>> installed headers.\n>>\n> \n> No, we can't do that.  Some tests reference __dso_handle and _ISOMAC\n> isn't defined for tests.\n\nThese tests should be moved to tests-internal, or __dso_handle should be\ndeclared in a different header and the tests should include it.\n\nAs far as I understand it, the _ISOMAC mechanism is there to make the\ninclude/ headers as close as possible to the installed headers, so\ndeclaring things there which are not available after installation\npartially invalidates in-tree testing.\n\nThanks,\nFlorian","headers":{"Return-Path":"<libc-alpha-return-84153-incoming=patchwork.ozlabs.org@sourceware.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84153-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"hr93zDJj\"; dkim-atps=neutral","sourceware.org; auth=none","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=fweimer@redhat.com"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xm1XY2QNLz9ryr\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon,  4 Sep 2017 17:23:09 +1000 (AEST)","(qmail 10903 invoked by alias); 4 Sep 2017 07:23:02 -0000","(qmail 10886 invoked by uid 89); 4 Sep 2017 07:23:02 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:cc:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; q=dns; s=default; b=O4WRViOuTACYcsmo\n\t2YSncObb9wKglNJvg6RW2APxXphC4cwkbpwWG2JHm675i+YROTqYh/MotFNDwMI3\n\tzdpE3pz5Ya/Ix4201iUU5UnwfkgUHRvp3TRNZ9ITHLo/0vI49ooSHfwbK1XXeimS\n\tWDRvnD5+NoRhDZOU+dos9umLCP4=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:cc:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; s=default; bh=CBjzSKv/7UhtBw9S/ufq18\n\txy8ag=; b=hr93zDJji1ROXmtoO5TW7qBLQzQ+4Axxle+cqNTHewT1P8TFXDPjsT\n\tFa/oOa7J0v6WIhD4LN+iaTVwwPTIdtT8htjGQdVKFsZG/YfO+xym95fRRflB0viJ\n\tDKRf2F4d+ACNinRm3DNoif6PS6yYNzraa7d0xb1iNIr4C+PKGjqQQ=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"<libc-alpha.sourceware.org>","List-Unsubscribe":"<mailto:libc-alpha-unsubscribe-incoming=patchwork.ozlabs.org@sourceware.org>","List-Subscribe":"<mailto:libc-alpha-subscribe@sourceware.org>","List-Archive":"<http://sourceware.org/ml/libc-alpha/>","List-Post":"<mailto:libc-alpha@sourceware.org>","List-Help":"<mailto:libc-alpha-help@sourceware.org>,\n\t<http://sourceware.org/ml/#faqs>","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-25.9 required=5.0 tests=BAYES_00, GIT_PATCH_0,\n\tGIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3,\n\tKAM_LAZY_DOMAIN_SECURITY, RP_MATCHES_RCVD,\n\tSPF_HELO_PASS autolearn=ham version=3.3.2 spammy=","X-HELO":"mx1.redhat.com","DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com EF91F61460","Subject":"Re: [PATCH 08/58] Mark __dso_handle as hidden [BZ #18822]","To":"\"H.J. Lu\" <hjl.tools@gmail.com>","Cc":"GNU C Library <libc-alpha@sourceware.org>","References":"<20170901180029.9527-1-hjl.tools@gmail.com>\n\t<20170901180029.9527-9-hjl.tools@gmail.com>\n\t<0939b71c-f05e-cfef-0499-9912bc82f49a@redhat.com>\n\t<72b6c789-caeb-08ba-67d2-30843d009658@redhat.com>\n\t<CAMe9rOrH0+EZXUv4_drxCGDgtL91Z1cw8CxZ46oModUbO4teTQ@mail.gmail.com>","From":"Florian Weimer <fweimer@redhat.com>","Message-ID":"<ba44334a-ae81-59d9-1e5d-2abc76f45ba2@redhat.com>","Date":"Mon, 4 Sep 2017 09:22:58 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<CAMe9rOrH0+EZXUv4_drxCGDgtL91Z1cw8CxZ46oModUbO4teTQ@mail.gmail.com>","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"7bit"}},{"id":1762879,"web_url":"http://patchwork.ozlabs.org/comment/1762879/","msgid":"<CAMe9rOqOSpJX=wPKq0pc4crbSvwN_wSZva_p=mEyLrP6t1BnrA@mail.gmail.com>","list_archive_url":null,"date":"2017-09-04T21:19:52","subject":"Re: [PATCH 08/58] Mark __dso_handle as hidden [BZ #18822]","submitter":{"id":4387,"url":"http://patchwork.ozlabs.org/api/people/4387/","name":"H.J. Lu","email":"hjl.tools@gmail.com"},"content":"On Mon, Sep 4, 2017 at 12:22 AM, Florian Weimer <fweimer@redhat.com> wrote:\n> On 09/03/2017 03:42 PM, H.J. Lu wrote:\n>> On Sun, Sep 3, 2017 at 2:11 AM, Florian Weimer <fweimer@redhat.com> wrote:\n>>> On 09/03/2017 10:21 AM, Florian Weimer wrote:\n>>>> On 09/01/2017 07:59 PM, H.J. Lu wrote:\n>>>>> diff --git a/include/stdlib.h b/include/stdlib.h\n>>>>> index 2274790a2e..d0dcbf81c3 100644\n>>>>> --- a/include/stdlib.h\n>>>>> +++ b/include/stdlib.h\n>>>>> @@ -5,6 +5,10 @@\n>>>>>  #endif\n>>>>>  #include <stdlib/stdlib.h>\n>>>>>\n>>>>> +/* __dso_handle is always defined by either crtbegin.o from GCC or our\n>>>>> +   dso_handle.c.  */\n>>>>> +extern void *__dso_handle __attribute__ ((visibility (\"hidden\")));\n>>>>\n>>>> This causes conform test failures.  You need to use __visibility__ here.\n>\n>>> Or alternatively, move the declaration under #ifndef _ISOMAC.  That's\n>>> probably the better approach because __dso_handle is not part of the\n>>> installed headers.\n>>>\n>>\n>> No, we can't do that.  Some tests reference __dso_handle and _ISOMAC\n>> isn't defined for tests.\n>\n> These tests should be moved to tests-internal, or __dso_handle should be\n\nWe may not define _ISOMAC for these tests since it may introduce\nmany issues.\n\n> declared in a different header and the tests should include it.\n\nHere is an updated with include/dso_handle.h.  OK for master?\n\nThanks.","headers":{"Return-Path":"<libc-alpha-return-84179-incoming=patchwork.ozlabs.org@sourceware.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84179-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"kyn2QtE/\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmN6J6WyDz9s8J\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue,  5 Sep 2017 07:20:08 +1000 (AEST)","(qmail 115420 invoked by alias); 4 Sep 2017 21:20:02 -0000","(qmail 115407 invoked by uid 89); 4 Sep 2017 21:20:01 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-type; q=dns; s=default; b=M7Rp\n\txPrzgm3/Z8SNkcI2SDLFq8rB4V81RbwL7fNHiG0JFFQYZ8Z9dAITq53iFxrjPYTm\n\tlJMHcK1SyD30DeF+b4FwHlpjV2b+/4UA8JjETEcBF6BTpQORIjOj+TcYrzO3G6lu\n\t/Hb9w/dLnv4n/0zbMLDpvzr1BkxjR+SBy5XEkJE=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-type; s=default; bh=2fl7RNgRO8\n\t2yBV5pLnNKsi99Y5w=; b=kyn2QtE/cQhF0leD9jKYDqo+ep9O/VmRDoFt6FG2ZQ\n\tL/nkQRw+X78cJfB5IklHMejiWgrNTW8TynyHa7+ipnO0bLBRN4LGXBfVsDja6xS6\n\td8dl6V627f1nmRTpK/92EUtkkoYxq/yrA2L0fk/ID70HwdDGEQFq5/LSrUV8FSOD\n\tc=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"<libc-alpha.sourceware.org>","List-Unsubscribe":"<mailto:libc-alpha-unsubscribe-incoming=patchwork.ozlabs.org@sourceware.org>","List-Subscribe":"<mailto:libc-alpha-subscribe@sourceware.org>","List-Archive":"<http://sourceware.org/ml/libc-alpha/>","List-Post":"<mailto:libc-alpha@sourceware.org>","List-Help":"<mailto:libc-alpha-help@sourceware.org>,\n\t<http://sourceware.org/ml/#faqs>","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-25.0 required=5.0 tests=AWL, BAYES_00,\n\tFREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2,\n\tGIT_PATCH_3, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM,\n\tSPF_PASS autolearn=ham version=3.3.2 spammy=","X-HELO":"mail-oi0-f65.google.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=915h8ZBOLkxbxSbyhScV2EhqtraV1m66HHZPUzxoSTs=;\n\tb=DJ6Uhgu8ZADTOn6tXEhoLbS1t/WCfhe8IVFBRD10oULAOVCZftwlU2GxfuYkCJS44i\n\t2cEXAa9/Fuo7iDobuO1ISAUPHzSL0Xp6p1pqoayEnhuR80VIEEaoFS5xYxQgejTrkAKt\n\tOaB+vV7UE35FZcZ4LAMdHlOPqyLiQOMA0sFJtWqhApM9+HFYKUxVsdPZ5dhOof7hnFbr\n\tC8vmP49QVtaNj7faDz4pmy8t8sZkqRTOFWLzLbOi2eUX5k258VlKg9Ao+ypQV/lJ70kV\n\tzzNu7Sl/mWEXFUg7bitjVXmgPj0xvxnYNyj0V967/RQz8gq14kB+GUbLj0zts83xzsir\n\tSsyQ==","X-Gm-Message-State":"AHPjjUi/uP/IVE4pTeS5Vt/U11tag0N54kY24l22iZRPenUVKytBDwT4\n\tpOdRdew2lcgRjbHT+sqHr1E6qLxMih6j","X-Google-Smtp-Source":"ADKCNb4gYy9plpODD3wA2mRks2VnQXgHI/+n7zMBBSXcT80WNIfmvZu0BJBNyRxXihzW3WDa30RHUOiyqa7ggPpbRRQ=","X-Received":"by 10.202.117.13 with SMTP id q13mr1532167oic.97.1504559993695; \n\tMon, 04 Sep 2017 14:19:53 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<ba44334a-ae81-59d9-1e5d-2abc76f45ba2@redhat.com>","References":"<20170901180029.9527-1-hjl.tools@gmail.com>\n\t<20170901180029.9527-9-hjl.tools@gmail.com>\n\t<0939b71c-f05e-cfef-0499-9912bc82f49a@redhat.com>\n\t<72b6c789-caeb-08ba-67d2-30843d009658@redhat.com>\n\t<CAMe9rOrH0+EZXUv4_drxCGDgtL91Z1cw8CxZ46oModUbO4teTQ@mail.gmail.com>\n\t<ba44334a-ae81-59d9-1e5d-2abc76f45ba2@redhat.com>","From":"\"H.J. Lu\" <hjl.tools@gmail.com>","Date":"Mon, 4 Sep 2017 14:19:52 -0700","Message-ID":"<CAMe9rOqOSpJX=wPKq0pc4crbSvwN_wSZva_p=mEyLrP6t1BnrA@mail.gmail.com>","Subject":"Re: [PATCH 08/58] Mark __dso_handle as hidden [BZ #18822]","To":"Florian Weimer <fweimer@redhat.com>","Cc":"GNU C Library <libc-alpha@sourceware.org>","Content-Type":"multipart/mixed; boundary=\"001a1134fb3ef8b62e055863ab39\""}},{"id":1767191,"web_url":"http://patchwork.ozlabs.org/comment/1767191/","msgid":"<CAMe9rOoc7w_GrY8FnC9XBp7Cfe2zdoRb3o=OzO_MySkVEHirVQ@mail.gmail.com>","list_archive_url":null,"date":"2017-09-12T15:56:56","subject":"Re: [PATCH 08/58] Mark __dso_handle as hidden [BZ #18822]","submitter":{"id":4387,"url":"http://patchwork.ozlabs.org/api/people/4387/","name":"H.J. Lu","email":"hjl.tools@gmail.com"},"content":"On Mon, Sep 4, 2017 at 2:19 PM, H.J. Lu <hjl.tools@gmail.com> wrote:\n> On Mon, Sep 4, 2017 at 12:22 AM, Florian Weimer <fweimer@redhat.com> wrote:\n>> On 09/03/2017 03:42 PM, H.J. Lu wrote:\n>>> On Sun, Sep 3, 2017 at 2:11 AM, Florian Weimer <fweimer@redhat.com> wrote:\n>>>> On 09/03/2017 10:21 AM, Florian Weimer wrote:\n>>>>> On 09/01/2017 07:59 PM, H.J. Lu wrote:\n>>>>>> diff --git a/include/stdlib.h b/include/stdlib.h\n>>>>>> index 2274790a2e..d0dcbf81c3 100644\n>>>>>> --- a/include/stdlib.h\n>>>>>> +++ b/include/stdlib.h\n>>>>>> @@ -5,6 +5,10 @@\n>>>>>>  #endif\n>>>>>>  #include <stdlib/stdlib.h>\n>>>>>>\n>>>>>> +/* __dso_handle is always defined by either crtbegin.o from GCC or our\n>>>>>> +   dso_handle.c.  */\n>>>>>> +extern void *__dso_handle __attribute__ ((visibility (\"hidden\")));\n>>>>>\n>>>>> This causes conform test failures.  You need to use __visibility__ here.\n>>\n>>>> Or alternatively, move the declaration under #ifndef _ISOMAC.  That's\n>>>> probably the better approach because __dso_handle is not part of the\n>>>> installed headers.\n>>>>\n>>>\n>>> No, we can't do that.  Some tests reference __dso_handle and _ISOMAC\n>>> isn't defined for tests.\n>>\n>> These tests should be moved to tests-internal, or __dso_handle should be\n>\n> We may not define _ISOMAC for these tests since it may introduce\n> many issues.\n>\n>> declared in a different header and the tests should include it.\n>\n> Here is an updated with include/dso_handle.h.  OK for master?\n>\n> Thanks.\n>\n\nAny comments or objections?\n\nThanks.","headers":{"Return-Path":"<libc-alpha-return-84519-incoming=patchwork.ozlabs.org@sourceware.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84519-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"RDJIwUqO\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xs8Yt1s2Pz9s76\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 13 Sep 2017 01:57:06 +1000 (AEST)","(qmail 109288 invoked by alias); 12 Sep 2017 15:57:00 -0000","(qmail 109279 invoked by uid 89); 12 Sep 2017 15:56:59 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-type; q=dns; s=default; b=wE9F\n\t7Xt5FFl3raUKagJ3J/vKGp2VlP1PkkEIeAgwbOMqSH9TqHmdqpbp2l/zhJWX/+C6\n\t5hG6+v8P+KXIvEOYPX47PebHav2WpTN8A30W0/mXa80KQNyUYemBKBHOdT4KPdgZ\n\thl2uUmsm9z/71boQ+54beNW+FaAHeDEqmK9xEyw=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-type; s=default; bh=LZzKABEho3\n\tWQ8uk8B/piXnir8aI=; b=RDJIwUqOnm9/Y9dZAlWCRYPeieyV9Xlx01gIQvPDNI\n\t7cKxI/uh+H00wB5ZTKtJD8eFLLqG0HYmtJNAT4KF5WTJmmzepNRIy6rHAnbuq+ee\n\tHELTwxlLc9lyrO7iYm7CeeocqghAaGDtuOHLeIPnSBMzvLWE/RmXuIwok9jvA1fO\n\ts=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"<libc-alpha.sourceware.org>","List-Unsubscribe":"<mailto:libc-alpha-unsubscribe-incoming=patchwork.ozlabs.org@sourceware.org>","List-Subscribe":"<mailto:libc-alpha-subscribe@sourceware.org>","List-Archive":"<http://sourceware.org/ml/libc-alpha/>","List-Post":"<mailto:libc-alpha@sourceware.org>","List-Help":"<mailto:libc-alpha-help@sourceware.org>,\n\t<http://sourceware.org/ml/#faqs>","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-25.0 required=5.0 tests=AWL, BAYES_00,\n\tFREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2,\n\tGIT_PATCH_3, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM,\n\tSPF_PASS autolearn=ham version=3.3.2 spammy=H*RU:209.85.223.196,\n\tHx-spam-relays-external:209.85.223.196,\n\tHx-languages-length:1568, our","X-HELO":"mail-io0-f196.google.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=sHtzwGvbK3de/Mnf7oTuQM7tBwPbg1SIyfA5URw9RG4=;\n\tb=tSU7HYf9l4VeWFPVL+wW6kJaHbnNMT7lxiiJzQZ7DkH4mXhyF6WV1K46sLliC7wlSX\n\tXMCHJuICGQ9n7+09/m3mxxJRUDWKDXp3KsjYwr9opSax6bSYk2jQaMjIiGa1pvv6XFUe\n\tyIMcxxg6ET5WPqrxCtNUqc91h5ZBs0uSX+uTzFLBmU8JMD/bO4/6WICxWvkPxm9dW4NH\n\tYBtLvCLROFoI0J6GA+I3dIeDIln21BKT3BqzErf/T/UEZT/p/UHhVZAtwXxOvLMsaunU\n\t2RaUB7RbzPpaFAFVALv6s3k5h6qaiBCOk7zGQiWC9uDELGRZXy8+CB6WAM7Vd4EaA3D+\n\tCJ/g==","X-Gm-Message-State":"AHPjjUg/xHzjD/J02QyyMInq/WVo5+R9YQmqL5eyGI+eZ6yhuo7jPoFH\n\tMw3GQGnNnu1BMy7GwPDur+A0lrxMgg==","X-Google-Smtp-Source":"AOwi7QA8VM/bEktB0Plkg6z0ZfMF1aE98m7oXZQ8x3magYxMPkBG+7KIfsT3EEfwVv8vrJsSQCx+rqAMovGXi2KbzG4=","X-Received":"by 10.202.227.21 with SMTP id a21mr15100964oih.194.1505231816765;\n\tTue, 12 Sep 2017 08:56:56 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<CAMe9rOqOSpJX=wPKq0pc4crbSvwN_wSZva_p=mEyLrP6t1BnrA@mail.gmail.com>","References":"<20170901180029.9527-1-hjl.tools@gmail.com>\n\t<20170901180029.9527-9-hjl.tools@gmail.com>\n\t<0939b71c-f05e-cfef-0499-9912bc82f49a@redhat.com>\n\t<72b6c789-caeb-08ba-67d2-30843d009658@redhat.com>\n\t<CAMe9rOrH0+EZXUv4_drxCGDgtL91Z1cw8CxZ46oModUbO4teTQ@mail.gmail.com>\n\t<ba44334a-ae81-59d9-1e5d-2abc76f45ba2@redhat.com>\n\t<CAMe9rOqOSpJX=wPKq0pc4crbSvwN_wSZva_p=mEyLrP6t1BnrA@mail.gmail.com>","From":"\"H.J. Lu\" <hjl.tools@gmail.com>","Date":"Tue, 12 Sep 2017 08:56:56 -0700","Message-ID":"<CAMe9rOoc7w_GrY8FnC9XBp7Cfe2zdoRb3o=OzO_MySkVEHirVQ@mail.gmail.com>","Subject":"Re: [PATCH 08/58] Mark __dso_handle as hidden [BZ #18822]","To":"Florian Weimer <fweimer@redhat.com>","Cc":"GNU C Library <libc-alpha@sourceware.org>","Content-Type":"text/plain; charset=\"UTF-8\""}},{"id":1775942,"web_url":"http://patchwork.ozlabs.org/comment/1775942/","msgid":"<CAMe9rOrnq2dycGY23f97ec9BHAkWqsnC8C1SugJpUY2b2Qj1zw@mail.gmail.com>","list_archive_url":null,"date":"2017-09-26T22:53:30","subject":"Re: [PATCH 08/58] Mark __dso_handle as hidden [BZ #18822]","submitter":{"id":4387,"url":"http://patchwork.ozlabs.org/api/people/4387/","name":"H.J. Lu","email":"hjl.tools@gmail.com"},"content":"On 9/12/17, H.J. Lu <hjl.tools@gmail.com> wrote:\n> On Mon, Sep 4, 2017 at 2:19 PM, H.J. Lu <hjl.tools@gmail.com> wrote:\n>> On Mon, Sep 4, 2017 at 12:22 AM, Florian Weimer <fweimer@redhat.com>\n>> wrote:\n>>> On 09/03/2017 03:42 PM, H.J. Lu wrote:\n>>>> On Sun, Sep 3, 2017 at 2:11 AM, Florian Weimer <fweimer@redhat.com>\n>>>> wrote:\n>>>>> On 09/03/2017 10:21 AM, Florian Weimer wrote:\n>>>>>> On 09/01/2017 07:59 PM, H.J. Lu wrote:\n>>>>>>> diff --git a/include/stdlib.h b/include/stdlib.h\n>>>>>>> index 2274790a2e..d0dcbf81c3 100644\n>>>>>>> --- a/include/stdlib.h\n>>>>>>> +++ b/include/stdlib.h\n>>>>>>> @@ -5,6 +5,10 @@\n>>>>>>>  #endif\n>>>>>>>  #include <stdlib/stdlib.h>\n>>>>>>>\n>>>>>>> +/* __dso_handle is always defined by either crtbegin.o from GCC or\n>>>>>>> our\n>>>>>>> +   dso_handle.c.  */\n>>>>>>> +extern void *__dso_handle __attribute__ ((visibility (\"hidden\")));\n>>>>>>\n>>>>>> This causes conform test failures.  You need to use __visibility__\n>>>>>> here.\n>>>\n>>>>> Or alternatively, move the declaration under #ifndef _ISOMAC.  That's\n>>>>> probably the better approach because __dso_handle is not part of the\n>>>>> installed headers.\n>>>>>\n>>>>\n>>>> No, we can't do that.  Some tests reference __dso_handle and _ISOMAC\n>>>> isn't defined for tests.\n>>>\n>>> These tests should be moved to tests-internal, or __dso_handle should be\n>>\n>> We may not define _ISOMAC for these tests since it may introduce\n>> many issues.\n>>\n>>> declared in a different header and the tests should include it.\n>>\n>> Here is an updated with include/dso_handle.h.  OK for master?\n>>\n>> Thanks.\n>>\n>\n> Any comments or objections?\n>\n> Thanks.\n>\n\nI will check it in today.","headers":{"Return-Path":"<libc-alpha-return-85004-incoming=patchwork.ozlabs.org@sourceware.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-85004-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"DSiEiUbf\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1x851PsNz9t30\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 27 Sep 2017 08:53:40 +1000 (AEST)","(qmail 48119 invoked by alias); 26 Sep 2017 22:53:33 -0000","(qmail 48105 invoked by uid 89); 26 Sep 2017 22:53:33 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-type; q=dns; s=default; b=MZkk\n\t4EQLx6BDJddd5NsXc7pHHvqBtzQo3W8lhDR+2qJIGqWWK9aogA39LgFdgQU6+Nta\n\tT+u+P3Kf4Wn4MVdmIkwBzkGOH8tuFuFI83RRF7G/rs2OceCZ1b2lzl4h4To7YeER\n\tErIEyhAdK75rLFzs3CRF/AjdfwszALumgdaquEc=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-type; s=default; bh=tpapgvRQs1\n\tnS/Y+msAU+Y2bNlqw=; b=DSiEiUbfkjlDwX6RHfRdnY8hAt+aDfl3v4WM3hBOBy\n\tqmwofMZHEVbJLIHJKwhzls8awh9La3F6NEcZ3mhmPKm02d8/bXlSWMmLtSkUgabv\n\tPY6WdTq7kXQMda+H0Tij5V6lQaX4pZqTgUZHJk3eoZO3i8dHOsexGZt+8fLmOpz2\n\tk=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"<libc-alpha.sourceware.org>","List-Unsubscribe":"<mailto:libc-alpha-unsubscribe-incoming=patchwork.ozlabs.org@sourceware.org>","List-Subscribe":"<mailto:libc-alpha-subscribe@sourceware.org>","List-Archive":"<http://sourceware.org/ml/libc-alpha/>","List-Post":"<mailto:libc-alpha@sourceware.org>","List-Help":"<mailto:libc-alpha-help@sourceware.org>,\n\t<http://sourceware.org/ml/#faqs>","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-25.0 required=5.0 tests=AWL, BAYES_00,\n\tFREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2,\n\tGIT_PATCH_3, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM,\n\tSPF_PASS autolearn=ham version=3.3.2 spammy=our","X-HELO":"mail-oi0-f66.google.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=709660Sw4CMe5zVGI3xE5vOe66YIJ9f0m2GwyXWxVj8=;\n\tb=RD7wuaCj/80FeJQKpN6iFUeKmFm+ZC/WM4ekKUQEy6GbeCbdS/mzlaDTAAHL2WesBI\n\toAYgnomMfVeutqxj34ucZfHekYdAoRwsUhvEP5dinkPL9I4Z9QkE38WofkJOn/LfYQdS\n\tTWooYQJu7DjeHpHIM5KOZ5aSOznu3UBi/1eso0FRCgMWRkCau/5wNfj+ikA8LQIteOSw\n\tXK8VqjJu4EzPB60BtAsGJmQlaCjfyVtydZ1a/URGXlyHMTh9yzJxrO90PhOjlIiUopqh\n\t8uW3h7vKReww+/st5Z35awqNsphlLwx4IU6QY05j8+M8/a2nHnCQSQCA/XrHmqe0A/nb\n\tzObw==","X-Gm-Message-State":"AHPjjUi5+Wdklmu/z9S4UWOe90zwiL6XaAvkB1KZ96SMbG43rdU+qLsX\n\tMw0e9riX90xYFZHR92zilF2UVL62QTr6AoQLx2g=","X-Google-Smtp-Source":"AOwi7QBxjtuPopXiFIEFwL2bJaDC3rRQGhzDuEGGNZERSdW9FAMfOEiIwye/WcOvmL++Ey+Y9bO5vA/tIqNe8MPFxv8=","X-Received":"by 10.157.61.72 with SMTP id a66mr3385101otc.290.1506466410439; \n\tTue, 26 Sep 2017 15:53:30 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<CAMe9rOoc7w_GrY8FnC9XBp7Cfe2zdoRb3o=OzO_MySkVEHirVQ@mail.gmail.com>","References":"<20170901180029.9527-1-hjl.tools@gmail.com>\n\t<20170901180029.9527-9-hjl.tools@gmail.com>\n\t<0939b71c-f05e-cfef-0499-9912bc82f49a@redhat.com>\n\t<72b6c789-caeb-08ba-67d2-30843d009658@redhat.com>\n\t<CAMe9rOrH0+EZXUv4_drxCGDgtL91Z1cw8CxZ46oModUbO4teTQ@mail.gmail.com>\n\t<ba44334a-ae81-59d9-1e5d-2abc76f45ba2@redhat.com>\n\t<CAMe9rOqOSpJX=wPKq0pc4crbSvwN_wSZva_p=mEyLrP6t1BnrA@mail.gmail.com>\n\t<CAMe9rOoc7w_GrY8FnC9XBp7Cfe2zdoRb3o=OzO_MySkVEHirVQ@mail.gmail.com>","From":"\"H.J. Lu\" <hjl.tools@gmail.com>","Date":"Tue, 26 Sep 2017 15:53:30 -0700","Message-ID":"<CAMe9rOrnq2dycGY23f97ec9BHAkWqsnC8C1SugJpUY2b2Qj1zw@mail.gmail.com>","Subject":"Re: [PATCH 08/58] Mark __dso_handle as hidden [BZ #18822]","To":"Florian Weimer <fweimer@redhat.com>","Cc":"GNU C Library <libc-alpha@sourceware.org>","Content-Type":"text/plain; charset=\"UTF-8\""}}]