[{"id":1778077,"web_url":"http://patchwork.ozlabs.org/comment/1778077/","msgid":"","list_archive_url":null,"date":"2017-10-01T21:45:19","subject":"Re: [PATCH 09/58] Mark internal wchar functions with\n\tattribute_hidden [BZ #18822]","submitter":{"id":4387,"url":"http://patchwork.ozlabs.org/api/people/4387/","name":"H.J. Lu","email":"hjl.tools@gmail.com"},"content":"On 9/1/17, H.J. Lu wrote:\n> Mark internal wchar functions with attribute_hidden to allow direct\n> access within libc.so and libc.a without using GOT nor PLT.\n>\n> \t[BZ #18822]\n> \t* include/wchar.h (__wcsnlen): Add attribute_hidden.\n> \t(__wcscat): Likewise.\n> \t(__btowc): Likewise.\n> \t(__wcrtomb): Likewise.\n> \t(__mbsrtowcs): Likewise.\n> \t(__wcsrtombs): Likewise.\n> \t(__mbsnrtowcs): Likewise.\n> \t(__wcsnrtombs): Likewise.\n> \t(__wcsncpy): Likewise.\n> \t(__wcpncpy): Likewise.\n> \t(__wmemcpy): Likewise.\n> \t(__wmempcpy): Likewise.\n> \t(__wmemmove): Likewise.\n> \t(__wcschrnul): Likewise.\n> \t(__vfwscanf): Likewise.\n> \t(__vswprintf): Likewise.\n> \t(__fwprintf): Likewise.\n> \t(__vfwprintf): Likewise.\n\nTested with build-many-glibcs.py. I am checking it in.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-85200-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"ggTIMyfk\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y4zPL3BcKz9t2V\n\tfor ;\n\tMon, 2 Oct 2017 08:45:42 +1100 (AEDT)","(qmail 65471 invoked by alias); 1 Oct 2017 21:45:35 -0000","(qmail 65386 invoked by uid 89); 1 Oct 2017 21:45:23 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:content-type; q=dns; s=default; b=nPDiZk/\n\t9D9zNynadJ9L+nFiyDVUpq2FTFfTIroG5cBV7JzLN7ohjGGgzF5p/M4iXUki+pvD\n\tJ5zb4qDkCcqn3tddgUcoYTKkyipdS720m4O/0dMJY8Dsk552sECdb2dUZtyc/UWS\n\tqgyPBD1cLo8qB0vuacG5RREEwXdE1grnZwX0=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:content-type; s=default; bh=57U4p21fVLczm\n\tTUm0SKTDyBk+2g=; b=ggTIMyfkSa+fzGcRnHWK/4HFCiWnASo6G+M5ugEt/MY0l\n\ttFqrvY6OWq2Q+g19Wg8UiaUoMqAax8JycjLoNHJ4o3Cs2bJn/GVMhylcvpgYBMLn\n\tgwsrv3d+cbaaHkocLm08GQwmFoUJeNEoD5Qu/e4m1kKd15PXCOiPguI2qjiXS4=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-2.5 required=5.0 tests=AWL, BAYES_00,\n\tFREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM,\n\tSPF_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:841","X-HELO":"mail-oi0-f67.google.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to;\n\tbh=FAhsIFN+6K2HvSKuQIm+xbJ6XhUmbdkgK+A9o0H2sWw=;\n\tb=HZAJL3b8gEJc2FIb6NzLy52v0Pb9zHffue6sNQKUI4FpYPGpB1CZIWhIlzdU/PLXbi\n\tP17qALyfnXP3tAgu8ogjmKTc3GxWj5FEKuSQpOmcAP5xYDY3STNvVwigXlT2djqt7Uep\n\tX+hwJKt945g+D9YWlTJV5H3/e4it+k9opBu78WQ752uqjoobqRghwNOuv6aEWjLHaQU9\n\t/+J9qohRh/oYoGb3NAkdSkAOaYAOToHqYNcafSD2RjEKDEYbL9FFUjPy6f1nO5j+8ipY\n\tbx7wpsranyxDGswgsuV4uCnq1SkYvAB9P35UjW6jT0tpgFrIPtIQbV8KwajbX7Z5ZIm9\n\tPN+A==","X-Gm-Message-State":"AMCzsaXmqOkK87x4VieR1XTYjUDux+PR9HOWSXACmjCLrE+UuhDsQpwj\n\tg9g/3gUYtN8NJpyqG+uW0tDUE/yLVwvDgHQmGV4=","X-Google-Smtp-Source":"AOwi7QCPtOZx9b7R1LJ35ppg57tDvlccsHHHe69ajiyBOisiCpMU1TREIPu/oOk0CtBTv4a0SSbIwFmxoDuhD/klEUQ=","X-Received":"by 10.157.43.104 with SMTP id f37mr2539582otd.491.1506894319962; \n\tSun, 01 Oct 2017 14:45:19 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170901180029.9527-10-hjl.tools@gmail.com>","References":"<20170901180029.9527-1-hjl.tools@gmail.com>\n\t<20170901180029.9527-10-hjl.tools@gmail.com>","From":"\"H.J. Lu\" ","Date":"Sun, 1 Oct 2017 14:45:19 -0700","Message-ID":"","Subject":"Re: [PATCH 09/58] Mark internal wchar functions with\n\tattribute_hidden [BZ #18822]","To":"libc-alpha@sourceware.org","Content-Type":"text/plain; charset=\"UTF-8\""}},{"id":1803560,"web_url":"http://patchwork.ozlabs.org/comment/1803560/","msgid":"<5a96c1f1-8a08-5382-8ed0-608ea26237ef@linux.vnet.ibm.com>","list_archive_url":null,"date":"2017-11-13T10:16:42","subject":"Re: [PATCH 09/58] Mark internal wchar functions with\n\tattribute_hidden [BZ #18822]","submitter":{"id":61855,"url":"http://patchwork.ozlabs.org/api/people/61855/","name":"Stefan Liebler","email":"stli@linux.vnet.ibm.com"},"content":"On 09/01/2017 07:59 PM, H.J. Lu wrote:\n> Mark internal wchar functions with attribute_hidden to allow direct\n> access within libc.so and libc.a without using GOT nor PLT.\n\nOn s390 (31bit) various debug/tst-*chk* testcases are failing as the \ntests are ending with a segmentation fault.\nAs some of the wchar functions are IFUNC, those are called via PLT,\nbut r12 is not loaded with the GOT-pointer. Then it e.g. branches to \naddress zero which leads to the segmentation fault.\n\nPlease have a look at the patch \"Use libc_hidden_proto / _def for hidden \nwchar ifunc symbols.\" \n(https://www.sourceware.org/ml/libc-alpha/2017-11/msg00391.html).\n\nBye.\nStefan","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-87017-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"HPwF3HKc\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yb65444Q2z9sMN\n\tfor ;\n\tMon, 13 Nov 2017 21:17:12 +1100 (AEDT)","(qmail 67507 invoked by alias); 13 Nov 2017 10:16:51 -0000","(qmail 67383 invoked by uid 89); 13 Nov 2017 10:16:51 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:from:date:mime-version\n\t:in-reply-to:content-type:content-transfer-encoding:message-id;\n\tq=dns; s=default; b=B/KSeDIKOB8BPmiWnUDCftmWTmxGH+o3YawaJLhid+b\n\tDmVMnj0otnyV2lqwcGHBriW2i/wFMFEEwQkHOjU3M7HmNPzGy7zKqc3P/mSo6eeP\n\tZuGF1hOAx826BRb4BIFetonoE7s9fK6xAC0snSocMdXl6/w55lCkKpZQ+AYiYrD8\n\t=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:from:date:mime-version\n\t:in-reply-to:content-type:content-transfer-encoding:message-id;\n\ts=default; bh=eZu5SwxLeDeVVjOBH6z/lbOV5nA=; b=HPwF3HKcL3qV4EF8L\n\tuWIR7t6Uw1wfaLlRQiNxhxYovjaxY2IqDGfqLcHCGCwb2YtElOYjKky50a6KDRbY\n\tJThRpCgBwoJiHd+iEfvz/6QBmHKLKBfbn7V9v74qweR1L/B9st8x83C8Twp8k0p4\n\t+zlVxA0NQYd9YEUbKfIRuZXoA4=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-2.0 required=5.0 tests=AWL, BAYES_00,\n\tKAM_LAZY_DOMAIN_SECURITY,\n\tRCVD_IN_DNSWL_LOW autolearn=no version=3.3.2\n\tspammy=Hx-languages-length:732","X-HELO":"mx0a-001b2d01.pphosted.com","Subject":"Re: [PATCH 09/58] Mark internal wchar functions with\n\tattribute_hidden [BZ #18822]","To":"libc-alpha@sourceware.org","References":"<20170901180029.9527-1-hjl.tools@gmail.com>\n\t<20170901180029.9527-10-hjl.tools@gmail.com>","From":"Stefan Liebler ","Date":"Mon, 13 Nov 2017 11:16:42 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.4.0","MIME-Version":"1.0","In-Reply-To":"<20170901180029.9527-10-hjl.tools@gmail.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","X-TM-AS-GCONF":"00","x-cbid":"17111310-0016-0000-0000-000005009C49","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17111310-0017-0000-0000-0000283C4E5A","Message-Id":"<5a96c1f1-8a08-5382-8ed0-608ea26237ef@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-11-13_04:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tpriorityscore=1501\n\tmalwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0\n\tclxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0\n\tclassifier=spam adjust=0 reason=mlx scancount=1\n\tengine=8.0.1-1707230000\n\tdefinitions=main-1711130143"}}]