[{"id":1778075,"web_url":"http://patchwork.ozlabs.org/comment/1778075/","msgid":"<CAMe9rOpT_C9obEoPRGO28935Vf5jpRKfTxVHaQZQeD-TUHOfxw@mail.gmail.com>","list_archive_url":null,"date":"2017-10-01T21:43:32","subject":"Re: [PATCH 06/58] Mark internal unistd functions with\n\tattribute_hidden [BZ #18822]","submitter":{"id":4387,"url":"http://patchwork.ozlabs.org/api/people/4387/","name":"H.J. Lu","email":"hjl.tools@gmail.com"},"content":"On 9/1/17, H.J. Lu <hjl.tools@gmail.com> wrote:\n> Mark internal unistd functions with attribute_hidden to allow direct\n> access to them within libc.so and libc.a without using GOT nor PLT.\n>\n> \t[BZ #18822]\n> \t* include/unistd.h (__access): Add attribute_hidden.\n> \t(__lseek64): Likewise.\n> \t(__libc_pread64): Likewise.\n> \t(__pipe2): Likewise.\n> \t(__sleep): Likewise.\n> \t(__chdir): Likewise.\n> \t(__fchdir): Likewise.\n> \t(__getcwd): Likewise.\n> \t(__rmdir): Likewise.\n> \t(__execvpe): Likewise.\n> \t(__execve): Likewise.\n> \t(__setsid): Likewise.\n> \t(__getuid): Likewise.\n> \t(__geteuid): Likewise.\n> \t(__getgid): Likewise.\n> \t(__getegid): Likewise.\n> \t(__getgroups): Likewise.\n> \t(__group_member): Likewise.\n> \t(__ttyname_r): Likewise.\n> \t(__isatty): Likewise.\n> \t(__readlink): Likewise.\n> \t(__unlink): Likewise.\n> \t(__gethostname): Likewise.\n> \t(__profil): Likewise.\n> \t(__getdtablesize): Likewise.\n> \t(__brk): Likewise.\n> \t(__ftruncate): Likewise.\n> \t(__ftruncate64): Likewise.\n\nTested with build-many-glibcs.py.  I am checking it in.","headers":{"Return-Path":"<libc-alpha-return-85198-incoming=patchwork.ozlabs.org@sourceware.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-85198-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"RKgep/Oh\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y4zM152Z2z9sxR\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon,  2 Oct 2017 08:43:41 +1100 (AEDT)","(qmail 62451 invoked by alias); 1 Oct 2017 21:43:36 -0000","(qmail 62442 invoked by uid 89); 1 Oct 2017 21:43:35 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:content-type; q=dns; s=default; b=BpA8hrd\n\t37bb14Us/SOj5LoD8D/z9C+2RPdNjt7gNhaiEmSLYA8kFr+uRu6TlTw9zwriyIc8\n\tCnOqTayHAso05nNhLQaXklAk4Gjw7jC2xoLdxVwky6TWmKSb7Xe3Y3g/GlnkzpJT\n\tb/AxX1qqaE9teujYHae+7yGA9jIBdMGHXmtc=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:content-type; s=default; bh=bqJRp7PlttlQY\n\tEeR55o0fRJxLgI=; b=RKgep/OhRJNz5R0T94Ud0v/Tfkib3ExHbm1l+uDCtp+Vc\n\tN+T/Dtz4/rpu0GMkb5Nufk4FC0ABho2AmytJnjJ/YXiEztS7ukV6dxj11ZYSjZ4S\n\t13YHUCskALCvJrz05Tye62gp+WSoKOHPzekV7fUHEc+Oakw6XXWNtJsaU+nXdU=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"<libc-alpha.sourceware.org>","List-Unsubscribe":"<mailto:libc-alpha-unsubscribe-incoming=patchwork.ozlabs.org@sourceware.org>","List-Subscribe":"<mailto:libc-alpha-subscribe@sourceware.org>","List-Archive":"<http://sourceware.org/ml/libc-alpha/>","List-Post":"<mailto:libc-alpha@sourceware.org>","List-Help":"<mailto:libc-alpha-help@sourceware.org>,\n\t<http://sourceware.org/ml/#faqs>","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-2.5 required=5.0 tests=AWL, BAYES_00,\n\tFREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM,\n\tSPF_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:1094","X-HELO":"mail-oi0-f48.google.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to;\n\tbh=oOGwN2SU3ciEULHNEyZJZ1OScuO7JpJRR5+n/WX2/wM=;\n\tb=ipmZZNH/P/oWXu30G+xVJgJXNdD5q22i+7v+Bx2S7hOG+dEBFpsa/rLIF2BHFk/GtB\n\tihtxE7O01itbi3OopH6jOo10IOQP1A+bkc9HMlZHB10CfTpXU90M8iGZiYEhkQO3cOIw\n\tadm60HR+P9Lb2CcpafKz1fXtWWPMLTt0GkMdg+fY/eS39k4SlLcOBLo8dxB7YAhaNkYD\n\tKlTYU07tQPHtp3LDRsHj+7ApyYjnP7xl9Io6vVkKJsW6Bbzu1TvoMRZL5CefvU2amO9x\n\tb7uNjabL4BWYtto7ci3Diy1+OYnc5ONtsnBvhZ66I1ipL4bF3p1ngF410DQ8G1tbFrT4\n\t59Xw==","X-Gm-Message-State":"AMCzsaW2+54ONe2ZVLPDJGiNiAThlpANFwx0OZCEP/+JtVP4vPr5vqjl\n\t/x40TY+XPTtLUOGyOpwurdB5Vmfz0w3ZIhFOlzg=","X-Google-Smtp-Source":"AOwi7QDqllhk9XZ/2W5XdTHeZQ/zVlKHiE99pSPaoV+scGlY7h8+JfZpGLKflD3v6kNT5s3lNTH38UQjulwxQM7irdQ=","X-Received":"by 10.202.171.216 with SMTP id\n\tu207mr1082937oie.430.1506894212933; \n\tSun, 01 Oct 2017 14:43:32 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170901180029.9527-7-hjl.tools@gmail.com>","References":"<20170901180029.9527-1-hjl.tools@gmail.com>\n\t<20170901180029.9527-7-hjl.tools@gmail.com>","From":"\"H.J. Lu\" <hjl.tools@gmail.com>","Date":"Sun, 1 Oct 2017 14:43:32 -0700","Message-ID":"<CAMe9rOpT_C9obEoPRGO28935Vf5jpRKfTxVHaQZQeD-TUHOfxw@mail.gmail.com>","Subject":"Re: [PATCH 06/58] Mark internal unistd functions with\n\tattribute_hidden [BZ #18822]","To":"libc-alpha@sourceware.org","Content-Type":"text/plain; charset=\"UTF-8\""}}]