[{"id":1778076,"web_url":"http://patchwork.ozlabs.org/comment/1778076/","msgid":"","list_archive_url":null,"date":"2017-10-01T21:44:24","subject":"Re: [PATCH 07/58] Mark internal grp/pwd/shadow functions with\n\tattribute_hidden [BZ #18822]","submitter":{"id":4387,"url":"http://patchwork.ozlabs.org/api/people/4387/","name":"H.J. Lu","email":"hjl.tools@gmail.com"},"content":"On 9/1/17, H.J. Lu wrote:\n> Mark internal grp/pwd/shadow functions with attribute_hidden to allow\n> direct access within libc.so and libc.a without using GOT nor PLT.\n>\n> \t[BZ #18822]\n> \t* include/grp.h (__fgetgrent_r): Add attribute_hidden.\n> \t(__getgrgid_r): Likewise.\n> \t(__getgrnam_r): Likewise.\n> \t* include/pwd.h (__getpwuid_r): Likewise.\n> \t(__getpwnam_r): Likewise.\n> \t(__fgetpwent_r): Likewise.\n> \t* include/shadow.h (__getspnam_r): Likewise.\n> \t(__sgetspent_r): Likewise.\n> \t(__fgetspent_r): Likewise.\n\nTested with build-many-glibcs.py. I am checking it in.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-85199-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"UVruq8fZ\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y4zN31RPGz9t2V\n\tfor ;\n\tMon, 2 Oct 2017 08:44:35 +1100 (AEDT)","(qmail 63822 invoked by alias); 1 Oct 2017 21:44:28 -0000","(qmail 63813 invoked by uid 89); 1 Oct 2017 21:44:28 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:content-type; q=dns; s=default; b=vYcZObB\n\txWrCy2unKhBaGiylfBluzEZIoIKOJuEItl5gZm070Lj3gQ54/dnwrUMCmPk0q4BP\n\t1Z7udWCYz8C4keIHRInEPROKJa38vxoldJvjLlucYs9CXsCUZ5V3JMQKVThA1C8x\n\tdnB306dRWbKoYL7UI1Gldj67tza05Z9SS4Jc=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:content-type; s=default; bh=aGYZTnYomxZkV\n\t6dfeZcFaWEzb0c=; b=UVruq8fZyjaKDyT2YA8AEW/cXCpyQGrJhqDilncih4FOp\n\tQJHziivet07Spd0Sn0KVhp/Pqa/CBvVUob/hGNWIAOg2OA3X0tvFLra9q8CCH/Fx\n\tX3oWPKyhU7Cvb0JvUPzWFFiHmNqSyjvEGRoPbQt927gM4I5Dgg3iXYaS+HSXoo=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-2.5 required=5.0 tests=AWL, BAYES_00,\n\tFREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM,\n\tSPF_PASS autolearn=no version=3.3.2 spammy=","X-HELO":"mail-oi0-f53.google.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to;\n\tbh=QhZ3Tsjx5NPOscnFqhsMPux6wTFlMmrX0Sb/wgWLx4c=;\n\tb=AnuTYDtg9bDaWo0U5rYd5lxVSLOquk2iWfy3XS8pXT4Ky0+e3Yf9uyrvVky3xVW2Zw\n\t5uZ4eDBxDEvbaZbpHeaVW92UojXa+vjYnD5B+8n74Kj2GP4d91vOR9zDmOUGg/I1xdwN\n\t42jrkFjtcS3c6oLX6dqD80bn/KKr23HBnoWFdwTF8DcUF8p5BehLDwU8e/l4yBtRrMkp\n\tniPvsvaLLcDhffYyGBjDfX/VNsGgnvUSPqCxSwtb+a4RSI2lmZA4XZLZlQS88auCv/Kp\n\tHzfcJqcnNPX8f3sIIIbkXSi1AdRd/AK0mf1BBufloxqFx9cOnoUKRY88unWPLGscBngy\n\tqAWw==","X-Gm-Message-State":"AMCzsaW9HVZMgAYixigbVek2uA9qZYDxlq8d5bQJqtvw67SWyvKsIWcL\n\t9hIRaiXYKfEXxYIRzANbbuW7cAtbA3aty2RUgdc=","X-Google-Smtp-Source":"AOwi7QDqknhB4j+yv45uNg4NgTOsJRsbRW3KOv4HQt5giTK5803aWoYWS2QyfDot4dIu0Xz5upOO4kuAgHlmg/H/DGY=","X-Received":"by 10.157.10.129 with SMTP id 1mr6310647otq.201.1506894265269;\n\tSun, 01 Oct 2017 14:44:25 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170901180029.9527-8-hjl.tools@gmail.com>","References":"<20170901180029.9527-1-hjl.tools@gmail.com>\n\t<20170901180029.9527-8-hjl.tools@gmail.com>","From":"\"H.J. Lu\" ","Date":"Sun, 1 Oct 2017 14:44:24 -0700","Message-ID":"","Subject":"Re: [PATCH 07/58] Mark internal grp/pwd/shadow functions with\n\tattribute_hidden [BZ #18822]","To":"libc-alpha@sourceware.org","Content-Type":"text/plain; charset=\"UTF-8\""}}]