[{"id":1761979,"web_url":"http://patchwork.ozlabs.org/comment/1761979/","msgid":"<20170901205207.GA1522@jhogan-linux.le.imgtec.org>","list_archive_url":null,"date":"2017-09-01T20:52:07","subject":"Re: [Qemu-devel] [PATCH v3 3/7] Convert single line fprintf(.../n)\n\tto warn_report()","submitter":{"id":18920,"url":"http://patchwork.ozlabs.org/api/people/18920/","name":"James Hogan","email":"james.hogan@imgtec.com"},"content":"On Fri, Sep 01, 2017 at 09:51:15AM -0700, Alistair Francis wrote:\n> diff --git a/target/mips/kvm.c b/target/mips/kvm.c\n> index 3317905e71..a23aa438d2 100644\n> --- a/target/mips/kvm.c\n> +++ b/target/mips/kvm.c\n> @@ -95,11 +95,11 @@ void kvm_mips_reset_vcpu(MIPSCPU *cpu)\n> CPUMIPSState *env = &cpu->env;\n> \n> if (!kvm_mips_fpu_cap && env->CP0_Config1 & (1 << CP0C1_FP)) {\n> - fprintf(stderr, \"Warning: KVM does not support FPU, disabling\\n\");\n> + warn_report(\"KVM does not support FPU, disabling\");\n> env->CP0_Config1 &= ~(1 << CP0C1_FP);\n> }\n> if (!kvm_mips_msa_cap && env->CP0_Config3 & (1 << CP0C3_MSAP)) {\n> - fprintf(stderr, \"Warning: KVM does not support MSA, disabling\\n\");\n> + warn_report(\"KVM does not support MSA, disabling\");\n> env->CP0_Config3 &= ~(1 << CP0C3_MSAP);\n> }\n\nThat looks sensible.\nReviewed-by: James Hogan [mips]\n\nThe 3 fprintfs in kvm_mips_update_state() are also pretty much non-fatal\nwarnings too (though only because old kernels v3.10-v3.15 didn't\nimplement the timer saving API). Feel free to convert those too if you\nlike, otherwise I'll submit along with some other changes.\n\nCheers\nJames","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkWf36xcMz9sNr\n\tfor ;\n\tSat, 2 Sep 2017 06:52:42 +1000 (AEST)","from localhost ([::1]:60076 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnsvf-0002qf-76\n\tfor incoming@patchwork.ozlabs.org; Fri, 01 Sep 2017 16:52:39 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:47368)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnsvK-0002pg-A6\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 16:52:19 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnsvH-0007dU-7x\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 16:52:18 -0400","from mailapp01.imgtec.com ([195.59.15.196]:55731)\n\tby eggs.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnsvH-0007a8-0n\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 16:52:15 -0400","from hhmail02.hh.imgtec.org (unknown [10.100.10.20])\n\tby Forcepoint Email with ESMTPS id 0A68F58AF4192;\n\tFri, 1 Sep 2017 21:52:05 +0100 (IST)","from localhost (192.168.154.110) by hhmail02.hh.imgtec.org\n\t(10.100.10.21) with Microsoft SMTP Server (TLS) id 14.3.294.0;\n\tFri, 1 Sep 2017 21:52:08 +0100"],"Date":"Fri, 1 Sep 2017 21:52:07 +0100","From":"James Hogan ","To":"Alistair Francis ","Message-ID":"<20170901205207.GA1522@jhogan-linux.le.imgtec.org>","References":"\n\t","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"jRHKVT23PllUwdXP\"","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.7.2 (2016-11-26)","X-Originating-IP":"[192.168.154.110]","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [fuzzy]","X-Received-From":"195.59.15.196","Subject":"Re: [Qemu-devel] [PATCH v3 3/7] Convert single line fprintf(.../n)\n\tto warn_report()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Kevin Wolf , Eduardo Habkost ,\n\t\"Michael S. Tsirkin\" , armbru@redhat.com,\n\tJason Wang , qemu-devel@nongnu.org,\n\tMax Reitz , Igor Mammedov ,\n\tGerd Hoffmann ,\n\tStefan Hajnoczi , pbonzini@redhat.com,\n\tYongbok Kim , alistair23@gmail.com,\n\tMichael Roth ,\n\tAurelien Jarno ,\n\tRichard Henderson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1763532,"web_url":"http://patchwork.ozlabs.org/comment/1763532/","msgid":"","list_archive_url":null,"date":"2017-09-05T17:46:38","subject":"Re: [Qemu-devel] [PATCH v3 3/7] Convert single line fprintf(.../n)\n\tto warn_report()","submitter":{"id":47878,"url":"http://patchwork.ozlabs.org/api/people/47878/","name":"Alistair Francis","email":"alistair.francis@xilinx.com"},"content":"On Fri, Sep 1, 2017 at 1:52 PM, James Hogan wrote:\n> On Fri, Sep 01, 2017 at 09:51:15AM -0700, Alistair Francis wrote:\n>> diff --git a/target/mips/kvm.c b/target/mips/kvm.c\n>> index 3317905e71..a23aa438d2 100644\n>> --- a/target/mips/kvm.c\n>> +++ b/target/mips/kvm.c\n>> @@ -95,11 +95,11 @@ void kvm_mips_reset_vcpu(MIPSCPU *cpu)\n>> CPUMIPSState *env = &cpu->env;\n>>\n>> if (!kvm_mips_fpu_cap && env->CP0_Config1 & (1 << CP0C1_FP)) {\n>> - fprintf(stderr, \"Warning: KVM does not support FPU, disabling\\n\");\n>> + warn_report(\"KVM does not support FPU, disabling\");\n>> env->CP0_Config1 &= ~(1 << CP0C1_FP);\n>> }\n>> if (!kvm_mips_msa_cap && env->CP0_Config3 & (1 << CP0C3_MSAP)) {\n>> - fprintf(stderr, \"Warning: KVM does not support MSA, disabling\\n\");\n>> + warn_report(\"KVM does not support MSA, disabling\");\n>> env->CP0_Config3 &= ~(1 << CP0C3_MSAP);\n>> }\n>\n> That looks sensible.\n> Reviewed-by: James Hogan [mips]\n\nThanks\n\n>\n> The 3 fprintfs in kvm_mips_update_state() are also pretty much non-fatal\n> warnings too (though only because old kernels v3.10-v3.15 didn't\n> implement the timer saving API). Feel free to convert those too if you\n> like, otherwise I'll submit along with some other changes.\n\nOk, I'll add an extra patch to this series which converts those.\n\nThanks,\nAlistair\n\n>\n> Cheers\n> James","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"vJE1Cclu\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmvMv3JHrz9sNc\n\tfor ;\n\tWed, 6 Sep 2017 03:48:43 +1000 (AEST)","from localhost ([::1]:60399 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpHxp-0006ZM-KW\n\tfor incoming@patchwork.ozlabs.org; Tue, 05 Sep 2017 13:48:41 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:55198)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpHwQ-0005xk-So\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 13:47:19 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpHwM-0005vS-5z\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 13:47:14 -0400","from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]:38637)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dpHwL-0005uq-V0\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 13:47:10 -0400","by mail-wm0-x243.google.com with SMTP id u26so3495548wma.5\n\tfor ; Tue, 05 Sep 2017 10:47:09 -0700 (PDT)","by 10.28.191.130 with HTTP; Tue, 5 Sep 2017 10:46:38 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=9jZssP0OZ5/oi4JyxtAeWdLSPv9qs5azwQ38n11n1rA=;\n\tb=vJE1CcluuXWos7VD8CovFpnwxeNHrZN36Ir9YiuFMft9+bTScW5f4IXGBiAkZP2TT1\n\tCuBRyFrfN0FYIOpHaLV0m2oW7AvknLY9xVRROVFeXy92AZkuAppeU95sX+c5/rGSfjDv\n\t79V3l8yiZpJALVi0Ovb4g2/5dPRyJbGUZShxiDHe2xp3ldsL3j6Q9m4ZPBIdq2VEhFeg\n\t9924Pqz+/F1nRXQV8475+kgs0CuNHbRambrpHP970KWKcgqIq/L0fdTDiB6Jwx/yXWn6\n\tG2GBMdXhhDesusdgmHv9rSKXoMG90WVJsaY87gYZgXyf9iAYf6CYJYSesO0I6wlkAOke\n\tl4+A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=9jZssP0OZ5/oi4JyxtAeWdLSPv9qs5azwQ38n11n1rA=;\n\tb=qRnOiANa3xWcKi6S+P+rfHEIB+eFWfGRiQgXoT1bRfrL06Tl1F/p5D7QIeTzLyzp/a\n\t6KNTfDivjZc39NdGIVZCqPC5moZKpw5uDlI2I8EPkQkAI+3ckmv0g4SkbwAfa+CedGPF\n\tbomR0BrSakm5Twl7Bo/DVOh1DZ3Q8c7ggS4+BrCNe4a3/BVLxs6d/zh0UbqlVzT7bfwN\n\tp8WqCnZ9d+71wkaom+4vrCPfThGbbGtB7pfqgDuTyuc70/LLjavgy3QjpJJ8e9EK3y7G\n\ttdI5txxBx4ROGOqFPP4tnrXTBQWk6tsNhBKnie6NXfJ8TmuEiyL5CoiJvocutAz9oGsz\n\tNRHQ==","X-Gm-Message-State":"AHPjjUg2FhP1gyNFIHqw9unstssz2K/R3Wg4xvJIwZKza0LKixNWhSBc\n\tkW5YQV2Iv08CTdzATKePlNUYVejIJg==","X-Google-Smtp-Source":"ADKCNb4cAwjzaf/1wiuyroxKHPh0NxDX8FlPl1u+lbIlAumvMFacbu75f36q4Wz6C3UczGoJn4QVsRJJfo9SekpBvVc=","X-Received":"by 10.28.234.196 with SMTP id g65mr3654752wmi.73.1504633628839; \n\tTue, 05 Sep 2017 10:47:08 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170901205207.GA1522@jhogan-linux.le.imgtec.org>","References":"\n\t\n\t<20170901205207.GA1522@jhogan-linux.le.imgtec.org>","From":"Alistair Francis ","Date":"Tue, 5 Sep 2017 10:46:38 -0700","X-Google-Sender-Auth":"5APnrzQ318xRz_4YI__O99-kow4","Message-ID":"","To":"James Hogan ","Content-Type":"text/plain; charset=\"UTF-8\"","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c09::243","Subject":"Re: [Qemu-devel] [PATCH v3 3/7] Convert single line fprintf(.../n)\n\tto warn_report()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Kevin Wolf , Eduardo Habkost ,\n\t\"Michael S. Tsirkin\" ,\n\tMichael Roth ,\n\tAlistair Francis ,\n\tMarkus Armbruster ,\n\t\"qemu-devel@nongnu.org Developers\" ,\n\tGerd Hoffmann ,\n\tStefan Hajnoczi , \n\tIgor Mammedov ,\n\tYongbok Kim , \n\tPaolo Bonzini ,\n\tMax Reitz , Jason Wang ,\n\tAurelien Jarno ,\n\tRichard Henderson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]