[{"id":1762682,"web_url":"http://patchwork.ozlabs.org/comment/1762682/","msgid":"<20170904141748.GU7570@localhost.localdomain>","list_archive_url":null,"date":"2017-09-04T14:17:48","subject":"Re: [Qemu-devel] [PATCH v3 1/7] hw/i386: Improve some of the\n\twarning messages","submitter":{"id":195,"url":"http://patchwork.ozlabs.org/api/people/195/","name":"Eduardo Habkost","email":"ehabkost@redhat.com"},"content":"On Fri, Sep 01, 2017 at 09:51:05AM -0700, Alistair Francis wrote:\n[...]\n> diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c\n> index 169a214d50..435eb2c458 100644\n> --- a/hw/i386/pc_q35.c\n> +++ b/hw/i386/pc_q35.c\n> @@ -101,9 +101,11 @@ static void pc_q35_init(MachineState *machine)\n> lowmem = pcms->max_ram_below_4g;\n> if (machine->ram_size - lowmem > lowmem &&\n> lowmem & ((1ULL << 30) - 1)) {\n> - warn_report(\"Large machine and max_ram_below_4g(%\"PRIu64\n> - \") not a multiple of 1G; possible bad performance.\",\n> - pcms->max_ram_below_4g);\n> + warn_report(\"Large machine as the ram size (0x%\" PRIx64 \") is more\"\n> + \" then twice the size of the internal limit\"\n> + \" (0x%\" PRIx64 \") and max-ram-below-4g (%\"PRIu64\")\"\n> + \" note a multiple of 1G; possible bad performance.\",\n> + machine->ram_size, lowmem, pcms->max_ram_below_4g);\n\nHere lowmem and max_ram_below_4g have exactly the same value,\ndon't they? There's no internal limit involved in this logic,\nonly max_ram_below_4g and ram_size.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=ehabkost@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmBmM6L27z9s7h\n\tfor ;\n\tTue, 5 Sep 2017 00:18:59 +1000 (AEST)","from localhost ([::1]:46139 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dosDJ-0004pR-Sm\n\tfor incoming@patchwork.ozlabs.org; Mon, 04 Sep 2017 10:18:57 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:53763)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dosCL-0004dc-6C\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 10:18:03 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dosCG-00068g-25\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 10:17:57 -0400","from mx1.redhat.com ([209.132.183.28]:58138)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dosCF-00068G-S5\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 10:17:51 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 981ED4E047;\n\tMon, 4 Sep 2017 14:17:50 +0000 (UTC)","from localhost (ovpn-116-66.gru2.redhat.com [10.97.116.66])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 056867F545;\n\tMon, 4 Sep 2017 14:17:49 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 981ED4E047","Date":"Mon, 4 Sep 2017 11:17:48 -0300","From":"Eduardo Habkost ","To":"Alistair Francis ","Message-ID":"<20170904141748.GU7570@localhost.localdomain>","References":"\n\t<5bf40ca8376c537ac05dd848a84e072a88a1d939.1504228916.git.alistair.francis@xilinx.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<5bf40ca8376c537ac05dd848a84e072a88a1d939.1504228916.git.alistair.francis@xilinx.com>","X-Fnord":"you can see the fnord","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tMon, 04 Sep 2017 14:17:50 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v3 1/7] hw/i386: Improve some of the\n\twarning messages","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"alistair23@gmail.com, pbonzini@redhat.com, qemu-devel@nongnu.org,\n\tDon Slutz , armbru@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1763525,"web_url":"http://patchwork.ozlabs.org/comment/1763525/","msgid":"","list_archive_url":null,"date":"2017-09-05T17:32:25","subject":"Re: [Qemu-devel] [PATCH v3 1/7] hw/i386: Improve some of the\n\twarning messages","submitter":{"id":47878,"url":"http://patchwork.ozlabs.org/api/people/47878/","name":"Alistair Francis","email":"alistair.francis@xilinx.com"},"content":"On Mon, Sep 4, 2017 at 7:17 AM, Eduardo Habkost wrote:\n> On Fri, Sep 01, 2017 at 09:51:05AM -0700, Alistair Francis wrote:\n> [...]\n>> diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c\n>> index 169a214d50..435eb2c458 100644\n>> --- a/hw/i386/pc_q35.c\n>> +++ b/hw/i386/pc_q35.c\n>> @@ -101,9 +101,11 @@ static void pc_q35_init(MachineState *machine)\n>> lowmem = pcms->max_ram_below_4g;\n>> if (machine->ram_size - lowmem > lowmem &&\n>> lowmem & ((1ULL << 30) - 1)) {\n>> - warn_report(\"Large machine and max_ram_below_4g(%\"PRIu64\n>> - \") not a multiple of 1G; possible bad performance.\",\n>> - pcms->max_ram_below_4g);\n>> + warn_report(\"Large machine as the ram size (0x%\" PRIx64 \") is more\"\n>> + \" then twice the size of the internal limit\"\n>> + \" (0x%\" PRIx64 \") and max-ram-below-4g (%\"PRIu64\")\"\n>> + \" note a multiple of 1G; possible bad performance.\",\n>> + machine->ram_size, lowmem, pcms->max_ram_below_4g);\n>\n> Here lowmem and max_ram_below_4g have exactly the same value,\n> don't they? There's no internal limit involved in this logic,\n> only max_ram_below_4g and ram_size.\n\nGood point, I'll change it to this:\n\nwarn_report(\"There is possibly poor performance as the ram size \"\n \" (0x%\" PRIx64 \") is more then twice the size of\"\n \" max-ram-below-4g (%\"PRIu64\") and\"\n \" max-ram-below-4g is not a multiple of 1G.\",\n machine->ram_size, pcms->max_ram_below_4g);\n\nThanks,\nAlistair\n\n>\n> --\n> Eduardo","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"bOmBSyin\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmv2S5RnZz9sRm\n\tfor ;\n\tWed, 6 Sep 2017 03:33:34 +1000 (AEST)","from localhost ([::1]:60340 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpHj7-00023B-CR\n\tfor incoming@patchwork.ozlabs.org; Tue, 05 Sep 2017 13:33:29 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:50719)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpHij-00022u-5K\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 13:33:09 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpHie-0005od-Ia\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 13:33:05 -0400","from mail-wr0-x241.google.com ([2a00:1450:400c:c0c::241]:36440)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dpHie-0005nY-BN\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 13:33:00 -0400","by mail-wr0-x241.google.com with SMTP id 40so2030196wrv.3\n\tfor ; Tue, 05 Sep 2017 10:32:58 -0700 (PDT)","by 10.28.191.130 with HTTP; Tue, 5 Sep 2017 10:32:25 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=qKQGVp1hBCv08yrTC0bruKueQOa1UDLGPmueS17MuwU=;\n\tb=bOmBSyinAh+ccxc8F+LjILdk/0v85QPsuxzoV8s1qKugavf0ZuXyxp+zYuxnfIl69L\n\ttLgC/I3x4Cty0I9vP1yAMrdXNePUs+LKbZREYzFbi2Qx1AeHTvqPS6+ULOxAsDutSuN/\n\tIzJvAYtE1e1DhcaUmmfXaUcu9+Go7ipVx6yVGsv6T9bCnescb2NefOMZVF8kqW6hUSXL\n\tJIYkqFMOEh86vyGaD00JEKlb2ksVL0RKqiSUADUtoTaqYUaRfowIYQpLSpSzUDj/Mc/h\n\tZstNs7eajiEUnIGVffuzR2gODW3wk3PhqNgDVXCVVZpGsXDkY6O2j7wZR0IR6nIMC+5H\n\twrrg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=qKQGVp1hBCv08yrTC0bruKueQOa1UDLGPmueS17MuwU=;\n\tb=ecAnooQTHzyK4xhTAkqv9mIDDJ9QZe7d/O3C8d6gqhjrfmFCUEukEc9LdQGa/ZcXNS\n\trYlxATv1wtReNMQWWnOyUrpkw8KyJ5zqN+4ModS67f9HDmi6BFRKDj5lOSKhKjLTWgQO\n\tGOmSPH8PUQsJx5MDsYt6IesDjoiBjWmAaOAVMpXTl2MJjBXZtnrA8SQ/XZAc/OjzxO8a\n\t5VEhGYFiuLI1eeiAqo80XPH0OtS21iKFHdHRFDLslWfW0FuohExhs42mghe87redAy3s\n\tcKQt9bPElg6tGfcWohGgKQH9XvQcL5EsNImEmKw2nJp1X7/zi5+wH8n4szSyCv/Kiqm6\n\t4K+Q==","X-Gm-Message-State":"AHPjjUjC1u+BWoznvlHvLofCtNgNLHUCFy5ynVYzdyNbD7ZwAH7uKQVJ\n\twHD2xKcKM8eJZqpXXB1xfqHsdBqS+w==","X-Google-Smtp-Source":"ADKCNb5nHmnYBrI31OU8o1IJg/8XyQwlQXFE97bv5vh8NSHOflTKhXWQgzO5E0XbdXj1/IQ/Nbgg9azzKjJyfRbsUw4=","X-Received":"by 10.223.163.83 with SMTP id d19mr2700604wrb.84.1504632776474; \n\tTue, 05 Sep 2017 10:32:56 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170904141748.GU7570@localhost.localdomain>","References":"\n\t<5bf40ca8376c537ac05dd848a84e072a88a1d939.1504228916.git.alistair.francis@xilinx.com>\n\t<20170904141748.GU7570@localhost.localdomain>","From":"Alistair Francis ","Date":"Tue, 5 Sep 2017 10:32:25 -0700","X-Google-Sender-Auth":"7HLA-VHNSlQbs3G7Fjsk4oNfq50","Message-ID":"","To":"Eduardo Habkost ","Content-Type":"text/plain; charset=\"UTF-8\"","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c0c::241","Subject":"Re: [Qemu-devel] [PATCH v3 1/7] hw/i386: Improve some of the\n\twarning messages","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Markus Armbruster ,\n\tPaolo Bonzini , \n\t\"qemu-devel@nongnu.org Developers\" ,\n\tDon Slutz ,\n\tAlistair Francis ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]