[{"id":1761904,"web_url":"http://patchwork.ozlabs.org/comment/1761904/","msgid":"<20170901182022.2m46ussfgiwo32c5@MacBook-Pro-de-Roger.local>","list_archive_url":null,"date":"2017-09-01T18:20:22","subject":"Re: [Qemu-devel] [Xen-devel] [PATCH] xen: use vMSI related\n\t#define-s from public interface","submitter":{"id":13974,"url":"http://patchwork.ozlabs.org/api/people/13974/","name":"Roger Pau Monné","email":"roger.pau@citrix.com"},"content":"On Fri, Sep 01, 2017 at 10:25:42AM -0600, Jan Beulich wrote:\n> Xen and qemu having identical #define-s (with different names) is a\n> strong hint that these should have been part of the public interface\n> from the very start. Use them if they're available, falling back to\n> privately defined values only when using older headers.\n> \n> Signed-off-by: Jan Beulich \n\nReviewed-by: Roger Pau Monné \n\n> \n> --- a/hw/xen/xen_pt_msi.c\n> +++ b/hw/xen/xen_pt_msi.c\n> @@ -18,6 +18,11 @@\n> \n> #define XEN_PT_AUTO_ASSIGN -1\n> \n> +#ifndef XEN_DOMCTL_VMSI_X86_DEST_ID_MASK\n> +#if XEN_DOMCTL_INTERFACE_VERSION >= 0x0000000e\n\nXEN_DOMCTL_INTERFACE_VERSION is already 0xe (without you added\ndefines), I guess it doesn't matter much because we only care for\nstable releases.\n\nI would probably be fine without the interface check and the error,\nbut I don't know the approach we usually take regarding those.\n\nThanks, Roger.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkSTl6L6Nz9sPk\n\tfor ;\n\tSat, 2 Sep 2017 04:30:19 +1000 (AEST)","from localhost ([::1]:54195 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnqht-0007Rr-EV\n\tfor incoming@patchwork.ozlabs.org; Fri, 01 Sep 2017 14:30:17 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:37385)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1dnqYW-00072w-F6\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 14:20:41 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from )\n\tid 1dnqYS-0003hb-5L\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 14:20:36 -0400","from smtp.eu.citrix.com ([185.25.65.24]:6192)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71)\n\t(envelope-from )\n\tid 1dnqYR-0003fV-SE\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 14:20:32 -0400"],"X-IronPort-AV":"E=Sophos;i=\"5.41,459,1498521600\"; d=\"scan'208\";a=\"52046424\"","Date":"Fri, 1 Sep 2017 19:20:22 +0100","From":"Roger Pau =?iso-8859-1?q?Monn=E9?= ","To":"Jan Beulich ","Message-ID":"<20170901182022.2m46ussfgiwo32c5@MacBook-Pro-de-Roger.local>","References":"<59A9A6260200007800176A6A@prv-mh.provo.novell.com>\n\t<59A9A6260200007800176A6A@prv-mh.provo.novell.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<59A9A6260200007800176A6A@prv-mh.provo.novell.com>","User-Agent":"NeoMutt/20170714 (1.8.3)","X-ClientProxiedBy":"AMSPEX02CAS02.citrite.net (10.69.22.113) To\n\tAMSPEX02CL02.citrite.net (10.69.22.126)","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"185.25.65.24","Subject":"Re: [Qemu-devel] [Xen-devel] [PATCH] xen: use vMSI related\n\t#define-s from public interface","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"xen-devel ,\n\tStefano Stabellini , qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1762527,"web_url":"http://patchwork.ozlabs.org/comment/1762527/","msgid":"<59AD3349020000780017704A@prv-mh.provo.novell.com>","list_archive_url":null,"date":"2017-09-04T09:04:41","subject":"Re: [Qemu-devel] [Xen-devel] [PATCH] xen: use vMSI related\n\t#define-s from public interface","submitter":{"id":9477,"url":"http://patchwork.ozlabs.org/api/people/9477/","name":"Jan Beulich","email":"JBeulich@suse.com"},"content":">>> On 01.09.17 at 20:20, wrote:\n> On Fri, Sep 01, 2017 at 10:25:42AM -0600, Jan Beulich wrote:\n>> Xen and qemu having identical #define-s (with different names) is a\n>> strong hint that these should have been part of the public interface\n>> from the very start. Use them if they're available, falling back to\n>> privately defined values only when using older headers.\n>> \n>> Signed-off-by: Jan Beulich \n> \n> Reviewed-by: Roger Pau Monné \n\nThanks.\n\n>> --- a/hw/xen/xen_pt_msi.c\n>> +++ b/hw/xen/xen_pt_msi.c\n>> @@ -18,6 +18,11 @@\n>> \n>> #define XEN_PT_AUTO_ASSIGN -1\n>> \n>> +#ifndef XEN_DOMCTL_VMSI_X86_DEST_ID_MASK\n>> +#if XEN_DOMCTL_INTERFACE_VERSION >= 0x0000000e\n> \n> XEN_DOMCTL_INTERFACE_VERSION is already 0xe (without you added\n> defines), I guess it doesn't matter much because we only care for\n> stable releases.\n\nWell, that's if you build qemu against master Xen. What about\npeople building against older Xen versions/headers?\n\nJan","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xm3qK0x23z9s4s\n\tfor ;\n\tMon, 4 Sep 2017 19:06:05 +1000 (AEST)","from localhost ([::1]:45169 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1donKV-0005Tp-8q\n\tfor incoming@patchwork.ozlabs.org; Mon, 04 Sep 2017 05:06:03 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:54445)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1donJM-0004pg-0g\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 05:05:01 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1donJH-0002cp-TN\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 05:04:52 -0400","from prv-mh.provo.novell.com ([137.65.248.74]:56795)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1donJH-0002bw-L9\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 05:04:47 -0400","from INET-PRV-MTA by prv-mh.provo.novell.com\n\twith Novell_GroupWise; Mon, 04 Sep 2017 03:04:44 -0600"],"Message-Id":"<59AD3349020000780017704A@prv-mh.provo.novell.com>","X-Mailer":"Novell GroupWise Internet Agent 14.2.2 ","Date":"Mon, 04 Sep 2017 03:04:41 -0600","From":"\"Jan Beulich\" ","To":"\"=?UTF-8?Q?Roger=20Pau=20Monn=C3=A9?=\" ","References":"<59A9A6260200007800176A6A@prv-mh.provo.novell.com>\n\t<59A9A6260200007800176A6A@prv-mh.provo.novell.com>\n\t<20170901182022.2m46ussfgiwo32c5@MacBook-Pro-de-Roger.local>","In-Reply-To":"<20170901182022.2m46ussfgiwo32c5@MacBook-Pro-de-Roger.local>","Mime-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"quoted-printable","Content-Disposition":"inline","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [fuzzy]","X-Received-From":"137.65.248.74","Subject":"Re: [Qemu-devel] [Xen-devel] [PATCH] xen: use vMSI related\n\t#define-s from public interface","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"xen-devel ,\n\tStefano Stabellini , qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1762531,"web_url":"http://patchwork.ozlabs.org/comment/1762531/","msgid":"<20170904092331.zj2nj4nawzobjero@MacBook-Pro-de-Roger.local>","list_archive_url":null,"date":"2017-09-04T09:23:31","subject":"Re: [Qemu-devel] [Xen-devel] [PATCH] xen: use vMSI related\n\t#define-s from public interface","submitter":{"id":13974,"url":"http://patchwork.ozlabs.org/api/people/13974/","name":"Roger Pau Monné","email":"roger.pau@citrix.com"},"content":"On Mon, Sep 04, 2017 at 03:04:41AM -0600, Jan Beulich wrote:\n> >>> On 01.09.17 at 20:20, wrote:\n> > On Fri, Sep 01, 2017 at 10:25:42AM -0600, Jan Beulich wrote:\n> >> Xen and qemu having identical #define-s (with different names) is a\n> >> strong hint that these should have been part of the public interface\n> >> from the very start. Use them if they're available, falling back to\n> >> privately defined values only when using older headers.\n> >> \n> >> Signed-off-by: Jan Beulich \n> > \n> > Reviewed-by: Roger Pau Monné \n> \n> Thanks.\n> \n> >> --- a/hw/xen/xen_pt_msi.c\n> >> +++ b/hw/xen/xen_pt_msi.c\n> >> @@ -18,6 +18,11 @@\n> >> \n> >> #define XEN_PT_AUTO_ASSIGN -1\n> >> \n> >> +#ifndef XEN_DOMCTL_VMSI_X86_DEST_ID_MASK\n> >> +#if XEN_DOMCTL_INTERFACE_VERSION >= 0x0000000e\n> > \n> > XEN_DOMCTL_INTERFACE_VERSION is already 0xe (without you added\n> > defines), I guess it doesn't matter much because we only care for\n> > stable releases.\n> \n> Well, that's if you build qemu against master Xen. What about\n> people building against older Xen versions/headers?\n\nSorry, I think I haven't explained myself clearly. What I mean is\nthat if this change gets committed before the Xen side one, QEMU would\nnot compile against current Xen. As said, this is only a transitory\nissue, and it's never going to be a problem in stable branches. This\nis because of the \"#error\" that you add.\n\nRoger.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xm4DC3rywz9s7C\n\tfor ;\n\tMon, 4 Sep 2017 19:24:11 +1000 (AEST)","from localhost ([::1]:46514 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1donc1-0004ev-Ju\n\tfor incoming@patchwork.ozlabs.org; Mon, 04 Sep 2017 05:24:09 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:40554)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1donbZ-0004bk-5W\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 05:23:46 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from )\n\tid 1donbU-0000jY-Sr\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 05:23:41 -0400","from smtp.eu.citrix.com ([185.25.65.24]:38355)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71)\n\t(envelope-from )\n\tid 1donbU-0000ia-HZ\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 05:23:36 -0400"],"X-IronPort-AV":"E=Sophos;i=\"5.41,474,1498521600\"; d=\"scan'208\";a=\"52156141\"","Date":"Mon, 4 Sep 2017 10:23:31 +0100","From":"Roger Pau =?iso-8859-1?q?Monn=E9?= ","To":"Jan Beulich ","Message-ID":"<20170904092331.zj2nj4nawzobjero@MacBook-Pro-de-Roger.local>","References":"<59A9A6260200007800176A6A@prv-mh.provo.novell.com>\n\t<59A9A6260200007800176A6A@prv-mh.provo.novell.com>\n\t<20170901182022.2m46ussfgiwo32c5@MacBook-Pro-de-Roger.local>\n\t<59AD3349020000780017704A@prv-mh.provo.novell.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<59AD3349020000780017704A@prv-mh.provo.novell.com>","User-Agent":"NeoMutt/20170714 (1.8.3)","X-ClientProxiedBy":"AMSPEX02CAS02.citrite.net (10.69.22.113) To\n\tAMSPEX02CL02.citrite.net (10.69.22.126)","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"185.25.65.24","Subject":"Re: [Qemu-devel] [Xen-devel] [PATCH] xen: use vMSI related\n\t#define-s from public interface","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"xen-devel ,\n\tStefano Stabellini , qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1762543,"web_url":"http://patchwork.ozlabs.org/comment/1762543/","msgid":"<59AD3CF302000078001770C4@prv-mh.provo.novell.com>","list_archive_url":null,"date":"2017-09-04T09:45:55","subject":"Re: [Qemu-devel] [Xen-devel] [PATCH] xen: use vMSI related\n\t#define-s from public interface","submitter":{"id":9477,"url":"http://patchwork.ozlabs.org/api/people/9477/","name":"Jan Beulich","email":"JBeulich@suse.com"},"content":">>> On 04.09.17 at 11:23, wrote:\n> On Mon, Sep 04, 2017 at 03:04:41AM -0600, Jan Beulich wrote:\n>> >>> On 01.09.17 at 20:20, wrote:\n>> > On Fri, Sep 01, 2017 at 10:25:42AM -0600, Jan Beulich wrote:\n>> >> Xen and qemu having identical #define-s (with different names) is a\n>> >> strong hint that these should have been part of the public interface\n>> >> from the very start. Use them if they're available, falling back to\n>> >> privately defined values only when using older headers.\n>> >> \n>> >> Signed-off-by: Jan Beulich \n>> > \n>> > Reviewed-by: Roger Pau Monné \n>> \n>> Thanks.\n>> \n>> >> --- a/hw/xen/xen_pt_msi.c\n>> >> +++ b/hw/xen/xen_pt_msi.c\n>> >> @@ -18,6 +18,11 @@\n>> >> \n>> >> #define XEN_PT_AUTO_ASSIGN -1\n>> >> \n>> >> +#ifndef XEN_DOMCTL_VMSI_X86_DEST_ID_MASK\n>> >> +#if XEN_DOMCTL_INTERFACE_VERSION >= 0x0000000e\n>> > \n>> > XEN_DOMCTL_INTERFACE_VERSION is already 0xe (without you added\n>> > defines), I guess it doesn't matter much because we only care for\n>> > stable releases.\n>> \n>> Well, that's if you build qemu against master Xen. What about\n>> people building against older Xen versions/headers?\n> \n> Sorry, I think I haven't explained myself clearly. What I mean is\n> that if this change gets committed before the Xen side one, QEMU would\n> not compile against current Xen. As said, this is only a transitory\n> issue, and it's never going to be a problem in stable branches. This\n> is because of the \"#error\" that you add.\n\nOh, yes, that's the case. I can't see an easy way around it, but I'm\npretty sure the qemu side of it will see some further delay anyway.\n\nJan","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xm4kL3ZbGz9s7c\n\tfor ;\n\tMon, 4 Sep 2017 19:46:49 +1000 (AEST)","from localhost ([::1]:48088 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1donxt-0003Qm-R3\n\tfor incoming@patchwork.ozlabs.org; Mon, 04 Sep 2017 05:46:45 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:53462)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1donxF-0003PJ-KF\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 05:46:10 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1donxA-00086J-Qz\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 05:46:05 -0400","from prv-mh.provo.novell.com ([137.65.248.74]:43475)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1donxA-00085P-Hb\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 05:46:00 -0400","from INET-PRV-MTA by prv-mh.provo.novell.com\n\twith Novell_GroupWise; Mon, 04 Sep 2017 03:45:58 -0600"],"Message-Id":"<59AD3CF302000078001770C4@prv-mh.provo.novell.com>","X-Mailer":"Novell GroupWise Internet Agent 14.2.2 ","Date":"Mon, 04 Sep 2017 03:45:55 -0600","From":"\"Jan Beulich\" ","To":"\"=?UTF-8?Q?Roger=20Pau=20Monn=C3=A9?=\" ","References":"<59A9A6260200007800176A6A@prv-mh.provo.novell.com>\n\t<59A9A6260200007800176A6A@prv-mh.provo.novell.com>\n\t<20170901182022.2m46ussfgiwo32c5@MacBook-Pro-de-Roger.local>\n\t<59AD3349020000780017704A@prv-mh.provo.novell.com>\n\t<20170904092331.zj2nj4nawzobjero@MacBook-Pro-de-Roger.local>","In-Reply-To":"<20170904092331.zj2nj4nawzobjero@MacBook-Pro-de-Roger.local>","Mime-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"quoted-printable","Content-Disposition":"inline","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [fuzzy]","X-Received-From":"137.65.248.74","Subject":"Re: [Qemu-devel] [Xen-devel] [PATCH] xen: use vMSI related\n\t#define-s from public interface","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"xen-devel ,\n\tStefano Stabellini , qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1772351,"web_url":"http://patchwork.ozlabs.org/comment/1772351/","msgid":"","list_archive_url":null,"date":"2017-09-21T01:12:10","subject":"Re: [Qemu-devel] [PATCH] xen: use vMSI related #define-s from\n\tpublic interface","submitter":{"id":68602,"url":"http://patchwork.ozlabs.org/api/people/68602/","name":"Stefano Stabellini","email":"sstabellini@kernel.org"},"content":"On Fri, 1 Sep 2017, Jan Beulich wrote:\n> Xen and qemu having identical #define-s (with different names) is a\n> strong hint that these should have been part of the public interface\n> from the very start. Use them if they're available, falling back to\n> privately defined values only when using older headers.\n> \n> Signed-off-by: Jan Beulich \n\nHi Jan,\n\nThanks for the patch and sorry for the delay in reviewing it.\n\n\n> --- a/hw/xen/xen_pt_msi.c\n> +++ b/hw/xen/xen_pt_msi.c\n> @@ -18,6 +18,11 @@\n> \n> #define XEN_PT_AUTO_ASSIGN -1\n> \n> +#ifndef XEN_DOMCTL_VMSI_X86_DEST_ID_MASK\n> +#if XEN_DOMCTL_INTERFACE_VERSION >= 0x0000000e\n> +#error vMSI defines missing from domctl.h\n> +#endif\n\nAll the version compatibility stuff goes to\ninclude/hw/xen/xen_common.h. Please move it there.\n\nWe usually assume that the Xen version we are building against is\n\"sane\", so we don't do #error's typically.\n\n\n> +\n> /* shift count for gflags */\n> #define XEN_PT_GFLAGS_SHIFT_DEST_ID 0\n> #define XEN_PT_GFLAGS_SHIFT_RH 8\n> @@ -26,6 +31,16 @@\n> #define XEN_PT_GFLAGSSHIFT_TRG_MODE 15\n> #define XEN_PT_GFLAGSSHIFT_UNMASKED 16\n> \n> +#define XEN_DOMCTL_VMSI_X86_DEST_ID_MASK (0xffU << XEN_PT_GFLAGS_SHIFT_DEST_ID)\n> +#define XEN_DOMCTL_VMSI_X86_RH_MASK (1U << XEN_PT_GFLAGS_SHIFT_RH)\n> +#define XEN_DOMCTL_VMSI_X86_DM_MASK (1U << XEN_PT_GFLAGS_SHIFT_DM)\n> +#define XEN_DOMCTL_VMSI_X86_DELIV_MASK (7U << XEN_PT_GFLAGSSHIFT_DELIV_MODE)\n> +#define XEN_DOMCTL_VMSI_X86_TRIG_MASK (1U << XEN_PT_GFLAGSSHIFT_TRG_MODE)\n> +#define XEN_DOMCTL_VMSI_X86_UNMASKED (1U << XEN_PT_GFLAGSSHIFT_UNMASKED)\n> +#endif\n> +\n> +#define MASK_INSR(v, m) (((v) * ((m) & -(m))) & (m))\n\nMASK_INSR can stay in this file.\n\n\n> #define latch(fld) latch[PCI_MSIX_ENTRY_##fld / sizeof(uint32_t)]\n> \n> /*\n> @@ -49,21 +64,18 @@ static inline uint32_t msi_ext_dest_id(u\n> \n> static uint32_t msi_gflags(uint32_t data, uint64_t addr)\n> {\n> - uint32_t result = 0;\n> - int rh, dm, dest_id, deliv_mode, trig_mode;\n> + int rh, dm, deliv_mode, trig_mode;\n> \n> rh = (addr >> MSI_ADDR_REDIRECTION_SHIFT) & 0x1;\n> dm = (addr >> MSI_ADDR_DEST_MODE_SHIFT) & 0x1;\n> - dest_id = msi_dest_id(addr);\n> deliv_mode = (data >> MSI_DATA_DELIVERY_MODE_SHIFT) & 0x7;\n> trig_mode = (data >> MSI_DATA_TRIGGER_SHIFT) & 0x1;\n> \n> - result = dest_id | (rh << XEN_PT_GFLAGS_SHIFT_RH)\n> - | (dm << XEN_PT_GFLAGS_SHIFT_DM)\n> - | (deliv_mode << XEN_PT_GFLAGSSHIFT_DELIV_MODE)\n> - | (trig_mode << XEN_PT_GFLAGSSHIFT_TRG_MODE);\n> -\n> - return result;\n> + return MASK_INSR(msi_dest_id(addr), XEN_DOMCTL_VMSI_X86_DEST_ID_MASK) |\n> + MASK_INSR(rh, XEN_DOMCTL_VMSI_X86_RH_MASK) |\n> + MASK_INSR(dm, XEN_DOMCTL_VMSI_X86_DM_MASK) |\n> + MASK_INSR(deliv_mode, XEN_DOMCTL_VMSI_X86_DELIV_MASK) |\n> + MASK_INSR(trig_mode, XEN_DOMCTL_VMSI_X86_TRIG_MASK);\n> }\n> \n> static inline uint64_t msi_addr64(XenPTMSI *msi)\n> @@ -173,7 +185,7 @@ static int msi_msix_update(XenPCIPassthr\n> table_addr = s->msix->mmio_base_addr;\n> }\n> \n> - gflags |= masked ? 0 : (1u << XEN_PT_GFLAGSSHIFT_UNMASKED);\n> + gflags |= masked ? 0 : XEN_DOMCTL_VMSI_X86_UNMASKED;\n> \n> rc = xc_domain_update_msi_irq(xen_xc, xen_domid, gvec,\n> pirq, gflags, table_addr);","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","mail.kernel.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.org","mail.kernel.org;\n\tspf=none smtp.mailfrom=sstabellini@kernel.org"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xyJWV1PGBz9s4q\n\tfor ;\n\tThu, 21 Sep 2017 11:12:54 +1000 (AEST)","from localhost ([::1]:51301 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duq2u-0006J1-A2\n\tfor incoming@patchwork.ozlabs.org; Wed, 20 Sep 2017 21:12:52 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:37618)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1duq2L-0006Fy-Kp\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 21:12:18 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1duq2G-0007W1-J1\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 21:12:17 -0400","from mail.kernel.org ([198.145.29.99]:44954)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1duq2G-0007Uu-Az\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 21:12:12 -0400","from [10.149.184.130]\n\t(162-198-228-33.lightspeed.wlfrct.sbcglobal.net [162.198.228.33])\n\t(using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id 31483218F8;\n\tThu, 21 Sep 2017 01:12:11 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mail.kernel.org 31483218F8","Date":"Wed, 20 Sep 2017 18:12:10 -0700 (PDT)","From":"Stefano Stabellini ","X-X-Sender":"sstabellini@sstabellini-ThinkPad-X260","To":"Jan Beulich ","In-Reply-To":"<59A9A6260200007800176A6A@prv-mh.provo.novell.com>","Message-ID":"","References":"<59A9A6260200007800176A6A@prv-mh.provo.novell.com>\n\t<59A9A6260200007800176A6A@prv-mh.provo.novell.com>","User-Agent":"Alpine 2.10 (DEB 1266 2009-07-14)","MIME-Version":"1.0","Content-Type":"TEXT/PLAIN; charset=US-ASCII","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"198.145.29.99","Subject":"Re: [Qemu-devel] [PATCH] xen: use vMSI related #define-s from\n\tpublic interface","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"xen-devel ,\n\tStefano Stabellini , qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1772437,"web_url":"http://patchwork.ozlabs.org/comment/1772437/","msgid":"<59C37692020000780017DCCA@prv-mh.provo.novell.com>","list_archive_url":null,"date":"2017-09-21T06:21:38","subject":"Re: [Qemu-devel] [PATCH] xen: use vMSI related #define-s from\n\tpublic interface","submitter":{"id":9477,"url":"http://patchwork.ozlabs.org/api/people/9477/","name":"Jan Beulich","email":"JBeulich@suse.com"},"content":">>> On 21.09.17 at 03:12, wrote:\n> On Fri, 1 Sep 2017, Jan Beulich wrote:\n>> --- a/hw/xen/xen_pt_msi.c\n>> +++ b/hw/xen/xen_pt_msi.c\n>> @@ -18,6 +18,11 @@\n>> \n>> #define XEN_PT_AUTO_ASSIGN -1\n>> \n>> +#ifndef XEN_DOMCTL_VMSI_X86_DEST_ID_MASK\n>> +#if XEN_DOMCTL_INTERFACE_VERSION >= 0x0000000e\n>> +#error vMSI defines missing from domctl.h\n>> +#endif\n> \n> All the version compatibility stuff goes to\n> include/hw/xen/xen_common.h. Please move it there.\n\nI know there's a central place, but moving there stuff that's\nneeded only in this file seemed rather counterproductive to\nme - why would you want all files including that shared one\nhave to see these definitions? If there was a remote chance\nthat some other file may need to make use of it, I might\nagree, but I don't see any such chance at all.\n\n> We usually assume that the Xen version we are building against is\n> \"sane\", so we don't do #error's typically.\n\nHmm, I can drop the #error, but to be honest I'm hesitant to do\nso - I've put it there intentionally.\n\nJan","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xyRNJ6sWSz9t3v\n\tfor ;\n\tThu, 21 Sep 2017 16:22:08 +1000 (AEST)","from localhost ([::1]:51999 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duusB-00014b-2U\n\tfor incoming@patchwork.ozlabs.org; Thu, 21 Sep 2017 02:22:07 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:36186)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1duurq-00013o-Ac\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 02:21:47 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1duurm-0008Uw-CE\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 02:21:46 -0400","from prv-mh.provo.novell.com ([137.65.248.74]:48996)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1duurm-0008UF-3D\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 02:21:42 -0400","from INET-PRV-MTA by prv-mh.provo.novell.com\n\twith Novell_GroupWise; Thu, 21 Sep 2017 00:21:39 -0600"],"Message-Id":"<59C37692020000780017DCCA@prv-mh.provo.novell.com>","X-Mailer":"Novell GroupWise Internet Agent 14.2.2 ","Date":"Thu, 21 Sep 2017 00:21:38 -0600","From":"\"Jan Beulich\" ","To":"\"Stefano Stabellini\" ","References":"<59A9A6260200007800176A6A@prv-mh.provo.novell.com>\n\t<59A9A6260200007800176A6A@prv-mh.provo.novell.com>\n\t","In-Reply-To":"","Mime-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"quoted-printable","Content-Disposition":"inline","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [fuzzy]","X-Received-From":"137.65.248.74","Subject":"Re: [Qemu-devel] [PATCH] xen: use vMSI related #define-s from\n\tpublic interface","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"xen-devel , qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1773209,"web_url":"http://patchwork.ozlabs.org/comment/1773209/","msgid":"","list_archive_url":null,"date":"2017-09-21T23:50:20","subject":"Re: [Qemu-devel] [PATCH] xen: use vMSI related #define-s from\n\tpublic interface","submitter":{"id":68602,"url":"http://patchwork.ozlabs.org/api/people/68602/","name":"Stefano Stabellini","email":"sstabellini@kernel.org"},"content":"On Thu, 21 Sep 2017, Jan Beulich wrote:\n> >>> On 21.09.17 at 03:12, wrote:\n> > On Fri, 1 Sep 2017, Jan Beulich wrote:\n> >> --- a/hw/xen/xen_pt_msi.c\n> >> +++ b/hw/xen/xen_pt_msi.c\n> >> @@ -18,6 +18,11 @@\n> >> \n> >> #define XEN_PT_AUTO_ASSIGN -1\n> >> \n> >> +#ifndef XEN_DOMCTL_VMSI_X86_DEST_ID_MASK\n> >> +#if XEN_DOMCTL_INTERFACE_VERSION >= 0x0000000e\n> >> +#error vMSI defines missing from domctl.h\n> >> +#endif\n> > \n> > All the version compatibility stuff goes to\n> > include/hw/xen/xen_common.h. Please move it there.\n> \n> I know there's a central place, but moving there stuff that's\n> needed only in this file seemed rather counterproductive to\n> me - why would you want all files including that shared one\n> have to see these definitions? If there was a remote chance\n> that some other file may need to make use of it, I might\n> agree, but I don't see any such chance at all.\n\nBasically, xen_common.h is meant to supply all definitions and\ndeclarations that should already be part of the Xen interface, but\nbecause of versioning, they are not.\n\nXen headers + xen_common.h = all declarations and definitions\n\nSo far, we haven't distinguished based on how many users of a given\nmissing functions exist in QEMU. Simply, xen_common.h fills all gaps.\nOne day, xen_common.h could become a set of header files, so that in\ncases such as this, one can only import the compat header file that she\nneeds. But today we only have one compat header in QEMU.\n\n\n> > We usually assume that the Xen version we are building against is\n> > \"sane\", so we don't do #error's typically.\n> \n> Hmm, I can drop the #error, but to be honest I'm hesitant to do\n> so - I've put it there intentionally.\n\nIt is difficult to draw the line when an #error is needed and when it is\nnot. I am just trying to be consistent. Why do you think we should have\nit in this specific case? Do you think we cannot make correct\nassumptions based on the XEN_DOMCTL_INTERFACE_VERSION only or the Xen\nversion? If so, please explain.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","mail.kernel.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.org","mail.kernel.org;\n\tspf=none smtp.mailfrom=sstabellini@kernel.org"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xyv9F6Pdfz9sRq\n\tfor ;\n\tFri, 22 Sep 2017 10:14:09 +1000 (AEST)","from localhost ([::1]:56022 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dvBFB-0008IH-IE\n\tfor incoming@patchwork.ozlabs.org; Thu, 21 Sep 2017 19:50:57 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:46953)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dvBEh-0008Ge-R0\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 19:50:28 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dvBEd-0004KS-Sj\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 19:50:27 -0400","from mail.kernel.org ([198.145.29.99]:37652)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dvBEd-0004Jj-MT\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 19:50:23 -0400","from [10.0.0.56] (c-24-130-70-9.hsd1.ca.comcast.net [24.130.70.9])\n\t(using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id 5EF3722A72;\n\tThu, 21 Sep 2017 23:50:21 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mail.kernel.org 5EF3722A72","Date":"Thu, 21 Sep 2017 16:50:20 -0700 (PDT)","From":"Stefano Stabellini ","X-X-Sender":"sstabellini@sstabellini-ThinkPad-X260","To":"Jan Beulich ","In-Reply-To":"<59C37692020000780017DCCA@prv-mh.provo.novell.com>","Message-ID":"","References":"<59A9A6260200007800176A6A@prv-mh.provo.novell.com>\n\t<59A9A6260200007800176A6A@prv-mh.provo.novell.com>\n\t\n\t<59C37692020000780017DCCA@prv-mh.provo.novell.com>","User-Agent":"Alpine 2.10 (DEB 1266 2009-07-14)","MIME-Version":"1.0","Content-Type":"TEXT/PLAIN; charset=US-ASCII","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"198.145.29.99","Subject":"Re: [Qemu-devel] [PATCH] xen: use vMSI related #define-s from\n\tpublic interface","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"xen-devel ,\n\tStefano Stabellini , qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]