[{"id":1761806,"web_url":"http://patchwork.ozlabs.org/comment/1761806/","msgid":"<60d2bbc9-51c0-e022-2b4d-687ec7f4f81a@redhat.com>","list_archive_url":null,"date":"2017-09-01T16:39:53","subject":"Re: [PATCH] struct sockaddr_storage: Rename internal members","submitter":{"id":22438,"url":"http://patchwork.ozlabs.org/api/people/22438/","name":"Carlos O'Donell","email":"carlos@redhat.com"},"content":"On 09/01/2017 11:16 AM, Florian Weimer wrote:\n> In commit 3375cfafa7961c6ae0e509c31c3b3cef9ad1f03d (Make padding in\n> struct sockaddr_storage explicit), the offsets of the members\n> changed. Some broken applications use these members to find\n> the start of the address data in struct sockaddr_in or\n> struct sockaddr_in6, and the change meant that they silently ended\n> up with an incorrect offset. Changing the struct member names\n> triggers a compilation failure, hopefully leading to a complete fix.\n> \n> 2017-09-01 Florian Weimer \n> \n> \t* bits/socket.h (struct sockaddr_storage): Rename __ss_padding to\n> \t__ss_padding_reserved and __ss_align to __ss_align_reserved.\n> \t* sysdeps/mach/hurd/bits/socket.h (struct sockaddr_storage): Likewise.\n> \t* sysdeps/unix/sysv/linux/bits/socket.h\n> \t(struct sockaddr_storage): Likewise.\n> \t* inet/tst-sockaddr.c (do_test): Adjust.\nWe've been consistently using __glibc_reserved* prefix for this kind of thing,\nbut perhaps __glibc_reserved_ss_align and __glibc_reserved_ss_aligntype are\ntoo long? \n\nI like that using __glibc_reserved_* clearly indicates who reserved it, and\nthat it is reserved like all other instances of __glibc_reserved_* should never\nclash with other reserved named in other operating systems.\n\nThe patch looks good. I'm just bike shedding on the name.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84031-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"sJz/PY3W\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkQ2g4Sc4z9t2x\n\tfor ;\n\tSat, 2 Sep 2017 02:40:11 +1000 (AEST)","(qmail 87992 invoked by alias); 1 Sep 2017 16:40:04 -0000","(qmail 87979 invoked by uid 89); 1 Sep 2017 16:40:04 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; q=dns; s=default; b=hjPMc6SLRMJgjd4Z\n\tcN+2cqx18oYauOg3Y7kEh0AGyLPSpcQ1BN8Vp6IO4TKQ8HQCbFLtCmr0ybNLqrRc\n\tD/ntRc4pXYmRqWJ867vs92QavlWKQccIN1Euujhl4Emer9oh7xcTl8Hg0n/JAjbw\n\tie2nUbYTPy8ojUkPV9iKA1wmJ3o=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:subject:to:references:from:message-id:date\n\t:mime-version:in-reply-to:content-type\n\t:content-transfer-encoding; s=default; bh=y+tlbR5SJL8KGI0mWozsPq\n\t4Ar9Q=; b=sJz/PY3WC0XYKJiYBhSuuX0UB/gcXS81amWhd8qLZu7kXMOiuFFd2t\n\tQSPXO9Qjh3jV+I4VJFOEZv9V55yvjg20UJ16GIzt6cOvvuNqm8hVKtZQIBnaZzSM\n\tbhzgpi94IrielDA37rt7F8EglGSuqoWp2a3CndB7dVtw0iKs5ORmc=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-1.4 required=5.0 tests=AWL, BAYES_00,\n\tKAM_LAZY_DOMAIN_SECURITY, RCVD_IN_DNSWL_LOW,\n\tRCVD_IN_SORBS_SPAM autolearn=no version=3.3.2 spammy=bike,\n\treserved","X-HELO":"mail-qt0-f182.google.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:from:organization\n\t:message-id:date:user-agent:mime-version:in-reply-to\n\t:content-language:content-transfer-encoding;\n\tbh=LdDrvkG4AdJsYhFEsV0U0osM9B4WP8dADGBbf3kwkdA=;\n\tb=i19Ml9jvlf7/hPBG86KNVpe6fgpxYCFAnnVuOeLDRCBMinoxMtCXrOvAzkdQxbAw0A\n\t8uEpeAfBPmvjD0wdOOehCYHy2w90MQDhz1UfTaqKm8SY/ze/DR/PsdWXO3vSuIRw00Pq\n\tZ2PDg4prxFMaoMQ4cn5WYtd1xfOtBmDedIpd9SHk6gooMPBt+4PoRZdHMnHSCpbM6Ip2\n\t4uAytEOJQBqUe6SQ8Z98Spjq1Lx85pXXHqT+vDpC6eyTR00qLLG1zNK2lLJQFyAaijwS\n\t8oDbeqYzzfBMGklOi8Y7Y3ULdRzDGtA2efzhHwSAFzAMq218dk4OoNaPlf5TNIkVVD5G\n\t8+kw==","X-Gm-Message-State":"AHPjjUg2YeiBNKSdhZL1bsz5PKZ9U7MPn0R9UutUES9ELSPP3x0iRgg4\n\tuPJoobDfaeAzXPzT+D3DgQ==","X-Google-Smtp-Source":"ADKCNb4LBlZqAD1E0qHlEfcltBMzO5KfTTfPAY2DdU7yQDswSxWcnz/3FwVs62981JYPHBXiX+kXgA==","X-Received":"by 10.200.57.97 with SMTP id t30mr3528170qtb.36.1504283997708;\n\tFri, 01 Sep 2017 09:39:57 -0700 (PDT)","Subject":"Re: [PATCH] struct sockaddr_storage: Rename internal members","To":"Florian Weimer , libc-alpha@sourceware.org","References":"<20170901161651.D5F51439942E3@oldenburg.str.redhat.com>","From":"Carlos O'Donell ","Message-ID":"<60d2bbc9-51c0-e022-2b4d-687ec7f4f81a@redhat.com>","Date":"Fri, 1 Sep 2017 11:39:53 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170901161651.D5F51439942E3@oldenburg.str.redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"7bit"}}]