[{"id":1761824,"web_url":"http://patchwork.ozlabs.org/comment/1761824/","msgid":"<071bb48e-5662-a6fe-d538-de3614bd542e@synopsys.com>","list_archive_url":null,"date":"2017-09-01T16:55:46","subject":"Re: [PATCH v3] arc: Re-enable MMU upon a Machine Check exception","submitter":{"id":26707,"url":"http://patchwork.ozlabs.org/api/people/26707/","name":"Vineet Gupta","email":"Vineet.Gupta1@synopsys.com"},"content":"Hi Jose,\n\nSome very minor nit picks to keep in mind for future patches.\n\n1. all arc patches start with uppercase ARC:\n\nOn 09/01/2017 09:05 AM, Jose Abreu wrote:\n> I recently came upon a scenario where I would get a double fault\n> after a machine check error. It turns out that for Ksymbol lookup\n> to work with modules we need to have MMU enabled because module\n> address is mapped in the cached space.\n> \n> This patch re-enables the MMU before calling die() so that\n> stacktracing of modules work when a machine check exception happens.\n> \n> Signed-off-by: Jose Abreu \n> Cc: Vineet Gupta \n> Cc: Alexey Brodkin \n> \n> Changes from v2:\n> \t- Rephrased commit title and description\n> Changes from v1:\n> \t- Moved MMU re-enable to machine check exception handler\n> ---\n\n2. The patch revision history needs to be added *after* the line with ---, that \nway git am automatically strips them off when patch is applied.\n\n-Vineet","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-snps-arc-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"jxSNuyeY\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkQPx0XYhz9t2x\n\tfor ;\n\tSat, 2 Sep 2017 02:56:53 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dnpFT-0005le-M7; Fri, 01 Sep 2017 16:56:51 +0000","from us01smtprelay-2.synopsys.com ([198.182.47.9]\n\thelo=smtprelay.synopsys.com)\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dnpFQ-0005iE-E1 for linux-snps-arc@lists.infradead.org;\n\tFri, 01 Sep 2017 16:56:49 +0000","from mailhost.synopsys.com (mailhost2.synopsys.com [10.13.184.66])\n\tby smtprelay.synopsys.com (Postfix) with ESMTP id 0906B24E1343\n\tfor ;\n\tFri, 1 Sep 2017 09:56:28 -0700 (PDT)","from mailhost.synopsys.com (localhost [127.0.0.1])\n\tby mailhost.synopsys.com (Postfix) with ESMTP id EB742549\n\tfor ;\n\tFri, 1 Sep 2017 09:56:27 -0700 (PDT)","from us01wehtc1.internal.synopsys.com\n\t(us01wehtc1.internal.synopsys.com [10.12.239.235])\n\tby mailhost.synopsys.com (Postfix) with ESMTP id E208F547\n\tfor ;\n\tFri, 1 Sep 2017 09:56:27 -0700 (PDT)","from IN01WEHTCB.internal.synopsys.com (10.144.199.106) by\n\tus01wehtc1.internal.synopsys.com (10.12.239.235) with Microsoft SMTP\n\tServer (TLS) id 14.3.266.1; Fri, 1 Sep 2017 09:56:03 -0700","from IN01WEHTCA.internal.synopsys.com (10.144.199.104) by\n\tIN01WEHTCB.internal.synopsys.com (10.144.199.105) with Microsoft SMTP\n\tServer (TLS) id 14.3.266.1; Fri, 1 Sep 2017 22:26:00 +0530","from [10.12.196.101] (10.12.196.101) by\n\tIN01WEHTCA.internal.synopsys.com (10.144.199.243) with Microsoft SMTP\n\tServer (TLS) id 14.3.266.1; Fri, 1 Sep 2017 22:26:00 +0530"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:\n\tContent-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive:\n\tList-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From:\n\tReferences:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=jqXfUbLnmE2CujfwcxeBexBrwpHm7xGiNoK3R7lTFIg=;\n\tb=jxSNuyeY0daY5Vddj1pkNB0c3\n\tOjESg3mresL2N3GFVJwiPKOVBwYa/EYYT3wGsxz8pWiCbrHgYewGxjlYFRF89X8k3HYvrKNGx43V7\n\t3tda+czznTzDQcOfggZ/o3KPS7Ts+JYxjyB2cNFBWgB1Gu3xYxPcFnYxxEPA2jMQoWB4xxq8GDp/T\n\t7c/eYJUXxg3bZXc3UxIQ4Q2OCsKoJp+F6h6D8AuYHJjE0ZkqrvkYvoa/Ok6rEtu4adwnrjiQAT86I\n\teF3+/9REdlHADolFuuB3BD6rSxJBnXc6UHbiiHY/pE17BaENHpoeaO/49aErfeB+4fsEx1Ix7CDTr\n\tTZfgQk80A==;","Subject":"Re: [PATCH v3] arc: Re-enable MMU upon a Machine Check exception","To":"Jose Abreu ,\n\t","Newsgroups":"gmane.linux.kernel.arc","References":"","From":"Vineet Gupta ","Message-ID":"<071bb48e-5662-a6fe-d538-de3614bd542e@synopsys.com>","Date":"Fri, 1 Sep 2017 09:55:46 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-US","X-Originating-IP":"[10.12.196.101]","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170901_095648_516263_5678FF7F ","X-CRM114-Status":"UNSURE ( 8.70 )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno trust [198.182.47.9 listed in list.dnswl.org]\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-snps-arc@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux on Synopsys ARC Processors\n\t","List-Unsubscribe":", \n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":", \n\t","Cc":"Vineet Gupta ,\n\tAlexey Brodkin ","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Sender":"\"linux-snps-arc\" ","Errors-To":"linux-snps-arc-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}}]