[{"id":1762196,"web_url":"http://patchwork.ozlabs.org/comment/1762196/","msgid":"<20170902231728.2be2989f@windsurf.lan>","list_archive_url":null,"date":"2017-09-02T21:17:28","subject":"Re: [Buildroot] [PATCH] package/sysdig: fix missing curlbuild\n\tinclude","submitter":{"id":2230,"url":"http://patchwork.ozlabs.org/api/people/2230/","name":"Thomas Petazzoni","email":"thomas.petazzoni@free-electrons.com"},"content":"Hello,\n\nOn Fri,  1 Sep 2017 17:51:21 +0200, Angelo Compagnucci wrote:\n> curlbuild.h was removed in recent versions of curl, backporting a\n> patch from mainline to fix sysdig until a newer version is\n> released.\n> \n> Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>\n\nThanks a lot, looks good, except...\n\n> ---\n>  .../sysdig/0001-Don-t-include-curlbuild.h.patch    | 56 ++++++++++++++++++++++\n>  1 file changed, 56 insertions(+)\n>  create mode 100644 package/sysdig/0001-Don-t-include-curlbuild.h.patch\n> \n> diff --git a/package/sysdig/0001-Don-t-include-curlbuild.h.patch b/package/sysdig/0001-Don-t-include-curlbuild.h.patch\n> new file mode 100644\n> index 0000000..ae406c0\n> --- /dev/null\n> +++ b/package/sysdig/0001-Don-t-include-curlbuild.h.patch\n> @@ -0,0 +1,56 @@\n> +From 8a6670ea4b57c0e2bf8588d4534b22d1ea860989 Mon Sep 17 00:00:00 2001\n> +From: Mark Stemm <mark.stemm@gmail.com>\n> +Date: Tue, 15 Aug 2017 17:49:53 -0700\n> +Subject: [PATCH] Don't include curlbuild.h\n> +\n> +It's not required to build and it's not present with some newer versions\n> +of libcurl, so removing it.\n> +\n> +Thanks to https://github.com/hhoffstaette for the tip.\n> +\n> +This fixes https://github.com/draios/sysdig/issues/895.\n\nYou must add your Signed-off-by here.\n\nCould you resend with this fixed ?\n\nThanks!\n\nThomas","headers":{"Return-Path":"<buildroot-bounces@busybox.net>","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=<UNKNOWN>)","Received":["from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xl88J3Chhz9sRW\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSun,  3 Sep 2017 07:17:36 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 5C57486B8A;\n\tSat,  2 Sep 2017 21:17:34 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id biaxsWAnvmF3; Sat,  2 Sep 2017 21:17:33 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id CEFEA86C04;\n\tSat,  2 Sep 2017 21:17:33 +0000 (UTC)","from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 0AD471C1539\n\tfor <buildroot@lists.busybox.net>;\n\tSat,  2 Sep 2017 21:17:32 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id EFAF586C04\n\tfor <buildroot@lists.busybox.net>;\n\tSat,  2 Sep 2017 21:17:31 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ahfIBftqD9ig for <buildroot@lists.busybox.net>;\n\tSat,  2 Sep 2017 21:17:30 +0000 (UTC)","from mail.free-electrons.com (mail.free-electrons.com [62.4.15.54])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id BB3E686B8A\n\tfor <buildroot@buildroot.org>; Sat,  2 Sep 2017 21:17:30 +0000 (UTC)","by mail.free-electrons.com (Postfix, from userid 110)\n\tid D8936209FF; Sat,  2 Sep 2017 23:17:28 +0200 (CEST)","from windsurf.lan (unknown [185.94.29.10])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id 9544120984;\n\tSat,  2 Sep 2017 23:17:28 +0200 (CEST)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","Date":"Sat, 2 Sep 2017 23:17:28 +0200","From":"Thomas Petazzoni <thomas.petazzoni@free-electrons.com>","To":"Angelo Compagnucci <angelo.compagnucci@gmail.com>","Message-ID":"<20170902231728.2be2989f@windsurf.lan>","In-Reply-To":"<1504281081-11201-1-git-send-email-angelo.compagnucci@gmail.com>","References":"<1504281081-11201-1-git-send-email-angelo.compagnucci@gmail.com>","Organization":"Free Electrons","X-Mailer":"Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu)","MIME-Version":"1.0","Cc":"buildroot@buildroot.org","Subject":"Re: [Buildroot] [PATCH] package/sysdig: fix missing curlbuild\n\tinclude","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot <buildroot.busybox.net>","List-Unsubscribe":"<http://lists.busybox.net/mailman/options/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=unsubscribe>","List-Archive":"<http://lists.busybox.net/pipermail/buildroot/>","List-Post":"<mailto:buildroot@busybox.net>","List-Help":"<mailto:buildroot-request@busybox.net?subject=help>","List-Subscribe":"<http://lists.busybox.net/mailman/listinfo/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" <buildroot-bounces@busybox.net>"}},{"id":1762221,"web_url":"http://patchwork.ozlabs.org/comment/1762221/","msgid":"<20170903091637.06725492@windsurf.lan>","list_archive_url":null,"date":"2017-09-03T07:16:37","subject":"Re: [Buildroot] [PATCH] package/sysdig: fix missing curlbuild\n\tinclude","submitter":{"id":2230,"url":"http://patchwork.ozlabs.org/api/people/2230/","name":"Thomas Petazzoni","email":"thomas.petazzoni@free-electrons.com"},"content":"Hello,\n\nPlease keep the mailing list in Cc.\n\nOn Sun, 3 Sep 2017 00:33:27 +0200, Angelo Compagnucci wrote:\n\n> Also if the patch is not mine? It's backported directly from the mainline\n> source code.\n\nSigned-off-by does not mean \"I am the author of the patch\", but \"I am\npassing the patch\". From the Linux kernel Submitting Patches\ndocumentation:\n\nDeveloper's Certificate of Origin 1.1\n^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n\nBy making a contribution to this project, I certify that:\n\n        (a) The contribution was created in whole or in part by me and I\n            have the right to submit it under the open source license\n            indicated in the file; or\n\n        (b) The contribution is based upon previous work that, to the best\n            of my knowledge, is covered under an appropriate open source\n            license and I have the right under that license to submit that\n            work with modifications, whether created in whole or in part\n            by me, under the same open source license (unless I am\n            permitted to submit under a different license), as indicated\n            in the file; or\n\n        (c) The contribution was provided directly to me by some other\n            person who certified (a), (b) or (c) and I have not modified\n            it.\n\n        (d) I understand and agree that this project and the contribution\n            are public and that a record of the contribution (including all\n            personal information I submit with it, including my sign-off) is\n            maintained indefinitely and may be redistributed consistent with\n            this project or the open source license(s) involved.\n\nthen you just add a line saying::\n\n        Signed-off-by: Random J Developer <random@developer.example.org>\n\nYou are in case (c), and the chain of Signed-off-by allows to trace how\nthe code ended up in Buildroot.\n\nThanks!\n\nThomas","headers":{"Return-Path":"<buildroot-bounces@busybox.net>","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=<UNKNOWN>)","Received":["from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xlPRh3lrsz9sP3\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSun,  3 Sep 2017 17:16:48 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 481CD86BFF;\n\tSun,  3 Sep 2017 07:16:45 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Pp3vqbXHvOfO; Sun,  3 Sep 2017 07:16:44 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 1619086B47;\n\tSun,  3 Sep 2017 07:16:44 +0000 (UTC)","from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 508051C1593\n\tfor <buildroot@lists.busybox.net>;\n\tSun,  3 Sep 2017 07:16:42 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 3FD602A35C\n\tfor <buildroot@lists.busybox.net>;\n\tSun,  3 Sep 2017 07:16:42 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Y6c7i2nFYvDZ for <buildroot@lists.busybox.net>;\n\tSun,  3 Sep 2017 07:16:41 +0000 (UTC)","from mail.free-electrons.com (mail.free-electrons.com [62.4.15.54])\n\tby silver.osuosl.org (Postfix) with ESMTP id 10E5822EE6\n\tfor <buildroot@uclibc.org>; Sun,  3 Sep 2017 07:16:40 +0000 (UTC)","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 9BD9A20972; Sun,  3 Sep 2017 09:16:37 +0200 (CEST)","from windsurf.lan (unknown [185.94.29.10])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id 468DB2093C;\n\tSun,  3 Sep 2017 09:16:37 +0200 (CEST)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","Date":"Sun, 3 Sep 2017 09:16:37 +0200","From":"Thomas Petazzoni <thomas.petazzoni@free-electrons.com>","To":"Angelo Compagnucci <angelo.compagnucci@gmail.com>","Message-ID":"<20170903091637.06725492@windsurf.lan>","In-Reply-To":"<CA+TH9Vkr+B6-1f0QUWP98UJxbnP+c-V=htKy9byKwF8-gzzZGA@mail.gmail.com>","References":"<1504281081-11201-1-git-send-email-angelo.compagnucci@gmail.com>\n\t<20170902231728.2be2989f@windsurf.lan>\n\t<CA+TH9Vkr+B6-1f0QUWP98UJxbnP+c-V=htKy9byKwF8-gzzZGA@mail.gmail.com>","Organization":"Free Electrons","X-Mailer":"Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu)","MIME-Version":"1.0","Cc":"\"buildroot@uclibc.org\" <buildroot@uclibc.org>","Subject":"Re: [Buildroot] [PATCH] package/sysdig: fix missing curlbuild\n\tinclude","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot <buildroot.busybox.net>","List-Unsubscribe":"<http://lists.busybox.net/mailman/options/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=unsubscribe>","List-Archive":"<http://lists.busybox.net/pipermail/buildroot/>","List-Post":"<mailto:buildroot@busybox.net>","List-Help":"<mailto:buildroot-request@busybox.net?subject=help>","List-Subscribe":"<http://lists.busybox.net/mailman/listinfo/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" <buildroot-bounces@busybox.net>"}}]