[{"id":1764146,"web_url":"http://patchwork.ozlabs.org/comment/1764146/","msgid":"<71a117da-fb2d-7e1e-2609-78dfb920d103@linux.vnet.ibm.com>","date":"2017-09-06T14:24:10","subject":"Re: [PATCH V13 2/4] powerpc/vphn: Improve recognition of PRRN/VPHN","submitter":{"id":17146,"url":"http://patchwork.ozlabs.org/api/people/17146/","name":"Nathan Fontenot","email":"nfont@linux.vnet.ibm.com"},"content":"On 09/01/2017 10:48 AM, Michael Bringmann wrote:\n> powerpc/vphn: On Power systems with shared configurations of CPUs\n> and memory, there are some issues with the association of additional\n> CPUs and memory to nodes when hot-adding resources. This patch\n> updates the initialization checks to independently recognize PRRN\n> or VPHN support.\n> \n> Signed-off-by: Michael Bringmann \n> ---\n> Changes in V13:\n> -- Split patch to improve review\n> ---\n> arch/powerpc/mm/numa.c | 6 ++++--\n> 1 file changed, 4 insertions(+), 2 deletions(-)\n> \n> diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c\n> index 312f6ee..c08d736 100644\n> --- a/arch/powerpc/mm/numa.c\n> +++ b/arch/powerpc/mm/numa.c\n> @@ -1543,7 +1543,8 @@ int start_topology_update(void)\n> \t\t\trc = of_reconfig_notifier_register(&dt_update_nb);\n> #endif\n> \t\t}\n> -\t} else if (firmware_has_feature(FW_FEATURE_VPHN) &&\n> +\t}\n> +\tif (firmware_has_feature(FW_FEATURE_VPHN) &&\n> \t\t lppaca_shared_proc(get_lppaca())) {\n> \t\tif (!vphn_enabled) {\n> \t\t\tvphn_enabled = 1;\n\nIn patch 1/4, you removed the setting of prrn_enabled and vphn_enabled\nto 0. It seems like that update would be part of this patch.\n\n-Nathan\n\n> @@ -1568,7 +1569,8 @@ int stop_topology_update(void)\n> #ifdef CONFIG_SMP\n> \t\trc = of_reconfig_notifier_unregister(&dt_update_nb);\n> #endif\n> -\t} else if (vphn_enabled) {\n> +\t}\n> +\tif (vphn_enabled) {\n> \t\tvphn_enabled = 0;> \t\trc = del_timer_sync(&topology_timer);\n> \t}\n>","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnQq10MPKz9t4P\n\tfor ;\n\tThu, 7 Sep 2017 00:25:33 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xnQq06b5QzDrWm\n\tfor ;\n\tThu, 7 Sep 2017 00:25:32 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n\t[148.163.158.5])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xnQnk22WzzDrMP\n\tfor ;\n\tThu, 7 Sep 2017 00:24:26 +1000 (AEST)","from pps.filterd (m0098419.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv86EOFkM111216\n\tfor ; Wed, 6 Sep 2017 10:24:23 -0400","from e13.ny.us.ibm.com (e13.ny.us.ibm.com [129.33.205.203])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 2cthjqdcdw-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Wed, 06 Sep 2017 10:24:23 -0400","from localhost\n\tby e13.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ; \n\tWed, 6 Sep 2017 10:24:15 -0400","from b01cxnp22033.gho.pok.ibm.com (9.57.198.23)\n\tby e13.ny.us.ibm.com (146.89.104.200) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tWed, 6 Sep 2017 10:24:12 -0400","from b01ledav003.gho.pok.ibm.com (b01ledav003.gho.pok.ibm.com\n\t[9.57.199.108])\n\tby b01cxnp22033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP\n\tid v86EOBOx23986256; Wed, 6 Sep 2017 14:24:11 GMT","from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 6D028B2056;\n\tWed, 6 Sep 2017 10:21:34 -0400 (EDT)","from [9.41.92.186] (unknown [9.41.92.186])\n\tby b01ledav003.gho.pok.ibm.com (Postfix) with ESMTP id DA835B205A;\n\tWed, 6 Sep 2017 10:21:33 -0400 (EDT)"],"Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=linux.vnet.ibm.com\n\t(client-ip=148.163.158.5; helo=mx0a-001b2d01.pphosted.com;\n\tenvelope-from=nfont@linux.vnet.ibm.com; receiver=)","Subject":"Re: [PATCH V13 2/4] powerpc/vphn: Improve recognition of PRRN/VPHN","To":"Michael Bringmann , linuxppc-dev@lists.ozlabs.org,\n\tlinux-kernel@vger.kernel.org","References":"<067ca4f6-3181-6c6d-32cf-7164fe2c715d@linux.vnet.ibm.com>","From":"Nathan Fontenot ","Date":"Wed, 6 Sep 2017 09:24:10 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<067ca4f6-3181-6c6d-32cf-7164fe2c715d@linux.vnet.ibm.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-TM-AS-GCONF":"00","x-cbid":"17090614-0008-0000-0000-0000027A2BF5","X-IBM-SpamModules-Scores":"","X-IBM-SpamModules-Versions":"BY=3.00007677; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000226; SDB=6.00913105; UDB=6.00458253;\n\tIPR=6.00693367; \n\tBA=6.00005574; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017033;\n\tXFM=3.00000015; UTC=2017-09-06 14:24:13","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17090614-0009-0000-0000-0000369B7384","Message-Id":"<71a117da-fb2d-7e1e-2609-78dfb920d103@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-06_05:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709060202","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"John Allen ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}}]