[{"id":1761866,"web_url":"http://patchwork.ozlabs.org/comment/1761866/","msgid":"<20170901.103408.279665918180927406.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-01T17:34:08","subject":"Re: [PATCH] qlcnic: remove redundant zero check on retries counter","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Colin King <colin.king@canonical.com>\nDate: Fri,  1 Sep 2017 14:44:31 +0100\n\n> From: Colin Ian King <colin.king@canonical.com>\n> \n> At the end of the do while loop the integer counter retries will\n> always be zero and so the subsequent check to see if it is zero\n> is always true and therefore redundant.  Remove the redundant check\n> and always return -EIO on this return path.  Also unbreak the literal\n> string in dev_err message to clean up a checkpatch warning.\n> \n> Detected by CoverityScan, CID#744279 (\"Logically dead code\")\n> \n> Signed-off-by: Colin Ian King <colin.king@canonical.com>\n\nApplied to net-next, thanks.","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkRFB1k8Tz9t32\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat,  2 Sep 2017 03:34:22 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752280AbdIAReL (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tFri, 1 Sep 2017 13:34:11 -0400","from shards.monkeyblade.net ([184.105.139.130]:50028 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752131AbdIAReJ (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Fri, 1 Sep 2017 13:34:09 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id EA19E13534D67;\n\tFri,  1 Sep 2017 10:34:08 -0700 (PDT)"],"Date":"Fri, 01 Sep 2017 10:34:08 -0700 (PDT)","Message-Id":"<20170901.103408.279665918180927406.davem@davemloft.net>","To":"colin.king@canonical.com","Cc":"harish.patil@cavium.com, manish.chopra@cavium.com,\n\tDept-GELinuxNICDev@cavium.com, netdev@vger.kernel.org,\n\tkernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH] qlcnic: remove redundant zero check on retries counter","From":"David Miller <davem@davemloft.net>","In-Reply-To":"<20170901134431.23179-1-colin.king@canonical.com>","References":"<20170901134431.23179-1-colin.king@canonical.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Fri, 01 Sep 2017 10:34:09 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}}]