[{"id":1761861,"web_url":"http://patchwork.ozlabs.org/comment/1761861/","msgid":"<20170901.103022.450258953816266474.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-01T17:30:22","subject":"Re: [PATCH net] udp: fix secpath leak","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Paolo Abeni \nDate: Fri, 1 Sep 2017 14:42:30 +0200\n\n> From: Yossi Kuperman \n> \n> After commit dce4551cb2ad (\"udp: preserve head state for IP_CMSG_PASSSEC\")\n> we preserve the secpath for the whole skb lifecycle, but we also\n> end up leaking a reference to it.\n> \n> We must clear the head state on skb reception, if secpath is\n> present.\n> \n> Fixes: dce4551cb2ad (\"udp: preserve head state for IP_CMSG_PASSSEC\")\n> Signed-off-by: Yossi Kuperman \n> Signed-off-by: Paolo Abeni \n\nApplied.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkR8h6XYNz9t32\n\tfor ;\n\tSat, 2 Sep 2017 03:30:28 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752275AbdIARa1 (ORCPT );\n\tFri, 1 Sep 2017 13:30:27 -0400","from shards.monkeyblade.net ([184.105.139.130]:49960 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752236AbdIARaX (ORCPT\n\t); Fri, 1 Sep 2017 13:30:23 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id A3EB41340B8CF;\n\tFri, 1 Sep 2017 10:30:22 -0700 (PDT)"],"Date":"Fri, 01 Sep 2017 10:30:22 -0700 (PDT)","Message-Id":"<20170901.103022.450258953816266474.davem@davemloft.net>","To":"pabeni@redhat.com","Cc":"netdev@vger.kernel.org, yossiku@mellanox.com, paul@paul-moore.com","Subject":"Re: [PATCH net] udp: fix secpath leak","From":"David Miller ","In-Reply-To":"<5bd7a6e643340d833718722c0508474c6c3a0a3a.1504260470.git.pabeni@redhat.com>","References":"<5bd7a6e643340d833718722c0508474c6c3a0a3a.1504260470.git.pabeni@redhat.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Fri, 01 Sep 2017 10:30:22 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]