[{"id":1762107,"web_url":"http://patchwork.ozlabs.org/comment/1762107/","msgid":"<60ac96bf-e99d-6bd1-9905-096d47cb490e@denx.de>","list_archive_url":null,"date":"2017-09-02T11:08:44","subject":"Re: [U-Boot] [PATCH v3 1/1] usb: gadget: g_dnl: Sync internal SN\n\tvariable with env","submitter":{"id":70701,"url":"http://patchwork.ozlabs.org/api/people/70701/","name":"Lukasz Majewski","email":"lukma@denx.de"},"content":"Hi Heiko,\n\nWould you find some time and run this patch through your test setup?\n\nThanks in advance.\n\nBest regards,\nŁukasz\n\n\n> Since commit 842778a09104 (\"usb: gadget: g_dnl: only set iSerialNumber\n> if we have a serial#\") \"fastboot devices\" stopped to show correct device\n> serial number for TI boards, showing this line instead:\n>\n> ????????????\tfastboot\n>\n> This is because serial# env variable could be set after g_dnl gadget was\n> initialized (e.g. by using env_set() in the board file).\n>\n> To fix this, let's update internal serial number variable (g_dnl_serial)\n> when \"serial#\" env var is changed.\n>\n> Signed-off-by: Sam Protsenko \n> Cc: Felipe Balbi \n> ---\n> drivers/usb/gadget/g_dnl.c | 15 +++++++++++++++\n> include/env_callback.h | 1 +\n> 2 files changed, 16 insertions(+)\n>\n> diff --git a/drivers/usb/gadget/g_dnl.c b/drivers/usb/gadget/g_dnl.c\n> index 0491a0eea9..039331a5af 100644\n> --- a/drivers/usb/gadget/g_dnl.c\n> +++ b/drivers/usb/gadget/g_dnl.c\n> @@ -19,6 +19,8 @@\n> #include \n> #include \n>\n> +#include \n> +\n> #include \"gadget_chips.h\"\n> #include \"composite.c\"\n>\n> @@ -202,6 +204,19 @@ static int g_dnl_get_bcd_device_number(struct usb_composite_dev *cdev)\n> \treturn g_dnl_get_board_bcd_device_number(gcnum);\n> }\n>\n> +/**\n> + * Update internal serial number variable when the \"serial#\" env var changes.\n> + *\n> + * Handle all cases, even when flags == H_PROGRAMMATIC or op == env_op_delete.\n> + */\n> +static int on_serialno(const char *name, const char *value, enum env_op op,\n> +\t\tint flags)\n> +{\n> +\tg_dnl_set_serialnumber((char *)value);\n> +\treturn 0;\n> +}\n> +U_BOOT_ENV_CALLBACK(serialno, on_serialno);\n> +\n> static int g_dnl_bind(struct usb_composite_dev *cdev)\n> {\n> \tstruct usb_gadget *gadget = cdev->gadget;\n> diff --git a/include/env_callback.h b/include/env_callback.h\n> index 90b95b5e66..5c4a30c2de 100644\n> --- a/include/env_callback.h\n> +++ b/include/env_callback.h\n> @@ -72,6 +72,7 @@\n> \tSILENT_CALLBACK \\\n> \tSPLASHIMAGE_CALLBACK \\\n> \t\"stdin:console,stdout:console,stderr:console,\" \\\n> +\t\"serial#:serialno,\" \\\n> \tCONFIG_ENV_CALLBACK_LIST_STATIC\n>\n> struct env_clbk_tbl {\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xktf15j0dz9s3T\n\tfor ;\n\tSat, 2 Sep 2017 21:08:57 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 7AAF9C21C5C; Sat, 2 Sep 2017 11:08:53 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id B65A0C21DAD;\n\tSat, 2 Sep 2017 11:08:50 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid BB182C21DAD; Sat, 2 Sep 2017 11:08:48 +0000 (UTC)","from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10])\n\tby lists.denx.de (Postfix) with ESMTPS id 26334C21C5C\n\tfor ; Sat, 2 Sep 2017 11:08:47 +0000 (UTC)","from frontend01.mail.m-online.net (unknown [192.168.8.182])\n\tby mail-out.m-online.net (Postfix) with ESMTP id 3xktdq2B26z1qrdn;\n\tSat, 2 Sep 2017 13:08:47 +0200 (CEST)","from localhost (dynscan1.mnet-online.de [192.168.6.70])\n\tby mail.m-online.net (Postfix) with ESMTP id 3xktdq13yLz3jgXq;\n\tSat, 2 Sep 2017 13:08:47 +0200 (CEST)","from mail.mnet-online.de ([192.168.8.182])\n\tby localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id 8chM7NA9Uid1; Sat, 2 Sep 2017 13:08:45 +0200 (CEST)","from [192.168.2.222] (89-77-92-62.dynamic.chello.pl [89.77.92.62])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mail.mnet-online.de (Postfix) with ESMTPSA;\n\tSat, 2 Sep 2017 13:08:45 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,\n\tRCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","X-Virus-Scanned":"amavisd-new at mnet-online.de","X-Auth-Info":"VpO0QvJg1FmeafpMogjODI6DHfiGlL5B9xmSgh0IaAU=","References":"<20170901124203.19462-1-semen.protsenko@linaro.org>","To":"Heiko Schocher ","From":"=?utf-8?q?=C5=81ukasz_Majewski?= ","Organization":"DENX","Message-ID":"<60ac96bf-e99d-6bd1-9905-096d47cb490e@denx.de>","Date":"Sat, 2 Sep 2017 13:08:44 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tThunderbird/45.8.0","MIME-Version":"1.0","In-Reply-To":"<20170901124203.19462-1-semen.protsenko@linaro.org>","Cc":"Marek Vasut , Tom Rini ,\n\tPraneeth Bajjuri , u-boot@lists.denx.de","Subject":"Re: [U-Boot] [PATCH v3 1/1] usb: gadget: g_dnl: Sync internal SN\n\tvariable with env","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1762424,"web_url":"http://patchwork.ozlabs.org/comment/1762424/","msgid":"<59ACE66F.9050207@denx.de>","list_archive_url":null,"date":"2017-09-04T05:36:47","subject":"Re: [U-Boot] [PATCH v3 1/1] usb: gadget: g_dnl: Sync internal SN\n\tvariable with env","submitter":{"id":99,"url":"http://patchwork.ozlabs.org/api/people/99/","name":"Heiko Schocher","email":"hs@denx.de"},"content":"Hello Lukasz,\n\nAm 02.09.2017 um 13:08 schrieb Łukasz Majewski:\n> Hi Heiko,\n>\n> Would you find some time and run this patch through your test setup?\n>\n> Thanks in advance.\n\nOf course, as it is automated ;-)\n\nOkay, I had to add an oneliner, to say tbot, which patchwork patch it\nhas to download... for the records see [1].\n\nHere the results for the smartweb board (in short, my dfu test are\nworking with this patch):\n\nhttp://xeidos.ddns.net/tests/test_db_auslesen.php#408\n\nLogs:\nhttp://xeidos.ddns.net/tbot/id_408/html_log.html\n\nEspecially the steps:\n\n(download patchwork patch, check with checkpatch, apply to mainline):\nhttp://xeidos.ddns.net/tbot/id_408/html_log.html#92\nhttp://xeidos.ddns.net/tbot/id_408/html_log.html#95\nhttp://xeidos.ddns.net/tbot/id_408/html_log.html#98\n\nand the dfu test:\n\nhttp://xeidos.ddns.net/tbot/id_408/html_log.html#398\nhttp://xeidos.ddns.net/tbot/id_408/html_log.html#409\nhttp://xeidos.ddns.net/tbot/id_408/html_log.html#413\nhttp://xeidos.ddns.net/tbot/id_408/html_log.html#417\n\nMy browser (firefox) seems to have problems with jumping to the correct\n\"id\"s in the html file ...\n\nHope you can find the logs, if not, look into the raw logfile:\n\nhttp://xeidos.ddns.net/tbot/id_408/tbot.txt\n\nbut this is not very comfortable ...\n\nSo, please add my:\n\nTested-by: Heiko Schocher \n\nbye,\nHeiko\n\n[1] tbot patch for adding a patchworkpatch\n\nroot@raspberrypi:/home/pi/data/tbot# git diff\ndiff --git a/config/smartweb.py b/config/smartweb.py\nindex 72a7972..98c8e0f 100644\n--- a/config/smartweb.py\n+++ b/config/smartweb.py\n@@ -37,6 +37,8 @@ tc_workfd_apply_patchwork_patches_list_hand = [\n]\ntc_workfd_apply_patchwork_patches_blacklist = ['204183', '561384']\n\n+tc_workfd_apply_patchwork_patches_list = ['808671']\n+\nuboot_get_parameter_file_list = ['.config', 'include/configs/smartweb.h', \n'arch/arm/mach-at91/include/mach/at91sam9260.h']\n\ntc_workfd_set_toolchain_arch = 'arm'\nroot@raspberrypi:/home/pi/data/tbot#","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xlzB72TM4z9s78\n\tfor ;\n\tMon, 4 Sep 2017 15:37:03 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 007D3C21E7C; Mon, 4 Sep 2017 05:36:59 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 8EFF0C21D7D;\n\tMon, 4 Sep 2017 05:36:57 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid D8F46C21D7D; Mon, 4 Sep 2017 05:36:55 +0000 (UTC)","from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10])\n\tby lists.denx.de (Postfix) with ESMTPS id 8DF7CC21D75\n\tfor ; Mon, 4 Sep 2017 05:36:55 +0000 (UTC)","from frontend01.mail.m-online.net (unknown [192.168.8.182])\n\tby mail-out.m-online.net (Postfix) with ESMTP id 3xlz9z097bz1qsgs;\n\tMon, 4 Sep 2017 07:36:55 +0200 (CEST)","from localhost (dynscan1.mnet-online.de [192.168.6.70])\n\tby mail.m-online.net (Postfix) with ESMTP id 3xlz9y61RRz3jgYb;\n\tMon, 4 Sep 2017 07:36:54 +0200 (CEST)","from mail.mnet-online.de ([192.168.8.182])\n\tby localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id QqCLRNCTShHb; Mon, 4 Sep 2017 07:36:52 +0200 (CEST)","from localhost.localdomain (87.97.19.79.pool.invitel.hu\n\t[87.97.19.79])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mail.mnet-online.de (Postfix) with ESMTPSA;\n\tMon, 4 Sep 2017 07:36:52 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,\n\tRCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","X-Virus-Scanned":"amavisd-new at mnet-online.de","X-Auth-Info":"HNwC1ilF+Q2a1dJwOTiDeJJtWvLfjdlf4zHerTvOTxA=","To":"=?utf-8?q?=C5=81ukasz_Majewski?= ","References":"<20170901124203.19462-1-semen.protsenko@linaro.org>\n\t<60ac96bf-e99d-6bd1-9905-096d47cb490e@denx.de>","From":"Heiko Schocher ","Message-ID":"<59ACE66F.9050207@denx.de>","Date":"Mon, 4 Sep 2017 07:36:47 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101\n\tThunderbird/38.1.0","MIME-Version":"1.0","In-Reply-To":"<60ac96bf-e99d-6bd1-9905-096d47cb490e@denx.de>","Cc":"Marek Vasut , Tom Rini ,\n\tPraneeth Bajjuri , u-boot@lists.denx.de","Subject":"Re: [U-Boot] [PATCH v3 1/1] usb: gadget: g_dnl: Sync internal SN\n\tvariable with env","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"hs@denx.de","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1763180,"web_url":"http://patchwork.ozlabs.org/comment/1763180/","msgid":"","list_archive_url":null,"date":"2017-09-05T10:23:24","subject":"Re: [U-Boot] [PATCH v3 1/1] usb: gadget: g_dnl: Sync internal SN\n\tvariable with env","submitter":{"id":68333,"url":"http://patchwork.ozlabs.org/api/people/68333/","name":"Sam Protsenko","email":"semen.protsenko@linaro.org"},"content":"On 4 September 2017 at 08:36, Heiko Schocher wrote:\n> Hello Lukasz,\n>\n> Am 02.09.2017 um 13:08 schrieb Łukasz Majewski:\n>>\n>> Hi Heiko,\n>>\n>> Would you find some time and run this patch through your test setup?\n>>\n>> Thanks in advance.\n>\n>\n> Of course, as it is automated ;-)\n>\n> Okay, I had to add an oneliner, to say tbot, which patchwork patch it\n> has to download... for the records see [1].\n>\n> Here the results for the smartweb board (in short, my dfu test are\n> working with this patch):\n>\n> http://xeidos.ddns.net/tests/test_db_auslesen.php#408\n>\n> Logs:\n> http://xeidos.ddns.net/tbot/id_408/html_log.html\n>\n> Especially the steps:\n>\n> (download patchwork patch, check with checkpatch, apply to mainline):\n> http://xeidos.ddns.net/tbot/id_408/html_log.html#92\n> http://xeidos.ddns.net/tbot/id_408/html_log.html#95\n> http://xeidos.ddns.net/tbot/id_408/html_log.html#98\n>\n> and the dfu test:\n>\n> http://xeidos.ddns.net/tbot/id_408/html_log.html#398\n> http://xeidos.ddns.net/tbot/id_408/html_log.html#409\n> http://xeidos.ddns.net/tbot/id_408/html_log.html#413\n> http://xeidos.ddns.net/tbot/id_408/html_log.html#417\n>\n> My browser (firefox) seems to have problems with jumping to the correct\n> \"id\"s in the html file ...\n>\n> Hope you can find the logs, if not, look into the raw logfile:\n>\n> http://xeidos.ddns.net/tbot/id_408/tbot.txt\n>\n> but this is not very comfortable ...\n>\n> So, please add my:\n>\n> Tested-by: Heiko Schocher \n>\n\nHi Lukasz,\n\nNow that testing is done (thanks Heiko!), can you please Ack or Review\nthis patch? I really want it to go in v2017.09 release, as it's\ncritical bug fix for us.\n\nThanks!\n\n> bye,\n> Heiko\n>\n> [1] tbot patch for adding a patchworkpatch\n>\n> root@raspberrypi:/home/pi/data/tbot# git diff\n> diff --git a/config/smartweb.py b/config/smartweb.py\n> index 72a7972..98c8e0f 100644\n> --- a/config/smartweb.py\n> +++ b/config/smartweb.py\n> @@ -37,6 +37,8 @@ tc_workfd_apply_patchwork_patches_list_hand = [\n> ]\n> tc_workfd_apply_patchwork_patches_blacklist = ['204183', '561384']\n>\n> +tc_workfd_apply_patchwork_patches_list = ['808671']\n> +\n> uboot_get_parameter_file_list = ['.config', 'include/configs/smartweb.h',\n> 'arch/arm/mach-at91/include/mach/at91sam9260.h']\n>\n> tc_workfd_set_toolchain_arch = 'arm'\n> root@raspberrypi:/home/pi/data/tbot#\n>\n>\n> --\n> DENX Software Engineering GmbH, Managing Director: Wolfgang Denk\n> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"Q6lu4jfZ\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmjVP3LbNz9s3w\n\tfor ;\n\tTue, 5 Sep 2017 20:23:40 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 3050AC21F3D; Tue, 5 Sep 2017 10:23:30 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 1B5F4C21C4E;\n\tTue, 5 Sep 2017 10:23:28 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 94A49C21C4E; Tue, 5 Sep 2017 10:23:27 +0000 (UTC)","from mail-io0-f174.google.com (mail-io0-f174.google.com\n\t[209.85.223.174])\n\tby lists.denx.de (Postfix) with ESMTPS id 4C5D6C21C2B\n\tfor ; Tue, 5 Sep 2017 10:23:26 +0000 (UTC)","by mail-io0-f174.google.com with SMTP id j141so9711470ioj.4\n\tfor ; Tue, 05 Sep 2017 03:23:26 -0700 (PDT)","by 10.107.36.139 with HTTP; Tue, 5 Sep 2017 03:23:24 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H2,\n\tT_DKIM_INVALID autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=IV0T7ohTfaEhKPv5iVdvqjlw+1sA0Ni7WerXP5fOxW0=;\n\tb=Q6lu4jfZboPiaCHlVf+Q/wVG8mc6CI0XttiwjxRerpByZ6sChbDLQ7lPn+gMwmughV\n\tVBgRyQVUpO+ovXINJuXEIQBd00EhN1qNfE8YX52Zhmo3BjEXi8xfJ1DSEhwrr91XEgfG\n\tTMj8cqxdZc4ZG8hD0fYSCdyN6wOt7Auv/ppTA=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=IV0T7ohTfaEhKPv5iVdvqjlw+1sA0Ni7WerXP5fOxW0=;\n\tb=QWK4hWnriFHznZJCmbuGl3X1zIpMhmbJ9lKI7GMz8xB6940hCWDAo0Mbz+iqjUjmHd\n\tm20B63ZWOq8xAlhfgxngPFvjHxY5OHmkk8g7e0YYinjgUBsHENyFyK/Q/h8CxCotY93L\n\tLTrTIedRVSibWmdMqx2hTuyDhFBQSZyyNvJtc27PZGWeDpxJZdFE8djwjpUOPtMVuMrc\n\tC7SgR8L+aI03ZgPgZoYD0clVTHFZCZ644yDNFcYBLpSxjSM4qdQ+/nzdNjiZCV4+hPZZ\n\tm7U3KHsDr3wlDEeScj9ouvlCXaBeGx9XEvJxTjRMGVCBY13+zRRkLy70lghZDl6WC8cA\n\tJp0w==","X-Gm-Message-State":"AHPjjUjWfmJnYrfY6mReBIq0PL2mOhUNQzewmkhh3066Sd7+UH41sBk4\n\tdgSVeFH5G58FHACmUhxpTCY3tMMerZWT","X-Google-Smtp-Source":"ADKCNb4UY0cwvy01IPZK6X38hPDKkwD2QnJfF/7Pt7C0e23G4HBLLrnDytRMNaXs79yGzDEjv8Pb+4OkcjnvYYSPOeM=","X-Received":"by 10.36.176.5 with SMTP id d5mr3763495itf.150.1504607004872;\n\tTue, 05 Sep 2017 03:23:24 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<59ACE66F.9050207@denx.de>","References":"<20170901124203.19462-1-semen.protsenko@linaro.org>\n\t<60ac96bf-e99d-6bd1-9905-096d47cb490e@denx.de>\n\t<59ACE66F.9050207@denx.de>","From":"Sam Protsenko ","Date":"Tue, 5 Sep 2017 13:23:24 +0300","Message-ID":"","To":"=?utf-8?q?=C5=81ukasz_Majewski?= ","Cc":"Marek Vasut , Tom Rini ,\n\tPraneeth Bajjuri ,\n\tU-Boot Mailing List ","Subject":"Re: [U-Boot] [PATCH v3 1/1] usb: gadget: g_dnl: Sync internal SN\n\tvariable with env","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1763185,"web_url":"http://patchwork.ozlabs.org/comment/1763185/","msgid":"","list_archive_url":null,"date":"2017-09-05T10:27:37","subject":"Re: [U-Boot] [PATCH v3 1/1] usb: gadget: g_dnl: Sync internal SN\n\tvariable with env","submitter":{"id":70701,"url":"http://patchwork.ozlabs.org/api/people/70701/","name":"Lukasz Majewski","email":"lukma@denx.de"},"content":"Hi Sam,\n\n> On 4 September 2017 at 08:36, Heiko Schocher wrote:\n>> Hello Lukasz,\n>>\n>> Am 02.09.2017 um 13:08 schrieb Łukasz Majewski:\n>>>\n>>> Hi Heiko,\n>>>\n>>> Would you find some time and run this patch through your test setup?\n>>>\n>>> Thanks in advance.\n>>\n>>\n>> Of course, as it is automated ;-)\n>>\n>> Okay, I had to add an oneliner, to say tbot, which patchwork patch it\n>> has to download... for the records see [1].\n>>\n>> Here the results for the smartweb board (in short, my dfu test are\n>> working with this patch):\n>>\n>> http://xeidos.ddns.net/tests/test_db_auslesen.php#408\n>>\n>> Logs:\n>> http://xeidos.ddns.net/tbot/id_408/html_log.html\n>>\n>> Especially the steps:\n>>\n>> (download patchwork patch, check with checkpatch, apply to mainline):\n>> http://xeidos.ddns.net/tbot/id_408/html_log.html#92\n>> http://xeidos.ddns.net/tbot/id_408/html_log.html#95\n>> http://xeidos.ddns.net/tbot/id_408/html_log.html#98\n>>\n>> and the dfu test:\n>>\n>> http://xeidos.ddns.net/tbot/id_408/html_log.html#398\n>> http://xeidos.ddns.net/tbot/id_408/html_log.html#409\n>> http://xeidos.ddns.net/tbot/id_408/html_log.html#413\n>> http://xeidos.ddns.net/tbot/id_408/html_log.html#417\n>>\n>> My browser (firefox) seems to have problems with jumping to the correct\n>> \"id\"s in the html file ...\n>>\n>> Hope you can find the logs, if not, look into the raw logfile:\n>>\n>> http://xeidos.ddns.net/tbot/id_408/tbot.txt\n>>\n>> but this is not very comfortable ...\n>>\n>> So, please add my:\n>>\n>> Tested-by: Heiko Schocher \n>>\n> \n> Hi Lukasz,\n> \n> Now that testing is done (thanks Heiko!), can you please Ack or Review\n> this patch? I really want it to go in v2017.09 release, as it's\n> critical bug fix for us.\n\nNo problem from my side:\n\nAcked-by: Łukasz Majewski \n\n\nIf Marek don't mind - I would like to ask Tom to apply it directly to \n-master branch (because of the patch importance).\n\n\n> \n> Thanks!\n> \n>> bye,\n>> Heiko\n>>\n>> [1] tbot patch for adding a patchworkpatch\n>>\n>> root@raspberrypi:/home/pi/data/tbot# git diff\n>> diff --git a/config/smartweb.py b/config/smartweb.py\n>> index 72a7972..98c8e0f 100644\n>> --- a/config/smartweb.py\n>> +++ b/config/smartweb.py\n>> @@ -37,6 +37,8 @@ tc_workfd_apply_patchwork_patches_list_hand = [\n>> ]\n>> tc_workfd_apply_patchwork_patches_blacklist = ['204183', '561384']\n>>\n>> +tc_workfd_apply_patchwork_patches_list = ['808671']\n>> +\n>> uboot_get_parameter_file_list = ['.config', 'include/configs/smartweb.h',\n>> 'arch/arm/mach-at91/include/mach/at91sam9260.h']\n>>\n>> tc_workfd_set_toolchain_arch = 'arm'\n>> root@raspberrypi:/home/pi/data/tbot#\n>>\n>>\n>> --\n>> DENX Software Engineering GmbH, Managing Director: Wolfgang Denk\n>> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmjb96R9Hz9s3w\n\tfor ;\n\tTue, 5 Sep 2017 20:27:49 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 7AC63C21E1E; Tue, 5 Sep 2017 10:27:46 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 5BECBC21C4E;\n\tTue, 5 Sep 2017 10:27:43 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 29954C21C4E; Tue, 5 Sep 2017 10:27:41 +0000 (UTC)","from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10])\n\tby lists.denx.de (Postfix) with ESMTPS id D1CEEC21C45\n\tfor ; Tue, 5 Sep 2017 10:27:40 +0000 (UTC)","from frontend01.mail.m-online.net (unknown [192.168.8.182])\n\tby mail-out.m-online.net (Postfix) with ESMTP id 3xmjb01lqsz1qqkS;\n\tTue, 5 Sep 2017 12:27:40 +0200 (CEST)","from localhost (dynscan1.mnet-online.de [192.168.6.70])\n\tby mail.m-online.net (Postfix) with ESMTP id 3xmjb0036Nz3hhhZ;\n\tTue, 5 Sep 2017 12:27:39 +0200 (CEST)","from mail.mnet-online.de ([192.168.8.182])\n\tby localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id 3Ou6wCu4cd89; Tue, 5 Sep 2017 12:27:38 +0200 (CEST)","from [192.168.2.222] (89-77-92-62.dynamic.chello.pl [89.77.92.62])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mail.mnet-online.de (Postfix) with ESMTPSA;\n\tTue, 5 Sep 2017 12:27:38 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,\n\tRCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","X-Virus-Scanned":"amavisd-new at mnet-online.de","X-Auth-Info":"/QmFk27SQBrzXRYkxTggAWxb6cc4lyHr3if0XaXkJoI=","To":"Sam Protsenko , Tom Rini\n\t, Marek Vasut ","References":"<20170901124203.19462-1-semen.protsenko@linaro.org>\n\t<60ac96bf-e99d-6bd1-9905-096d47cb490e@denx.de>\n\t<59ACE66F.9050207@denx.de>\n\t","From":"=?utf-8?q?=C5=81ukasz_Majewski?= ","Organization":"DENX","Message-ID":"","Date":"Tue, 5 Sep 2017 12:27:37 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-US","Cc":"Praneeth Bajjuri ,\n\tU-Boot Mailing List ","Subject":"Re: [U-Boot] [PATCH v3 1/1] usb: gadget: g_dnl: Sync internal SN\n\tvariable with env","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1763355,"web_url":"http://patchwork.ozlabs.org/comment/1763355/","msgid":"<4ddafa3d-8e85-da92-8712-86954dade9b2@denx.de>","list_archive_url":null,"date":"2017-09-05T13:23:46","subject":"Re: [U-Boot] [PATCH v3 1/1] usb: gadget: g_dnl: Sync internal SN\n\tvariable with env","submitter":{"id":12009,"url":"http://patchwork.ozlabs.org/api/people/12009/","name":"Marek Vasut","email":"marex@denx.de"},"content":"On 09/01/2017 02:42 PM, Sam Protsenko wrote:\n> Since commit 842778a09104 (\"usb: gadget: g_dnl: only set iSerialNumber\n> if we have a serial#\") \"fastboot devices\" stopped to show correct device\n> serial number for TI boards, showing this line instead:\n> \n> ????????????\tfastboot\n> \n> This is because serial# env variable could be set after g_dnl gadget was\n> initialized (e.g. by using env_set() in the board file).\n> \n> To fix this, let's update internal serial number variable (g_dnl_serial)\n> when \"serial#\" env var is changed.\n> \n> Signed-off-by: Sam Protsenko \n> Cc: Felipe Balbi \n\nReviewed-by: Marek Vasut ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmnVY53JDz9t2S\n\tfor ;\n\tTue, 5 Sep 2017 23:24:05 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 69A8AC21E4D; Tue, 5 Sep 2017 13:23:56 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 9D3EAC21C57;\n\tTue, 5 Sep 2017 13:23:53 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 470ECC21C57; Tue, 5 Sep 2017 13:23:52 +0000 (UTC)","from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9])\n\tby lists.denx.de (Postfix) with ESMTPS id A4ADBC21C45\n\tfor ; Tue, 5 Sep 2017 13:23:51 +0000 (UTC)","from frontend01.mail.m-online.net (unknown [192.168.8.182])\n\tby mail-out.m-online.net (Postfix) with ESMTP id 3xmnVH18qSz1qqy9;\n\tTue, 5 Sep 2017 15:23:51 +0200 (CEST)","from localhost (dynscan1.mnet-online.de [192.168.6.70])\n\tby mail.m-online.net (Postfix) with ESMTP id 3xmnVG5zClz3j375;\n\tTue, 5 Sep 2017 15:23:50 +0200 (CEST)","from mail.mnet-online.de ([192.168.8.182])\n\tby localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id ACutzix430La; Tue, 5 Sep 2017 15:23:47 +0200 (CEST)","from [IPv6:::1] (unknown [195.140.253.167])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mail.mnet-online.de (Postfix) with ESMTPSA;\n\tTue, 5 Sep 2017 15:23:47 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,\n\tRCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","X-Virus-Scanned":"amavisd-new at mnet-online.de","X-Auth-Info":"vPTgLB6OMzOZbD45eFXiSK8mEC4ftxVaFJrh3AOTIow=","To":"Sam Protsenko , u-boot@lists.denx.de","References":"<20170901124203.19462-1-semen.protsenko@linaro.org>","From":"Marek Vasut ","Message-ID":"<4ddafa3d-8e85-da92-8712-86954dade9b2@denx.de>","Date":"Tue, 5 Sep 2017 15:23:46 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170901124203.19462-1-semen.protsenko@linaro.org>","Content-Language":"en-US","Cc":"Praneeth Bajjuri , Tom Rini ","Subject":"Re: [U-Boot] [PATCH v3 1/1] usb: gadget: g_dnl: Sync internal SN\n\tvariable with env","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1763744,"web_url":"http://patchwork.ozlabs.org/comment/1763744/","msgid":"<20170906003559.GJ17058@bill-the-cat>","list_archive_url":null,"date":"2017-09-06T00:35:59","subject":"Re: [U-Boot] [U-Boot, v3,\n\t1/1] usb: gadget: g_dnl: Sync internal SN variable with env","submitter":{"id":65875,"url":"http://patchwork.ozlabs.org/api/people/65875/","name":"Tom Rini","email":"trini@konsulko.com"},"content":"On Fri, Sep 01, 2017 at 03:42:03PM +0300, Sam Protsenko wrote:\n\n> Since commit 842778a09104 (\"usb: gadget: g_dnl: only set iSerialNumber\n> if we have a serial#\") \"fastboot devices\" stopped to show correct device\n> serial number for TI boards, showing this line instead:\n> \n> ????????????\tfastboot\n> \n> This is because serial# env variable could be set after g_dnl gadget was\n> initialized (e.g. by using env_set() in the board file).\n> \n> To fix this, let's update internal serial number variable (g_dnl_serial)\n> when \"serial#\" env var is changed.\n> \n> Signed-off-by: Sam Protsenko \n> Cc: Felipe Balbi \n> Tested-by: Heiko Schocher \n> Acked-by: Łukasz Majewski \n> Reviewed-by: Marek Vasut \n\nApplied to u-boot/master, thanks!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=konsulko.com header.i=@konsulko.com\n\theader.b=\"DWwlpwa+\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xn4S30PKYz9t2y\n\tfor ;\n\tWed, 6 Sep 2017 10:37:55 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid C18A0C21E6E; Wed, 6 Sep 2017 00:36:28 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 045C6C21D7E;\n\tWed, 6 Sep 2017 00:36:18 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid E6F58C21D7E; Wed, 6 Sep 2017 00:35:32 +0000 (UTC)","from mail-yw0-f170.google.com (mail-yw0-f170.google.com\n\t[209.85.161.170])\n\tby lists.denx.de (Postfix) with ESMTPS id D99B9C21E01\n\tfor ; Wed, 6 Sep 2017 00:35:31 +0000 (UTC)","by mail-yw0-f170.google.com with SMTP id x144so17728237ywg.2\n\tfor ; Tue, 05 Sep 2017 17:35:31 -0700 (PDT)","from bill-the-cat ([2606:a000:140b:dc:e812:f686:84fa:3ab0])\n\tby smtp.gmail.com with ESMTPSA id\n\tr81sm672014ywb.87.2017.09.05.17.35.29\n\t(version=TLS1_2 cipher=AES128-SHA bits=128/128);\n\tTue, 05 Sep 2017 17:35:30 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com;\n\ts=google; \n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=kZVbqjxAGamIRMpdRc3EW43YryWgukdjRtQfx7+KwOE=;\n\tb=DWwlpwa+E4VhaZZs3o3SeLQDFT2yR4wwJhURe4Zin9LOw0Gtihgeel2JPs6i3WWmfa\n\tuqM6WwSUhPK5HPknolmcV32h5TKgEJ7ueKs6b/2ZrVL5PaiqIMYsZ19Bbq3LLXkmoasT\n\t28E1xopVbQW5jUisCCXoNJYOiDv8rP3ATVw4I=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=kZVbqjxAGamIRMpdRc3EW43YryWgukdjRtQfx7+KwOE=;\n\tb=Yt/I9clucQhZdWjkv5vbHoKsgZLAGLn1DNSctgfEB0SgZgGS0Gt4sooC8knMZRYFVi\n\t2jOlKloFpmEiSV+naGUjc5FlKfQO7YcaRLYk19DKeCnBPVrn8tTT9HjV5cfxBWZ4Kt3G\n\trNLmjY6WlcM/lfU9RbgF2ldkd1sjrxq6Zqf3IIVWkxzl68kpO1aeVseprqiplcaun5Kd\n\t/Ky0lpDaadV6d6xOUUHX8/Lbg0lF46cvEF3e+LkKR28vl1EDkwdwMXrSEvsPHm4+63U4\n\tFzY5IR1vYbw+Xqv45Jvy0ZrUKOC6SGbO/qFU320RZInDl4dT9ImH3KdgUVWH78TEzgi3\n\t69IQ==","X-Gm-Message-State":"AHPjjUgLCWo/IOXigjCvHpOIyYgLLE1g9+wKEwazbKNs9yjiRYgDkaCF\n\tMYy3f7vvpdupv+46","X-Google-Smtp-Source":"ADKCNb5o/zxF1wtD+BfvB04t6ErHb1ieD6J15Y2QlPo0wIzcBYByCV6dr7Q1hKWc0AgfswZ+GBgjyw==","X-Received":"by 10.129.129.1 with SMTP id r1mr720961ywf.322.1504658130790;\n\tTue, 05 Sep 2017 17:35:30 -0700 (PDT)","Date":"Tue, 5 Sep 2017 20:35:59 -0400","From":"Tom Rini ","To":"Sam Protsenko ","Message-ID":"<20170906003559.GJ17058@bill-the-cat>","References":"<20170901124203.19462-1-semen.protsenko@linaro.org>","MIME-Version":"1.0","In-Reply-To":"<20170901124203.19462-1-semen.protsenko@linaro.org>","User-Agent":"Mutt/1.5.21 (2010-09-15)","Cc":"Marek Vasut , u-boot@lists.denx.de,\n\tPraneeth Bajjuri ","Subject":"Re: [U-Boot] [U-Boot, v3,\n\t1/1] usb: gadget: g_dnl: Sync internal SN variable with env","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============0182962481528674549==\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]