[{"id":1761695,"web_url":"http://patchwork.ozlabs.org/comment/1761695/","msgid":"<20170901133850.GA22289@lunn.ch>","list_archive_url":null,"date":"2017-09-01T13:38:50","subject":"Re: [PATCH v2 5/5] net: mdio-mux: fix unbalanced put_device","submitter":{"id":13608,"url":"http://patchwork.ozlabs.org/api/people/13608/","name":"Andrew Lunn","email":"andrew@lunn.ch"},"content":"On Fri, Sep 01, 2017 at 01:56:04PM +0200, Corentin Labbe wrote:\n> mdio_mux_uninit() call put_device (unconditionally) because of\n> of_mdio_find_bus() in mdio_mux_init.\n> But of_mdio_find_bus is only called if mux_bus is empty.\n> If mux_bus is set, mdio_mux_uninit will print a \"refcount_t: underflow\"\n> trace.\n> \n> This patch add a get_device in the other branch of \"if (mux_bus)\".\n> \n> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>\n\nReviewed-by: Andrew Lunn <andrew@lunn.ch>\n\n    Andrew","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkL1V2XFPz9s2G\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri,  1 Sep 2017 23:38:54 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752406AbdIANiw (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tFri, 1 Sep 2017 09:38:52 -0400","from vps0.lunn.ch ([178.209.37.122]:49357 \"EHLO vps0.lunn.ch\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1752072AbdIANiv (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tFri, 1 Sep 2017 09:38:51 -0400","from andrew by vps0.lunn.ch with local (Exim 4.84_2)\n\t(envelope-from <andrew@lunn.ch>)\n\tid 1dnm9q-0007Yj-Fy; Fri, 01 Sep 2017 15:38:50 +0200"],"Date":"Fri, 1 Sep 2017 15:38:50 +0200","From":"Andrew Lunn <andrew@lunn.ch>","To":"Corentin Labbe <clabbe.montjoie@gmail.com>","Cc":"f.fainelli@gmail.com, netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH v2 5/5] net: mdio-mux: fix unbalanced put_device","Message-ID":"<20170901133850.GA22289@lunn.ch>","References":"<20170901115604.27513-1-clabbe.montjoie@gmail.com>\n\t<20170901115604.27513-6-clabbe.montjoie@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170901115604.27513-6-clabbe.montjoie@gmail.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}}]