[{"id":1762941,"web_url":"http://patchwork.ozlabs.org/comment/1762941/","msgid":"<20170905032255.GQ22515@lemon.lan>","list_archive_url":null,"date":"2017-09-05T03:22:55","subject":"Re: [Qemu-devel] [PATCH v8 13/13] qemu.py: don't launch again\n\tbefore shutdown()","submitter":{"id":24872,"url":"http://patchwork.ozlabs.org/api/people/24872/","name":"Fam Zheng","email":"famz@redhat.com"},"content":"On Fri, 09/01 13:28, Amador Pahim wrote:\n> If a VM is launched, files are created and a cleanup is required before\n> a new launch. This cleanup is executed by shutdown(), so shutdown() must\n> be called even if the VM is manually terminated (i.e. using kill).\n> \n> This patch creates a control to make sure launch() will not be executed\n> again if shutdown() is not called after the previous launch().\n> \n> Signed-off-by: Amador Pahim \n> ---\n> scripts/qemu.py | 7 +++++++\n> 1 file changed, 7 insertions(+)\n> \n> diff --git a/scripts/qemu.py b/scripts/qemu.py\n> index 363f649a7e..05fca4d268 100644\n> --- a/scripts/qemu.py\n> +++ b/scripts/qemu.py\n> @@ -52,6 +52,7 @@ class QEMUMachine(object):\n> self._debug = debug\n> self._qemu_full_args = None\n> self._created_files = []\n> + self._pending_shutdown = False\n\nThe name is very poor, it can be confused as \"user requested a shutdown but the\naction is pending for some reason\". Maybe \"self._launched\"?\n\nFam\n\n> \n> # This can be used to add an unused monitor instance.\n> def add_monitor_telnet(self, ip, port):\n> @@ -168,10 +169,14 @@ class QEMUMachine(object):\n> if self.is_running():\n> raise QEMUMachineError('VM already running')\n> \n> + if self._pending_shutdown:\n> + raise QEMUMachineError('Shutdown pending after previous launch')\n> +\n> self._iolog = None\n> self._qemu_full_args = None\n> try:\n> self._launch()\n> + self._pending_shutdown = True\n> except:\n> self.shutdown()\n> \n> @@ -217,6 +222,8 @@ class QEMUMachine(object):\n> command = ''\n> LOG.warn(msg, exitcode, command)\n> \n> + self._pending_shutdown = False\n> +\n> underscore_to_dash = string.maketrans('_', '-')\n> def qmp(self, cmd, conv_keys=True, **args):\n> '''Invoke a QMP command and return the result dict'''\n> -- \n> 2.13.5\n> \n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=famz@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmX9Z0hXCz9sNr\n\tfor ;\n\tTue, 5 Sep 2017 13:23:30 +1000 (AEST)","from localhost ([::1]:56633 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dp4SW-0002CJ-7O\n\tfor incoming@patchwork.ozlabs.org; Mon, 04 Sep 2017 23:23:28 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:33066)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dp4S9-0002By-CY\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 23:23:10 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dp4S4-0003wJ-K5\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 23:23:05 -0400","from mx1.redhat.com ([209.132.183.28]:56504)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dp4S4-0003vo-E7\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 23:23:00 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 7CCC41585FB;\n\tTue, 5 Sep 2017 03:22:59 +0000 (UTC)","from localhost (ovpn-12-97.pek2.redhat.com [10.72.12.97])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id AA7A55D96A;\n\tTue, 5 Sep 2017 03:22:56 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 7CCC41585FB","Date":"Tue, 5 Sep 2017 11:22:55 +0800","From":"Fam Zheng ","To":"Amador Pahim ","Message-ID":"<20170905032255.GQ22515@lemon.lan>","References":"<20170901112829.2571-1-apahim@redhat.com>\n\t<20170901112829.2571-14-apahim@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170901112829.2571-14-apahim@redhat.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tTue, 05 Sep 2017 03:22:59 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v8 13/13] qemu.py: don't launch again\n\tbefore shutdown()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kwolf@redhat.com, ldoktor@redhat.com, ehabkost@redhat.com,\n\tstefanha@gmail.com, qemu-devel@nongnu.org, armbru@redhat.com,\n\tcrosa@redhat.com, mreitz@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]