[{"id":1762932,"web_url":"http://patchwork.ozlabs.org/comment/1762932/","msgid":"<20170905030523.GI22515@lemon.lan>","list_archive_url":null,"date":"2017-09-05T03:05:23","subject":"Re: [Qemu-devel] [PATCH v8 05/13] qemu.py: include debug\n\tinformation on launch error","submitter":{"id":24872,"url":"http://patchwork.ozlabs.org/api/people/24872/","name":"Fam Zheng","email":"famz@redhat.com"},"content":"On Fri, 09/01 13:28, Amador Pahim wrote:\n> When launching a VM, if an exception happens and the VM is not\n> initiated, it might be useful to see the qemu command line and\n> the qemu command output.\n> \n> This patch creates that message. Notice that self._iolog needs to be\n> cleaned up in the beginning of the launch() to make sure we will not\n> expose the qemu log from a previous launch if the current one fails.\n> \n> Signed-off-by: Amador Pahim \n> ---\n> scripts/qemu.py | 7 +++++++\n> 1 file changed, 7 insertions(+)\n> \n> diff --git a/scripts/qemu.py b/scripts/qemu.py\n> index 670c048569..3ebe5ee0a4 100644\n> --- a/scripts/qemu.py\n> +++ b/scripts/qemu.py\n> @@ -141,6 +141,7 @@ class QEMUMachine(object):\n> \n> def launch(self):\n> '''Launch the VM and establish a QMP connection'''\n> + self._iolog = None\n> self._qemu_full_args = None\n> devnull = open(os.path.devnull, 'rb')\n> qemulog = open(self._qemu_log_path, 'wb')\n> @@ -160,6 +161,12 @@ class QEMUMachine(object):\n> self._popen.wait()\n> self._load_io_log()\n> self._post_shutdown()\n> +\n> + LOG.debug('Error launching VM')\n> + if self._qemu_full_args:\n> + LOG.debug('Command: %r', ' '.join(self._qemu_full_args))\n> + if self._iolog:\n> + LOG.debug('Output: %r', self._iolog)\n> raise\n> \n> def shutdown(self):\n> -- \n> 2.13.5\n> \n\nIt would be nice if these messages are added to the exception obj, but it's\nalready an improvement over what we have now, so:\n\nReviewed-by: Fam Zheng ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=famz@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmWnZ5Z5hz9sNc\n\tfor ;\n\tTue, 5 Sep 2017 13:06:10 +1000 (AEST)","from localhost ([::1]:56582 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dp4Bk-0003VS-QG\n\tfor incoming@patchwork.ozlabs.org; Mon, 04 Sep 2017 23:06:08 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:55316)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dp4BB-0003SD-VA\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 23:05:38 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dp4B6-00016M-S9\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 23:05:33 -0400","from mx1.redhat.com ([209.132.183.28]:33436)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dp4B6-00015c-Lt\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 23:05:28 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id B7DF34A6EE;\n\tTue, 5 Sep 2017 03:05:27 +0000 (UTC)","from localhost (ovpn-12-97.pek2.redhat.com [10.72.12.97])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id DAB717F812;\n\tTue, 5 Sep 2017 03:05:24 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com B7DF34A6EE","Date":"Tue, 5 Sep 2017 11:05:23 +0800","From":"Fam Zheng ","To":"Amador Pahim ","Message-ID":"<20170905030523.GI22515@lemon.lan>","References":"<20170901112829.2571-1-apahim@redhat.com>\n\t<20170901112829.2571-6-apahim@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170901112829.2571-6-apahim@redhat.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tTue, 05 Sep 2017 03:05:27 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v8 05/13] qemu.py: include debug\n\tinformation on launch error","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kwolf@redhat.com, ldoktor@redhat.com, ehabkost@redhat.com,\n\tstefanha@gmail.com, qemu-devel@nongnu.org, mreitz@redhat.com,\n\tcrosa@redhat.com, armbru@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]