[{"id":1762933,"web_url":"http://patchwork.ozlabs.org/comment/1762933/","msgid":"<20170905030553.GJ22515@lemon.lan>","list_archive_url":null,"date":"2017-09-05T03:05:53","subject":"Re: [Qemu-devel] [PATCH v8 07/13] qemu.py: close _qemu_log_path on\n\tcleanup","submitter":{"id":24872,"url":"http://patchwork.ozlabs.org/api/people/24872/","name":"Fam Zheng","email":"famz@redhat.com"},"content":"On Fri, 09/01 13:28, Amador Pahim wrote:\n> We are opening the _qemu_log_path during the launch() but we are\n> forgetting to close it.\n> \n> This patch makes sure we will close the self._qemu_log_path during the\n> cleanup (post_shutdown()).\n> \n> Signed-off-by: Amador Pahim \n> ---\n> scripts/qemu.py | 3 +++\n> 1 file changed, 3 insertions(+)\n> \n> diff --git a/scripts/qemu.py b/scripts/qemu.py\n> index c26e1412f9..1b77fec48b 100644\n> --- a/scripts/qemu.py\n> +++ b/scripts/qemu.py\n> @@ -153,6 +153,9 @@ class QEMUMachine(object):\n> self._qmp.accept()\n> \n> def _post_shutdown(self):\n> + if self._qemu_log_fd is not None:\n> + self._qemu_log_fd.close()\n> +\n> while self._created_files:\n> self._remove_if_exists(self._created_files.pop())\n> \n> -- \n> 2.13.5\n> \n\nReviewed-by: Fam Zheng ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=famz@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmWpP0vj1z9sNc\n\tfor ;\n\tTue, 5 Sep 2017 13:06:53 +1000 (AEST)","from localhost ([::1]:56586 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dp4CR-000420-6T\n\tfor incoming@patchwork.ozlabs.org; Mon, 04 Sep 2017 23:06:51 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:55630)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dp4Bf-0003mq-5p\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 23:06:07 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dp4Ba-0001aK-Jc\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 23:06:03 -0400","from mx1.redhat.com ([209.132.183.28]:50676)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dp4Ba-0001Zz-CI\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 23:05:58 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 5ECCE882FF;\n\tTue, 5 Sep 2017 03:05:57 +0000 (UTC)","from localhost (ovpn-12-97.pek2.redhat.com [10.72.12.97])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 9811017D23;\n\tTue, 5 Sep 2017 03:05:54 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 5ECCE882FF","Date":"Tue, 5 Sep 2017 11:05:53 +0800","From":"Fam Zheng ","To":"Amador Pahim ","Message-ID":"<20170905030553.GJ22515@lemon.lan>","References":"<20170901112829.2571-1-apahim@redhat.com>\n\t<20170901112829.2571-8-apahim@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170901112829.2571-8-apahim@redhat.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tTue, 05 Sep 2017 03:05:57 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v8 07/13] qemu.py: close _qemu_log_path on\n\tcleanup","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kwolf@redhat.com, ldoktor@redhat.com, ehabkost@redhat.com,\n\tstefanha@gmail.com, qemu-devel@nongnu.org, mreitz@redhat.com,\n\tcrosa@redhat.com, armbru@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]