[{"id":1761734,"web_url":"http://patchwork.ozlabs.org/comment/1761734/","msgid":"<20170901143016.GK7570@localhost.localdomain>","list_archive_url":null,"date":"2017-09-01T14:30:16","subject":"Re: [Qemu-devel] [PATCH] dma/i82374: avoid double creation of\n\ti82374 device","submitter":{"id":195,"url":"http://patchwork.ozlabs.org/api/people/195/","name":"Eduardo Habkost","email":"ehabkost@redhat.com"},"content":"i82374 is compiled in only on ppc and sh4, so I'm CCing the\nmaintainers for those architectures.\n\nOn Fri, Sep 01, 2017 at 01:03:32PM +0200, Eduardo Otubo wrote:\n> When used with the following command line:\n> \n> ./ppc64-softmmu/qemu-system-ppc64 -S -machine 40p,accel=tcg -device i82374\n> \n> QEMU with machine type 40p already creates the device i82374. If\n> specified in the command line, it will try to create it again, hence\n> generating the error.\n\nWhich error?\n\n\n> One way to avoid this problem is to set\n> user_creatable=false.\n> \n> Signed-off-by: Eduardo Otubo \n\nThe patch does more than just avoiding double creation: it\nprevents usage of \"-device i82374\" completely.\n\nMaybe nobody needs it to work with -device today (would the\ndevice even work?) and it is OK to set user_creatable=false until\nwe fix the crash. But we need to be sure of that.\n\n> ---\n> hw/dma/i82374.c | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/hw/dma/i82374.c b/hw/dma/i82374.c\n> index 6c0f975df0..5275d822e0 100644\n> --- a/hw/dma/i82374.c\n> +++ b/hw/dma/i82374.c\n> @@ -139,6 +139,7 @@ static void i82374_class_init(ObjectClass *klass, void *data)\n> dc->realize = i82374_realize;\n> dc->vmsd = &vmstate_i82374;\n> dc->props = i82374_properties;\n> + dc->user_creatable = false;\n\nA \"Reason:\" comment explaining why user_creatable=false is\nmandatory. See the comment above user_creatable declaration in\nqdev-core.h for reference.\n\nI suggest the following:\n\n /*\n * Reason: i82374_realize() crashes (assertion failure inside isa_bus_dma()\n * if the device is instantiated twice.\n */","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=ehabkost@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkMBP6Vxtz9sPk\n\tfor ;\n\tSat, 2 Sep 2017 00:31:41 +1000 (AEST)","from localhost ([::1]:43763 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnmyy-0003P9-1Y\n\tfor incoming@patchwork.ozlabs.org; Fri, 01 Sep 2017 10:31:40 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:34637)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnmyR-0003OY-J4\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 10:31:12 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnmyN-00036k-Li\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 10:31:07 -0400","from mx1.redhat.com ([209.132.183.28]:45602)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dnmyN-00036R-Fj; Fri, 01 Sep 2017 10:31:03 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 488EA68B3;\n\tFri, 1 Sep 2017 14:31:02 +0000 (UTC)","from localhost (ovpn-116-66.gru2.redhat.com [10.97.116.66])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 9F21378381;\n\tFri, 1 Sep 2017 14:30:18 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 488EA68B3","Date":"Fri, 1 Sep 2017 11:30:16 -0300","From":"Eduardo Habkost ","To":"Eduardo Otubo ","Message-ID":"<20170901143016.GK7570@localhost.localdomain>","References":"<20170901110332.32650-1-otubo@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170901110332.32650-1-otubo@redhat.com>","X-Fnord":"you can see the fnord","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tFri, 01 Sep 2017 14:31:02 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH] dma/i82374: avoid double creation of\n\ti82374 device","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"mst@redhat.com, qemu-trivial@nongnu.org, Alexander Graf , \n\tqemu-devel@nongnu.org, qemu-ppc@nongnu.org, pbonzini@redhat.com,\n\tAurelien Jarno ,\n\tDavid Gibson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1761766,"web_url":"http://patchwork.ozlabs.org/comment/1761766/","msgid":"<87lglyzb3p.fsf@dusky.pond.sub.org>","list_archive_url":null,"date":"2017-09-01T15:34:34","subject":"Re: [Qemu-devel] [PATCH] dma/i82374: avoid double creation of\n\ti82374 device","submitter":{"id":2645,"url":"http://patchwork.ozlabs.org/api/people/2645/","name":"Markus Armbruster","email":"armbru@redhat.com"},"content":"Eduardo Habkost writes:\n\n> i82374 is compiled in only on ppc and sh4, so I'm CCing the\n> maintainers for those architectures.\n>\n> On Fri, Sep 01, 2017 at 01:03:32PM +0200, Eduardo Otubo wrote:\n>> When used with the following command line:\n>> \n>> ./ppc64-softmmu/qemu-system-ppc64 -S -machine 40p,accel=tcg -device i82374\n>> \n>> QEMU with machine type 40p already creates the device i82374. If\n>> specified in the command line, it will try to create it again, hence\n>> generating the error.\n>\n> Which error?\n>\n>\n>> One way to avoid this problem is to set\n>> user_creatable=false.\n>> \n>> Signed-off-by: Eduardo Otubo \n>\n> The patch does more than just avoiding double creation: it\n> prevents usage of \"-device i82374\" completely.\n>\n> Maybe nobody needs it to work with -device today (would the\n> device even work?) and it is OK to set user_creatable=false until\n> we fix the crash. But we need to be sure of that.\n>\n>> ---\n>> hw/dma/i82374.c | 1 +\n>> 1 file changed, 1 insertion(+)\n>> \n>> diff --git a/hw/dma/i82374.c b/hw/dma/i82374.c\n>> index 6c0f975df0..5275d822e0 100644\n>> --- a/hw/dma/i82374.c\n>> +++ b/hw/dma/i82374.c\n>> @@ -139,6 +139,7 @@ static void i82374_class_init(ObjectClass *klass, void *data)\n>> dc->realize = i82374_realize;\n>> dc->vmsd = &vmstate_i82374;\n>> dc->props = i82374_properties;\n>> + dc->user_creatable = false;\n>\n> A \"Reason:\" comment explaining why user_creatable=false is\n> mandatory. See the comment above user_creatable declaration in\n> qdev-core.h for reference.\n>\n> I suggest the following:\n>\n> /*\n> * Reason: i82374_realize() crashes (assertion failure inside isa_bus_dma()\n> * if the device is instantiated twice.\n> */\n\nWe need to find out *why* it crashes. Once we know, we can likely write\na better comment.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=armbru@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkNc72lF1z9t1t\n\tfor ;\n\tSat, 2 Sep 2017 01:35:35 +1000 (AEST)","from localhost ([::1]:46012 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnnyn-0003dA-FS\n\tfor incoming@patchwork.ozlabs.org; Fri, 01 Sep 2017 11:35:33 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:50293)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnny3-0003W2-FG\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 11:34:52 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnny0-0007tg-Ix\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 11:34:47 -0400","from mx1.redhat.com ([209.132.183.28]:40072)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dnny0-0007t8-Dr; Fri, 01 Sep 2017 11:34:44 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 633157EA9F;\n\tFri, 1 Sep 2017 15:34:43 +0000 (UTC)","from blackfin.pond.sub.org (ovpn-116-75.ams2.redhat.com\n\t[10.36.116.75])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 4FC2F78206;\n\tFri, 1 Sep 2017 15:34:36 +0000 (UTC)","by blackfin.pond.sub.org (Postfix, from userid 1000)\n\tid A761A1138662; Fri, 1 Sep 2017 17:34:34 +0200 (CEST)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 633157EA9F","From":"Markus Armbruster ","To":"Eduardo Habkost ","References":"<20170901110332.32650-1-otubo@redhat.com>\n\t<20170901143016.GK7570@localhost.localdomain>","Date":"Fri, 01 Sep 2017 17:34:34 +0200","In-Reply-To":"<20170901143016.GK7570@localhost.localdomain> (Eduardo Habkost's\n\tmessage of \"Fri, 1 Sep 2017 11:30:16 -0300\")","Message-ID":"<87lglyzb3p.fsf@dusky.pond.sub.org>","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)","MIME-Version":"1.0","Content-Type":"text/plain","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tFri, 01 Sep 2017 15:34:43 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH] dma/i82374: avoid double creation of\n\ti82374 device","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Eduardo Otubo , mst@redhat.com, qemu-trivial@nongnu.org,\n\tqemu-devel@nongnu.org, Alexander Graf ,\n\tqemu-ppc@nongnu.org, pbonzini@redhat.com,\n\tAurelien Jarno ,\n\tDavid Gibson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1761781,"web_url":"http://patchwork.ozlabs.org/comment/1761781/","msgid":"<20170901154430.GN7570@localhost.localdomain>","list_archive_url":null,"date":"2017-09-01T15:44:30","subject":"Re: [Qemu-devel] [PATCH] dma/i82374: avoid double creation of\n\ti82374 device","submitter":{"id":195,"url":"http://patchwork.ozlabs.org/api/people/195/","name":"Eduardo Habkost","email":"ehabkost@redhat.com"},"content":"On Fri, Sep 01, 2017 at 05:34:34PM +0200, Markus Armbruster wrote:\n> Eduardo Habkost writes:\n> \n> > i82374 is compiled in only on ppc and sh4, so I'm CCing the\n> > maintainers for those architectures.\n> >\n> > On Fri, Sep 01, 2017 at 01:03:32PM +0200, Eduardo Otubo wrote:\n> >> When used with the following command line:\n> >> \n> >> ./ppc64-softmmu/qemu-system-ppc64 -S -machine 40p,accel=tcg -device i82374\n> >> \n> >> QEMU with machine type 40p already creates the device i82374. If\n> >> specified in the command line, it will try to create it again, hence\n> >> generating the error.\n> >\n> > Which error?\n> >\n> >\n> >> One way to avoid this problem is to set\n> >> user_creatable=false.\n> >> \n> >> Signed-off-by: Eduardo Otubo \n> >\n> > The patch does more than just avoiding double creation: it\n> > prevents usage of \"-device i82374\" completely.\n> >\n> > Maybe nobody needs it to work with -device today (would the\n> > device even work?) and it is OK to set user_creatable=false until\n> > we fix the crash. But we need to be sure of that.\n> >\n> >> ---\n> >> hw/dma/i82374.c | 1 +\n> >> 1 file changed, 1 insertion(+)\n> >> \n> >> diff --git a/hw/dma/i82374.c b/hw/dma/i82374.c\n> >> index 6c0f975df0..5275d822e0 100644\n> >> --- a/hw/dma/i82374.c\n> >> +++ b/hw/dma/i82374.c\n> >> @@ -139,6 +139,7 @@ static void i82374_class_init(ObjectClass *klass, void *data)\n> >> dc->realize = i82374_realize;\n> >> dc->vmsd = &vmstate_i82374;\n> >> dc->props = i82374_properties;\n> >> + dc->user_creatable = false;\n> >\n> > A \"Reason:\" comment explaining why user_creatable=false is\n> > mandatory. See the comment above user_creatable declaration in\n> > qdev-core.h for reference.\n> >\n> > I suggest the following:\n> >\n> > /*\n> > * Reason: i82374_realize() crashes (assertion failure inside isa_bus_dma()\n> > * if the device is instantiated twice.\n> > */\n> \n> We need to find out *why* it crashes. Once we know, we can likely write\n> a better comment.\n\nIt crashes because isa_bus_dma() isn't supposed to be called\ntwice for the same bus.\n\nMaking isa_bus_dma()/DMA_init()/i82374_realize() return an error\ninstead of asserting would be even better than setting\nuser_creatable=false.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=ehabkost@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkPCG0tcvz9s2G\n\tfor ;\n\tSat, 2 Sep 2017 02:02:34 +1000 (AEST)","from localhost ([::1]:46651 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnoOu-00067u-3P\n\tfor incoming@patchwork.ozlabs.org; Fri, 01 Sep 2017 12:02:32 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:53996)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dno7d-00060C-8y\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 11:44:42 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dno7a-0004BU-5w\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 11:44:41 -0400","from mx1.redhat.com ([209.132.183.28]:53142)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dno7Z-0004Ar-TI; Fri, 01 Sep 2017 11:44:38 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id C30D41F574;\n\tFri, 1 Sep 2017 15:44:36 +0000 (UTC)","from localhost (ovpn-116-66.gru2.redhat.com [10.97.116.66])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 9ADCD9568A;\n\tFri, 1 Sep 2017 15:44:32 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com C30D41F574","Date":"Fri, 1 Sep 2017 12:44:30 -0300","From":"Eduardo Habkost ","To":"Markus Armbruster ","Message-ID":"<20170901154430.GN7570@localhost.localdomain>","References":"<20170901110332.32650-1-otubo@redhat.com>\n\t<20170901143016.GK7570@localhost.localdomain>\n\t<87lglyzb3p.fsf@dusky.pond.sub.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<87lglyzb3p.fsf@dusky.pond.sub.org>","X-Fnord":"you can see the fnord","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tFri, 01 Sep 2017 15:44:36 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH] dma/i82374: avoid double creation of\n\ti82374 device","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Eduardo Otubo , mst@redhat.com, qemu-trivial@nongnu.org,\n\tqemu-devel@nongnu.org, Alexander Graf ,\n\tqemu-ppc@nongnu.org, pbonzini@redhat.com,\n\tAurelien Jarno ,\n\tDavid Gibson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1762098,"web_url":"http://patchwork.ozlabs.org/comment/1762098/","msgid":"<20170902091520.bxecfhisvy46o4cb@aurel32.net>","list_archive_url":null,"date":"2017-09-02T09:15:20","subject":"Re: [Qemu-devel] [PATCH] dma/i82374: avoid double creation of\n\ti82374 device","submitter":{"id":2775,"url":"http://patchwork.ozlabs.org/api/people/2775/","name":"Aurelien Jarno","email":"aurelien@aurel32.net"},"content":"On 2017-09-01 11:30, Eduardo Habkost wrote:\n> i82374 is compiled in only on ppc and sh4, so I'm CCing the\n> maintainers for those architectures.\n\nThe i82374 device is not useful nor usable on SH4. It has just been\nadded in commit 85d3846a39 to be able to run the tests.\n\nAurelien","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkr8M6DD2z9s75\n\tfor ;\n\tSat, 2 Sep 2017 19:16:32 +1000 (AEST)","from localhost ([::1]:58782 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1do4XU-0007fz-4t\n\tfor incoming@patchwork.ozlabs.org; Sat, 02 Sep 2017 05:16:28 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:47932)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1do4Wq-0007d1-6z\n\tfor qemu-devel@nongnu.org; Sat, 02 Sep 2017 05:15:52 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1do4Wl-0005Fw-CE\n\tfor qemu-devel@nongnu.org; Sat, 02 Sep 2017 05:15:48 -0400","from hall.aurel32.net ([2001:bc8:30d7:100::1]:35460)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1do4Wk-00055u-TD; Sat, 02 Sep 2017 05:15:43 -0400","from [2001:bc8:30d7:120:9bb5:8936:7e6a:9e36] (helo=ohm.rr44.fr)\n\tby hall.aurel32.net with esmtpsa\n\t(TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89)\n\t(envelope-from )\n\tid 1do4WP-0003lS-Mb; Sat, 02 Sep 2017 11:15:21 +0200","from aurel32 by ohm.rr44.fr with local (Exim 4.89)\n\t(envelope-from )\n\tid 1do4WO-00041G-QD; Sat, 02 Sep 2017 11:15:20 +0200"],"Date":"Sat, 2 Sep 2017 11:15:20 +0200","From":"Aurelien Jarno ","To":"Eduardo Habkost ","Message-ID":"<20170902091520.bxecfhisvy46o4cb@aurel32.net>","References":"<20170901110332.32650-1-otubo@redhat.com>\n\t<20170901143016.GK7570@localhost.localdomain>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170901143016.GK7570@localhost.localdomain>","User-Agent":"NeoMutt/20170609 (1.8.3)","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2001:bc8:30d7:100::1","Subject":"Re: [Qemu-devel] [PATCH] dma/i82374: avoid double creation of\n\ti82374 device","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Eduardo Otubo , mst@redhat.com, qemu-trivial@nongnu.org,\n\tqemu-devel@nongnu.org, Alexander Graf ,\n\tqemu-ppc@nongnu.org, pbonzini@redhat.com,\n\tDavid Gibson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1764588,"web_url":"http://patchwork.ozlabs.org/comment/1764588/","msgid":"<20170907083829.GB2441@vader>","list_archive_url":null,"date":"2017-09-07T08:38:29","subject":"Re: [Qemu-devel] [Qemu-trivial] [PATCH] dma/i82374: avoid double\n\tcreation of i82374 device","submitter":{"id":71779,"url":"http://patchwork.ozlabs.org/api/people/71779/","name":"Eduardo Otubo","email":"otubo@redhat.com"},"content":"On Fri, Sep 01, 2017 at 12:44:30PM -0300, Eduardo Habkost wrote:\n> On Fri, Sep 01, 2017 at 05:34:34PM +0200, Markus Armbruster wrote:\n> > Eduardo Habkost writes:\n> > \n> > > i82374 is compiled in only on ppc and sh4, so I'm CCing the\n> > > maintainers for those architectures.\n> > >\n> > > On Fri, Sep 01, 2017 at 01:03:32PM +0200, Eduardo Otubo wrote:\n> > >> When used with the following command line:\n> > >> \n> > >> ./ppc64-softmmu/qemu-system-ppc64 -S -machine 40p,accel=tcg -device i82374\n> > >> \n> > >> QEMU with machine type 40p already creates the device i82374. If\n> > >> specified in the command line, it will try to create it again, hence\n> > >> generating the error.\n\nWell pointed, forgot to describe the actual error. I may inlcude for\nthe next version of the patch. For for correctness sake, here it is:\n\n ./ppc64-softmmu/qemu-system-ppc64 -S -machine 40p,accel=tcg -device i82374\n qemu-system-ppc64: hw/isa/isa-bus.c:110: isa_bus_dma: Assertion `!bus->dma[0] && !bus->dma[1]' failed.\n Aborted (core dumped)\n\n> > >\n> > > Which error?\n> > >\n> > >\n> > >> One way to avoid this problem is to set\n> > >> user_creatable=false.\n> > >> \n> > >> Signed-off-by: Eduardo Otubo \n> > >\n> > > The patch does more than just avoiding double creation: it\n> > > prevents usage of \"-device i82374\" completely.\n> > >\n> > > Maybe nobody needs it to work with -device today (would the\n> > > device even work?) and it is OK to set user_creatable=false until\n> > > we fix the crash. But we need to be sure of that.\n> > >\n> > >> ---\n> > >> hw/dma/i82374.c | 1 +\n> > >> 1 file changed, 1 insertion(+)\n> > >> \n> > >> diff --git a/hw/dma/i82374.c b/hw/dma/i82374.c\n> > >> index 6c0f975df0..5275d822e0 100644\n> > >> --- a/hw/dma/i82374.c\n> > >> +++ b/hw/dma/i82374.c\n> > >> @@ -139,6 +139,7 @@ static void i82374_class_init(ObjectClass *klass, void *data)\n> > >> dc->realize = i82374_realize;\n> > >> dc->vmsd = &vmstate_i82374;\n> > >> dc->props = i82374_properties;\n> > >> + dc->user_creatable = false;\n> > >\n> > > A \"Reason:\" comment explaining why user_creatable=false is\n> > > mandatory. See the comment above user_creatable declaration in\n> > > qdev-core.h for reference.\n> > >\n> > > I suggest the following:\n> > >\n> > > /*\n> > > * Reason: i82374_realize() crashes (assertion failure inside isa_bus_dma()\n> > > * if the device is instantiated twice.\n> > > */\n\nI agree with the comment above. If there's nothing left to fix/add\nI'll just send a v2 for this shortly.\n\n> > \n> > We need to find out *why* it crashes. Once we know, we can likely write\n> > a better comment.\n> \n> It crashes because isa_bus_dma() isn't supposed to be called\n> twice for the same bus.\n> \n> Making isa_bus_dma()/DMA_init()/i82374_realize() return an error\n> instead of asserting would be even better than setting\n> user_creatable=false.\n> \n> -- \n> Eduardo\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=otubo@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnv580phRz9sRV\n\tfor ;\n\tThu, 7 Sep 2017 18:39:24 +1000 (AEST)","from localhost ([::1]:39315 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpsLK-0005JR-5y\n\tfor incoming@patchwork.ozlabs.org; Thu, 07 Sep 2017 04:39:22 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:39634)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpsKi-0005HQ-KW\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 04:38:45 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpsKd-0006Cu-LN\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 04:38:44 -0400","from mx1.redhat.com ([209.132.183.28]:32892)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dpsKd-0006Ch-CN; Thu, 07 Sep 2017 04:38:39 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 44FA1C0587E5;\n\tThu, 7 Sep 2017 08:38:38 +0000 (UTC)","from vader (ovpn-117-116.ams2.redhat.com [10.36.117.116])\n\tby smtp.corp.redhat.com (Postfix) with SMTP id 60D8360603;\n\tThu, 7 Sep 2017 08:38:30 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 44FA1C0587E5","Date":"Thu, 7 Sep 2017 10:38:29 +0200","From":"Eduardo Otubo ","To":"Eduardo Habkost ","Message-ID":"<20170907083829.GB2441@vader>","References":"<20170901110332.32650-1-otubo@redhat.com>\n\t<20170901143016.GK7570@localhost.localdomain>\n\t<87lglyzb3p.fsf@dusky.pond.sub.org>\n\t<20170901154430.GN7570@localhost.localdomain>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20170901154430.GN7570@localhost.localdomain>","User-Agent":"Mutt/1.8.3+47 (5f034395e53d) (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]);\n\tThu, 07 Sep 2017 08:38:38 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [Qemu-trivial] [PATCH] dma/i82374: avoid double\n\tcreation of i82374 device","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"mst@redhat.com, qemu-trivial@nongnu.org,\n\tMarkus Armbruster ,\n\tAlexander Graf , qemu-devel@nongnu.org,\n\tqemu-ppc@nongnu.org, pbonzini@redhat.com,\n\tDavid Gibson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1764589,"web_url":"http://patchwork.ozlabs.org/comment/1764589/","msgid":"<20170907083855.GC2441@vader>","list_archive_url":null,"date":"2017-09-07T08:38:55","subject":"Re: [Qemu-devel] [Qemu-trivial] [PATCH] dma/i82374: avoid double\n\tcreation of i82374 device","submitter":{"id":71779,"url":"http://patchwork.ozlabs.org/api/people/71779/","name":"Eduardo Otubo","email":"otubo@redhat.com"},"content":"On Sat, Sep 02, 2017 at 11:15:20AM +0200, Aurelien Jarno wrote:\n> On 2017-09-01 11:30, Eduardo Habkost wrote:\n> > i82374 is compiled in only on ppc and sh4, so I'm CCing the\n> > maintainers for those architectures.\n> \n> The i82374 device is not useful nor usable on SH4. It has just been\n> added in commit 85d3846a39 to be able to run the tests.\n> \n> Aurelien\n> \n\nAny word from the ppc guys?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=otubo@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnv805LFNz9sRY\n\tfor ;\n\tThu, 7 Sep 2017 18:41:52 +1000 (AEST)","from localhost ([::1]:39330 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpsNi-0007Aq-PW\n\tfor incoming@patchwork.ozlabs.org; Thu, 07 Sep 2017 04:41:50 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:39852)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpsL6-0005au-Md\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 04:39:09 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpsL2-0006ML-8t\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 04:39:08 -0400","from mx1.redhat.com ([209.132.183.28]:35534)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dpsL2-0006Lw-3j; Thu, 07 Sep 2017 04:39:04 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id C5C73C04B924;\n\tThu, 7 Sep 2017 08:39:02 +0000 (UTC)","from vader (ovpn-117-116.ams2.redhat.com [10.36.117.116])\n\tby smtp.corp.redhat.com (Postfix) with SMTP id A982E60603;\n\tThu, 7 Sep 2017 08:38:56 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com C5C73C04B924","Date":"Thu, 7 Sep 2017 10:38:55 +0200","From":"Eduardo Otubo ","To":"Aurelien Jarno ","Message-ID":"<20170907083855.GC2441@vader>","References":"<20170901110332.32650-1-otubo@redhat.com>\n\t<20170901143016.GK7570@localhost.localdomain>\n\t<20170902091520.bxecfhisvy46o4cb@aurel32.net>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20170902091520.bxecfhisvy46o4cb@aurel32.net>","User-Agent":"Mutt/1.8.3+47 (5f034395e53d) (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tThu, 07 Sep 2017 08:39:03 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [Qemu-trivial] [PATCH] dma/i82374: avoid double\n\tcreation of i82374 device","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Eduardo Habkost , mst@redhat.com,\n\tqemu-trivial@nongnu.org, Alexander Graf ,\n\tqemu-devel@nongnu.org, qemu-ppc@nongnu.org, pbonzini@redhat.com,\n\tDavid Gibson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1764800,"web_url":"http://patchwork.ozlabs.org/comment/1764800/","msgid":"","list_archive_url":null,"date":"2017-09-07T16:05:37","subject":"Re: [Qemu-devel] [PATCH] dma/i82374: avoid double creation of\n\ti82374 device","submitter":{"id":2701,"url":"http://patchwork.ozlabs.org/api/people/2701/","name":"Paolo Bonzini","email":"pbonzini@redhat.com"},"content":"Il 02 set 2017 11:17 AM, \"Aurelien Jarno\" ha scritto:\n\nOn 2017-09-01 11:30, Eduardo Habkost wrote:\n> i82374 is compiled in only on ppc and sh4, so I'm CCing the\n> maintainers for those architectures.\n\nThe i82374 device is not useful nor usable on SH4. It has just been\nadded in commit 85d3846a39 to be able to run the tests.\n\n\nBut that means that the patch is wrong and probably was not tested with\n\"make check\".\n\nEduardo's proposal is the right one.\n\nPaolo\n\n\nAurelien\n\n--\nAurelien Jarno GPG: 4096R/1DDD8C9B\naurelien@aurel32.net http://www.aurel32.net","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xp53928b8z9s78\n\tfor ;\n\tFri, 8 Sep 2017 02:08:21 +1000 (AEST)","from localhost ([::1]:41201 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpzLn-0001ET-9X\n\tfor incoming@patchwork.ozlabs.org; Thu, 07 Sep 2017 12:08:19 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:41556)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpzJJ-00081l-MH\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 12:05:50 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpzJE-00070s-OH\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 12:05:45 -0400","from mail-oi0-f41.google.com ([209.85.218.41]:33339)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from ) id 1dpzJE-000709-HS\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 12:05:40 -0400","by mail-oi0-f41.google.com with SMTP id r20so883138oie.0\n\tfor ; Thu, 07 Sep 2017 09:05:39 -0700 (PDT)","by 10.157.56.185 with HTTP; Thu, 7 Sep 2017 09:05:37 -0700 (PDT)","by 10.157.56.185 with HTTP; Thu, 7 Sep 2017 09:05:37 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=QHcktpQBahhrzWz3N4CmmoK1scMk9yDRMXW15ZzpfIY=;\n\tb=YBlvXVMZgc9emmWf10kP1aTY9clVOTkxxbwlbvHx6myTyrijJjJ+GczgdGryptYvb9\n\tomS07N9KhyLtwsom1nQ6/DchOJOQCkE3EBeqF64zYoI93RzH0tj1RqYqFcTup/93uOUn\n\tffGIRwM3PIWE1fIOo4dByFyOS3hxImSBhoC/VRgKKk8a8xZ5WfZKo+yJAskePFu1z6sy\n\tBQ/4hr/rpi8gOVSaCZO5G9VEVhBmQ+TKv5QRwogf6Zy39w11/pfvhJ9FVxRvurnm26Ng\n\tkwATQMUyXNbqR0XZ0JAGOIIJuyhi5YLdPosStZnoLhq2trXFLMTbKsPExBskupg4nDQf\n\td/xw==","X-Gm-Message-State":"AHPjjUhwNEqcHqOVFiI2szoeQ1u+FkQyrNba5whJYVi167N/diJd2Pta\n\t62MXGUVwUHDQK+LrjPyU+P0XecYiAVxi","X-Google-Smtp-Source":"ADKCNb6XAj+ohk6/Rnc8eVObkNOOTcFfe+y2VgEDPlOpKqJgPWLCDxtIP42MVhO68WNT8IjnDuNQyS3b2lp3wCE5efY=","X-Received":"by 10.202.82.4 with SMTP id g4mr3672983oib.154.1504800338681;\n\tThu, 07 Sep 2017 09:05:38 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170902091520.bxecfhisvy46o4cb@aurel32.net>","References":"<20170901110332.32650-1-otubo@redhat.com>\n\t<20170901143016.GK7570@localhost.localdomain>\n\t<20170902091520.bxecfhisvy46o4cb@aurel32.net>","From":"Paolo Bonzini ","Date":"Thu, 7 Sep 2017 18:05:37 +0200","Message-ID":"","To":"\"Jarno, Aurelien\" ","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.85.218.41","Content-Type":"text/plain; charset=\"UTF-8\"","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH] dma/i82374: avoid double creation of\n\ti82374 device","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Eduardo Otubo , Eduardo Habkost , \n\tmst@redhat.com, qemu-trivial@nongnu.org, Alexander Graf , \n\tqemu-devel , qemu-ppc@nongnu.org, \"Gibson,\n\tDavid\" ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1765143,"web_url":"http://patchwork.ozlabs.org/comment/1765143/","msgid":"<20170908075705.GA16888@vader>","list_archive_url":null,"date":"2017-09-08T07:57:05","subject":"Re: [Qemu-devel] [Qemu-trivial] [PATCH] dma/i82374: avoid double\n\tcreation of i82374 device","submitter":{"id":71779,"url":"http://patchwork.ozlabs.org/api/people/71779/","name":"Eduardo Otubo","email":"otubo@redhat.com"},"content":"On Thu, Sep 07, 2017 at 06:05:37PM +0200, Paolo Bonzini wrote:\n> Il 02 set 2017 11:17 AM, \"Aurelien Jarno\" ha scritto:\n> \n> On 2017-09-01 11:30, Eduardo Habkost wrote:\n> > i82374 is compiled in only on ppc and sh4, so I'm CCing the\n> > maintainers for those architectures.\n> \n> The i82374 device is not useful nor usable on SH4. It has just been\n> added in commit 85d3846a39 to be able to run the tests.\n> \n> \n> But that means that the patch is wrong and probably was not tested with\n> \"make check\".\n> \n> Eduardo's proposal is the right one.\n> \n\nGreat, I'll just add the missing details and resend the v2. Thanks for\nthe review.\n\nRegards,","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=otubo@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpV6q6Btlz9s75\n\tfor ;\n\tFri, 8 Sep 2017 17:57:52 +1000 (AEST)","from localhost ([::1]:43772 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dqEAf-0005hU-IV\n\tfor incoming@patchwork.ozlabs.org; Fri, 08 Sep 2017 03:57:49 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:46280)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dqEAB-0005fV-FN\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 03:57:24 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dqEA6-000814-VD\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 03:57:19 -0400","from mx1.redhat.com ([209.132.183.28]:52092)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dqEA6-00080S-Oc; Fri, 08 Sep 2017 03:57:14 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 56B3F80461;\n\tFri, 8 Sep 2017 07:57:13 +0000 (UTC)","from vader (ovpn-117-133.ams2.redhat.com [10.36.117.133])\n\tby smtp.corp.redhat.com (Postfix) with SMTP id 2631980A9C;\n\tFri, 8 Sep 2017 07:57:05 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 56B3F80461","Date":"Fri, 8 Sep 2017 09:57:05 +0200","From":"Eduardo Otubo ","To":"Paolo Bonzini ","Message-ID":"<20170908075705.GA16888@vader>","References":"<20170901110332.32650-1-otubo@redhat.com>\n\t<20170901143016.GK7570@localhost.localdomain>\n\t<20170902091520.bxecfhisvy46o4cb@aurel32.net>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.8.3+47 (5f034395e53d) (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tFri, 08 Sep 2017 07:57:13 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [Qemu-trivial] [PATCH] dma/i82374: avoid double\n\tcreation of i82374 device","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Eduardo Habkost , mst@redhat.com,\n\tqemu-trivial@nongnu.org, Alexander Graf ,\n\tqemu-devel , qemu-ppc@nongnu.org, \"Jarno,\n\tAurelien\" , \"Gibson,\n\tDavid\" ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1765875,"web_url":"http://patchwork.ozlabs.org/comment/1765875/","msgid":"<20170909215243.GK7570@localhost.localdomain>","list_archive_url":null,"date":"2017-09-09T21:52:43","subject":"Re: [Qemu-devel] [Qemu-trivial] [PATCH] dma/i82374: avoid double\n\tcreation of i82374 device","submitter":{"id":195,"url":"http://patchwork.ozlabs.org/api/people/195/","name":"Eduardo Habkost","email":"ehabkost@redhat.com"},"content":"On Thu, Sep 07, 2017 at 10:38:29AM +0200, Eduardo Otubo wrote:\n> On Fri, Sep 01, 2017 at 12:44:30PM -0300, Eduardo Habkost wrote:\n> > On Fri, Sep 01, 2017 at 05:34:34PM +0200, Markus Armbruster wrote:\n> > > Eduardo Habkost writes:\n> > > > On Fri, Sep 01, 2017 at 01:03:32PM +0200, Eduardo Otubo wrote:\n[...]\n> > > >> diff --git a/hw/dma/i82374.c b/hw/dma/i82374.c\n> > > >> index 6c0f975df0..5275d822e0 100644\n> > > >> --- a/hw/dma/i82374.c\n> > > >> +++ b/hw/dma/i82374.c\n> > > >> @@ -139,6 +139,7 @@ static void i82374_class_init(ObjectClass *klass, void *data)\n> > > >> dc->realize = i82374_realize;\n> > > >> dc->vmsd = &vmstate_i82374;\n> > > >> dc->props = i82374_properties;\n> > > >> + dc->user_creatable = false;\n> > > >\n> > > > A \"Reason:\" comment explaining why user_creatable=false is\n> > > > mandatory. See the comment above user_creatable declaration in\n> > > > qdev-core.h for reference.\n> > > >\n> > > > I suggest the following:\n> > > >\n> > > > /*\n> > > > * Reason: i82374_realize() crashes (assertion failure inside isa_bus_dma()\n> > > > * if the device is instantiated twice.\n> > > > */\n> \n> I agree with the comment above. If there's nothing left to fix/add\n> I'll just send a v2 for this shortly.\n\nI suggest amending it with the additional info below, explaining\nthat isa_bus_dma() isn't supposed to be called twice, and that we\nneed to make isa_bus_dma()/DMA_init()/i82374_realize() return an\nappropriate error if the device is instantiated twice.\n\n\n> \n> > > \n> > > We need to find out *why* it crashes. Once we know, we can likely write\n> > > a better comment.\n> > \n> > It crashes because isa_bus_dma() isn't supposed to be called\n> > twice for the same bus.\n> > \n> > Making isa_bus_dma()/DMA_init()/i82374_realize() return an error\n> > instead of asserting would be even better than setting\n> > user_creatable=false.\n> > \n> > -- \n> > Eduardo\n> > \n> \n> -- \n> Eduardo Otubo\n> Senior Software Engineer @ RedHat","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=ehabkost@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xqScY325sz9sPk\n\tfor ;\n\tSun, 10 Sep 2017 07:53:31 +1000 (AEST)","from localhost ([::1]:50977 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dqngu-0008DC-CP\n\tfor incoming@patchwork.ozlabs.org; Sat, 09 Sep 2017 17:53:28 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:58549)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dqngP-0008Ci-6q\n\tfor qemu-devel@nongnu.org; Sat, 09 Sep 2017 17:52:58 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dqngK-000093-BO\n\tfor qemu-devel@nongnu.org; Sat, 09 Sep 2017 17:52:57 -0400","from mx1.redhat.com ([209.132.183.28]:59518)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dqngK-00008i-4s; Sat, 09 Sep 2017 17:52:52 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id E87474DD4B;\n\tSat, 9 Sep 2017 21:52:49 +0000 (UTC)","from localhost (ovpn-116-45.gru2.redhat.com [10.97.116.45])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 36F4E5C552;\n\tSat, 9 Sep 2017 21:52:45 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com E87474DD4B","Date":"Sat, 9 Sep 2017 18:52:43 -0300","From":"Eduardo Habkost ","To":"Eduardo Otubo ","Message-ID":"<20170909215243.GK7570@localhost.localdomain>","References":"<20170901110332.32650-1-otubo@redhat.com>\n\t<20170901143016.GK7570@localhost.localdomain>\n\t<87lglyzb3p.fsf@dusky.pond.sub.org>\n\t<20170901154430.GN7570@localhost.localdomain>\n\t<20170907083829.GB2441@vader>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170907083829.GB2441@vader>","X-Fnord":"you can see the fnord","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tSat, 09 Sep 2017 21:52:51 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [Qemu-trivial] [PATCH] dma/i82374: avoid double\n\tcreation of i82374 device","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"mst@redhat.com, qemu-trivial@nongnu.org,\n\tMarkus Armbruster ,\n\tAlexander Graf , qemu-devel@nongnu.org,\n\tqemu-ppc@nongnu.org, pbonzini@redhat.com,\n\tDavid Gibson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]