[{"id":1761592,"web_url":"http://patchwork.ozlabs.org/comment/1761592/","msgid":"<20170901110422.GJ31680@redhat.com>","list_archive_url":null,"date":"2017-09-01T11:04:22","subject":"Re: [Qemu-devel] [PATCHv4 1/6] seccomp: changing from whitelist to\n\tblacklist","submitter":{"id":2694,"url":"http://patchwork.ozlabs.org/api/people/2694/","name":"Daniel P. Berrangé","email":"berrange@redhat.com"},"content":"On Fri, Sep 01, 2017 at 12:58:13PM +0200, Eduardo Otubo wrote:\n> This patch changes the default behavior of the seccomp filter from\n> whitelist to blacklist. By default now all system calls are allowed and\n> a small black list of definitely forbidden ones was created.\n> \n> Signed-off-by: Eduardo Otubo \n> ---\n> include/sysemu/seccomp.h | 2 +\n> qemu-seccomp.c | 264 ++++++-----------------------------------------\n> vl.c | 1 -\n> 3 files changed, 35 insertions(+), 232 deletions(-)\n> \n> diff --git a/include/sysemu/seccomp.h b/include/sysemu/seccomp.h\n> index cfc06008cb..23b9c3c789 100644\n> --- a/include/sysemu/seccomp.h\n> +++ b/include/sysemu/seccomp.h\n\n> + for (i = 0; i < ARRAY_SIZE(blacklist); i++) {\n> + switch (blacklist[i].set) {\n> + default:\n> + goto add_syscall;\n\nThis goto rule is pointless - just use 'break'\n\n> }\n> - rc = seccomp_syscall_priority(ctx, seccomp_whitelist[i].num,\n> - seccomp_whitelist[i].priority);\n> +add_syscall:\n> + rc = seccomp_rule_add(ctx, SCMP_ACT_KILL, blacklist[i].num, 0);\n> if (rc < 0) {\n> goto seccomp_return;\n> }\n\nRegards,\nDaniel","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=berrange@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkGfb1pLvz9s7p\n\tfor ;\n\tFri, 1 Sep 2017 21:07:19 +1000 (AEST)","from localhost ([::1]:35371 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnjnB-0007Eh-9L\n\tfor incoming@patchwork.ozlabs.org; Fri, 01 Sep 2017 07:07:17 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:53428)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnjkb-0005P3-I2\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 07:04:43 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnjkV-0003X2-Kv\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 07:04:37 -0400","from mx1.redhat.com ([209.132.183.28]:35834)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dnjkV-0003Wo-FA\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 07:04:31 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 8E538267DF\n\tfor ; Fri, 1 Sep 2017 11:04:30 +0000 (UTC)","from redhat.com (unknown [10.42.22.189])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id A624D9340D;\n\tFri, 1 Sep 2017 11:04:24 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 8E538267DF","Date":"Fri, 1 Sep 2017 12:04:22 +0100","From":"\"Daniel P. Berrange\" ","To":"Eduardo Otubo ","Message-ID":"<20170901110422.GJ31680@redhat.com>","References":"<20170901105818.31956-1-otubo@redhat.com>\n\t<20170901105818.31956-2-otubo@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20170901105818.31956-2-otubo@redhat.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tFri, 01 Sep 2017 11:04:30 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCHv4 1/6] seccomp: changing from whitelist to\n\tblacklist","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"\"Daniel P. Berrange\" ","Cc":"thuth@redhat.com, qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]