[{"id":1761727,"web_url":"http://patchwork.ozlabs.org/comment/1761727/","msgid":"<34c1bda5-90bb-a79a-8cf3-c680ea05ed6c@redhat.com>","list_archive_url":null,"date":"2017-09-01T14:25:04","subject":"Re: [Qemu-devel] [PATCH 2/2] iotests: blacklist 194 with the luks\n\tdriver","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 09/01/2017 05:54 AM, Daniel P. Berrange wrote:\n> The 194 test has alot of code that assumes a simple image file. Rewriting\n\ns/alot/a lot/\n\n> this to work with luks is possible, but non-trivial, so blacklist the\n> luks format for now.\n> \n> Signed-off-by: Daniel P. Berrange \n> ---\n> tests/qemu-iotests/194 | 1 +\n> tests/qemu-iotests/iotests.py | 4 +++-\n> 2 files changed, 4 insertions(+), 1 deletion(-)\n\nReviewed-by: Eric Blake ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkM3d2SFzz9sPk\n\tfor ;\n\tSat, 2 Sep 2017 00:25:49 +1000 (AEST)","from localhost ([::1]:43553 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnmtH-0000IE-GU\n\tfor incoming@patchwork.ozlabs.org; Fri, 01 Sep 2017 10:25:47 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:33447)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnmst-0000BX-9G\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 10:25:28 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnmso-0000sD-FR\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 10:25:23 -0400","from mx1.redhat.com ([209.132.183.28]:34868)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dnmsi-0000qE-4b; Fri, 01 Sep 2017 10:25:12 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 3C61B7E455;\n\tFri, 1 Sep 2017 14:25:11 +0000 (UTC)","from [10.10.121.149] (ovpn-121-149.rdu2.redhat.com [10.10.121.149])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 930FD81F9F;\n\tFri, 1 Sep 2017 14:25:05 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 3C61B7E455","To":"\"Daniel P. Berrange\" , qemu-devel@nongnu.org","References":"<20170901105434.3288-1-berrange@redhat.com>\n\t<20170901105434.3288-3-berrange@redhat.com>","From":"Eric Blake ","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"<34c1bda5-90bb-a79a-8cf3-c680ea05ed6c@redhat.com>","Date":"Fri, 1 Sep 2017 09:25:04 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170901105434.3288-3-berrange@redhat.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"2Oxkn1uxG2drr2qrS3FmwdSXX3FQXWluE\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tFri, 01 Sep 2017 14:25:11 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH 2/2] iotests: blacklist 194 with the luks\n\tdriver","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Kevin Wolf , Fam Zheng ,\n\tStefan Hajnoczi , qemu-block@nongnu.org,\n\tMax Reitz ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1762529,"web_url":"http://patchwork.ozlabs.org/comment/1762529/","msgid":"<20170904091415.wgsuqx67y3il7hnd@eukaryote>","list_archive_url":null,"date":"2017-09-04T09:14:15","subject":"Re: [Qemu-devel] [Qemu-block] [PATCH 2/2] iotests: blacklist 194\n\twith the luks driver","submitter":{"id":65934,"url":"http://patchwork.ozlabs.org/api/people/65934/","name":"Kashyap Chamarthy","email":"kchamart@redhat.com"},"content":"On Fri, Sep 01, 2017 at 11:54:34AM +0100, Daniel P. Berrange wrote:\n> The 194 test has alot of code that assumes a simple image file. Rewriting\n> this to work with luks is possible, but non-trivial, so blacklist the\n> luks format for now.\n> \n> Signed-off-by: Daniel P. Berrange \n> ---\n> tests/qemu-iotests/194 | 1 +\n> tests/qemu-iotests/iotests.py | 4 +++-\n> 2 files changed, 4 insertions(+), 1 deletion(-)\n\nReviewed-by: Kashyap Chamarthy \n\n> diff --git a/tests/qemu-iotests/194 b/tests/qemu-iotests/194\n> index a3e3bad664..bfe1859ecf 100755\n> --- a/tests/qemu-iotests/194\n> +++ b/tests/qemu-iotests/194\n> @@ -23,6 +23,7 @@ import os\n> import atexit\n> import iotests\n> \n> +iotests.verify_image_format(unsupported_fmts=['luks'])\n> iotests.verify_platform(['linux'])\n> \n> img_size = '1G'\n> diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py\n> index 7233983f3c..3e7304b678 100644\n> --- a/tests/qemu-iotests/iotests.py\n> +++ b/tests/qemu-iotests/iotests.py\n> @@ -395,9 +395,11 @@ def notrun(reason):\n> print '%s not run: %s' % (seq, reason)\n> sys.exit(0)\n> \n> -def verify_image_format(supported_fmts=[]):\n> +def verify_image_format(supported_fmts=[], unsupported_fmts=[]):\n> if supported_fmts and (imgfmt not in supported_fmts):\n> notrun('not suitable for this image format: %s' % imgfmt)\n> + if unsupported_fmts and (imgfmt in unsupported_fmts):\n> + notrun('not suitable for this image format: %s' % imgfmt)\n> \n> def verify_platform(supported_oses=['linux']):\n> if True not in [sys.platform.startswith(x) for x in supported_oses]:\n> -- \n> 2.13.5\n> \n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=kchamart@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xm41k5pSRz9s72\n\tfor ;\n\tMon, 4 Sep 2017 19:15:01 +1000 (AEST)","from localhost ([::1]:45860 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1donT8-00008G-M4\n\tfor incoming@patchwork.ozlabs.org; Mon, 04 Sep 2017 05:14:58 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:34383)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1donSi-00006S-HE\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 05:14:33 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1donSh-0001q2-M8\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 05:14:32 -0400","from mx1.redhat.com ([209.132.183.28]:34658)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1donSb-0001iU-FO; Mon, 04 Sep 2017 05:14:25 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 0150B5F7B9;\n\tMon, 4 Sep 2017 09:14:23 +0000 (UTC)","from eukaryote.localdomain (ovpn-117-212.ams2.redhat.com\n\t[10.36.117.212])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 2B70A18227;\n\tMon, 4 Sep 2017 09:14:18 +0000 (UTC)","by eukaryote.localdomain (Postfix, from userid 1000)\n\tid E567E240DE8; Mon, 4 Sep 2017 11:14:15 +0200 (CEST)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 0150B5F7B9","Date":"Mon, 4 Sep 2017 11:14:15 +0200","From":"Kashyap Chamarthy ","To":"\"Daniel P. Berrange\" ","Message-ID":"<20170904091415.wgsuqx67y3il7hnd@eukaryote>","References":"<20170901105434.3288-1-berrange@redhat.com>\n\t<20170901105434.3288-3-berrange@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170901105434.3288-3-berrange@redhat.com>","User-Agent":"Mutt/1.6.0.1 (2016-04-01)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tMon, 04 Sep 2017 09:14:23 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [Qemu-block] [PATCH 2/2] iotests: blacklist 194\n\twith the luks driver","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Kevin Wolf , Fam Zheng ,\n\tqemu-block@nongnu.org, qemu-devel@nongnu.org,\n\tMax Reitz , Stefan Hajnoczi ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1763171,"web_url":"http://patchwork.ozlabs.org/comment/1763171/","msgid":"<20170905100404.GH17449@stefanha-x1.localdomain>","list_archive_url":null,"date":"2017-09-05T10:04:04","subject":"Re: [Qemu-devel] [Qemu-block] [PATCH 2/2] iotests: blacklist 194\n\twith the luks driver","submitter":{"id":2747,"url":"http://patchwork.ozlabs.org/api/people/2747/","name":"Stefan Hajnoczi","email":"stefanha@gmail.com"},"content":"On Fri, Sep 01, 2017 at 11:54:34AM +0100, Daniel P. Berrange wrote:\n> The 194 test has alot of code that assumes a simple image file. Rewriting\n> this to work with luks is possible, but non-trivial, so blacklist the\n> luks format for now.\n> \n> Signed-off-by: Daniel P. Berrange \n> ---\n> tests/qemu-iotests/194 | 1 +\n> tests/qemu-iotests/iotests.py | 4 +++-\n> 2 files changed, 4 insertions(+), 1 deletion(-)\n\nReviewed-by: Stefan Hajnoczi ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"SrOVp2hh\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmj5f741Hz9sNq\n\tfor ;\n\tTue, 5 Sep 2017 20:05:42 +1000 (AEST)","from localhost ([::1]:57873 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpAjk-0001yn-C6\n\tfor incoming@patchwork.ozlabs.org; Tue, 05 Sep 2017 06:05:40 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:39080)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpAiN-0001Ev-MT\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 06:04:20 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpAiG-00028b-4A\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 06:04:15 -0400","from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]:33484)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dpAiF-00027i-TQ; Tue, 05 Sep 2017 06:04:08 -0400","by mail-wm0-x242.google.com with SMTP id 187so2540141wmn.0;\n\tTue, 05 Sep 2017 03:04:07 -0700 (PDT)","from localhost ([51.15.41.238]) by smtp.gmail.com with ESMTPSA id\n\tq31sm92022edd.43.2017.09.05.03.04.05\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 05 Sep 2017 03:04:06 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=o2BnkSLr5H3IPg5sTv4BVjzlT4sspzQ6MBEt6oWTM9c=;\n\tb=SrOVp2hhpa1quPiXs0Dty2KqYRGJ2+GS3zE/REXtR2c2NuOVbOWExcnaFvLhwi9dUn\n\t4GuYB6qwo9tu9BHAfbEi9rexFQiO9i789te36YW9XM84/HrDkdXdNXECH8lD21Pw92UR\n\ts9y98Va3WQ+t4tIqCrpYPkmK9y+ZQLMiPHxqMQ9uzkhUANoXit8+YECvyPALMaSNEL25\n\t8TzfjCMPdQlKydRqPfX+Fv5mOdLwkSyCe3mVHcghDAn8OwQ92KbQRTabN3az9GytYITa\n\tP9EqUnwAfR/mnsAPQNXh9PcRwJ7wjx92wS41TiPZ/ZCnv4KWpG4xc8G1MklacMRdL2jl\n\t1+mw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=o2BnkSLr5H3IPg5sTv4BVjzlT4sspzQ6MBEt6oWTM9c=;\n\tb=As1vSy/IKEVZST9+18wNUPNbQ2NQ4iKuR+O6kS4LuvTULuWlFP4wUljknPcvUyeM+C\n\tovsdFX9iWMA/9HiROdabzmFOtqmNJ5xxG/+UjBMSU4UBnAY8UqCkB6oo2HKYbd/jb9Pq\n\tdc/qLJbQ8LmLsoXLRf7bAmhwXcQTVXxTTArfuu2ViQ+bK+hbTyKYflm4fd2KNoRNXENc\n\troCPl3uyK/hMznLDMFXvM/QOyLfaYO+LGB4WXOemAMofY5vG8lp2tngosk2YZ0yV07ml\n\tZEE5YIbfM9otj4Uiz1SIO/dZddyrku/HWmW9FrqvC+QzvZdCrU3JH7uUOKg7dxyt5Q1m\n\t15Lg==","X-Gm-Message-State":"AHPjjUjDhkBSwc3Czgd/wdn2Agbs2x0OY8c82iHZiyNa6w+PzPEki8+4\n\t6ClyMBhshwyOnITKpoU=","X-Google-Smtp-Source":"ADKCNb5DzZIohBWNlM3AbWfisoBUo3iekbFmjsSLzS5z/zrBjS1FKbBlTiFmNLnxCpw9x0BDzD6YCQ==","X-Received":"by 10.80.182.181 with SMTP id d50mr2793134ede.130.1504605846749; \n\tTue, 05 Sep 2017 03:04:06 -0700 (PDT)","Date":"Tue, 5 Sep 2017 11:04:04 +0100","From":"Stefan Hajnoczi ","To":"\"Daniel P. Berrange\" ","Message-ID":"<20170905100404.GH17449@stefanha-x1.localdomain>","References":"<20170901105434.3288-1-berrange@redhat.com>\n\t<20170901105434.3288-3-berrange@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170901105434.3288-3-berrange@redhat.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c09::242","Subject":"Re: [Qemu-devel] [Qemu-block] [PATCH 2/2] iotests: blacklist 194\n\twith the luks driver","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Kevin Wolf , Fam Zheng ,\n\tqemu-block@nongnu.org, qemu-devel@nongnu.org,\n\tMax Reitz , Stefan Hajnoczi ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]