[{"id":1762075,"web_url":"http://patchwork.ozlabs.org/comment/1762075/","msgid":"<20170901.203430.1204195231321352853.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-02T03:34:30","subject":"Re: [PATCH net-next] net: Add module reference to FIB notifiers","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Ido Schimmel \nDate: Fri, 1 Sep 2017 12:15:17 +0300\n\n> When a listener registers to the FIB notification chain it receives a\n> dump of the FIB entries and rules from existing address families by\n> invoking their dump operations.\n> \n> While we call into these modules we need to make sure they aren't\n> removed. Do that by increasing their reference count before invoking\n> their dump operations and decrease it afterwards.\n> \n> Fixes: 04b1d4e50e82 (\"net: core: Make the FIB notification chain generic\")\n> Signed-off-by: Ido Schimmel \n> Reviewed-by: Jiri Pirko \n\nOops, yes, you'll need to do this.\n\nApplied, thanks.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkhYl1Hhtz9s3w\n\tfor ;\n\tSat, 2 Sep 2017 13:34:35 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751677AbdIBDec (ORCPT );\n\tFri, 1 Sep 2017 23:34:32 -0400","from shards.monkeyblade.net ([184.105.139.130]:58004 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750941AbdIBDeb (ORCPT\n\t); Fri, 1 Sep 2017 23:34:31 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id D414C13534D9C;\n\tFri, 1 Sep 2017 20:34:30 -0700 (PDT)"],"Date":"Fri, 01 Sep 2017 20:34:30 -0700 (PDT)","Message-Id":"<20170901.203430.1204195231321352853.davem@davemloft.net>","To":"idosch@mellanox.com","Cc":"netdev@vger.kernel.org, jiri@mellanox.com, dsahern@gmail.com,\n\tmlxsw@mellanox.com","Subject":"Re: [PATCH net-next] net: Add module reference to FIB notifiers","From":"David Miller ","In-Reply-To":"<20170901091517.31271-1-idosch@mellanox.com>","References":"<20170901091517.31271-1-idosch@mellanox.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Fri, 01 Sep 2017 20:34:31 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]