[{"id":1761633,"web_url":"http://patchwork.ozlabs.org/comment/1761633/","msgid":"<20170901120842.GJ2323@tucnak>","list_archive_url":null,"date":"2017-09-01T12:08:42","subject":"Re: Patch for [Bug fortran/81841] [5/6/7/8 Regression]\n\tTHREADPRIVATE (OpenMP) wrongly rejected in BLOCK DATA","submitter":{"id":671,"url":"http://patchwork.ozlabs.org/api/people/671/","name":"Jakub Jelinek","email":"jakub@redhat.com"},"content":"On Fri, Sep 01, 2017 at 11:09:47AM +0200, dbroemmel wrote:\n> Hi all,\n> \n> attached are a proposed fix and new testcase for PR81841. The\n> THREADPRIVATE statement is currently wrongly rejected as part of BLOCK DATA.\n> \n> The testcase also does (very basic) runtime checks. It fails (compiling)\n> prior to the patch and completes after. Tested on x86_64 GNU/Linux.\n> \n> Thanks,\n> Dirk\n> \n> \n> 2017-09-01 dbroemmel\n\nThe ChangeLog format is date two spaces real name two spaces \n> \n> PR fortran/81841\n> * parse.c (parse_spec): adding ST_OMP_THREADPRIVATE as allowed\n\nAdd instead of adding\nAlso all the ChangeLog lines except empty and ones starting with date\nshould be tab indented, not sure if it is your mailer that ate it or\nomission.\n\n> statement.\n> \n> 2017-09-01 dbroemmel\n> \n> PR fortran/81841\n> * gfortran.dg/gomp/omp_threadprivate3.f90: New testcase.\n\n> Index: gcc/fortran/parse.c\n> ===================================================================\n> --- gcc/fortran/parse.c\t(revision 251553)\n> +++ gcc/fortran/parse.c\t(working copy)\n> @@ -3694,6 +3694,7 @@\n> \tcase ST_EQUIVALENCE:\n> \tcase ST_IMPLICIT:\n> \tcase ST_IMPLICIT_NONE:\n> +\tcase ST_OMP_THREADPRIVATE:\n> \tcase ST_PARAMETER:\n> \tcase ST_STRUCTURE_DECL:\n> \tcase ST_TYPE:\n\nThis looks good.\n\n> Index: gcc/testsuite/gfortran.dg/gomp/omp_threadprivate3.f90\n> ===================================================================\n> --- gcc/testsuite/gfortran.dg/gomp/omp_threadprivate3.f90\t(revision 0)\n> +++ gcc/testsuite/gfortran.dg/gomp/omp_threadprivate3.f90\t(working copy)\n> @@ -0,0 +1,158 @@\n> +! { dg-do run }\n\nThis is wrong. Runtime testcases for OpenMP belong into libgomp/testsuite/.\nThat said, I fail to see why such a large testcase is needed, wouldn't a\nsimple\n! PR fortran/81841\n! { dg-do compile }\n\nblock data\n implicit none\n integer :: int2\n real :: flt2\n common /c_block_2/ int2, flt2\n !$OMP THREADPRIVATE(/c_block_2/)\n data int2, flt2 /2, 2.2/\nend block data\n\ntestcase in gfortran.dg/gomp/ be sufficient here?\n\n\tJakub","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list gcc-patches@gcc.gnu.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=gcc-patches-return-461274-incoming=patchwork.ozlabs.org@gcc.gnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org\n\theader.b=\"gc8+aCKh\"; dkim-atps=neutral","sourceware.org; auth=none","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=jakub@redhat.com"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkJ1k3D4zz9s7M\n\tfor ;\n\tFri, 1 Sep 2017 22:08:58 +1000 (AEST)","(qmail 66481 invoked by alias); 1 Sep 2017 12:08:51 -0000","(qmail 66422 invoked by uid 89); 1 Sep 2017 12:08:50 -0000","from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by\n\tsourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP;\n\tFri, 01 Sep 2017 12:08:48 +0000","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com\n\t[10.5.11.11])\t(using TLSv1.2 with cipher AECDH-AES256-SHA\n\t(256/256 bits))\t(No client certificate requested)\tby\n\tmx1.redhat.com (Postfix) with ESMTPS id 98B96C9D25;\n\tFri, 1 Sep 2017 12:08:47 +0000 (UTC)","from tucnak.zalov.cz (ovpn-116-33.ams2.redhat.com\n\t[10.36.116.33])\tby smtp.corp.redhat.com (Postfix) with ESMTPS\n\tid 4B4ED96FC0; Fri, 1 Sep 2017 12:08:46 +0000 (UTC)","from tucnak.zalov.cz (localhost [127.0.0.1])\tby tucnak.zalov.cz\n\t(8.15.2/8.15.2) with ESMTP id v81C8hC5007516;\n\tFri, 1 Sep 2017 14:08:43 +0200","(from jakub@localhost)\tby tucnak.zalov.cz (8.15.2/8.15.2/Submit)\n\tid v81C8g74007515; Fri, 1 Sep 2017 14:08:42 +0200"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:date\n\t:from:to:cc:subject:message-id:reply-to:references:mime-version\n\t:content-type:in-reply-to; q=dns; s=default; b=JxaM7HcXfVtM6wNJ9\n\tKn6aawN9ZqN9FDH483R+Qhk9VcMywpg2mAm+DnqSvxDLRWOE4HqweILFjMcBArzK\n\tKIKRmCJklGPDjACz885sVBVETele+Hqqih+RbYVNK6YxvzMu/IYtBKmzawkcS1rW\n\tDdmA5V/0D0gsDWjz9McHPujRNo=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:date\n\t:from:to:cc:subject:message-id:reply-to:references:mime-version\n\t:content-type:in-reply-to; s=default; bh=mJhoY7qArN9vlM/ZPT6EnQX\n\tLcDk=; b=gc8+aCKhV1NSemjvy8PqptmEd3VViGzkZMxDBR5PDmYutMXZN8M2A2r\n\tS3zz4GswFpXoYK8OsHuvm5NAKpdRIzwcgahNdaFm+YjEbRVTKwNeV/JTUE7CsUrb\n\tHZ5ypB3r0SszLq6Rs19dcPdGXEUu3YWdufuL3RS9zMu5hdnNKJ/c=","Mailing-List":"contact gcc-patches-help@gcc.gnu.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Archive":"","List-Post":"","List-Help":"","Sender":"gcc-patches-owner@gcc.gnu.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-11.1 required=5.0 tests=BAYES_00, GIT_PATCH_2,\n\tGIT_PATCH_3, KAM_ASCII_DIVIDERS, RP_MATCHES_RCVD,\n\tSPF_HELO_PASS autolearn=ham version=3.3.2 spammy=mailer","X-Spam-User":"qpsmtpd, 2 recipients","X-HELO":"mx1.redhat.com","DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 98B96C9D25","Date":"Fri, 1 Sep 2017 14:08:42 +0200","From":"Jakub Jelinek ","To":"dbroemmel ","Cc":"fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org","Subject":"Re: Patch for [Bug fortran/81841] [5/6/7/8 Regression]\n\tTHREADPRIVATE (OpenMP) wrongly rejected in BLOCK DATA","Message-ID":"<20170901120842.GJ2323@tucnak>","Reply-To":"Jakub Jelinek ","References":"<2f2d738f-90d7-0efe-1caf-7e3a6387b0eb@daswigwam.de>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<2f2d738f-90d7-0efe-1caf-7e3a6387b0eb@daswigwam.de>","User-Agent":"Mutt/1.7.1 (2016-10-04)","X-IsSubscribed":"yes"}},{"id":1761645,"web_url":"http://patchwork.ozlabs.org/comment/1761645/","msgid":"","list_archive_url":null,"date":"2017-09-01T12:27:40","subject":"Re: Patch for [Bug fortran/81841] [5/6/7/8 Regression]\n\tTHREADPRIVATE (OpenMP) wrongly rejected in BLOCK DATA","submitter":{"id":72275,"url":"http://patchwork.ozlabs.org/api/people/72275/","name":"dbroemmel","email":"dibr-bugzilla@daswigwam.de"},"content":"> This is wrong. Runtime testcases for OpenMP belong into libgomp/testsuite/.\nWell, that's a path where I found some Fortran OpenMP stuff, I didn't\nlook for other places.\n\n> That said, I fail to see why such a large testcase is needed, wouldn't a\n> simple\n> ! PR fortran/81841\n> ! { dg-do compile }\n> \n> block data\n> implicit none\n> integer :: int2\n> real :: flt2\n> common /c_block_2/ int2, flt2\n> !$OMP THREADPRIVATE(/c_block_2/)\n> data int2, flt2 /2, 2.2/\n> end block data\n> \n> testcase in gfortran.dg/gomp/ be sufficient here?\nThat would suffice and is the first testcase I added to PR81841. It was\nsuggested I could add runtime tests as well, so I tried.\n\nDirk","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list gcc-patches@gcc.gnu.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=gcc-patches-return-461275-incoming=patchwork.ozlabs.org@gcc.gnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org\n\theader.b=\"oD69K+F1\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkJRf2Vwgz9sRV\n\tfor ;\n\tFri, 1 Sep 2017 22:27:57 +1000 (AEST)","(qmail 108323 invoked by alias); 1 Sep 2017 12:27:46 -0000","(qmail 108250 invoked by uid 89); 1 Sep 2017 12:27:45 -0000","from mail.daswigwam.de (HELO mail.daswigwam.de) (92.51.130.26) by\n\tsourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP;\n\tFri, 01 Sep 2017 12:27:44 +0000","from localhost (localhost [127.0.0.1])\tby mail.daswigwam.de\n\t(Postfix) with ESMTP id 0AB411004E0;\n\tFri, 1 Sep 2017 14:27:42 +0200 (CEST)","from mail.daswigwam.de ([127.0.0.1])\tby localhost\n\t(lvps92-51-130-26.dedicated.hosteurope.de [127.0.0.1])\n\t(amavisd-new, port 10024)\twith LMTP id FJeqnhuROjbh;\n\tFri, 1 Sep 2017 14:27:41 +0200 (CEST)","from 127.0.0.1 (zam390.zam.kfa-juelich.de [134.94.168.28])\t(using\n\tTLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits))\t(No client certificate requested)\tby mail.daswigwam.de\n\t(Postfix) with ESMTPSA id 8C1681004D5;\n\tFri, 1 Sep 2017 14:27:41 +0200 (CEST)"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender\n\t:subject:to:cc:references:from:message-id:date:mime-version\n\t:in-reply-to:content-type:content-transfer-encoding; q=dns; s=\n\tdefault; b=hvVtkXZlV3RNmYLjuIrinezGhV30i9lz6UcI9BJHLsVvG2TE1ehck\n\tJIHanXEZBxtmZtIanuRFnNhos+geclD55oCsUrkcbn3T9TB68J83M/4jelxpi+Ne\n\t5VbSqfSo9ejYky8CsWDMAP18vPqtm7P7sp3+TTc92MfnwVDMCRySPo=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender\n\t:subject:to:cc:references:from:message-id:date:mime-version\n\t:in-reply-to:content-type:content-transfer-encoding; s=default;\n\tbh=yg+fXJRmD35Ncrjoz0076Rt7/wg=; b=oD69K+F1AsNSZOxC4O5iiwUHgDEF\n\tyvdOK9DrrXWBKYO8pRDCx9KsssUo0Kb+xk+XChQ3zzE6U4RAgAa7K2XBT9y3CnWu\n\t1ubYsQdyC4NW53MjNeExE++CRaa2t2eNUwDu1yB4olGEf+gr6FCYyFBqZCF003uz\n\tIdqOoedT5CPciLE=","Mailing-List":"contact gcc-patches-help@gcc.gnu.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Archive":"","List-Post":"","List-Help":"","Sender":"gcc-patches-owner@gcc.gnu.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-0.9 required=5.0 tests=AWL, BAYES_00,\n\tKAM_LAZY_DOMAIN_SECURITY,\n\tRP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=H*M:b247,\n\tH*MI:sk:2017090","X-Spam-User":"qpsmtpd, 2 recipients","X-HELO":"mail.daswigwam.de","Subject":"Re: Patch for [Bug fortran/81841] [5/6/7/8 Regression]\n\tTHREADPRIVATE (OpenMP) wrongly rejected in BLOCK DATA","To":"Jakub Jelinek ","Cc":"fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org","References":"<2f2d738f-90d7-0efe-1caf-7e3a6387b0eb@daswigwam.de>\n\t<20170901120842.GJ2323@tucnak>","From":"dbroemmel ","Message-ID":"","Date":"Fri, 1 Sep 2017 14:27:40 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64;\n\trv:52.0) Gecko/20100101 Thunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170901120842.GJ2323@tucnak>","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"7bit"}},{"id":1761673,"web_url":"http://patchwork.ozlabs.org/comment/1761673/","msgid":"<20170901131124.GK2323@tucnak>","list_archive_url":null,"date":"2017-09-01T13:11:24","subject":"Re: Patch for [Bug fortran/81841] [5/6/7/8 Regression]\n\tTHREADPRIVATE (OpenMP) wrongly rejected in BLOCK DATA","submitter":{"id":671,"url":"http://patchwork.ozlabs.org/api/people/671/","name":"Jakub Jelinek","email":"jakub@redhat.com"},"content":"On Fri, Sep 01, 2017 at 02:27:40PM +0200, dbroemmel wrote:\n> > This is wrong. Runtime testcases for OpenMP belong into libgomp/testsuite/.\n> Well, that's a path where I found some Fortran OpenMP stuff, I didn't\n> look for other places.\n> \n> > That said, I fail to see why such a large testcase is needed, wouldn't a\n> > simple\n> > ! PR fortran/81841\n> > ! { dg-do compile }\n> > \n> > block data\n> > implicit none\n> > integer :: int2\n> > real :: flt2\n> > common /c_block_2/ int2, flt2\n> > !$OMP THREADPRIVATE(/c_block_2/)\n> > data int2, flt2 /2, 2.2/\n> > end block data\n> > \n> > testcase in gfortran.dg/gomp/ be sufficient here?\n> That would suffice and is the first testcase I added to PR81841. It was\n> suggested I could add runtime tests as well, so I tried.\n\nIf you really need a testcase, it would be enough to do something like:\n use omp_lib\n !$omp parallel num_threads(2)\n int2 = omp_get_thread_num ()\n !$omp barrier\n if (int2 != omp_get_thread_num ()) call abort\n !$omp end parallel\nor so to ensure it has the threadprivate property by writing something\ndifferent to it in each thread and after barrier verifying it has the\nexpected value in each thread.\n\n\tJakub","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list gcc-patches@gcc.gnu.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=gcc-patches-return-461285-incoming=patchwork.ozlabs.org@gcc.gnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org\n\theader.b=\"VzlZF0RV\"; dkim-atps=neutral","sourceware.org; auth=none","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=jakub@redhat.com"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkKQD4pnyz9s83\n\tfor ;\n\tFri, 1 Sep 2017 23:11:47 +1000 (AEST)","(qmail 33685 invoked by alias); 1 Sep 2017 13:11:34 -0000","(qmail 33664 invoked by uid 89); 1 Sep 2017 13:11:33 -0000","from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by\n\tsourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP;\n\tFri, 01 Sep 2017 13:11:32 +0000","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com\n\t[10.5.11.16])\t(using TLSv1.2 with cipher AECDH-AES256-SHA\n\t(256/256 bits))\t(No client certificate requested)\tby\n\tmx1.redhat.com (Postfix) with ESMTPS id 5A01BC058EC0;\n\tFri, 1 Sep 2017 13:11:31 +0000 (UTC)","from tucnak.zalov.cz (ovpn-116-33.ams2.redhat.com\n\t[10.36.116.33])\tby smtp.corp.redhat.com (Postfix) with ESMTPS\n\tid 03D5566831; Fri, 1 Sep 2017 13:11:30 +0000 (UTC)","from tucnak.zalov.cz (localhost [127.0.0.1])\tby tucnak.zalov.cz\n\t(8.15.2/8.15.2) with ESMTP id v81DBRVE007665;\n\tFri, 1 Sep 2017 15:11:27 +0200","(from jakub@localhost)\tby tucnak.zalov.cz (8.15.2/8.15.2/Submit)\n\tid v81DBO2h007664; Fri, 1 Sep 2017 15:11:24 +0200"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:date\n\t:from:to:cc:subject:message-id:reply-to:references:mime-version\n\t:content-type:in-reply-to; q=dns; s=default; b=ijTN5cxHGheFnmu6v\n\tnta9W356qYZkVh6kUHyQrHI7aUKQNTmywmi1mzEzSJqeSwfe1ohc/hKVmCvmz7b9\n\tp9gWC0nDGo8rX0OHMYiAhTSXEQoGquz+R/UTSLM2c1lOa3II3wh5Y6bv13jT89Dd\n\tWcNkoo8RYRIoFdNUDwJxfXXcyU=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:date\n\t:from:to:cc:subject:message-id:reply-to:references:mime-version\n\t:content-type:in-reply-to; s=default; bh=kIz45LDUfk4yM6rx5aei5go\n\tJzwE=; b=VzlZF0RV+N4daI1xb3MDs29YKvFzm7h7hHPELfbJH2VwsmyFbwJalyw\n\tUv4/6zqw/BS1A/zDyIhJVaX9qoYH67Yb0cQ6on77zpFrORlHiT6cReRunCrBrctt\n\tNMnZuKserl3abn9ojc7Wg5cnjIHGUB4lSEkhjyLtS14ND4mYfgGs=","Mailing-List":"contact gcc-patches-help@gcc.gnu.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Archive":"","List-Post":"","List-Help":"","Sender":"gcc-patches-owner@gcc.gnu.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-1.9 required=5.0 tests=BAYES_00,\n\tRP_MATCHES_RCVD,\n\tSPF_HELO_PASS autolearn=ham version=3.3.2 spammy=","X-Spam-User":"qpsmtpd, 2 recipients","X-HELO":"mx1.redhat.com","DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 5A01BC058EC0","Date":"Fri, 1 Sep 2017 15:11:24 +0200","From":"Jakub Jelinek ","To":"dbroemmel ","Cc":"fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org","Subject":"Re: Patch for [Bug fortran/81841] [5/6/7/8 Regression]\n\tTHREADPRIVATE (OpenMP) wrongly rejected in BLOCK DATA","Message-ID":"<20170901131124.GK2323@tucnak>","Reply-To":"Jakub Jelinek ","References":"<2f2d738f-90d7-0efe-1caf-7e3a6387b0eb@daswigwam.de>\n\t<20170901120842.GJ2323@tucnak>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.7.1 (2016-10-04)","X-IsSubscribed":"yes"}},{"id":1761704,"web_url":"http://patchwork.ozlabs.org/comment/1761704/","msgid":"","list_archive_url":null,"date":"2017-09-01T13:47:10","subject":"Re: Patch for [Bug fortran/81841] [5/6/7/8 Regression]\n\tTHREADPRIVATE (OpenMP) wrongly rejected in BLOCK DATA","submitter":{"id":72275,"url":"http://patchwork.ozlabs.org/api/people/72275/","name":"dbroemmel","email":"dibr-bugzilla@daswigwam.de"},"content":"> If you really need a testcase, it would be enough to do something like:\n> use omp_lib\n> !$omp parallel num_threads(2)\n> int2 = omp_get_thread_num ()\n> !$omp barrier\n> if (int2 != omp_get_thread_num ()) call abort\n> !$omp end parallel\n> or so to ensure it has the threadprivate property by writing something\n> different to it in each thread and after barrier verifying it has the\n> expected value in each thread.\nI'm more than fine with the short compile-only testcase. I pretty sure\nmy largish runtime test doesn't get near covering all relevant aspects\nof the THREADPRIVATE directive for common blocks. Also, the fix is for\nthis reject-valid parsing error, so not really to do with anything else,\nso perhaps shouldn't test anything else?\n\nDirk","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list gcc-patches@gcc.gnu.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=gcc-patches-return-461296-incoming=patchwork.ozlabs.org@gcc.gnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org\n\theader.b=\"qZ/mmNQP\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkLCP6GMRz9rvt\n\tfor ;\n\tFri, 1 Sep 2017 23:47:27 +1000 (AEST)","(qmail 65056 invoked by alias); 1 Sep 2017 13:47:20 -0000","(qmail 65035 invoked by uid 89); 1 Sep 2017 13:47:19 -0000","from mail.daswigwam.de (HELO mail.daswigwam.de) (92.51.130.26) by\n\tsourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP;\n\tFri, 01 Sep 2017 13:47:13 +0000","from localhost (localhost [127.0.0.1])\tby mail.daswigwam.de\n\t(Postfix) with ESMTP id A98F71004E0;\n\tFri, 1 Sep 2017 15:47:11 +0200 (CEST)","from mail.daswigwam.de ([127.0.0.1])\tby localhost\n\t(lvps92-51-130-26.dedicated.hosteurope.de [127.0.0.1])\n\t(amavisd-new, port 10024)\twith LMTP id yyh9pEptcGeD;\n\tFri, 1 Sep 2017 15:47:11 +0200 (CEST)","from 127.0.0.1 (zam390.zam.kfa-juelich.de [134.94.168.28])\t(using\n\tTLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits))\t(No client certificate requested)\tby mail.daswigwam.de\n\t(Postfix) with ESMTPSA id 69FEB1004D5;\n\tFri, 1 Sep 2017 15:47:11 +0200 (CEST)"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender\n\t:subject:to:cc:references:from:message-id:date:mime-version\n\t:in-reply-to:content-type:content-transfer-encoding; q=dns; s=\n\tdefault; b=f69Gx1YCyc5u6u2+ygZlrp0JnSNH2CN695o0pqB2xyBn3QxTSc3Kg\n\tPCS9RzQvdqqXUHYmVYjjrZ0lHKeSY7fSApnpac1hOPMAqVzjs1PeVBHKNLoYQ0+n\n\thdA5QrUMMDtoo5TBqc3J2FJZeK12zOhv/CRhfaufKiQ3vKfFCm0gdk=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender\n\t:subject:to:cc:references:from:message-id:date:mime-version\n\t:in-reply-to:content-type:content-transfer-encoding; s=default;\n\tbh=Sx0urqV6p8oInHUK+ucnCgRKp9w=; b=qZ/mmNQPlb6K7sMaZRFWxvUndGbH\n\tYx2tETLfDkYWRwx2nplNrkQBHtIb19HrB5z0TkizYweBnvQl0Z24o8qwzDy9HPlN\n\t+w5u7XGl5Qkhp9e6Tda87ss78CNkYHnI843kdIu5EsWtzIkEmpb0tVWxxKCgXTMj\n\t6WnbqpS87kW2aQE=","Mailing-List":"contact gcc-patches-help@gcc.gnu.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Archive":"","List-Post":"","List-Help":"","Sender":"gcc-patches-owner@gcc.gnu.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-0.9 required=5.0 tests=AWL, BAYES_00,\n\tKAM_LAZY_DOMAIN_SECURITY,\n\tRP_MATCHES_RCVD autolearn=no version=3.3.2\n\tspammy=Hx-languages-length:857, H*M:9da7, H*M:186c","X-Spam-User":"qpsmtpd, 2 recipients","X-HELO":"mail.daswigwam.de","Subject":"Re: Patch for [Bug fortran/81841] [5/6/7/8 Regression]\n\tTHREADPRIVATE (OpenMP) wrongly rejected in BLOCK DATA","To":"Jakub Jelinek ","Cc":"fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org","References":"<2f2d738f-90d7-0efe-1caf-7e3a6387b0eb@daswigwam.de>\n\t<20170901120842.GJ2323@tucnak>\n\t\n\t<20170901131124.GK2323@tucnak>","From":"dbroemmel ","Message-ID":"","Date":"Fri, 1 Sep 2017 15:47:10 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64;\n\trv:52.0) Gecko/20100101 Thunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170901131124.GK2323@tucnak>","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"7bit"}},{"id":1761713,"web_url":"http://patchwork.ozlabs.org/comment/1761713/","msgid":"<20170901135452.GM2323@tucnak>","list_archive_url":null,"date":"2017-09-01T13:54:52","subject":"Re: Patch for [Bug fortran/81841] [5/6/7/8 Regression]\n\tTHREADPRIVATE (OpenMP) wrongly rejected in BLOCK DATA","submitter":{"id":671,"url":"http://patchwork.ozlabs.org/api/people/671/","name":"Jakub Jelinek","email":"jakub@redhat.com"},"content":"On Fri, Sep 01, 2017 at 03:47:10PM +0200, dbroemmel wrote:\n> > If you really need a testcase, it would be enough to do something like:\n> > use omp_lib\n> > !$omp parallel num_threads(2)\n> > int2 = omp_get_thread_num ()\n> > !$omp barrier\n> > if (int2 != omp_get_thread_num ()) call abort\n> > !$omp end parallel\n> > or so to ensure it has the threadprivate property by writing something\n> > different to it in each thread and after barrier verifying it has the\n> > expected value in each thread.\n> I'm more than fine with the short compile-only testcase. I pretty sure\n> my largish runtime test doesn't get near covering all relevant aspects\n> of the THREADPRIVATE directive for common blocks. Also, the fix is for\n> this reject-valid parsing error, so not really to do with anything else,\n> so perhaps shouldn't test anything else?\n\nYes, I said initially a compile time testcase is just fine for me.\n\n\tJakub","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list gcc-patches@gcc.gnu.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=gcc-patches-return-461299-incoming=patchwork.ozlabs.org@gcc.gnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org\n\theader.b=\"O3+G6Vgk\"; dkim-atps=neutral","sourceware.org; auth=none","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=jakub@redhat.com"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkLNG0clJz9s7F\n\tfor ;\n\tFri, 1 Sep 2017 23:55:09 +1000 (AEST)","(qmail 88002 invoked by alias); 1 Sep 2017 13:55:02 -0000","(qmail 87168 invoked by uid 89); 1 Sep 2017 13:55:01 -0000","from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by\n\tsourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP;\n\tFri, 01 Sep 2017 13:54:56 +0000","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com\n\t[10.5.11.13])\t(using TLSv1.2 with cipher AECDH-AES256-SHA\n\t(256/256 bits))\t(No client certificate requested)\tby\n\tmx1.redhat.com (Postfix) with ESMTPS id 9FDAE6147F;\n\tFri, 1 Sep 2017 13:54:55 +0000 (UTC)","from tucnak.zalov.cz (ovpn-116-33.ams2.redhat.com\n\t[10.36.116.33])\tby smtp.corp.redhat.com (Postfix) with ESMTPS\n\tid 4855378215; Fri, 1 Sep 2017 13:54:55 +0000 (UTC)","from tucnak.zalov.cz (localhost [127.0.0.1])\tby tucnak.zalov.cz\n\t(8.15.2/8.15.2) with ESMTP id v81DsrXj007878;\n\tFri, 1 Sep 2017 15:54:53 +0200","(from jakub@localhost)\tby tucnak.zalov.cz (8.15.2/8.15.2/Submit)\n\tid v81Dsq8H007877; Fri, 1 Sep 2017 15:54:52 +0200"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:date\n\t:from:to:cc:subject:message-id:reply-to:references:mime-version\n\t:content-type:in-reply-to; q=dns; s=default; b=n+zSr7NP59+Ug2A5J\n\tRy4eINtkNVQ0C1E7DjOOK+hQd3ChvxlxoY6CD4Oi2e63FxdQ3xbhsjSERwujAZ5h\n\tDekr71aHaadj6EULRmGAHg/z0RkLl7SqM70B5jfDVreqNiTGWFSWVRq0r6weGSOI\n\tXG/GDKcwP6d/MVSoWJXGBnDBqg=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:date\n\t:from:to:cc:subject:message-id:reply-to:references:mime-version\n\t:content-type:in-reply-to; s=default; bh=XgHaAJB0VV4hPOiYEzDKtKN\n\tKpRM=; b=O3+G6VgkZXMpdZ2VDqM1K3cMbfoTobaWQCh1mk5BCSZWE7KpRPlZxYj\n\tZ+1E3YkGJ/MXo0xECl7F+ezfnh2ZJvcGK6pnD2mPlYxq05L2B6U6zlNWhHmI//cF\n\tyu2W2aaqx2H4qF61cTsqhz+UkMAxCUMPfVXjE9FiLlwwHFG3BpiI=","Mailing-List":"contact gcc-patches-help@gcc.gnu.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Archive":"","List-Post":"","List-Help":"","Sender":"gcc-patches-owner@gcc.gnu.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-0.9 required=5.0 tests=BAYES_00,\n\tKAM_LAZY_DOMAIN_SECURITY, RP_MATCHES_RCVD,\n\tSPF_HELO_PASS autolearn=no version=3.3.2 spammy=","X-Spam-User":"qpsmtpd, 2 recipients","X-HELO":"mx1.redhat.com","DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 9FDAE6147F","Date":"Fri, 1 Sep 2017 15:54:52 +0200","From":"Jakub Jelinek ","To":"dbroemmel ","Cc":"fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org","Subject":"Re: Patch for [Bug fortran/81841] [5/6/7/8 Regression]\n\tTHREADPRIVATE (OpenMP) wrongly rejected in BLOCK DATA","Message-ID":"<20170901135452.GM2323@tucnak>","Reply-To":"Jakub Jelinek ","References":"<2f2d738f-90d7-0efe-1caf-7e3a6387b0eb@daswigwam.de>\n\t<20170901120842.GJ2323@tucnak>\n\t\n\t<20170901131124.GK2323@tucnak>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.7.1 (2016-10-04)","X-IsSubscribed":"yes"}},{"id":1809468,"web_url":"http://patchwork.ozlabs.org/comment/1809468/","msgid":"<20171123202158.GP14653@tucnak>","list_archive_url":null,"date":"2017-11-23T20:21:58","subject":"Re: Patch for [Bug fortran/81841] [5/6/7/8 Regression]\n\tTHREADPRIVATE (OpenMP) wrongly rejected in BLOCK DATA","submitter":{"id":671,"url":"http://patchwork.ozlabs.org/api/people/671/","name":"Jakub Jelinek","email":"jakub@redhat.com"},"content":"On Fri, Sep 01, 2017 at 03:47:10PM +0200, dbroemmel wrote:\n> > If you really need a testcase, it would be enough to do something like:\n> > use omp_lib\n> > !$omp parallel num_threads(2)\n> > int2 = omp_get_thread_num ()\n> > !$omp barrier\n> > if (int2 != omp_get_thread_num ()) call abort\n> > !$omp end parallel\n> > or so to ensure it has the threadprivate property by writing something\n> > different to it in each thread and after barrier verifying it has the\n> > expected value in each thread.\n> I'm more than fine with the short compile-only testcase. I pretty sure\n> my largish runtime test doesn't get near covering all relevant aspects\n> of the THREADPRIVATE directive for common blocks. Also, the fix is for\n> this reject-valid parsing error, so not really to do with anything else,\n> so perhaps shouldn't test anything else?\n\nI was expecting you'd repost the patch with updated testcase and then\nforgot about the issue, got to it only now when looking through regressions.\n\nI've bootstrapped/regtested this version and committed it so far to trunk:\n\n2017-11-23 Dirk Broemmel \n\t Jakub Jelinek \n\n\tPR fortran/81841\n\t* parse.c (parse_spec): Allow ST_OMP_THREADPRIVATE inside of\n\tBLOCK DATA.\n\n\t* libgomp.fortran/pr81841.f90: New test.\n\n--- gcc/fortran/parse.c.jj\t2017-11-06 08:46:32.000000000 +0100\n+++ gcc/fortran/parse.c\t2017-11-23 18:40:44.727973342 +0100\n@@ -3699,6 +3699,7 @@ loop:\n \tcase ST_EQUIVALENCE:\n \tcase ST_IMPLICIT:\n \tcase ST_IMPLICIT_NONE:\n+\tcase ST_OMP_THREADPRIVATE:\n \tcase ST_PARAMETER:\n \tcase ST_STRUCTURE_DECL:\n \tcase ST_TYPE:\n--- libgomp/testsuite/libgomp.fortran/pr81841.f90.jj\t2017-11-23 18:34:37.319385141 +0100\n+++ libgomp/testsuite/libgomp.fortran/pr81841.f90\t2017-11-23 18:44:36.055198860 +0100\n@@ -0,0 +1,26 @@\n+! PR fortran/81841\n+! { dg-do run }\n+\n+block data\n+ integer :: a\n+ real :: b(2)\n+ common /c/ a, b\n+ !$omp threadprivate (/c/)\n+ data a / 32 /\n+ data b /2*1./\n+end\n+\n+program pr81841\n+ use omp_lib\n+ integer :: e\n+ real :: f(2)\n+ common /c/ e, f\n+ !$omp threadprivate (/c/)\n+ !$omp parallel num_threads(8)\n+ if ((e /= 32) .or. any(f /= 1.)) call abort\n+ e = omp_get_thread_num ()\n+ f = e + 19.\n+ !$omp barrier\n+ if ((e /= omp_get_thread_num ()) .or. any(f /= e + 19.)) call abort\n+ !$omp end parallel\n+end\n\n\n\tJakub","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list gcc-patches@gcc.gnu.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=gcc-patches-return-467818-incoming=patchwork.ozlabs.org@gcc.gnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org\n\theader.b=\"B4cIT6KS\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yjW2Y5rxhz9s76\n\tfor ;\n\tFri, 24 Nov 2017 07:22:13 +1100 (AEDT)","(qmail 1672 invoked by alias); 23 Nov 2017 20:22:05 -0000","(qmail 1646 invoked by uid 89); 23 Nov 2017 20:22:05 -0000","from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by\n\tsourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP;\n\tThu, 23 Nov 2017 20:22:04 +0000","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com\n\t[10.5.11.12])\t(using TLSv1.2 with cipher AECDH-AES256-SHA\n\t(256/256 bits))\t(No client certificate requested)\tby\n\tmx1.redhat.com (Postfix) with ESMTPS id A1C4160177;\n\tThu, 23 Nov 2017 20:22:02 +0000 (UTC)","from tucnak.zalov.cz (ovpn-116-247.ams2.redhat.com\n\t[10.36.116.247])\tby smtp.corp.redhat.com (Postfix) with\n\tESMTPS id 24FF160C90; Thu, 23 Nov 2017 20:22:01 +0000 (UTC)","from tucnak.zalov.cz (localhost [127.0.0.1])\tby tucnak.zalov.cz\n\t(8.15.2/8.15.2) with ESMTP id vANKLxqr001680;\n\tThu, 23 Nov 2017 21:21:59 +0100","(from jakub@localhost)\tby tucnak.zalov.cz (8.15.2/8.15.2/Submit)\n\tid vANKLw4K001679; Thu, 23 Nov 2017 21:21:58 +0100"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:date\n\t:from:to:cc:subject:message-id:reply-to:references:mime-version\n\t:content-type:in-reply-to; q=dns; s=default; b=lL4/QF+omNaLKniS3\n\t7qdI/DjZbC2yKNqrm2b/pZGfQgvIFuKN0c+QcmeFO/gt5On8dT2t6aBawvI4USda\n\t9MUJSWhSXYPsFtcRgWCuvwsw/GmJb9cuzsmgm6EDGyH/MGB4oCJhtQ4XJTHAdYNU\n\tP2DfmxS/sj4TUirxWd5J/88XKg=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:date\n\t:from:to:cc:subject:message-id:reply-to:references:mime-version\n\t:content-type:in-reply-to; s=default; bh=kkPe/zvOWo2C+icuR1cl/Hu\n\t0GIw=; b=B4cIT6KSs3amP3c55MzorBNNFKw440COTNu0sJsAo8TrknEHr5Sy6Da\n\tKq89XLwHHf7soTNllr8DIrcA6OXAjlaQFJPUut0FBSCpNb3YdsxiLsXFcRsaqE8M\n\tRWThYwnHSe18CNhhKfZyPTyXmodOCwuqxK7SWhC9ddgQr8OZm1gM=","Mailing-List":"contact gcc-patches-help@gcc.gnu.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Archive":"","List-Post":"","List-Help":"","Sender":"gcc-patches-owner@gcc.gnu.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-11.7 required=5.0 tests=BAYES_00, GIT_PATCH_2,\n\tGIT_PATCH_3, KB_WAM_FROM_NAME_SINGLEWORD, SPF_HELO_PASS,\n\tT_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=","X-Spam-User":"qpsmtpd, 2 recipients","X-HELO":"mx1.redhat.com","Date":"Thu, 23 Nov 2017 21:21:58 +0100","From":"Jakub Jelinek ","To":"dbroemmel ","Cc":"fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org","Subject":"Re: Patch for [Bug fortran/81841] [5/6/7/8 Regression]\n\tTHREADPRIVATE (OpenMP) wrongly rejected in BLOCK DATA","Message-ID":"<20171123202158.GP14653@tucnak>","Reply-To":"Jakub Jelinek ","References":"<2f2d738f-90d7-0efe-1caf-7e3a6387b0eb@daswigwam.de>\n\t<20170901120842.GJ2323@tucnak>\n\t\n\t<20170901131124.GK2323@tucnak>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.7.1 (2016-10-04)","X-IsSubscribed":"yes"}}]