[{"id":1761827,"web_url":"http://patchwork.ozlabs.org/comment/1761827/","msgid":"<20170901.100034.224684373888616212.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-01T17:00:34","subject":"Re: [patch net] mlxsw: spectrum: Forbid linking to devices that\n\thave uppers","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Jiri Pirko \nDate: Fri, 1 Sep 2017 10:52:31 +0200\n\n> From: Ido Schimmel \n> \n> The mlxsw driver relies on NETDEV_CHANGEUPPER events to configure the\n> device in case a port is enslaved to a master netdev such as bridge or\n> bond.\n> \n> Since the driver ignores events unrelated to its ports and their\n> uppers, it's possible to engineer situations in which the device's data\n> path differs from the kernel's.\n> \n> One example to such a situation is when a port is enslaved to a bond\n> that is already enslaved to a bridge. When the bond was enslaved the\n> driver ignored the event - as the bond wasn't one of its uppers - and\n> therefore a bridge port instance isn't created in the device.\n> \n> Until such configurations are supported forbid them by checking that the\n> upper device doesn't have uppers of its own.\n> \n> Fixes: 0d65fc13042f (\"mlxsw: spectrum: Implement LAG port join/leave\")\n> Signed-off-by: Ido Schimmel \n> Reported-by: Nogah Frankel \n> Tested-by: Nogah Frankel \n> Signed-off-by: Jiri Pirko \n\nApplied and queued up for -stable, thanks.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkQVG36k9z9t2x\n\tfor ;\n\tSat, 2 Sep 2017 03:00:38 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752127AbdIARAf (ORCPT );\n\tFri, 1 Sep 2017 13:00:35 -0400","from shards.monkeyblade.net ([184.105.139.130]:49400 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751998AbdIARAf (ORCPT\n\t); Fri, 1 Sep 2017 13:00:35 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 9E75E134B12A0;\n\tFri, 1 Sep 2017 10:00:34 -0700 (PDT)"],"Date":"Fri, 01 Sep 2017 10:00:34 -0700 (PDT)","Message-Id":"<20170901.100034.224684373888616212.davem@davemloft.net>","To":"jiri@resnulli.us","Cc":"netdev@vger.kernel.org, idosch@mellanox.com, nogahf@mellanox.com,\n\tmlxsw@mellanox.com","Subject":"Re: [patch net] mlxsw: spectrum: Forbid linking to devices that\n\thave uppers","From":"David Miller ","In-Reply-To":"<20170901085231.1396-1-jiri@resnulli.us>","References":"<20170901085231.1396-1-jiri@resnulli.us>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Fri, 01 Sep 2017 10:00:34 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]