[{"id":1761728,"web_url":"http://patchwork.ozlabs.org/comment/1761728/","msgid":"<20170901142622.GC599@roeck-us.net>","list_archive_url":null,"date":"2017-09-01T14:26:22","subject":"Re: [PATCH v3 2/2] hwmon: (ltq-cputemp) add devicetree bindings\n\tdocumentation","submitter":{"id":21889,"url":"http://patchwork.ozlabs.org/api/people/21889/","name":"Guenter Roeck","email":"linux@roeck-us.net"},"content":"On Fri, Sep 01, 2017 at 08:58:18AM +0200, Florian Eckert wrote:\n> Document the devicetree bindings for the ltq-cputemp\n> \n> Signed-off-by: Florian Eckert <fe@dev.tdt.de>\n\nI see nothing special with the bindings, and they are in line with other lantiq\nbindings, so I am taking the risk of accepting this patch (and the matching\ndriver) without waiting for explicit approval from Rob. Rob, scream at me if\nthat is not ok.\n\nThanks,\nGuenter\n\n> ---\n>  Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt | 10 ++++++++++\n>  1 file changed, 10 insertions(+)\n>  create mode 100644 Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt\n> \n> diff --git a/Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt b/Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt\n> new file mode 100644\n> index 000000000000..33fd00a987c7\n> --- /dev/null\n> +++ b/Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt\n> @@ -0,0 +1,10 @@\n> +Lantiq cpu temperatur sensor\n> +\n> +Requires node properties:\n> +- compatible value :\n> +\t\"lantiq,cputemp\"\n> +\n> +Example:\n> +\tcputemp@0 {\n> +\t\tcompatible = \"lantiq,cputemp\";\n> +\t};\n> -- \n> 2.11.0\n> \n> --\n> To unsubscribe from this list: send the line \"unsubscribe linux-hwmon\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at  http://vger.kernel.org/majordomo-info.html\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at  http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"<devicetree-owner@vger.kernel.org>","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"R1Ek71uo\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkM4L6QM2z9t2d\n\tfor <incoming-dt@patchwork.ozlabs.org>;\n\tSat,  2 Sep 2017 00:26:26 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751984AbdIAO0Z (ORCPT\n\t<rfc822;incoming-dt@patchwork.ozlabs.org>);\n\tFri, 1 Sep 2017 10:26:25 -0400","from mail-pg0-f66.google.com ([74.125.83.66]:35414 \"EHLO\n\tmail-pg0-f66.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751970AbdIAO0Y (ORCPT\n\t<rfc822; devicetree@vger.kernel.org>); Fri, 1 Sep 2017 10:26:24 -0400","by mail-pg0-f66.google.com with SMTP id r133so223210pgr.2;\n\tFri, 01 Sep 2017 07:26:23 -0700 (PDT)","from localhost (108-223-40-66.lightspeed.sntcca.sbcglobal.net.\n\t[108.223.40.66]) by smtp.gmail.com with ESMTPSA id\n\tn18sm628523pgd.13.2017.09.01.07.26.22\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 01 Sep 2017 07:26:23 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=/ez6eVVC1unXsruuiTJceVBtjDpF/xZ/KiLXMS94Juc=;\n\tb=R1Ek71uoe5d7N3xT+kkuugVFHj3L9Kfmklnye5te+RSpEepcjky9pWi40BuqdMcsio\n\tbYbxU/Kmb+jZHIH/ul2cOhn4PM7AycAe7LoQtojgjSQi1+u2SD88Zgz5bSeZcoAGauEt\n\tBqpy3BIDIQst8coTFQnQdEJxMtlKuqB/dzevV0PeuRDUtrtH7YbaOe+PMJe9wD8lcwFz\n\tlUmMHnXXoUiJmuAdkXl1w22Ku5AwqHAIwCBndcu+EyxPVAIgvuAPvUzUIDooVCyrsJ4U\n\tHAK+OtLy51zvo1iWrVplZL7dlhMhrNI/vEeDgV/b17gFrbZJuEJLSNqmuCH/iFOh/9i0\n\t3ACg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:date:from:to:cc:subject:message-id\n\t:references:mime-version:content-disposition:in-reply-to:user-agent; \n\tbh=/ez6eVVC1unXsruuiTJceVBtjDpF/xZ/KiLXMS94Juc=;\n\tb=DnVP/asjm4Z+yaVgIcJYnGrYd2j8UrIVQ22P/3O7sxQOteHwlWLCIKBD3tQhS9gi3Z\n\tYOvL375ie8ksCr2Bcb0V6SSd4HCRjllB/ruHjNJ/s/b6bf/HqOYr2eZ2bKslwIQpumR8\n\tUYW+CYJcPDFG26qh/EavVfwRXZdpsZc9y0B0ocozOMk9rV5aySFYcK69HoGfdBsJXd2u\n\tyKBD+7SOw0aeglEPZb1+gCvA3xHm4n/knxUUQULyBjimrbK3HDeJ/6K4ssKEjxvfAkC4\n\tWDBxJKHF12orAveHikEF/EvgsIz1H7reZIG9wJQL0Sl0ihnJQBGyAtLZxpRMcm6zZd8f\n\tBRvA==","X-Gm-Message-State":"AHPjjUgJWboLi57TThfxI/2WUSGXmRqJJ+Qxn4ny1f8YuSUB0mbtA/qt\n\tN+sUS4gL5d6jpN6A","X-Google-Smtp-Source":"ADKCNb45qyTeCSvF/LXaNJgEt4VhzbpIN7rb2xlSzZ+7MOWrKXeKX/1s3c5P04pUk+3Ijs1nhRTKbQ==","X-Received":"by 10.99.112.20 with SMTP id l20mr2663172pgc.146.1504275983551; \n\tFri, 01 Sep 2017 07:26:23 -0700 (PDT)","Date":"Fri, 1 Sep 2017 07:26:22 -0700","From":"Guenter Roeck <linux@roeck-us.net>","To":"Florian Eckert <fe@dev.tdt.de>","Cc":"robh+dt@kernel.org, mark.rutland@arm.com,\n\tdevicetree@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tlinux-hwmon@vger.kernel.org, jdelvare@suse.com","Subject":"Re: [PATCH v3 2/2] hwmon: (ltq-cputemp) add devicetree bindings\n\tdocumentation","Message-ID":"<20170901142622.GC599@roeck-us.net>","References":"<20170901065818.2037-1-fe@dev.tdt.de>\n\t<20170901065818.2037-2-fe@dev.tdt.de>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170901065818.2037-2-fe@dev.tdt.de>","User-Agent":"Mutt/1.5.24 (2015-08-30)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<devicetree.vger.kernel.org>","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1767219,"web_url":"http://patchwork.ozlabs.org/comment/1767219/","msgid":"<20170912162008.y2dp3llaikkp3l45@rob-hp-laptop>","list_archive_url":null,"date":"2017-09-12T16:20:08","subject":"Re: [PATCH v3 2/2] hwmon: (ltq-cputemp) add devicetree bindings\n\tdocumentation","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Fri, Sep 01, 2017 at 07:26:22AM -0700, Guenter Roeck wrote:\n> On Fri, Sep 01, 2017 at 08:58:18AM +0200, Florian Eckert wrote:\n> > Document the devicetree bindings for the ltq-cputemp\n> > \n> > Signed-off-by: Florian Eckert <fe@dev.tdt.de>\n> \n> I see nothing special with the bindings, and they are in line with other lantiq\n> bindings, so I am taking the risk of accepting this patch (and the matching\n> driver) without waiting for explicit approval from Rob. Rob, scream at me if\n> that is not ok.\n\nPerhaps the existing one was not well reviewed.\n\n> \n> Thanks,\n> Guenter\n> \n> > ---\n> >  Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt | 10 ++++++++++\n> >  1 file changed, 10 insertions(+)\n> >  create mode 100644 Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt\n> > \n> > diff --git a/Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt b/Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt\n> > new file mode 100644\n> > index 000000000000..33fd00a987c7\n> > --- /dev/null\n> > +++ b/Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt\n> > @@ -0,0 +1,10 @@\n> > +Lantiq cpu temperatur sensor\n\ns/temperatur/temperature/\n\n> > +\n> > +Requires node properties:\n> > +- compatible value :\n> > +\t\"lantiq,cputemp\"\n\nKind of non-specific. How is this device even accessed without any other \nproperty? \n\n> > +\n> > +Example:\n> > +\tcputemp@0 {\n\nunit-address without reg property is not valid.\n\n> > +\t\tcompatible = \"lantiq,cputemp\";\n> > +\t};\n> > -- \n> > 2.11.0\n> > \n> > --\n> > To unsubscribe from this list: send the line \"unsubscribe linux-hwmon\" in\n> > the body of a message to majordomo@vger.kernel.org\n> > More majordomo info at  http://vger.kernel.org/majordomo-info.html\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at  http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"<devicetree-owner@vger.kernel.org>","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xs94Y1cj1z9s7g\n\tfor <incoming-dt@patchwork.ozlabs.org>;\n\tWed, 13 Sep 2017 02:20:13 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751423AbdILQUL (ORCPT\n\t<rfc822;incoming-dt@patchwork.ozlabs.org>);\n\tTue, 12 Sep 2017 12:20:11 -0400","from mail-io0-f195.google.com ([209.85.223.195]:34189 \"EHLO\n\tmail-io0-f195.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751054AbdILQUK (ORCPT\n\t<rfc822; devicetree@vger.kernel.org>); Tue, 12 Sep 2017 12:20:10 -0400","by mail-io0-f195.google.com with SMTP id g32so7061303ioj.1;\n\tTue, 12 Sep 2017 09:20:10 -0700 (PDT)","from localhost (216-188-254-6.dyn.grandenetworks.net.\n\t[216.188.254.6]) by smtp.gmail.com with ESMTPSA id\n\tk3sm12387667oia.52.2017.09.12.09.20.09\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 12 Sep 2017 09:20:09 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=NXTbP/vDtS9YbeB9Swu5qZ1YGTBjDRS1Sd0nddFghuk=;\n\tb=qVla+o3DB0B8rSrTDmRxDAB0fE7PmIf7CgC0FPepfi95WwhewGVOUT8aNSF07y2BUJ\n\tD91TA7DXQZPa0pFv8tPSje5YvnhAho0Lse1cjv+F8pci4zIuSvZcY/MOB+pR4vprnBVC\n\tqCWUso1LgGack3WAIsdr0XVPwD2MSaZNMT45I9T2glK/jToyrTt+EeNjfb6Eay7KxZkC\n\tQBpUG/6OrSSGUwp0WW8G7jf9jT2SJ2XiUWLq5NTto2F/8gdh2T/diXiJa8j26o795El6\n\tszy74gEGNTWHQZxFu3Sz2IxfAgkmB+k8zw8ZQU8sySzobONlpx1yh7YEzm1fQECf74C+\n\tGz5g==","X-Gm-Message-State":"AHPjjUigLDsE8AxMqq02ORa0G5/QQVOhARx615EyulWRoSnmTct5dSn/\n\tAx2ze39fgWEW4mt9q6Q=","X-Google-Smtp-Source":"AOwi7QAsVNH+XbP4px7oQ/yxMmkKd5bCuygFdLBY18fyhWOMvg5pxah7Is9C4jg0bUJ/Mj40q+nStg==","X-Received":"by 10.202.171.87 with SMTP id u84mr14109463oie.321.1505233209815;\n\tTue, 12 Sep 2017 09:20:09 -0700 (PDT)","Date":"Tue, 12 Sep 2017 11:20:08 -0500","From":"Rob Herring <robh@kernel.org>","To":"Guenter Roeck <linux@roeck-us.net>","Cc":"Florian Eckert <fe@dev.tdt.de>, mark.rutland@arm.com,\n\tdevicetree@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tlinux-hwmon@vger.kernel.org, jdelvare@suse.com","Subject":"Re: [PATCH v3 2/2] hwmon: (ltq-cputemp) add devicetree bindings\n\tdocumentation","Message-ID":"<20170912162008.y2dp3llaikkp3l45@rob-hp-laptop>","References":"<20170901065818.2037-1-fe@dev.tdt.de>\n\t<20170901065818.2037-2-fe@dev.tdt.de>\n\t<20170901142622.GC599@roeck-us.net>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170901142622.GC599@roeck-us.net>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<devicetree.vger.kernel.org>","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1767581,"web_url":"http://patchwork.ozlabs.org/comment/1767581/","msgid":"<a5a2e95a1fb671eb59459542af122d6e@dev.tdt.de>","list_archive_url":null,"date":"2017-09-13T05:36:16","subject":"Re: [PATCH v3 2/2] hwmon: (ltq-cputemp) add devicetree bindings\n\tdocumentation","submitter":{"id":72238,"url":"http://patchwork.ozlabs.org/api/people/72238/","name":"Florian Eckert","email":"fe@dev.tdt.de"},"content":"Hello Rob\n\n>> > --- /dev/null\n>> > +++ b/Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt\n>> > @@ -0,0 +1,10 @@\n>> > +Lantiq cpu temperatur sensor\n> \n> s/temperatur/temperature/\n\nWill update this in a follow up page based on the old one. So no v4?\n\n> \n>> > +\n>> > +Requires node properties:\n>> > +- compatible value :\n>> > +\t\"lantiq,cputemp\"\n> \n> Kind of non-specific. How is this device even accessed without any \n> other\n> property?\n\nIt does not need any further properties. If this is set in the device \ntree then the driver is loaded.\nAfter loading the temperature could be read from \"/sys/class/hwmon\".\n\nLet me know what should i do to get this fixed?\n\nThanks for feedback\n\nFlorian\n\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at  http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"<devicetree-owner@vger.kernel.org>","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xsVlB5wjqz9ryT\n\tfor <incoming-dt@patchwork.ozlabs.org>;\n\tWed, 13 Sep 2017 15:36:22 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751369AbdIMFgU (ORCPT\n\t<rfc822;incoming-dt@patchwork.ozlabs.org>);\n\tWed, 13 Sep 2017 01:36:20 -0400","from ms.tdt.de ([195.243.126.94]:39797 \"EHLO mail.dev.tdt.de\"\n\trhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP\n\tid S1751056AbdIMFgT (ORCPT <rfc822;devicetree@vger.kernel.org>);\n\tWed, 13 Sep 2017 01:36:19 -0400","from mail.dev.tdt.de (localhost [IPv6:::1])\n\tby mail.dev.tdt.de (Postfix) with ESMTP id 8BD3C21953;\n\tWed, 13 Sep 2017 05:36:16 +0000 (UTC)"],"MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII;\n format=flowed","Content-Transfer-Encoding":"7bit","Date":"Wed, 13 Sep 2017 07:36:16 +0200","From":"Florian Eckert <fe@dev.tdt.de>","To":"Rob Herring <robh@kernel.org>","Cc":"Guenter Roeck <linux@roeck-us.net>, mark.rutland@arm.com,\n\tdevicetree@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tlinux-hwmon@vger.kernel.org, jdelvare@suse.com","Subject":"Re: [PATCH v3 2/2] hwmon: (ltq-cputemp) add devicetree bindings\n\tdocumentation","In-Reply-To":"<20170912162008.y2dp3llaikkp3l45@rob-hp-laptop>","References":"<20170901065818.2037-1-fe@dev.tdt.de>\n\t<20170901065818.2037-2-fe@dev.tdt.de>\n\t<20170901142622.GC599@roeck-us.net>\n\t<20170912162008.y2dp3llaikkp3l45@rob-hp-laptop>","Message-ID":"<a5a2e95a1fb671eb59459542af122d6e@dev.tdt.de>","X-Sender":"fe@dev.tdt.de","User-Agent":"Roundcube Webmail/1.1.5","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=ham\n\tautolearn_force=no version=3.4.0","X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on mail.dev.tdt.de","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<devicetree.vger.kernel.org>","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1767916,"web_url":"http://patchwork.ozlabs.org/comment/1767916/","msgid":"<20170913141234.GA27765@roeck-us.net>","list_archive_url":null,"date":"2017-09-13T14:12:34","subject":"Re: [PATCH v3 2/2] hwmon: (ltq-cputemp) add devicetree bindings\n\tdocumentation","submitter":{"id":21889,"url":"http://patchwork.ozlabs.org/api/people/21889/","name":"Guenter Roeck","email":"linux@roeck-us.net"},"content":"On Tue, Sep 12, 2017 at 11:20:08AM -0500, Rob Herring wrote:\n> On Fri, Sep 01, 2017 at 07:26:22AM -0700, Guenter Roeck wrote:\n> > On Fri, Sep 01, 2017 at 08:58:18AM +0200, Florian Eckert wrote:\n> > > Document the devicetree bindings for the ltq-cputemp\n> > > \n> > > Signed-off-by: Florian Eckert <fe@dev.tdt.de>\n> > \n> > I see nothing special with the bindings, and they are in line with other lantiq\n> > bindings, so I am taking the risk of accepting this patch (and the matching\n> > driver) without waiting for explicit approval from Rob. Rob, scream at me if\n> > that is not ok.\n> \n> Perhaps the existing one was not well reviewed.\n> \nBummer. Should teach me to never accept DT patches without your review.\nI owe you a beer or two.\n\nGuenter\n\n> > \n> > Thanks,\n> > Guenter\n> > \n> > > ---\n> > >  Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt | 10 ++++++++++\n> > >  1 file changed, 10 insertions(+)\n> > >  create mode 100644 Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt\n> > > \n> > > diff --git a/Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt b/Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt\n> > > new file mode 100644\n> > > index 000000000000..33fd00a987c7\n> > > --- /dev/null\n> > > +++ b/Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt\n> > > @@ -0,0 +1,10 @@\n> > > +Lantiq cpu temperatur sensor\n> \n> s/temperatur/temperature/\n> \n> > > +\n> > > +Requires node properties:\n> > > +- compatible value :\n> > > +\t\"lantiq,cputemp\"\n> \n> Kind of non-specific. How is this device even accessed without any other \n> property? \n> \n> > > +\n> > > +Example:\n> > > +\tcputemp@0 {\n> \n> unit-address without reg property is not valid.\n> \n> > > +\t\tcompatible = \"lantiq,cputemp\";\n> > > +\t};\n> > > -- \n> > > 2.11.0\n> > > \n> > > --\n> > > To unsubscribe from this list: send the line \"unsubscribe linux-hwmon\" in\n> > > the body of a message to majordomo@vger.kernel.org\n> > > More majordomo info at  http://vger.kernel.org/majordomo-info.html\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at  http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"<devicetree-owner@vger.kernel.org>","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"KDWVT/cs\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xskC91FQQz9sNr\n\tfor <incoming-dt@patchwork.ozlabs.org>;\n\tThu, 14 Sep 2017 00:12:53 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751106AbdIMOMj (ORCPT\n\t<rfc822;incoming-dt@patchwork.ozlabs.org>);\n\tWed, 13 Sep 2017 10:12:39 -0400","from mail-pg0-f68.google.com ([74.125.83.68]:38878 \"EHLO\n\tmail-pg0-f68.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751012AbdIMOMi (ORCPT\n\t<rfc822; devicetree@vger.kernel.org>); Wed, 13 Sep 2017 10:12:38 -0400","by mail-pg0-f68.google.com with SMTP id m30so154700pgn.5;\n\tWed, 13 Sep 2017 07:12:37 -0700 (PDT)","from localhost (108-223-40-66.lightspeed.sntcca.sbcglobal.net.\n\t[108.223.40.66]) by smtp.gmail.com with ESMTPSA id\n\tm24sm26822887pfj.28.2017.09.13.07.12.35\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 13 Sep 2017 07:12:35 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=GMDZfYPPNouB4uie4AzoYagk96RhLGrufLenq1pGTCk=;\n\tb=KDWVT/csCC3vvYRs8Fw0LOqRw6WoD4E6jM6FaWqDm3e+S80sQH6IcKP9y/KFIB8Uas\n\tGG0lrvaJfjpjOeKmsbgPx8uhBpfsD9EOhIzhEfMz7RMEOxDbpoZ9ioicKcYBtz6Th/tF\n\tdF0tJMgSOaj74TwItO0peIDrmL96eqImnD00meQe6t+iaa/z/mpWxRg1rRaiYqk5hIKU\n\tdFMmY80miR3EOKD5nurtu63wrDo4DGVFYznDXBE82bK0abSUEiN5PNhhBQhgWoZJIEIK\n\tn/T70IBak25y/6BffZUUPpn1nElQOtVlSsrrzh2osVygIWlU1fGUISbNz8UBUabaAjEy\n\taSxg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:date:from:to:cc:subject:message-id\n\t:references:mime-version:content-disposition:in-reply-to:user-agent; \n\tbh=GMDZfYPPNouB4uie4AzoYagk96RhLGrufLenq1pGTCk=;\n\tb=ORwn1XhnthWfo1D/65HvTQKOT1Cpuj/EAuchqfvBpqFUk93/oe1B5BhSG2elsQqCY+\n\tDUPzHOIKEfqdLEpeItaFBInpWrPq4giUm3fmLYKww90W9vPvsD9oj57D0Y0ED94ZYV8l\n\t4eAiKsmvT5GuPBZzEZn/QGO5X9W9ysqTJNWzKy/Owr3+xhxn5yiHsCNAgi6RzLcSsWME\n\tIkFA1GPAMX3oxQgO7O1/gKVDi+NUkqciimm2aIrQbZqDrgIx9b34q6F9TWUQNPKBD3Zj\n\tTVs87dNeDkJb2OvQ0zCiqrO2EqC9GKPOMBcxoKbUaZPPX5bwN+54d4Az8Kbg/fkVIbkW\n\tl+nA==","X-Gm-Message-State":"AHPjjUgdULChF9jAiQzgIsEA54/4YSrVDHYCo6hO0z9/7blcQzQlqZ5e\n\takavJW8D2/Zrag==","X-Google-Smtp-Source":"AOwi7QDDrYtl9OoHbxxpgxRqvB2ToRw7O4TgO3cNafg898kH1oKATSL2YdaCAAyyWIDEK8XXDtpwgw==","X-Received":"by 10.84.142.101 with SMTP id 92mr1300732plw.254.1505311957391; \n\tWed, 13 Sep 2017 07:12:37 -0700 (PDT)","Date":"Wed, 13 Sep 2017 07:12:34 -0700","From":"Guenter Roeck <linux@roeck-us.net>","To":"Rob Herring <robh@kernel.org>","Cc":"Florian Eckert <fe@dev.tdt.de>, mark.rutland@arm.com,\n\tdevicetree@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tlinux-hwmon@vger.kernel.org, jdelvare@suse.com","Subject":"Re: [PATCH v3 2/2] hwmon: (ltq-cputemp) add devicetree bindings\n\tdocumentation","Message-ID":"<20170913141234.GA27765@roeck-us.net>","References":"<20170901065818.2037-1-fe@dev.tdt.de>\n\t<20170901065818.2037-2-fe@dev.tdt.de>\n\t<20170901142622.GC599@roeck-us.net>\n\t<20170912162008.y2dp3llaikkp3l45@rob-hp-laptop>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170912162008.y2dp3llaikkp3l45@rob-hp-laptop>","User-Agent":"Mutt/1.5.24 (2015-08-30)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<devicetree.vger.kernel.org>","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1767917,"web_url":"http://patchwork.ozlabs.org/comment/1767917/","msgid":"<20170913141258.GB27765@roeck-us.net>","list_archive_url":null,"date":"2017-09-13T14:12:58","subject":"Re: [PATCH v3 2/2] hwmon: (ltq-cputemp) add devicetree bindings\n\tdocumentation","submitter":{"id":21889,"url":"http://patchwork.ozlabs.org/api/people/21889/","name":"Guenter Roeck","email":"linux@roeck-us.net"},"content":"On Wed, Sep 13, 2017 at 07:36:16AM +0200, Florian Eckert wrote:\n> Hello Rob\n> \n> >>> --- /dev/null\n> >>> +++ b/Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt\n> >>> @@ -0,0 +1,10 @@\n> >>> +Lantiq cpu temperatur sensor\n> >\n> >s/temperatur/temperature/\n> \n> Will update this in a follow up page based on the old one. So no v4?\n> \nPlease send a follow-up patch.\n\nThanks,\nGuenter\n\n> >\n> >>> +\n> >>> +Requires node properties:\n> >>> +- compatible value :\n> >>> +\t\"lantiq,cputemp\"\n> >\n> >Kind of non-specific. How is this device even accessed without any other\n> >property?\n> \n> It does not need any further properties. If this is set in the device tree\n> then the driver is loaded.\n> After loading the temperature could be read from \"/sys/class/hwmon\".\n> \n> Let me know what should i do to get this fixed?\n> \n> Thanks for feedback\n> \n> Florian\n> \n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at  http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"<devicetree-owner@vger.kernel.org>","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"vgfUPltA\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xskCL0gVMz9sNw\n\tfor <incoming-dt@patchwork.ozlabs.org>;\n\tThu, 14 Sep 2017 00:13:02 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751067AbdIMONA (ORCPT\n\t<rfc822;incoming-dt@patchwork.ozlabs.org>);\n\tWed, 13 Sep 2017 10:13:00 -0400","from mail-pf0-f196.google.com ([209.85.192.196]:34192 \"EHLO\n\tmail-pf0-f196.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751012AbdIMONA (ORCPT\n\t<rfc822; devicetree@vger.kernel.org>); Wed, 13 Sep 2017 10:13:00 -0400","by mail-pf0-f196.google.com with SMTP id g65so145679pfe.1;\n\tWed, 13 Sep 2017 07:12:59 -0700 (PDT)","from localhost (108-223-40-66.lightspeed.sntcca.sbcglobal.net.\n\t[108.223.40.66]) by smtp.gmail.com with ESMTPSA id\n\tj7sm23219713pfb.30.2017.09.13.07.12.58\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 13 Sep 2017 07:12:59 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=1ExgtIETFNaE3KJdpZm6iZTfd7B5W1isujtn7RQFnzI=;\n\tb=vgfUPltACfcBUJHmdPSfpQcJhgesCj43dkT+sC2Iu75ZZjCusGfH6yKRXtwHtsJcXw\n\t/Yrk8q3jsgbTP1NSzX6XLGP2NKxVrqMSXBTa+pZMFiiho2fSg5Jk9BjHISy4GvFz91Vj\n\twsuURUeh0ScA3GcsrhQzOt/ksVJWCu89aHZ/lvnk1Led1Gqup8pE9n+CyJs1KruTJq83\n\t5dU+p2L6h5QuNJsMyy12zB20DKClfRNeEoo7Qg7yAHiekvrlNxa/CKJmH2Qn78XOMnxj\n\thzkaR2IlZzOtBjDc8mOf998YzEtIectdNhpnt8NqC2qzqCs6uCAnYmHxa0MI/UjsLjMR\n\toWvg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:date:from:to:cc:subject:message-id\n\t:references:mime-version:content-disposition:in-reply-to:user-agent; \n\tbh=1ExgtIETFNaE3KJdpZm6iZTfd7B5W1isujtn7RQFnzI=;\n\tb=IYXH+U2kQa4Xv+4sxvcQZh8hMrtYQa8cfkW+VeovdlDlArgOb5war2XUw6aluOh9gX\n\tRrSID2Ztx7h+4uPlQLdwAFBgQfpIzZpkshB9pX4219noJdT2qUCvRM0PkBQE+FwI6Lut\n\tXgFYSoj/jDEYeu1h52OIy5w1GReuJN8NuwycTiPHSh9jtRt8vTI7SSPKJJU9nzfDYqg5\n\t3xmjbLR2AxVXGtE3W54MIFY3BwDJyqJfggb+GEa3odH+5io1tujxq/rQDoZWfaTi8jTQ\n\tl3z4bWU5kgYPzwRrv034Eel+OX2LuVT05VCnSML0bziln1ss7Kg6JYJXrCaRlYmJY3+h\n\tWYLA==","X-Gm-Message-State":"AHPjjUg0EpSZi4wYRqz5amoy+XtESBRTsHq65QGDdk/54tUBM0TRKs1v\n\tmff/9IB238yI3A==","X-Google-Smtp-Source":"ADKCNb58W5tIOHJLNiDKEpANv7NGUonqnDvF0UgBcvaKZtW1Q9nHpq3kpIouzNocp7l+nc1bvORGvA==","X-Received":"by 10.84.217.27 with SMTP id o27mr20829984pli.339.1505311979566; \n\tWed, 13 Sep 2017 07:12:59 -0700 (PDT)","Date":"Wed, 13 Sep 2017 07:12:58 -0700","From":"Guenter Roeck <linux@roeck-us.net>","To":"Florian Eckert <fe@dev.tdt.de>","Cc":"Rob Herring <robh@kernel.org>, mark.rutland@arm.com,\n\tdevicetree@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tlinux-hwmon@vger.kernel.org, jdelvare@suse.com","Subject":"Re: [PATCH v3 2/2] hwmon: (ltq-cputemp) add devicetree bindings\n\tdocumentation","Message-ID":"<20170913141258.GB27765@roeck-us.net>","References":"<20170901065818.2037-1-fe@dev.tdt.de>\n\t<20170901065818.2037-2-fe@dev.tdt.de>\n\t<20170901142622.GC599@roeck-us.net>\n\t<20170912162008.y2dp3llaikkp3l45@rob-hp-laptop>\n\t<a5a2e95a1fb671eb59459542af122d6e@dev.tdt.de>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<a5a2e95a1fb671eb59459542af122d6e@dev.tdt.de>","User-Agent":"Mutt/1.5.24 (2015-08-30)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<devicetree.vger.kernel.org>","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1767938,"web_url":"http://patchwork.ozlabs.org/comment/1767938/","msgid":"<5da3b25f6eec79f103ef880100a403f7@dev.tdt.de>","list_archive_url":null,"date":"2017-09-13T14:42:33","subject":"Re: [PATCH v3 2/2] hwmon: (ltq-cputemp) add devicetree bindings\n\tdocumentation","submitter":{"id":72238,"url":"http://patchwork.ozlabs.org/api/people/72238/","name":"Florian Eckert","email":"fe@dev.tdt.de"},"content":">> >\n>> >>> +\n>> >>> +Requires node properties:\n>> >>> +- compatible value :\n>> >>> +\t\"lantiq,cputemp\"\n>> >\n>> >Kind of non-specific. How is this device even accessed without any other\n>> >property?\n>> \n>> It does not need any further properties. If this is set in the device \n>> tree\n>> then the driver is loaded.\n>> After loading the temperature could be read from \"/sys/class/hwmon\".\n>> Let me know what should i do to get this fixed?\n>> \n\nWhat about with this is this OK from your side or do I have do to \nsomething?\nSo I only update \"s/temperatur/temperature/\" with an follow-up patch \nbased the current linux-next tree?\n\nThanks\n\nFlorian\n\n\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at  http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"<devicetree-owner@vger.kernel.org>","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xsksV1Cngz9sNr\n\tfor <incoming-dt@patchwork.ozlabs.org>;\n\tThu, 14 Sep 2017 00:42:38 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751442AbdIMOmg (ORCPT\n\t<rfc822;incoming-dt@patchwork.ozlabs.org>);\n\tWed, 13 Sep 2017 10:42:36 -0400","from ms.tdt.de ([195.243.126.94]:40771 \"EHLO mail.dev.tdt.de\"\n\trhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP\n\tid S1750999AbdIMOmf (ORCPT <rfc822;devicetree@vger.kernel.org>);\n\tWed, 13 Sep 2017 10:42:35 -0400","from mail.dev.tdt.de (localhost [IPv6:::1])\n\tby mail.dev.tdt.de (Postfix) with ESMTP id 9344721699;\n\tWed, 13 Sep 2017 14:42:33 +0000 (UTC)"],"MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII;\n format=flowed","Content-Transfer-Encoding":"7bit","Date":"Wed, 13 Sep 2017 16:42:33 +0200","From":"Florian Eckert <fe@dev.tdt.de>","To":"Guenter Roeck <linux@roeck-us.net>, Rob Herring <robh@kernel.org>","Cc":"mark.rutland@arm.com, devicetree@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,\n\tjdelvare@suse.com, Guenter Roeck <groeck7@gmail.com>","Subject":"Re: [PATCH v3 2/2] hwmon: (ltq-cputemp) add devicetree bindings\n\tdocumentation","In-Reply-To":"<20170913141258.GB27765@roeck-us.net>","References":"<20170901065818.2037-1-fe@dev.tdt.de>\n\t<20170901065818.2037-2-fe@dev.tdt.de>\n\t<20170901142622.GC599@roeck-us.net>\n\t<20170912162008.y2dp3llaikkp3l45@rob-hp-laptop>\n\t<a5a2e95a1fb671eb59459542af122d6e@dev.tdt.de>\n\t<20170913141258.GB27765@roeck-us.net>","Message-ID":"<5da3b25f6eec79f103ef880100a403f7@dev.tdt.de>","X-Sender":"fe@dev.tdt.de","User-Agent":"Roundcube Webmail/1.1.5","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=ham\n\tautolearn_force=no version=3.4.0","X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on mail.dev.tdt.de","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<devicetree.vger.kernel.org>","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1767961,"web_url":"http://patchwork.ozlabs.org/comment/1767961/","msgid":"<20170913151234.GH27765@roeck-us.net>","list_archive_url":null,"date":"2017-09-13T15:12:34","subject":"Re: [PATCH v3 2/2] hwmon: (ltq-cputemp) add devicetree bindings\n\tdocumentation","submitter":{"id":21889,"url":"http://patchwork.ozlabs.org/api/people/21889/","name":"Guenter Roeck","email":"linux@roeck-us.net"},"content":"On Wed, Sep 13, 2017 at 04:42:33PM +0200, Florian Eckert wrote:\n> >>>\n> >>>>> +\n> >>>>> +Requires node properties:\n> >>>>> +- compatible value :\n> >>>>> +\t\"lantiq,cputemp\"\n> >>>\n> >>>Kind of non-specific. How is this device even accessed without any other\n> >>>property?\n> >>\n> >>It does not need any further properties. If this is set in the device\n> >>tree\n> >>then the driver is loaded.\n> >>After loading the temperature could be read from \"/sys/class/hwmon\".\n> >>Let me know what should i do to get this fixed?\n> >>\n> \n> What about with this is this OK from your side or do I have do to something?\n> So I only update \"s/temperatur/temperature/\" with an follow-up patch based\n> the current linux-next tree?\n> \n\nAlso s/cputemp@0/cputemp/ if I understand Rob's comment correctly.\n\nQuestion for Rob: The driver checks the SOC version and bails out\nif the version is not vr9 v1.2. Should that be expressed in DT ?\n\nGuenter\n\n> Thanks\n> \n> Florian\n> \n> \n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at  http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"<devicetree-owner@vger.kernel.org>","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"jDnEF6P/\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xslXR0x6nz9sPk\n\tfor <incoming-dt@patchwork.ozlabs.org>;\n\tThu, 14 Sep 2017 01:12:55 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752222AbdIMPMk (ORCPT\n\t<rfc822;incoming-dt@patchwork.ozlabs.org>);\n\tWed, 13 Sep 2017 11:12:40 -0400","from mail-pg0-f65.google.com ([74.125.83.65]:35060 \"EHLO\n\tmail-pg0-f65.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752059AbdIMPMh (ORCPT\n\t<rfc822; devicetree@vger.kernel.org>); Wed, 13 Sep 2017 11:12:37 -0400","by mail-pg0-f65.google.com with SMTP id j16so239007pga.2;\n\tWed, 13 Sep 2017 08:12:36 -0700 (PDT)","from localhost (108-223-40-66.lightspeed.sntcca.sbcglobal.net.\n\t[108.223.40.66]) by smtp.gmail.com with ESMTPSA id\n\ts1sm25463911pfk.27.2017.09.13.08.12.35\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 13 Sep 2017 08:12:35 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=x1K0ORdg98l02upclWjnxIVYMKpQNHe7sLRURfNIEuE=;\n\tb=jDnEF6P/Z9yi3qS0NKACVw/wSW07fFPj298JoxXJpZVaRH8gbNG9Dq4xvc2VmRhJXa\n\tkHJxs26UpCjalIWZws7+ID/GK65gTwTa7Q3+tVwC9pN3cTQquXjnCa8C67qBo7u7iHq9\n\tX5CCJd6ukYRuYtb7KP4ZTsKhks/RkcMIL5S/0BkKthIQAZp3IS+t6BKGobtgnW5yYyt9\n\tBwen6fLSY5VKwRw2oBIiuWDpwoo1Y7XX4LPzYixvcxVrqfNbNIjsS/7oHFrloGsNsRMk\n\t8WLBkbKopq/98MsfMb7ZszvgOYMv47vZOKbaRKdUcHv+XIUQtLiKGr0sgdyYuiFirfwQ\n\tYf5Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:date:from:to:cc:subject:message-id\n\t:references:mime-version:content-disposition:in-reply-to:user-agent; \n\tbh=x1K0ORdg98l02upclWjnxIVYMKpQNHe7sLRURfNIEuE=;\n\tb=n4mvc/US5jt8BHhOMKnEoF3fYSDTMj6sjiRKy+FhC4wqd9vdNS8zqZTY0rcNPTh7M1\n\tE5dBjZKF585Yj76twlQOjdtb22AzpfeTs1SAbrP/4SqT2NcgYqXcw38Tzxw8Wn/JuUgO\n\tU55itaKVEE6jHCgLvi3Yt3BSGFRdJ5Hyj5dXbPFlFpySbsexlQZOLq3qubsSAhQ9JNwP\n\tP0EaGztKTneBOu6cV/pWALOCwCsV7DPTCpvHCp73LT9XuRIWmYMVsH/wjAoFJdyctNw4\n\tumkNS8taByycwj8rYeV0M23NQFQ6T+kPb1JS/K1jXFAiEA7vrsF0Q+SFcpuKxE9BmUhg\n\tfvCA==","X-Gm-Message-State":"AHPjjUiB7R+c3V2LKk722bRdVPyNHHEcG1uxJez0HOZDC+fFqegyv7jj\n\tGqXsiYSMQLPsJw==","X-Google-Smtp-Source":"ADKCNb6ClJtceVCsh38u94rLcbCtR3ZmcOt9S0lrlYeGOMFAUOm7Vzns/rFzin+Fu48kLh+Rh0X43w==","X-Received":"by 10.99.61.143 with SMTP id k137mr17786254pga.389.1505315556549;\n\tWed, 13 Sep 2017 08:12:36 -0700 (PDT)","Date":"Wed, 13 Sep 2017 08:12:34 -0700","From":"Guenter Roeck <linux@roeck-us.net>","To":"Florian Eckert <fe@dev.tdt.de>","Cc":"Rob Herring <robh@kernel.org>, mark.rutland@arm.com,\n\tdevicetree@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tlinux-hwmon@vger.kernel.org, jdelvare@suse.com,\n\tGuenter Roeck <groeck7@gmail.com>","Subject":"Re: [PATCH v3 2/2] hwmon: (ltq-cputemp) add devicetree bindings\n\tdocumentation","Message-ID":"<20170913151234.GH27765@roeck-us.net>","References":"<20170901065818.2037-1-fe@dev.tdt.de>\n\t<20170901065818.2037-2-fe@dev.tdt.de>\n\t<20170901142622.GC599@roeck-us.net>\n\t<20170912162008.y2dp3llaikkp3l45@rob-hp-laptop>\n\t<a5a2e95a1fb671eb59459542af122d6e@dev.tdt.de>\n\t<20170913141258.GB27765@roeck-us.net>\n\t<5da3b25f6eec79f103ef880100a403f7@dev.tdt.de>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<5da3b25f6eec79f103ef880100a403f7@dev.tdt.de>","User-Agent":"Mutt/1.5.24 (2015-08-30)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<devicetree.vger.kernel.org>","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1767969,"web_url":"http://patchwork.ozlabs.org/comment/1767969/","msgid":"<CAL_Jsq+udc2p_jqQN+m4R69zW=7RBfJCDrQgNXOiMycErP43LQ@mail.gmail.com>","list_archive_url":null,"date":"2017-09-13T15:25:51","subject":"Re: [PATCH v3 2/2] hwmon: (ltq-cputemp) add devicetree bindings\n\tdocumentation","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Wed, Sep 13, 2017 at 12:36 AM, Florian Eckert <fe@dev.tdt.de> wrote:\n> Hello Rob\n>\n>>> > --- /dev/null\n>>> > +++ b/Documentation/devicetree/bindings/hwmon/ltq-cputemp.txt\n>>> > @@ -0,0 +1,10 @@\n>>> > +Lantiq cpu temperatur sensor\n>>\n>>\n>> s/temperatur/temperature/\n>\n>\n> Will update this in a follow up page based on the old one. So no v4?\n>\n>>\n>>> > +\n>>> > +Requires node properties:\n>>> > +- compatible value :\n>>> > +     \"lantiq,cputemp\"\n>>\n>>\n>> Kind of non-specific. How is this device even accessed without any other\n>> property?\n>\n>\n> It does not need any further properties. If this is set in the device tree\n> then the driver is loaded.\n\nDT is not the only way to instantiate drivers.\n\nWhat I meant is how do you access the hardware? That should be evident\nfrom the binding and it is not.\n\nLooking at the driver, you have some memory mapped system control\nregisters which get ioremapped in arch/mips/lantiq/xway/sysctrl.c and\naccesses thru some platform specific macros. That is not the ideal way\nto do things as we use syscon and regmap for such things. But that's\nall mostly kernel details not so relevant to the DT binding.\n\nFor DT, I'd expect this is a child node of the sysctrl block with a\nreg property value of <0x40 4> (along with any other child devices).\nYou could also not even put this in DT and the system controller can\nhave it's own driver that instantiates the child device for this\ndriver.\n\nRob\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at  http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"<devicetree-owner@vger.kernel.org>","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=<UNKNOWN>)","mail.kernel.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.org","mail.kernel.org;\n\tspf=none smtp.mailfrom=robh@kernel.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xslqr4mVGz9sPk\n\tfor <incoming-dt@patchwork.ozlabs.org>;\n\tThu, 14 Sep 2017 01:26:16 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751870AbdIMP0O (ORCPT\n\t<rfc822;incoming-dt@patchwork.ozlabs.org>);\n\tWed, 13 Sep 2017 11:26:14 -0400","from mail.kernel.org ([198.145.29.99]:51618 \"EHLO mail.kernel.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751800AbdIMP0O (ORCPT <rfc822;devicetree@vger.kernel.org>);\n\tWed, 13 Sep 2017 11:26:14 -0400","from mail-qt0-f171.google.com (mail-qt0-f171.google.com\n\t[209.85.216.171])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id 87A7C21D28;\n\tWed, 13 Sep 2017 15:26:13 +0000 (UTC)","by mail-qt0-f171.google.com with SMTP id b1so1397309qtc.4;\n\tWed, 13 Sep 2017 08:26:13 -0700 (PDT)","by 10.12.209.75 with HTTP; Wed, 13 Sep 2017 08:25:51 -0700 (PDT)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mail.kernel.org 87A7C21D28","X-Gm-Message-State":"AHPjjUhGkVqNt58ULoUSWLyK4AS14SArWJsWyiv3snwI5A5hqkDU5uXD\n\tPjKOD6Nz6PeQAdx6iNMMMECF0wT85mu2ta1MWQ==","X-Google-Smtp-Source":"AOwi7QBnu+2X68/3o5cIzIttSgFuPxg8Ql9FzH4/RGpgLPmQpZJBL/BA4IMYw9rirTEzEwbJJG76A7gjr0gq4Kee47o=","X-Received":"by 10.200.44.107 with SMTP id e40mr24946722qta.262.1505316372658;\n\tWed, 13 Sep 2017 08:26:12 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<a5a2e95a1fb671eb59459542af122d6e@dev.tdt.de>","References":"<20170901065818.2037-1-fe@dev.tdt.de>\n\t<20170901065818.2037-2-fe@dev.tdt.de>\n\t<20170901142622.GC599@roeck-us.net>\n\t<20170912162008.y2dp3llaikkp3l45@rob-hp-laptop>\n\t<a5a2e95a1fb671eb59459542af122d6e@dev.tdt.de>","From":"Rob Herring <robh@kernel.org>","Date":"Wed, 13 Sep 2017 10:25:51 -0500","X-Gmail-Original-Message-ID":"<CAL_Jsq+udc2p_jqQN+m4R69zW=7RBfJCDrQgNXOiMycErP43LQ@mail.gmail.com>","Message-ID":"<CAL_Jsq+udc2p_jqQN+m4R69zW=7RBfJCDrQgNXOiMycErP43LQ@mail.gmail.com>","Subject":"Re: [PATCH v3 2/2] hwmon: (ltq-cputemp) add devicetree bindings\n\tdocumentation","To":"Florian Eckert <fe@dev.tdt.de>","Cc":"Guenter Roeck <linux@roeck-us.net>, Mark Rutland <mark.rutland@arm.com>, \n\t\"devicetree@vger.kernel.org\" <devicetree@vger.kernel.org>,\n\t\"linux-kernel@vger.kernel.org\" <linux-kernel@vger.kernel.org>,\n\tLinux HWMON List <linux-hwmon@vger.kernel.org>,\n\tJean Delvare <jdelvare@suse.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<devicetree.vger.kernel.org>","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1768371,"web_url":"http://patchwork.ozlabs.org/comment/1768371/","msgid":"<b6c6310ff0fde9d0df29a57fcd229591@dev.tdt.de>","list_archive_url":null,"date":"2017-09-14T07:06:30","subject":"Re: [PATCH v3 2/2] hwmon: (ltq-cputemp) add devicetree bindings\n\tdocumentation","submitter":{"id":72238,"url":"http://patchwork.ozlabs.org/api/people/72238/","name":"Florian Eckert","email":"fe@dev.tdt.de"},"content":"Hello Rob\n\n>>>> > +\n>>>> > +Requires node properties:\n>>>> > +- compatible value :\n>>>> > +     \"lantiq,cputemp\"\n>>> \n>>> \n>>> Kind of non-specific. How is this device even accessed without any \n>>> other\n>>> property?\n>> \n>> \n>> It does not need any further properties. If this is set in the device \n>> tree\n>> then the driver is loaded.\n> \n> DT is not the only way to instantiate drivers.\n> \n> What I meant is how do you access the hardware? That should be evident\n> from the binding and it is not.\n\nAgree with our statement.\n\n> \n> Looking at the driver, you have some memory mapped system control\n> registers which get ioremapped in arch/mips/lantiq/xway/sysctrl.c and\n> accesses thru some platform specific macros. That is not the ideal way\n> to do things as we use syscon and regmap for such things. But that's\n> all mostly kernel details not so relevant to the DT binding.\n\nFor lanitq xrx200 this is all i have. So if i have to use syscon and \nregmap i am also not sure how to handle this.\n\n> For DT, I'd expect this is a child node of the sysctrl block with a\n> reg property value of <0x40 4> (along with any other child devices).\n> You could also not even put this in DT and the system controller can\n> have it's own driver that instantiates the child device for this\n> driver.\n\nYes this would be the best practice. But the hardware designer for what \never reason\nplaced the Register for the temperature sensors into the CGU (Clock \nGeneration Unit) section!\nAnd the Register is also shared with some other stuff which is not only \nassign for temperature\nstuff! I am not sure how to handle this in the device tree.\n\nThis is a Register description extract from the data sheet\n\nGPHY Configuration Register 01\nThis register configures the booting options of GPHY1 IP.\n\nOffset 0x0040\nReset Value 0x01FC0000\n\n31: RES\n30: 100FX_H\n29: 100FX_F\n28: 10BT_F\n27: 10BT_H\n26: 100BT_F\n25: 100BT_H\n24: 1000BT_F\n23: 1000BT_H\n22: RES\n21: RES\n19: TEMP_PD <--- NEEDED Power down the Temperature Sensor\n18: TEMP_HL <--- NEEDED Indicate temperature higher than 128 C\n17: TEMP    <--- NEEDED Value\n16: TEMP    <--- NEEDED Value\n15: TEMP    <--- NEEDED Value\n14: TEMP    <--- NEEDED Value\n13: TEMP    <--- NEEDED Value\n12: TEMP    <--- NEEDED Value\n11: TEMP    <--- NEEDED Value\n10: TEMP    <--- NEEDED Value\n09: TEMP    <--- NEEDED Value\n08: RES\n07: RES\n06: SPI_Delay\n05: SPI_Delay\n04: AHB_EnD\n03: DMA_OR\n02: RES\n01: RES\n00: RES\n\nAnd that is a dts tree from LEDE/Openwrt for lantiq\nURL:\nhttps://github.com/lede-project/source/blob/c88770c766fdc5599efc4672bca230017f52e8e4/target/linux/lantiq/dts/vr9.dtsi#L54\n\nExtraction:\n\tsram@1F000000 {\n\t\t#address-cells = <1>;\n\t\t#size-cells = <1>;\n\t\tcompatible = \"lantiq,sram\", \"simple-bus\";\n\t\treg = <0x1F000000 0x800000>;\n\t\tranges = <0x0 0x1F000000 0x7FFFFF>;\n\n\t\teiu0: eiu@101000 {\n\t\t\t#interrupt-cells = <1>;\n\t\t\tinterrupt-controller;\n\t\t\tcompatible = \"lantiq,eiu-xway\";\n\t\t\treg = <0x101000 0x1000>;\n\t\t\tinterrupt-parent = <&icu0>;\n\t\t\tlantiq,eiu-irqs = <166 135 66 40 41 42>;\n\t\t};\n\n\t\tpmu0: pmu@102000 {\n\t\t\tcompatible = \"lantiq,pmu-xway\";\n\t\t\treg = <0x102000 0x1000>;\n\t\t};\n\n\t\tcgu0: cgu@103000 {\n\t\t\tcompatible = \"lantiq,cgu-xway\";\n\t\t\treg = <0x103000 0x1000>;\n-> This is the place to add the binding?\n\t\t};\n\nSorry for the noise but i am unsure how to do this.\nThanks for help\n\nFlorian\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at  http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"<devicetree-owner@vger.kernel.org>","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xt8hr0jBYz9t1t\n\tfor <incoming-dt@patchwork.ozlabs.org>;\n\tThu, 14 Sep 2017 17:06:36 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751174AbdINHGe (ORCPT\n\t<rfc822;incoming-dt@patchwork.ozlabs.org>);\n\tThu, 14 Sep 2017 03:06:34 -0400","from ms.tdt.de ([195.243.126.94]:42307 \"EHLO mail.dev.tdt.de\"\n\trhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP\n\tid S1751132AbdINHGd (ORCPT <rfc822;devicetree@vger.kernel.org>);\n\tThu, 14 Sep 2017 03:06:33 -0400","from mail.dev.tdt.de (localhost [IPv6:::1])\n\tby mail.dev.tdt.de (Postfix) with ESMTP id 98A95200C0;\n\tThu, 14 Sep 2017 07:06:30 +0000 (UTC)"],"MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII;\n format=flowed","Content-Transfer-Encoding":"7bit","Date":"Thu, 14 Sep 2017 09:06:30 +0200","From":"Florian Eckert <fe@dev.tdt.de>","To":"Rob Herring <robh@kernel.org>","Cc":"Guenter Roeck <linux@roeck-us.net>, Mark Rutland <mark.rutland@arm.com>, \n\tdevicetree@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tLinux HWMON List <linux-hwmon@vger.kernel.org>,\n\tJean Delvare <jdelvare@suse.com>","Subject":"Re: [PATCH v3 2/2] hwmon: (ltq-cputemp) add devicetree bindings\n\tdocumentation","In-Reply-To":"<CAL_Jsq+udc2p_jqQN+m4R69zW=7RBfJCDrQgNXOiMycErP43LQ@mail.gmail.com>","References":"<20170901065818.2037-1-fe@dev.tdt.de>\n\t<20170901065818.2037-2-fe@dev.tdt.de>\n\t<20170901142622.GC599@roeck-us.net>\n\t<20170912162008.y2dp3llaikkp3l45@rob-hp-laptop>\n\t<a5a2e95a1fb671eb59459542af122d6e@dev.tdt.de>\n\t<CAL_Jsq+udc2p_jqQN+m4R69zW=7RBfJCDrQgNXOiMycErP43LQ@mail.gmail.com>","Message-ID":"<b6c6310ff0fde9d0df29a57fcd229591@dev.tdt.de>","X-Sender":"fe@dev.tdt.de","User-Agent":"Roundcube Webmail/1.1.5","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,URIBL_BLOCKED\n\tautolearn=ham autolearn_force=no version=3.4.0","X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on mail.dev.tdt.de","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<devicetree.vger.kernel.org>","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1771520,"web_url":"http://patchwork.ozlabs.org/comment/1771520/","msgid":"<CAL_JsqKKqTdHCxf-rbg4FN_JxtDVmm9KXW7HgjRm-kHWT7bjdg@mail.gmail.com>","list_archive_url":null,"date":"2017-09-20T02:53:41","subject":"Re: [PATCH v3 2/2] hwmon: (ltq-cputemp) add devicetree bindings\n\tdocumentation","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Thu, Sep 14, 2017 at 2:06 AM, Florian Eckert <fe@dev.tdt.de> wrote:\n> Hello Rob\n>\n>>>>> > +\n>>>>> > +Requires node properties:\n>>>>> > +- compatible value :\n>>>>> > +     \"lantiq,cputemp\"\n>>>>\n>>>>\n>>>>\n>>>> Kind of non-specific. How is this device even accessed without any other\n>>>> property?\n>>>\n>>>\n>>>\n>>> It does not need any further properties. If this is set in the device\n>>> tree\n>>> then the driver is loaded.\n>>\n>>\n>> DT is not the only way to instantiate drivers.\n>>\n>> What I meant is how do you access the hardware? That should be evident\n>> from the binding and it is not.\n>\n>\n> Agree with our statement.\n>\n>>\n>> Looking at the driver, you have some memory mapped system control\n>> registers which get ioremapped in arch/mips/lantiq/xway/sysctrl.c and\n>> accesses thru some platform specific macros. That is not the ideal way\n>> to do things as we use syscon and regmap for such things. But that's\n>> all mostly kernel details not so relevant to the DT binding.\n>\n>\n> For lanitq xrx200 this is all i have. So if i have to use syscon and regmap\n> i am also not sure how to handle this.\n>\n>> For DT, I'd expect this is a child node of the sysctrl block with a\n>> reg property value of <0x40 4> (along with any other child devices).\n>> You could also not even put this in DT and the system controller can\n>> have it's own driver that instantiates the child device for this\n>> driver.\n>\n>\n> Yes this would be the best practice. But the hardware designer for what ever\n> reason\n> placed the Register for the temperature sensors into the CGU (Clock\n> Generation Unit) section!\n> And the Register is also shared with some other stuff which is not only\n> assign for temperature\n> stuff! I am not sure how to handle this in the device tree.\n\nThis is quite common and there are plenty of examples. Look for\nbindings with \"syscon\".\n\n>\n> This is a Register description extract from the data sheet\n>\n> GPHY Configuration Register 01\n> This register configures the booting options of GPHY1 IP.\n>\n> Offset 0x0040\n> Reset Value 0x01FC0000\n>\n> 31: RES\n> 30: 100FX_H\n> 29: 100FX_F\n> 28: 10BT_F\n> 27: 10BT_H\n> 26: 100BT_F\n> 25: 100BT_H\n> 24: 1000BT_F\n> 23: 1000BT_H\n> 22: RES\n> 21: RES\n> 19: TEMP_PD <--- NEEDED Power down the Temperature Sensor\n> 18: TEMP_HL <--- NEEDED Indicate temperature higher than 128 C\n> 17: TEMP    <--- NEEDED Value\n> 16: TEMP    <--- NEEDED Value\n> 15: TEMP    <--- NEEDED Value\n> 14: TEMP    <--- NEEDED Value\n> 13: TEMP    <--- NEEDED Value\n> 12: TEMP    <--- NEEDED Value\n> 11: TEMP    <--- NEEDED Value\n> 10: TEMP    <--- NEEDED Value\n> 09: TEMP    <--- NEEDED Value\n> 08: RES\n> 07: RES\n> 06: SPI_Delay\n> 05: SPI_Delay\n> 04: AHB_EnD\n> 03: DMA_OR\n> 02: RES\n> 01: RES\n> 00: RES\n>\n> And that is a dts tree from LEDE/Openwrt for lantiq\n> URL:\n> https://github.com/lede-project/source/blob/c88770c766fdc5599efc4672bca230017f52e8e4/target/linux/lantiq/dts/vr9.dtsi#L54\n>\n> Extraction:\n>         sram@1F000000 {\n>                 #address-cells = <1>;\n>                 #size-cells = <1>;\n>                 compatible = \"lantiq,sram\", \"simple-bus\";\n>                 reg = <0x1F000000 0x800000>;\n>                 ranges = <0x0 0x1F000000 0x7FFFFF>;\n>\n>                 eiu0: eiu@101000 {\n>                         #interrupt-cells = <1>;\n>                         interrupt-controller;\n>                         compatible = \"lantiq,eiu-xway\";\n>                         reg = <0x101000 0x1000>;\n>                         interrupt-parent = <&icu0>;\n>                         lantiq,eiu-irqs = <166 135 66 40 41 42>;\n>                 };\n>\n>                 pmu0: pmu@102000 {\n>                         compatible = \"lantiq,pmu-xway\";\n>                         reg = <0x102000 0x1000>;\n>                 };\n>\n>                 cgu0: cgu@103000 {\n>                         compatible = \"lantiq,cgu-xway\";\n>                         reg = <0x103000 0x1000>;\n> -> This is the place to add the binding?\n\nYes.\n\n>                 };\n>\n> Sorry for the noise but i am unsure how to do this.\n> Thanks for help\n>\n> Florian\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at  http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"<devicetree-owner@vger.kernel.org>","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=<UNKNOWN>)","mail.kernel.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.org","mail.kernel.org;\n\tspf=none smtp.mailfrom=robh@kernel.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxkpk2mr2z9s78\n\tfor <incoming-dt@patchwork.ozlabs.org>;\n\tWed, 20 Sep 2017 12:54:06 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751341AbdITCyE (ORCPT\n\t<rfc822;incoming-dt@patchwork.ozlabs.org>);\n\tTue, 19 Sep 2017 22:54:04 -0400","from mail.kernel.org ([198.145.29.99]:39764 \"EHLO mail.kernel.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751343AbdITCyD (ORCPT <rfc822;devicetree@vger.kernel.org>);\n\tTue, 19 Sep 2017 22:54:03 -0400","from mail-qt0-f181.google.com (mail-qt0-f181.google.com\n\t[209.85.216.181])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id B293821C9B;\n\tWed, 20 Sep 2017 02:54:02 +0000 (UTC)","by mail-qt0-f181.google.com with SMTP id 47so1531849qts.10;\n\tTue, 19 Sep 2017 19:54:02 -0700 (PDT)","by 10.12.209.75 with HTTP; Tue, 19 Sep 2017 19:53:41 -0700 (PDT)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mail.kernel.org B293821C9B","X-Gm-Message-State":"AHPjjUi2L/oyGHGiIdWsoyLA2GRF10rK86EQ9a/Ik5b2OOJhdGnTUM5s\n\tRnSBo3TQJTjdG1F58aZFdqZPbhvGH0Gfgn6Phg==","X-Google-Smtp-Source":"AOwi7QA8TSbBNaIMY8bJ0rHGEY92DAAMTteAtBu9pNUT8242wTvmClr9G9N4TUwLjmnco958B9pjjLlP936XmAIKz5A=","X-Received":"by 10.200.56.252 with SMTP id g57mr5140706qtc.322.1505876041840; \n\tTue, 19 Sep 2017 19:54:01 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<b6c6310ff0fde9d0df29a57fcd229591@dev.tdt.de>","References":"<20170901065818.2037-1-fe@dev.tdt.de>\n\t<20170901065818.2037-2-fe@dev.tdt.de>\n\t<20170901142622.GC599@roeck-us.net>\n\t<20170912162008.y2dp3llaikkp3l45@rob-hp-laptop>\n\t<a5a2e95a1fb671eb59459542af122d6e@dev.tdt.de>\n\t<CAL_Jsq+udc2p_jqQN+m4R69zW=7RBfJCDrQgNXOiMycErP43LQ@mail.gmail.com>\n\t<b6c6310ff0fde9d0df29a57fcd229591@dev.tdt.de>","From":"Rob Herring <robh@kernel.org>","Date":"Tue, 19 Sep 2017 21:53:41 -0500","X-Gmail-Original-Message-ID":"<CAL_JsqKKqTdHCxf-rbg4FN_JxtDVmm9KXW7HgjRm-kHWT7bjdg@mail.gmail.com>","Message-ID":"<CAL_JsqKKqTdHCxf-rbg4FN_JxtDVmm9KXW7HgjRm-kHWT7bjdg@mail.gmail.com>","Subject":"Re: [PATCH v3 2/2] hwmon: (ltq-cputemp) add devicetree bindings\n\tdocumentation","To":"Florian Eckert <fe@dev.tdt.de>","Cc":"Guenter Roeck <linux@roeck-us.net>, Mark Rutland <mark.rutland@arm.com>, \n\t\"devicetree@vger.kernel.org\" <devicetree@vger.kernel.org>,\n\t\"linux-kernel@vger.kernel.org\" <linux-kernel@vger.kernel.org>,\n\tLinux HWMON List <linux-hwmon@vger.kernel.org>,\n\tJean Delvare <jdelvare@suse.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<devicetree.vger.kernel.org>","X-Mailing-List":"devicetree@vger.kernel.org"}}]