[{"id":1783583,"web_url":"http://patchwork.ozlabs.org/comment/1783583/","msgid":"<87lgkjwbxj.fsf@concordia.ellerman.id.au>","date":"2017-10-10T10:10:32","subject":"Re: [PATCH] selftests/powerpc: fix build error in powerpc ptrace\n\tselftests.","submitter":{"id":46580,"url":"http://patchwork.ozlabs.org/api/people/46580/","name":"Michael Ellerman","email":"mpe@ellerman.id.au"},"content":"wei.guo.simon@gmail.com writes:\n\n> From: Simon Guo \n>\n> GCC 7 will take \"r2\" in clobber list as an error will it will get following\n> build errors for powerpc ptrace selftests even with -fno-pic option:\n> ptrace-tm-vsx.c: In function ‘tm_vsx’:\n> ptrace-tm-vsx.c:42:2: error: PIC register clobbered by ‘r2’ in ‘asm’\n> asm __volatile__(\n> ^~~\n> make[1]: *** [ptrace-tm-vsx] Error 1\n> ptrace-tm-spd-vsx.c: In function ‘tm_spd_vsx’:\n> ptrace-tm-spd-vsx.c:55:2: error: PIC register clobbered by ‘r2’ in ‘asm’\n> asm __volatile__(\n> ^~~\n> make[1]: *** [ptrace-tm-spd-vsx] Error 1\n> ptrace-tm-spr.c: In function ‘tm_spr’:\n> ptrace-tm-spr.c:46:2: error: PIC register clobbered by ‘r2’ in ‘asm’\n> asm __volatile__(\n> ^~~\n>\n> This patch fix the build error by removing \"r2\" out of clobber list.\n\nBut do any of the blocks clobber r2? If so then it should be in the\nclobber list.\n\ncheers","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yBCZn71yYz9tY3\n\tfor ;\n\tTue, 10 Oct 2017 21:12:01 +1100 (AEDT)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3yBCZn64fpzDr69\n\tfor ;\n\tTue, 10 Oct 2017 21:12:01 +1100 (AEDT)","from ozlabs.org (bilbo.ozlabs.org [103.22.144.67])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3yBCY82xp7zDqlv\n\tfor ;\n\tTue, 10 Oct 2017 21:10:36 +1100 (AEDT)","from authenticated.ozlabs.org (localhost [127.0.0.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPSA id 3yBCY80zkwz9tY3;\n\tTue, 10 Oct 2017 21:10:36 +1100 (AEDT)"],"From":"Michael Ellerman ","To":"wei.guo.simon@gmail.com, Anshuman Khandual ","Subject":"Re: [PATCH] selftests/powerpc: fix build error in powerpc ptrace\n\tselftests.","In-Reply-To":"<1504232234-4161-1-git-send-email-wei.guo.simon@gmail.com>","References":"<1504232234-4161-1-git-send-email-wei.guo.simon@gmail.com>","Date":"Tue, 10 Oct 2017 21:10:32 +1100","Message-ID":"<87lgkjwbxj.fsf@concordia.ellerman.id.au>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Simon Guo , linuxppc-dev@lists.ozlabs.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1784253,"web_url":"http://patchwork.ozlabs.org/comment/1784253/","msgid":"<20171009201847.GA9571@simonLocalRHEL7.x64>","date":"2017-10-09T20:18:47","subject":"Re: [PATCH] selftests/powerpc: fix build error in powerpc ptrace\n\tselftests.","submitter":{"id":68632,"url":"http://patchwork.ozlabs.org/api/people/68632/","name":"Simon Guo","email":"wei.guo.simon@gmail.com"},"content":"Hi Michael,\nOn Tue, Oct 10, 2017 at 09:10:32PM +1100, Michael Ellerman wrote:\n> wei.guo.simon@gmail.com writes:\n> \n> > From: Simon Guo \n> >\n> > GCC 7 will take \"r2\" in clobber list as an error will it will get following\n> > build errors for powerpc ptrace selftests even with -fno-pic option:\n> > ptrace-tm-vsx.c: In function ‘tm_vsx’:\n> > ptrace-tm-vsx.c:42:2: error: PIC register clobbered by ‘r2’ in ‘asm’\n> > asm __volatile__(\n> > ^~~\n> > make[1]: *** [ptrace-tm-vsx] Error 1\n> > ptrace-tm-spd-vsx.c: In function ‘tm_spd_vsx’:\n> > ptrace-tm-spd-vsx.c:55:2: error: PIC register clobbered by ‘r2’ in ‘asm’\n> > asm __volatile__(\n> > ^~~\n> > make[1]: *** [ptrace-tm-spd-vsx] Error 1\n> > ptrace-tm-spr.c: In function ‘tm_spr’:\n> > ptrace-tm-spr.c:46:2: error: PIC register clobbered by ‘r2’ in ‘asm’\n> > asm __volatile__(\n> > ^~~\n> >\n> > This patch fix the build error by removing \"r2\" out of clobber list.\n> \n> But do any of the blocks clobber r2? If so then it should be in the\n> clobber list.\n\nI see none of them clobbers r2, and neither does those assembly\nfunctions which those blocks calls, like \"loadvsx\".\n\nFor the change on tools/testing/selftests/powerpc/ptrace/Makefile, it\ncan be ignored since I noticed recent commit a3c01050584da3 \"selftests/powerpc: \nForce ptrace tests to build -fno-pie\". Please let me know if you want\na new v2 to remove that change on ptrace/Makefile.\n\nThanks,\n- Simon","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yBdm02g9gz9sRV\n\tfor ;\n\tWed, 11 Oct 2017 13:51:28 +1100 (AEDT)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3yBdm015nlzDr6n\n\tfor ;\n\tWed, 11 Oct 2017 13:51:28 +1100 (AEDT)","from mail-pg0-x231.google.com (mail-pg0-x231.google.com\n\t[IPv6:2607:f8b0:400e:c05::231])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3yBdk62HRWzDr5S\n\tfor ;\n\tWed, 11 Oct 2017 13:49:49 +1100 (AEDT)","by mail-pg0-x231.google.com with SMTP id j3so238097pga.1\n\tfor ;\n\tTue, 10 Oct 2017 19:49:49 -0700 (PDT)","from localhost ([112.73.6.48]) by smtp.gmail.com with ESMTPSA id\n\tv14sm20248923pgq.72.2017.10.10.19.49.45\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 10 Oct 2017 19:49:46 -0700 (PDT)"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"aMpSMfYT\"; dkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"aMpSMfYT\"; dkim-atps=neutral","ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gmail.com\n\t(client-ip=2607:f8b0:400e:c05::231; helo=mail-pg0-x231.google.com;\n\tenvelope-from=wei.guo.simon@gmail.com; receiver=)","lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"aMpSMfYT\"; dkim-atps=neutral"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=q/MB9KhtL33FNreVApsBwSmlkMsa2eAvrnWK9bBYm0Q=;\n\tb=aMpSMfYT3AMUkQOSRVG6P35Jv+FXgMDi9sLo4nGciv8bpWBmXNsX3+YjAScqwbk1Pr\n\tO1wv5ptJPyKSbYgUe6Uy2fyrJUId9QrFseC1Y9ICY1plU97EvpGmpHI6jwu3uDMVXq5M\n\tSbfCd+2HJeFX4xyg+TxNEiCQz2HgCQgsSwxFBqwRzNnTGr0y6LmpwftjvFNz/6MfM8It\n\tD6/ffnmCxyYc7+trmrZLmeWJRNGtgJAR+RrfsGXhdnnyEnAowJGW2yduW3lmIpXC6XGs\n\tXa2w4lorX2QC6wd+y1U4gCl7zn36WxNqPYLmai0GpYzyov603yJURF5R+G/+8T0NNGlD\n\t+VVQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=q/MB9KhtL33FNreVApsBwSmlkMsa2eAvrnWK9bBYm0Q=;\n\tb=tt2R8WA7eVSLq2sI/pHLD7qnn1PHtbdVkdzLmpc2VnHYP6afN4FCHG0X9Bch0zKqNj\n\tFT6zhQ1G9N1xwzOig+0cPh4wVS1JjAtwqckYMkDdFE11qmOmirNz3dMicumP4Zo/KnAK\n\tgtasxKRgy5neA05PydpdqH1a+xxREj/O/l/Waa8bxpmMHmFKkEWhmWc0sQytwhVF5SI2\n\tjGfcUmBJ6OO4ONfIjpg5UjG/U3272jtP4YlsfMhI9jh8KlTpGBnX3S5eR9JpYkLh/LwU\n\tnjQv+1x0+Y/6AohZMwro9oaTE93/9tgaUjvIi357HQuMWcnfPpEL4R4Uxe42qbHudhWL\n\tfdjg==","X-Gm-Message-State":"AMCzsaWScAp//Meh7oxKwTV4R6OCu12T2W84/v+C0pR8z+zhIUNO50Eq\n\tRVr8a6FiEhKSJQ0t+9QUVbo=","X-Google-Smtp-Source":"AOwi7QDjdHYzD5ORZpGnzxVnQ8vrbYTMQ/s5q6m4uWJfhQArUuwNqxoqaYvdLiWUojCBIjCgXi7pbQ==","X-Received":"by 10.99.175.65 with SMTP id s1mr13957501pgo.448.1507690187298; \n\tTue, 10 Oct 2017 19:49:47 -0700 (PDT)","Date":"Tue, 10 Oct 2017 04:18:47 +0800","From":"Simon Guo ","To":"Michael Ellerman ","Subject":"Re: [PATCH] selftests/powerpc: fix build error in powerpc ptrace\n\tselftests.","Message-ID":"<20171009201847.GA9571@simonLocalRHEL7.x64>","References":"<1504232234-4161-1-git-send-email-wei.guo.simon@gmail.com>\n\t<87lgkjwbxj.fsf@concordia.ellerman.id.au>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<87lgkjwbxj.fsf@concordia.ellerman.id.au>","User-Agent":"Mutt/1.5.21 (2010-09-15)","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"linuxppc-dev@lists.ozlabs.org,\n\tAnshuman Khandual ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1820621,"web_url":"http://patchwork.ozlabs.org/comment/1820621/","msgid":"<3ywyXV3x38z9t7B@ozlabs.org>","date":"2017-12-12T11:39:21","subject":"Re: selftests/powerpc: fix build error in powerpc ptrace selftests.","submitter":{"id":69509,"url":"http://patchwork.ozlabs.org/api/people/69509/","name":"Michael Ellerman","email":"patch-notifications@ellerman.id.au"},"content":"On Fri, 2017-09-01 at 02:17:14 UTC, wei.guo.simon@gmail.com wrote:\n> From: Simon Guo \n> \n> GCC 7 will take \"r2\" in clobber list as an error will it will get following\n> build errors for powerpc ptrace selftests even with -fno-pic option:\n> ptrace-tm-vsx.c: In function ‘tm_vsx’:\n> ptrace-tm-vsx.c:42:2: error: PIC register clobbered by ‘r2’ in ‘asm’\n> asm __volatile__(\n> ^~~\n> make[1]: *** [ptrace-tm-vsx] Error 1\n> ptrace-tm-spd-vsx.c: In function ‘tm_spd_vsx’:\n> ptrace-tm-spd-vsx.c:55:2: error: PIC register clobbered by ‘r2’ in ‘asm’\n> asm __volatile__(\n> ^~~\n> make[1]: *** [ptrace-tm-spd-vsx] Error 1\n> ptrace-tm-spr.c: In function ‘tm_spr’:\n> ptrace-tm-spr.c:46:2: error: PIC register clobbered by ‘r2’ in ‘asm’\n> asm __volatile__(\n> ^~~\n> \n> This patch fix the build error by removing \"r2\" out of clobber list.\n> \n> Reported-by: Seth Forshee \n> Signed-off-by: Simon Guo \n> Tested-by: Seth Forshee \n\nApplied to powerpc next, thanks.\n\nhttps://git.kernel.org/powerpc/c/f36dbfe1a504b85c7b3bf89fdd9999\n\ncheers","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3ywysF22dXz9ryk\n\tfor ;\n\tTue, 12 Dec 2017 22:53:53 +1100 (AEDT)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3ywysF0mL9zDrWG\n\tfor ;\n\tTue, 12 Dec 2017 22:53:53 +1100 (AEDT)","from ozlabs.org (bilbo.ozlabs.org [103.22.144.67])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3ywyXV6kbGzDqmM\n\tfor ;\n\tTue, 12 Dec 2017 22:39:22 +1100 (AEDT)","by ozlabs.org (Postfix, from userid 1034)\n\tid 3ywyXV3x38z9t7B; Tue, 12 Dec 2017 22:39:21 +1100 (AEDT)"],"X-powerpc-patch-notification":"thanks","X-powerpc-patch-commit":"f36dbfe1a504b85c7b3bf89fdd99991afbaa0f74","In-Reply-To":"<1504232234-4161-1-git-send-email-wei.guo.simon@gmail.com>","To":"wei.guo.simon@gmail.com, Anshuman Khandual ","From":"Michael Ellerman ","Subject":"Re: selftests/powerpc: fix build error in powerpc ptrace selftests.","Message-Id":"<3ywyXV3x38z9t7B@ozlabs.org>","Date":"Tue, 12 Dec 2017 22:39:21 +1100 (AEDT)","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Simon Guo , linuxppc-dev@lists.ozlabs.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}}]