[{"id":1783372,"web_url":"http://patchwork.ozlabs.org/comment/1783372/","msgid":"<20171010022958.GD5259@localhost.localdomain>","list_archive_url":null,"date":"2017-10-10T02:29:58","subject":"Re: [Qemu-devel] [PATCH v6 2/4] hw/acpi-build: Make assignment\n\tstatement of next_base easy to read","submitter":{"id":195,"url":"http://patchwork.ozlabs.org/api/people/195/","name":"Eduardo Habkost","email":"ehabkost@redhat.com"},"content":"On Fri, Sep 01, 2017 at 10:10:03AM +0800, Dou Liyang wrote:\n> It may be hard to read the assignment statement of \"next_base\", so\n> \n> S/next_base += (1ULL << 32) - pcms->below_4g_mem_size;\n> /next_base = mem_base + mem_len;\n> \n> ... for readability.\n> \n> No functionality change.\n> \n> Signed-off-by: Dou Liyang \n\nThis or the new test case at patch 3/4 seem to have caused build\nfailures under some circumstances:\n\nhttps://www.mail-archive.com/qemu-devel@nongnu.org/msg486368.html\n\nI couldn't reproduce the failure yet, but I'm removing this and\npatch 3/4 from the queue until this is investigated.\n\n> ---\n> hw/i386/acpi-build.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c\n> index a0cf3bf..48525a1 100644\n> --- a/hw/i386/acpi-build.c\n> +++ b/hw/i386/acpi-build.c\n> @@ -2411,7 +2411,7 @@ build_srat(GArray *table_data, BIOSLinker *linker, MachineState *machine)\n> }\n> mem_base = 1ULL << 32;\n> mem_len = next_base - pcms->below_4g_mem_size;\n> - next_base += (1ULL << 32) - pcms->below_4g_mem_size;\n> + next_base = mem_base + mem_len;\n> }\n> numamem = acpi_data_push(table_data, sizeof *numamem);\n> build_srat_memory(numamem, mem_base, mem_len, i - 1,\n> -- \n> 2.5.5\n> \n> \n> \n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=ehabkost@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yB1LS4Bmkz9t6C\n\tfor ;\n\tTue, 10 Oct 2017 13:30:35 +1100 (AEDT)","from localhost ([::1]:60735 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e1kJU-000700-0j\n\tfor incoming@patchwork.ozlabs.org; Mon, 09 Oct 2017 22:30:32 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:35211)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e1kJ6-0006xN-3l\n\tfor qemu-devel@nongnu.org; Mon, 09 Oct 2017 22:30:09 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1e1kJ2-0005Ab-WE\n\tfor qemu-devel@nongnu.org; Mon, 09 Oct 2017 22:30:08 -0400","from mx1.redhat.com ([209.132.183.28]:33394)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1e1kJ2-00056v-Pl\n\tfor qemu-devel@nongnu.org; Mon, 09 Oct 2017 22:30:04 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id A53098765D;\n\tTue, 10 Oct 2017 02:30:02 +0000 (UTC)","from localhost (ovpn-116-25.gru2.redhat.com [10.97.116.25])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id DC5EF17C5F;\n\tTue, 10 Oct 2017 02:29:59 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com A53098765D","Date":"Mon, 9 Oct 2017 23:29:58 -0300","From":"Eduardo Habkost ","To":"Dou Liyang ","Message-ID":"<20171010022958.GD5259@localhost.localdomain>","References":"<1504231805-30957-1-git-send-email-douly.fnst@cn.fujitsu.com>\n\t<1504231805-30957-3-git-send-email-douly.fnst@cn.fujitsu.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<1504231805-30957-3-git-send-email-douly.fnst@cn.fujitsu.com>","X-Fnord":"you can see the fnord","User-Agent":"Mutt/1.9.0 (2017-09-02)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tTue, 10 Oct 2017 02:30:03 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v6 2/4] hw/acpi-build: Make assignment\n\tstatement of next_base easy to read","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Peter Maydell , imammedo@redhat.com,\n\tmst@redhat.com, qemu-devel@nongnu.org, rth@twiddle.net","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1783377,"web_url":"http://patchwork.ozlabs.org/comment/1783377/","msgid":"<8d1a75b0-fe25-aa93-4e68-fb9e193e837e@cn.fujitsu.com>","list_archive_url":null,"date":"2017-10-10T02:34:54","subject":"Re: [Qemu-devel] [PATCH v6 2/4] hw/acpi-build: Make assignment\n\tstatement of next_base easy to read","submitter":{"id":69629,"url":"http://patchwork.ozlabs.org/api/people/69629/","name":"Dou Liyang","email":"douly.fnst@cn.fujitsu.com"},"content":"Hi Eduardo,\n\nAt 10/10/2017 10:29 AM, Eduardo Habkost wrote:\n> On Fri, Sep 01, 2017 at 10:10:03AM +0800, Dou Liyang wrote:\n>> It may be hard to read the assignment statement of \"next_base\", so\n>>\n>> S/next_base += (1ULL << 32) - pcms->below_4g_mem_size;\n>> /next_base = mem_base + mem_len;\n>>\n>> ... for readability.\n>>\n>> No functionality change.\n>>\n>> Signed-off-by: Dou Liyang \n>\n> This or the new test case at patch 3/4 seem to have caused build\n> failures under some circumstances:\n>\n> https://www.mail-archive.com/qemu-devel@nongnu.org/msg486368.html\n>\n> I couldn't reproduce the failure yet, but I'm removing this and\n> patch 3/4 from the queue until this is investigated.\n\nHmm, I see, I will do it.\n\nThanks,\n\tdou.\n>\n>> ---\n>> hw/i386/acpi-build.c | 2 +-\n>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>\n>> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c\n>> index a0cf3bf..48525a1 100644\n>> --- a/hw/i386/acpi-build.c\n>> +++ b/hw/i386/acpi-build.c\n>> @@ -2411,7 +2411,7 @@ build_srat(GArray *table_data, BIOSLinker *linker, MachineState *machine)\n>> }\n>> mem_base = 1ULL << 32;\n>> mem_len = next_base - pcms->below_4g_mem_size;\n>> - next_base += (1ULL << 32) - pcms->below_4g_mem_size;\n>> + next_base = mem_base + mem_len;\n>> }\n>> numamem = acpi_data_push(table_data, sizeof *numamem);\n>> build_srat_memory(numamem, mem_base, mem_len, i - 1,\n>> --\n>> 2.5.5\n>>\n>>\n>>\n>>\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yB1T25nMkz9t38\n\tfor ;\n\tTue, 10 Oct 2017 13:36:22 +1100 (AEDT)","from localhost ([::1]:60755 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e1kP6-0000K1-SV\n\tfor incoming@patchwork.ozlabs.org; Mon, 09 Oct 2017 22:36:20 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:36340)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e1kO2-0008Hg-01\n\tfor qemu-devel@nongnu.org; Mon, 09 Oct 2017 22:35:15 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1e1kNy-0007Xn-Oi\n\tfor qemu-devel@nongnu.org; Mon, 09 Oct 2017 22:35:13 -0400","from mail.cn.fujitsu.com ([183.91.158.132]:12503\n\thelo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e1kNy-0007U9-DX\n\tfor qemu-devel@nongnu.org; Mon, 09 Oct 2017 22:35:10 -0400","from localhost (HELO cn.fujitsu.com) ([10.167.33.5])\n\tby heian.cn.fujitsu.com with ESMTP; 10 Oct 2017 10:34:57 +0800","from G08CNEXCHPEKD03.g08.fujitsu.local (unknown [10.167.33.85])\n\tby cn.fujitsu.com (Postfix) with ESMTP id 5DE04482CFF0;\n\tTue, 10 Oct 2017 10:34:56 +0800 (CST)","from localhost.localdomain (10.167.226.106) by\n\tG08CNEXCHPEKD03.g08.fujitsu.local (10.167.33.89) with Microsoft SMTP\n\tServer (TLS) id 14.3.361.1; Tue, 10 Oct 2017 10:34:54 +0800"],"X-IronPort-AV":"E=Sophos;i=\"5.42,502,1500912000\"; d=\"scan'208\";a=\"28785795\"","To":"Eduardo Habkost ","References":"<1504231805-30957-1-git-send-email-douly.fnst@cn.fujitsu.com>\n\t<1504231805-30957-3-git-send-email-douly.fnst@cn.fujitsu.com>\n\t<20171010022958.GD5259@localhost.localdomain>","From":"Dou Liyang ","Message-ID":"<8d1a75b0-fe25-aa93-4e68-fb9e193e837e@cn.fujitsu.com>","Date":"Tue, 10 Oct 2017 10:34:54 +0800","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tThunderbird/45.4.0","MIME-Version":"1.0","In-Reply-To":"<20171010022958.GD5259@localhost.localdomain>","Content-Type":"text/plain; charset=\"windows-1252\"; format=flowed","Content-Transfer-Encoding":"7bit","X-Originating-IP":"[10.167.226.106]","X-yoursite-MailScanner-ID":"5DE04482CFF0.AD0CC","X-yoursite-MailScanner":"Found to be clean","X-yoursite-MailScanner-From":"douly.fnst@cn.fujitsu.com","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"183.91.158.132","Subject":"Re: [Qemu-devel] [PATCH v6 2/4] hw/acpi-build: Make assignment\n\tstatement of next_base easy to read","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Peter Maydell , imammedo@redhat.com,\n\tmst@redhat.com, qemu-devel@nongnu.org, rth@twiddle.net","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]