[{"id":1761385,"web_url":"http://patchwork.ozlabs.org/comment/1761385/","msgid":"","list_archive_url":null,"date":"2017-08-31T23:55:30","subject":"Re: [PATCH v2 net-next 2/2] net: convert (struct ubuf_info)->refcnt\n\tto refcount_t","submitter":{"id":67615,"url":"http://patchwork.ozlabs.org/api/people/67615/","name":"Willem de Bruijn","email":"willemdebruijn.kernel@gmail.com"},"content":"On Thu, Aug 31, 2017 at 7:48 PM, Eric Dumazet wrote:\n> refcount_t type and corresponding API should be\n> used instead of atomic_t when the variable is used as\n> a reference counter. This allows to avoid accidental\n> refcounter overflows that might lead to use-after-free\n> situations.\n>\n> v2: added the change in drivers/vhost/net.c as spotted\n> by Willem.\n>\n> Signed-off-by: Eric Dumazet \n\nAcked-by: Willem de Bruijn ","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"ae3KHsdY\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjzmG1Fn2z9s7p\n\tfor ;\n\tFri, 1 Sep 2017 09:56:14 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751537AbdHaX4M (ORCPT );\n\tThu, 31 Aug 2017 19:56:12 -0400","from mail-oi0-f65.google.com ([209.85.218.65]:33458 \"EHLO\n\tmail-oi0-f65.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751345AbdHaX4L (ORCPT\n\t); Thu, 31 Aug 2017 19:56:11 -0400","by mail-oi0-f65.google.com with SMTP id t124so975117oih.0\n\tfor ; Thu, 31 Aug 2017 16:56:11 -0700 (PDT)","by 10.168.52.10 with HTTP; Thu, 31 Aug 2017 16:55:30 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=59NEDCXAElnl2xKSZKhNlb+kEkFi24W/2wPKDUtsESg=;\n\tb=ae3KHsdYLuUuYSVla9EDKIBp0Q+x0yo+d4K10bgvOVtILFKApqKtwUfWJY1ODZiPvF\n\taiC09jmO/kDq2e24WXyklFs78TsuNJ/1JovgD8eri9yNmrvDp5F9fpwNnqQtV2bodnNM\n\tGvteC0LJqCiHwQQIMhsiYxv/OKvSPWwaOC7e4vsQE6BbqUObX6yUU9MEqd7YynXMfUx5\n\tQiw1FnMkRejNyBDHJRxkJ7tLqscWp27cXC7DGpox+c/1a6Cbmx1ZtPv6txOfwXZDLhF+\n\tAzHgLjrVQxSWD0HvbCwVzNglQ+d0WWTUGmDqDGoUkfcHYWTRyq49GXtZ5bZVVaG2vsNk\n\tRP6g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=59NEDCXAElnl2xKSZKhNlb+kEkFi24W/2wPKDUtsESg=;\n\tb=HER3eGUVwUpn2NHr5b2Ny8k01fSXDuqOZIXj0TcUrw/G/RN894xqQSL5pqQnfrn8k8\n\tgle1nT1q8AxyirdZV+s6ZHBjBNDYSM0VhR4Ft2QnsUIoEAAeV3a26ScFFFSFnJ6vOmZf\n\tm+4/9AN5XeHItoL2HsIj1O6fPFURMIuc6B+19xGh+xMKF+VR6Nfn1/C5D6X8UviPH4qO\n\tC6IoF6Cl3V68efjYJJweJVTSKcwz8dYSOt5TENaPuLQNdoEM3++4rfe3srh/ZAJCduxm\n\tnwP4vfzL8KPqD4CghmRYvEyl/OeIoUbqcv8P1KJtkyrE4eSVriG8l2qWOufH2VK7iNMr\n\tLuuA==","X-Gm-Message-State":"AHPjjUjKOByxndZx00TMoA1TT1mw4mj2bpynldXoOTs8fijz9Ih/GwBo\n\tO4kHbQTTyXB2jR9AR5PsakO+zgAXag==","X-Google-Smtp-Source":"ADKCNb5uBkL3U2uDuEUZkDHhu9vsDvAQHO+Sl8zP1fdmpqa9OjyIKyjrycJ3yR5MI/t7eWKyXqS55eSqkLnW0Vd4+BA=","X-Received":"by 10.202.168.129 with SMTP id r123mr176965oie.148.1504223770482;\n\tThu, 31 Aug 2017 16:56:10 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170831234822.26612-3-edumazet@google.com>","References":"<20170831234822.26612-1-edumazet@google.com>\n\t<20170831234822.26612-3-edumazet@google.com>","From":"Willem de Bruijn ","Date":"Thu, 31 Aug 2017 19:55:30 -0400","Message-ID":"","Subject":"Re: [PATCH v2 net-next 2/2] net: convert (struct ubuf_info)->refcnt\n\tto refcount_t","To":"Eric Dumazet ","Cc":"\"David S . Miller\" ,\n\tnetdev , Willem de Bruijn ,\n\tEric Dumazet ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]