[{"id":1761384,"web_url":"http://patchwork.ozlabs.org/comment/1761384/","msgid":"<CAF=yD-KfLKxJPbo3C1NPv0TXOR20m0LGbjmc208S2E-gPEwz=w@mail.gmail.com>","list_archive_url":null,"date":"2017-08-31T23:54:39","subject":"Re: [PATCH v2 net-next 1/2] net: prepare (struct ubuf_info)->refcnt\n\tconversion","submitter":{"id":67615,"url":"http://patchwork.ozlabs.org/api/people/67615/","name":"Willem de Bruijn","email":"willemdebruijn.kernel@gmail.com"},"content":"On Thu, Aug 31, 2017 at 7:48 PM, Eric Dumazet <edumazet@google.com> wrote:\n> In order to convert this atomic_t refcnt to refcount_t,\n> we need to init the refcount to one to not trigger\n> a 0 -> 1 transition.\n>\n> This also removes one atomic operation in fast path.\n>\n> v2: removed dead code in sock_zerocopy_put_abort()\n> as suggested by Willem.\n>\n> Signed-off-by: Eric Dumazet <edumazet@google.com>\n\nAcked-by: Willem de Bruijn <willemb@google.com>","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"UaVZ16vN\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjzlJ560Mz9s7p\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri,  1 Sep 2017 09:55:24 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751415AbdHaXzV (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tThu, 31 Aug 2017 19:55:21 -0400","from mail-oi0-f65.google.com ([209.85.218.65]:36378 \"EHLO\n\tmail-oi0-f65.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751398AbdHaXzU (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Thu, 31 Aug 2017 19:55:20 -0400","by mail-oi0-f65.google.com with SMTP id x184so956185oia.3\n\tfor <netdev@vger.kernel.org>; Thu, 31 Aug 2017 16:55:20 -0700 (PDT)","by 10.168.52.10 with HTTP; Thu, 31 Aug 2017 16:54:39 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=vQwf48dcMW/qNrXgcg2c5jtAMSBZ4pm9//K612qaBI4=;\n\tb=UaVZ16vNkHQv0vKRSuLVcnWrvZV14Cdxyy+Rm930f8L+N4uJgKT4PtFvIPDmrHSo6x\n\tvzwveGBL5/9bWp9zxHyzm2sJeWV2eNcEBawCuNWe28tvkvAlx2nP7lqLAIKU1o20uBll\n\tbFmYbaoDI5ypOKeqahohX4l0bsGFUQdeeX8Fo0DBE4/SyBjmTOPL1y3JbIAJy9XUSjWR\n\tEDrCmpxYmgU9wXFLWG/Py0sfe5b8Ef9ruihiemKPt1BFTeeGKP4hWlVTHgeS0hqAopaQ\n\tO2jD5J2N91z93Gz4FNnrTOIhtuk6sUGSmKFPEznLRwNXgMW1oyKmw5ZXUicgjFYIhpsS\n\tysSA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=vQwf48dcMW/qNrXgcg2c5jtAMSBZ4pm9//K612qaBI4=;\n\tb=jkAL46aI0FNTW8sF79Jv1QMKH7HpM+DmEGd2eNaJjlONEtigBkB/yyupnYMhSjW958\n\t7aD6CTZeuc/Gtgy4wys89V2/3i+RZpd+pXW5qtVpk2gTkYL3f8ZPbcmPrLbPx6bqmsD1\n\tCvPgHderyr+S2xpPPDpmeHIrGoEo3rSReDDiniDjS9x+berqNlBhSTN5Em2//tVCWTa8\n\tmTKNSHlGKOprx8LpuNABCQFicPwlKZmvib+/BBxiq+d8iMpx5QHu8B+WZHISLq0Zz4tm\n\tXgocIsVgzw4CsGaClJdXEODRDshBFeXBMN60Ofk8Ht9o29PUnEwLWTAVqgC+JblasS4B\n\tx2OQ==","X-Gm-Message-State":"AHPjjUhl3kXz/yTtb4QoiErXQgfaBDjD9xkaGMf3q/AcaPrnMtmgfipn\n\tbPM5DGRQziVcerQNK5wDmXSpNADRpQ==","X-Google-Smtp-Source":"ADKCNb7kAgzYlQB83hQgRLXfYqI0jqwmyAVnNAizKibHm2A6cMpy7Dwd2ZJq912VC0TRppnGyQCs3w5nXXyLjDy4cIM=","X-Received":"by 10.202.48.194 with SMTP id w185mr192253oiw.196.1504223719782; \n\tThu, 31 Aug 2017 16:55:19 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170831234822.26612-2-edumazet@google.com>","References":"<20170831234822.26612-1-edumazet@google.com>\n\t<20170831234822.26612-2-edumazet@google.com>","From":"Willem de Bruijn <willemdebruijn.kernel@gmail.com>","Date":"Thu, 31 Aug 2017 19:54:39 -0400","Message-ID":"<CAF=yD-KfLKxJPbo3C1NPv0TXOR20m0LGbjmc208S2E-gPEwz=w@mail.gmail.com>","Subject":"Re: [PATCH v2 net-next 1/2] net: prepare (struct ubuf_info)->refcnt\n\tconversion","To":"Eric Dumazet <edumazet@google.com>","Cc":"\"David S . Miller\" <davem@davemloft.net>,\n\tnetdev <netdev@vger.kernel.org>, Willem de Bruijn <willemb@google.com>,\n\tEric Dumazet <eric.dumazet@gmail.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}}]