[{"id":1761382,"web_url":"http://patchwork.ozlabs.org/comment/1761382/","msgid":"","list_archive_url":null,"date":"2017-08-31T23:45:37","subject":"Re: [PATCH 31/31] timer: Switch to testing for .function instead of\n\t.data","submitter":{"id":695,"url":"http://patchwork.ozlabs.org/api/people/695/","name":"Dmitry Torokhov","email":"dmitry.torokhov@gmail.com"},"content":"On Thu, Aug 31, 2017 at 4:29 PM, Kees Cook wrote:\n> In several places, .data is checked for initialization to gate early\n> calls to del_timer_sync(). Checking for .function is equally valid, so\n> switch to this in all callers.\n\nNot seeing the rest of patches it is unclear from the patch\ndescription why this is needed/wanted.\n\nThanks.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"CY3Yxyrg\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjzXJ1mn1z9s8J\n\tfor ;\n\tFri, 1 Sep 2017 09:45:52 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751851AbdHaXpl (ORCPT );\n\tThu, 31 Aug 2017 19:45:41 -0400","from mail-vk0-f52.google.com ([209.85.213.52]:37302 \"EHLO\n\tmail-vk0-f52.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751355AbdHaXpj (ORCPT\n\t); Thu, 31 Aug 2017 19:45:39 -0400","by mail-vk0-f52.google.com with SMTP id q189so2998382vke.4;\n\tThu, 31 Aug 2017 16:45:38 -0700 (PDT)","by 10.176.19.242 with HTTP; Thu, 31 Aug 2017 16:45:37 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=7S5wCFKWdws42VlK1B7ur75tyJRdgVmPwWXmTLmkjVA=;\n\tb=CY3YxyrgMi8VumEYUxzXsvoyl4AW9NfeVB2ABdAG2AfoPCYSRAe5tXtXQUshHvTtD/\n\t5aq5+ooMM4HlnhXDSFSKIwuAB4Y2GDQ09PH51Z1LGUtlfsjMLIZep4QeApNg88aKx7Hh\n\tQSMOWkzL3kRrX559K8KcxRtUh8+U8avZSkq3gZYRZta5jvFFwKT4t0eD/vMrXVMdVBMK\n\trzJWtUEPe8V2gKVcJqFE1Luteot96uoyWPN0tv0XJ0KBEHKxF2Odi0sbi2SveQef+VSu\n\tIG1AROMm0F+qI0aJSt396LW4TTjc9aB22vCW+Ev/YfUtUmw/NsOxZm/Ry8ohxFaFeHt1\n\tOAHw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=7S5wCFKWdws42VlK1B7ur75tyJRdgVmPwWXmTLmkjVA=;\n\tb=t1o4YdvtlztgcByng+eaw6yzodqnawJGaYTvTyBFu9M6+9LT5uFprRh0ID5lrxwL/T\n\tNx6KPAazAnZeqmudwbESc8N3UmOjs9orYOB/MXXdvs1l3Seg8i7MH084/OBQlK12mb6k\n\t8USoHVldZIBLybRTBae85XcVSMaremQmK7ZPaWRgxCEKBYKv4LkyudPAKPg729Py16k/\n\t+fYe1Jb9JW/y3jx0fuPA+Di6pUML4i0rkbYH0qjtWCpAhUt8MecGmRgZf44v3i8HLqUp\n\t6mhu8YSLCpRwnv4RCC3bOX/iiHPyTBo5O4js1LBNsBoVp8MLrD5oxfMbMsDF9WYq9Fc1\n\t9yXQ==","X-Gm-Message-State":"AHPjjUjwNzI3Pc85Doeu4jRwrkN8q9/AbJqaEr6RIDqTtcszVgv1r90K\n\tFeKAziz4WTqFJobWMj9ftS0My7evOA==","X-Google-Smtp-Source":"ADKCNb7BOuuwhx8c1P1uyVWRRkShZp/eA+ZW0cXWbz7B7wSZd7zEcbb4vMN+FN+k/AHlF5493HrqFzo/lh1niCVCIFE=","X-Received":"by 10.31.8.79 with SMTP id 76mr66821vki.151.1504223137883;\n\tThu, 31 Aug 2017 16:45:37 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1504222183-61202-32-git-send-email-keescook@chromium.org>","References":"<1504222183-61202-1-git-send-email-keescook@chromium.org>\n\t<1504222183-61202-32-git-send-email-keescook@chromium.org>","From":"Dmitry Torokhov ","Date":"Thu, 31 Aug 2017 16:45:37 -0700","Message-ID":"","Subject":"Re: [PATCH 31/31] timer: Switch to testing for .function instead of\n\t.data","To":"Kees Cook ","Cc":"Thomas Gleixner ,\n\t\"Rafael J. Wysocki\" ,\n\tPavel Machek , Len Brown ,\n\tGreg Kroah-Hartman ,\n\tMike Marciniszyn ,\n\tDennis Dalessandro ,\n\tDoug Ledford , Sean Hefty ,\n\tHal Rosenstock ,\n\tJeff Kirsher ,\n\t\"linux-pm@vger.kernel.org\" ,\n\tlinux-rdma@vger.kernel.org,\n\t\"linux-input@vger.kernel.org\" ,\n\tintel-wired-lan@lists.osuosl.org, netdev ,\n\tlkml ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1761388,"web_url":"http://patchwork.ozlabs.org/comment/1761388/","msgid":"","list_archive_url":null,"date":"2017-08-31T23:59:05","subject":"Re: [PATCH 31/31] timer: Switch to testing for .function instead of\n\t.data","submitter":{"id":10641,"url":"http://patchwork.ozlabs.org/api/people/10641/","name":"Kees Cook","email":"keescook@chromium.org"},"content":"On Thu, Aug 31, 2017 at 4:45 PM, Dmitry Torokhov\n wrote:\n> On Thu, Aug 31, 2017 at 4:29 PM, Kees Cook wrote:\n>> In several places, .data is checked for initialization to gate early\n>> calls to del_timer_sync(). Checking for .function is equally valid, so\n>> switch to this in all callers.\n>\n> Not seeing the rest of patches it is unclear from the patch\n> description why this is needed/wanted.\n\nThe CC list would have been really giant, but here is the first patch\nand the earlier series list:\n\nhttps://lkml.org/lkml/2017/8/31/904\nhttps://lkml.org/lkml/2017/8/30/760\n\ntl;dr: We're going to switch all struct timer_list callbacks to get\nthe timer pointer as the argument instead of from the .data field.\nThis patch is one step in removing open-coded users of the .data\nfield.\n\n-Kees","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"rO3jVPxI\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"QcVH9r9d\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjzqt2gmpz9s8J\n\tfor ;\n\tFri, 1 Sep 2017 09:59:22 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751618AbdHaX7J (ORCPT );\n\tThu, 31 Aug 2017 19:59:09 -0400","from mail-io0-f176.google.com ([209.85.223.176]:36139 \"EHLO\n\tmail-io0-f176.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751355AbdHaX7G (ORCPT\n\t); Thu, 31 Aug 2017 19:59:06 -0400","by mail-io0-f176.google.com with SMTP id f99so7894235ioi.3\n\tfor ; Thu, 31 Aug 2017 16:59:06 -0700 (PDT)","by 10.107.7.101 with HTTP; Thu, 31 Aug 2017 16:59:05 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=google.com; s=20161025;\n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=9r9SxFAIRQmip/QzBBSAlK2kXfSEk5c45Ow/bRrxCCo=;\n\tb=rO3jVPxILwmzNO3lwUmreNxeKTYtcbDTQFBlR67+jn+C7e3nhVnv0RnKmWDekTXDRP\n\taTMsei5o7XIIc93Tkn66xpU+fobMTV94KrMJV5Owr6mWIl+LF6wzKEum6kuqZN9vZqfl\n\trv+Vti+BUK/VoRBzol6boRFSvlN+eqMYwljUPM66E+IN4mzod3uWCznurgDAunSo18Nh\n\tyIG7LhVxlR4E4/qbIwY2Y+nHZcS5zZriunC+RKmRboPvE//k3tJe55JJXVrbV1BkD9q6\n\t62EOcPAtqJn8cdG+Xicr8hnOuYew8kn7WdykhTiBM8UCnrlrFaZv6ASNgjYDVJ7ZAXaR\n\taEsQ==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google;\n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=9r9SxFAIRQmip/QzBBSAlK2kXfSEk5c45Ow/bRrxCCo=;\n\tb=QcVH9r9dHwolLUC/2XC+WRJbYfs9xl4j7ag3GRvMYXgXMtoAonQzCo9KPpVNTFiclr\n\tfBcnPBpLM/jfNaF7KIop7oRFFj367XZWCwch3zAXnFEetFRAD/FIKU9uc1MlSLylPhEg\n\t8UqDl0yEhdIECfcDXqXTfMJY7gzTxbteq3wNA="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=9r9SxFAIRQmip/QzBBSAlK2kXfSEk5c45Ow/bRrxCCo=;\n\tb=jYfLCrsjHVe1sDM/3IRrizWDRAL3/714v4vrdTNc9Cc2341hXgWW+WmiFmXGHD/8qo\n\tx8fI1y8QsjnVcz919foS4JYO6iiAVrHXaorCpTnVRvQwhLIPu62fUp1/WSj1dzohzKUQ\n\t1H5mweF1NfP7xkCkySnfzh2yUapdYUMyrXaXrPDbtFuLesW9p+lsIytNhivEDPFBI+su\n\tVExMCMZmp21KGzNu5V5ATs48rs+/q+9HeqmDORk4EhRDTW1Tj4URE5SuO6w6U1KjmFT7\n\tcy+F0yVRoJ+CRnD3Gr1wJt1FnMTsURylIjFOSwJyVY28NQyIPoIfP7J+hjsJfnK174u0\n\tQLOA==","X-Gm-Message-State":"AHPjjUjA8z1rHOInNi1eLJcE8oYSRozv+e2oRtnQCDSjPN/NSK98f4fC\n\tJRxpY/RuapkBBFdIDghlATSqaNMh27KJ","X-Google-Smtp-Source":"ADKCNb6W9zUYoiVrK+zBNtNfacAD2+CLLgPOtLv8Exl1oyBJ4AT8gAsCct+DTrHLczY/IDzOhgsk8I3m331NYv02jsU=","X-Received":"by 10.107.20.144 with SMTP id 138mr126653iou.217.1504223946161; \n\tThu, 31 Aug 2017 16:59:06 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<1504222183-61202-1-git-send-email-keescook@chromium.org>\n\t<1504222183-61202-32-git-send-email-keescook@chromium.org>\n\t","From":"Kees Cook ","Date":"Thu, 31 Aug 2017 16:59:05 -0700","X-Google-Sender-Auth":"wtXEiUSrwLjKzeFxfcsuc1JVUPo","Message-ID":"","Subject":"Re: [PATCH 31/31] timer: Switch to testing for .function instead of\n\t.data","To":"Dmitry Torokhov ","Cc":"Thomas Gleixner ,\n\t\"Rafael J. Wysocki\" ,\n\tPavel Machek , Len Brown ,\n\tGreg Kroah-Hartman ,\n\tMike Marciniszyn ,\n\tDennis Dalessandro ,\n\tDoug Ledford , Sean Hefty ,\n\tHal Rosenstock ,\n\tJeff Kirsher ,\n\t\"linux-pm@vger.kernel.org\" ,\n\tlinux-rdma ,\n\t\"linux-input@vger.kernel.org\" ,\n\tintel-wired-lan@lists.osuosl.org, netdev ,\n\tlkml ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1761416,"web_url":"http://patchwork.ozlabs.org/comment/1761416/","msgid":"","list_archive_url":null,"date":"2017-09-01T01:06:29","subject":"Re: [PATCH 31/31] timer: Switch to testing for .function instead of\n\t.data","submitter":{"id":695,"url":"http://patchwork.ozlabs.org/api/people/695/","name":"Dmitry Torokhov","email":"dmitry.torokhov@gmail.com"},"content":"On Thu, Aug 31, 2017 at 4:59 PM, Kees Cook wrote:\n> On Thu, Aug 31, 2017 at 4:45 PM, Dmitry Torokhov\n> wrote:\n>> On Thu, Aug 31, 2017 at 4:29 PM, Kees Cook wrote:\n>>> In several places, .data is checked for initialization to gate early\n>>> calls to del_timer_sync(). Checking for .function is equally valid, so\n>>> switch to this in all callers.\n>>\n>> Not seeing the rest of patches it is unclear from the patch\n>> description why this is needed/wanted.\n>\n> The CC list would have been really giant, but here is the first patch\n> and the earlier series list:\n>\n> https://lkml.org/lkml/2017/8/31/904\n> https://lkml.org/lkml/2017/8/30/760\n>\n> tl;dr: We're going to switch all struct timer_list callbacks to get\n> the timer pointer as the argument instead of from the .data field.\n> This patch is one step in removing open-coded users of the .data\n> field.\n>\n\nAnd that is exactly what should have been in the patch description.\n\nFWIW for input bits:\n\nAcked-by: Dmitry Torokhov \n\nThanks.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"syUF5Y9y\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xk1Kg5hq7z9ryv\n\tfor ;\n\tFri, 1 Sep 2017 11:06:47 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751285AbdIABGd (ORCPT );\n\tThu, 31 Aug 2017 21:06:33 -0400","from mail-ua0-f193.google.com ([209.85.217.193]:36919 \"EHLO\n\tmail-ua0-f193.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750955AbdIABGb (ORCPT\n\t); Thu, 31 Aug 2017 21:06:31 -0400","by mail-ua0-f193.google.com with SMTP id g16so512625uah.4;\n\tThu, 31 Aug 2017 18:06:30 -0700 (PDT)","by 10.176.19.242 with HTTP; Thu, 31 Aug 2017 18:06:29 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=r6WqfEA+P+1NxkVoCd+CuTQ7UoY9Db5GpktX1mKnEbY=;\n\tb=syUF5Y9yL/TNqSuW3yKTCu9uXBQTRckpYroC+mbg7deOOb2map+A3QTofYVb1YFNEG\n\tvtuUJJchmb0rFTGfyHIxD1uBYlCBGYT3RTTS2lIazNBwNCwWGhE3UOR5MmudP8nliPaf\n\tf7dxzGiIeGPiPnv3FmIP+G0IjdCadhwMLrD1bgl44j8ToCeG33eX5CLZ6+ECjPJv1r0R\n\t8YIevl/oHzreepyfC04nV4TPRAaANPzGWLKYTAAeN+OWaAtZw3RLqmw2uSv5js+aTYez\n\tm/UFcOSb6ykxmQK29OxQ6/okT4hRjh+4lniYNRpaZ4uPRHCW1UFhPd0uT6y/qKx54+Bf\n\tw+GQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=r6WqfEA+P+1NxkVoCd+CuTQ7UoY9Db5GpktX1mKnEbY=;\n\tb=eFFJmFnve5Aj04cbxho25jZSOHElVP3svAhU0xAUa2Fs7terM4Boo8QmeAqDl6qO7E\n\tUVRCohu4FOSg6b6NMrMiD8Mr4kx48+Ju1LYKvUtzqeurcZeK0yvn84TUqJF7mvIQDIbG\n\tRKuW/XWh/+5oT85vFGqNE+cb9rj3cRxoGemJnNzaZZduHMG0qsFMwbOunWXJy5wLIG01\n\tKWWXWQExgqc5oX64vb8UOJMcDPoowUbWqeaKaspOHs4Qx51ZS2vlWyNhpsgEyBDwHRFu\n\tWQZ8X/q7PVuUOIGQq0EwsZoPpil/7YSXPQOmn5dhPp+SPRe0gy37KAANfqJLcukowhbm\n\tA88A==","X-Gm-Message-State":"AHPjjUha6D57kUwIyMSmAsssjU5YHA1j7b+Ve/fSS13cF5VS5y9tS2DS\n\tgbCWkB5JmgwziKPR1HHVCrgE5ucNfw==","X-Google-Smtp-Source":"ADKCNb5PX/r/Cql6nyUNxcDUaVKj/WpTDw+iunv2Zn9B//YVHSSYjdpSo/iuNIiPNd8eAVt92SAtcnbePWEd4Gpa6ZE=","X-Received":"by 10.176.90.50 with SMTP id l47mr217571uad.150.1504227990060;\n\tThu, 31 Aug 2017 18:06:30 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<1504222183-61202-1-git-send-email-keescook@chromium.org>\n\t<1504222183-61202-32-git-send-email-keescook@chromium.org>\n\t\n\t","From":"Dmitry Torokhov ","Date":"Thu, 31 Aug 2017 18:06:29 -0700","Message-ID":"","Subject":"Re: [PATCH 31/31] timer: Switch to testing for .function instead of\n\t.data","To":"Kees Cook ","Cc":"Thomas Gleixner ,\n\t\"Rafael J. Wysocki\" ,\n\tPavel Machek , Len Brown ,\n\tGreg Kroah-Hartman ,\n\tMike Marciniszyn ,\n\tDennis Dalessandro ,\n\tDoug Ledford , Sean Hefty ,\n\tHal Rosenstock ,\n\tJeff Kirsher ,\n\t\"linux-pm@vger.kernel.org\" ,\n\tlinux-rdma ,\n\t\"linux-input@vger.kernel.org\" ,\n\tintel-wired-lan@lists.osuosl.org, netdev ,\n\tlkml ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1761997,"web_url":"http://patchwork.ozlabs.org/comment/1761997/","msgid":"<1504301657.3922.47.camel@intel.com>","list_archive_url":null,"date":"2017-09-01T21:34:17","subject":"Re: [PATCH 31/31] timer: Switch to testing for .function instead of\n\t.data","submitter":{"id":473,"url":"http://patchwork.ozlabs.org/api/people/473/","name":"Kirsher, Jeffrey T","email":"jeffrey.t.kirsher@intel.com"},"content":"On Thu, 2017-08-31 at 16:29 -0700, Kees Cook wrote:\n> In several places, .data is checked for initialization to gate early\n> calls to del_timer_sync(). Checking for .function is equally valid,\n> so\n> switch to this in all callers.\n> \n> Cc: \"Rafael J. Wysocki\" \n> Cc: Pavel Machek \n> Cc: Len Brown \n> Cc: Greg Kroah-Hartman \n> Cc: Mike Marciniszyn \n> Cc: Dennis Dalessandro \n> Cc: Doug Ledford \n> Cc: Sean Hefty \n> Cc: Hal Rosenstock \n> Cc: Dmitry Torokhov \n> Cc: Jeff Kirsher \n> Cc: linux-pm@vger.kernel.org\n> Cc: linux-rdma@vger.kernel.org\n> Cc: linux-input@vger.kernel.org\n> Cc: intel-wired-lan@lists.osuosl.org\n> Cc: netdev@vger.kernel.org\n> Signed-off-by: Kees Cook \n\nFor the changes to i40e...\n\nAcked-by: Jeff Kirsher ","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkXZS4D1pz9sPt\n\tfor ;\n\tSat, 2 Sep 2017 07:34:40 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752561AbdIAVe2 (ORCPT );\n\tFri, 1 Sep 2017 17:34:28 -0400","from mga05.intel.com ([192.55.52.43]:45242 \"EHLO mga05.intel.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1752503AbdIAVe0 (ORCPT );\n\tFri, 1 Sep 2017 17:34:26 -0400","from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby fmsmga105.fm.intel.com with ESMTP; 01 Sep 2017 14:34:25 -0700","from maguila2-mobl.amr.corp.intel.com ([10.252.196.46])\n\tby fmsmga006.fm.intel.com with ESMTP; 01 Sep 2017 14:34:24 -0700"],"X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.41,459,1498546800\"; \n\td=\"asc'?scan'208\";a=\"147251982\"","Message-ID":"<1504301657.3922.47.camel@intel.com>","Subject":"Re: [PATCH 31/31] timer: Switch to testing for .function instead of\n\t.data","From":"Jeff Kirsher ","To":"Kees Cook , Thomas Gleixner ","Cc":"\"Rafael J. Wysocki\" ,\n\tPavel Machek , Len Brown ,\n\tGreg Kroah-Hartman ,\n\tMike Marciniszyn ,\n\tDennis Dalessandro ,\n\tDoug Ledford , Sean Hefty ,\n\tHal Rosenstock ,\n\tDmitry Torokhov ,\n\tlinux-pm@vger.kernel.org, linux-rdma@vger.kernel.org,\n\tlinux-input@vger.kernel.org, intel-wired-lan@lists.osuosl.org,\n\tnetdev@vger.kernel.org, linux-kernel@vger.kernel.org","Date":"Fri, 01 Sep 2017 14:34:17 -0700","In-Reply-To":"<1504222183-61202-32-git-send-email-keescook@chromium.org>","References":"<1504222183-61202-1-git-send-email-keescook@chromium.org>\n\t<1504222183-61202-32-git-send-email-keescook@chromium.org>","Content-Type":"multipart/signed; micalg=\"pgp-sha256\";\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"=-r9bmlAtWiFfE64fwCMV8\"","X-Mailer":"Evolution 3.24.5 ","Mime-Version":"1.0","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1762126,"web_url":"http://patchwork.ozlabs.org/comment/1762126/","msgid":"<1857082.urnTVIQKcg@aspire.rjw.lan>","list_archive_url":null,"date":"2017-09-02T13:47:20","subject":"Re: [PATCH 31/31] timer: Switch to testing for .function instead of\n\t.data","submitter":{"id":26536,"url":"http://patchwork.ozlabs.org/api/people/26536/","name":"Rafael J. Wysocki","email":"rjw@rjwysocki.net"},"content":"On Friday, September 1, 2017 1:29:43 AM CEST Kees Cook wrote:\n> In several places, .data is checked for initialization to gate early\n> calls to del_timer_sync(). Checking for .function is equally valid, so\n> switch to this in all callers.\n> \n> Cc: \"Rafael J. Wysocki\" \n> Cc: Pavel Machek \n> Cc: Len Brown \n> Cc: Greg Kroah-Hartman \n> Cc: Mike Marciniszyn \n> Cc: Dennis Dalessandro \n> Cc: Doug Ledford \n> Cc: Sean Hefty \n> Cc: Hal Rosenstock \n> Cc: Dmitry Torokhov \n> Cc: Jeff Kirsher \n> Cc: linux-pm@vger.kernel.org\n> Cc: linux-rdma@vger.kernel.org\n> Cc: linux-input@vger.kernel.org\n> Cc: intel-wired-lan@lists.osuosl.org\n> Cc: netdev@vger.kernel.org\n> Signed-off-by: Kees Cook \n> ---\n> drivers/base/power/wakeup.c | 3 +--\n> drivers/infiniband/hw/hfi1/chip.c | 6 ++----\n> drivers/infiniband/hw/hfi1/init.c | 2 +-\n> drivers/infiniband/hw/qib/qib_iba7220.c | 2 +-\n> drivers/infiniband/hw/qib/qib_iba7322.c | 2 +-\n> drivers/infiniband/hw/qib/qib_init.c | 14 +++++---------\n> drivers/infiniband/hw/qib/qib_mad.c | 2 +-\n> drivers/input/input.c | 5 ++---\n> drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +-\n> 9 files changed, 15 insertions(+), 23 deletions(-)\n> \n> diff --git a/drivers/base/power/wakeup.c b/drivers/base/power/wakeup.c\n> index 144e6d8fafc8..79a3c1b204af 100644\n> --- a/drivers/base/power/wakeup.c\n> +++ b/drivers/base/power/wakeup.c\n> @@ -479,8 +479,7 @@ static bool wakeup_source_not_registered(struct wakeup_source *ws)\n> \t * Use timer struct to check if the given source is initialized\n> \t * by wakeup_source_add.\n> \t */\n> -\treturn ws->timer.function != pm_wakeup_timer_fn ||\n> -\t\t ws->timer.data != (unsigned long)ws;\n> +\treturn ws->timer.function != pm_wakeup_timer_fn;\n> }\n> \n> /*\n\nAcked-by: Rafael J. Wysocki \n\nfor the above.\n\nThanks!","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkyM42xRTz9sRW\n\tfor ;\n\tSat, 2 Sep 2017 23:56:16 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752706AbdIBN4J (ORCPT );\n\tSat, 2 Sep 2017 09:56:09 -0400","from cloudserver094114.home.net.pl ([79.96.170.134]:60563 \"EHLO\n\tcloudserver094114.home.net.pl\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1752441AbdIBN4H (ORCPT\n\t); Sat, 2 Sep 2017 09:56:07 -0400","from 79.184.253.199.ipv4.supernova.orange.pl (79.184.253.199)\n\t(HELO aspire.rjw.lan)\n\tby serwer1319399.home.pl (79.96.170.134) with SMTP (IdeaSmtpServer\n\t0.82) id dcd8555db90b710d; Sat, 2 Sep 2017 15:56:04 +0200"],"From":"\"Rafael J. Wysocki\" ","To":"Kees Cook ","Cc":"Thomas Gleixner , Pavel Machek ,\n\tLen Brown ,\n\tGreg Kroah-Hartman ,\n\tMike Marciniszyn ,\n\tDennis Dalessandro ,\n\tDoug Ledford , Sean Hefty ,\n\tHal Rosenstock ,\n\tDmitry Torokhov ,\n\tJeff Kirsher ,\n\tlinux-pm@vger.kernel.org, linux-rdma@vger.kernel.org,\n\tlinux-input@vger.kernel.org, intel-wired-lan@lists.osuosl.org,\n\tnetdev@vger.kernel.org, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH 31/31] timer: Switch to testing for .function instead of\n\t.data","Date":"Sat, 02 Sep 2017 15:47:20 +0200","Message-ID":"<1857082.urnTVIQKcg@aspire.rjw.lan>","In-Reply-To":"<1504222183-61202-32-git-send-email-keescook@chromium.org>","References":"<1504222183-61202-1-git-send-email-keescook@chromium.org>\n\t<1504222183-61202-32-git-send-email-keescook@chromium.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"7Bit","Content-Type":"text/plain; charset=\"us-ascii\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]