[{"id":1761466,"web_url":"http://patchwork.ozlabs.org/comment/1761466/","msgid":"<20170901050910.GB2584@kroah.com>","list_archive_url":null,"date":"2017-09-01T05:09:10","subject":"Re: [PATCH 13/31] timer: Remove meaningless .data/.function\n\tassignments","submitter":{"id":11800,"url":"http://patchwork.ozlabs.org/api/people/11800/","name":"Greg Kroah-Hartman","email":"gregkh@linuxfoundation.org"},"content":"On Thu, Aug 31, 2017 at 04:29:25PM -0700, Kees Cook wrote:\n> Several timer users needlessly reset their .function/.data fields during\n> their timer callback, but nothing else changes them. Some users do not\n> use their .data field at all. Each instance is removed here.\n> \n> Cc: Krzysztof Halasa \n> Cc: Aditya Shankar \n> Cc: Ganesh Krishna \n> Cc: Greg Kroah-Hartman \n> Cc: Jens Axboe \n> Cc: netdev@vger.kernel.org\n> Cc: linux-wireless@vger.kernel.org\n> Cc: devel@driverdev.osuosl.org\n> Signed-off-by: Kees Cook \n> ---\n> drivers/block/amiflop.c | 3 +--\n> drivers/net/wan/hdlc_cisco.c | 2 --\n> drivers/net/wan/hdlc_fr.c | 2 --\n> drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 4 +---\n> 4 files changed, 2 insertions(+), 9 deletions(-)\n\nFor the staging driver:\n\nAcked-by: Greg Kroah-Hartman ","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xk6jV1wt9z9s81\n\tfor ;\n\tFri, 1 Sep 2017 15:09:18 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751310AbdIAFJI (ORCPT );\n\tFri, 1 Sep 2017 01:09:08 -0400","from mail.linuxfoundation.org ([140.211.169.12]:37776 \"EHLO\n\tmail.linuxfoundation.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750707AbdIAFJG (ORCPT\n\t); Fri, 1 Sep 2017 01:09:06 -0400","from localhost (LFbn-1-12253-150.w90-92.abo.wanadoo.fr\n\t[90.92.67.150])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPSA id 292EFD60;\n\tFri, 1 Sep 2017 05:09:05 +0000 (UTC)"],"Date":"Fri, 1 Sep 2017 07:09:10 +0200","From":"Greg Kroah-Hartman ","To":"Kees Cook ","Cc":"Thomas Gleixner , Krzysztof Halasa ,\n\tAditya Shankar ,\n\tGanesh Krishna ,\n\tJens Axboe , netdev@vger.kernel.org,\n\tlinux-wireless@vger.kernel.org, devel@driverdev.osuosl.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH 13/31] timer: Remove meaningless .data/.function\n\tassignments","Message-ID":"<20170901050910.GB2584@kroah.com>","References":"<1504222183-61202-1-git-send-email-keescook@chromium.org>\n\t<1504222183-61202-14-git-send-email-keescook@chromium.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<1504222183-61202-14-git-send-email-keescook@chromium.org>","User-Agent":"Mutt/1.8.3 (2017-05-23)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1761890,"web_url":"http://patchwork.ozlabs.org/comment/1761890/","msgid":"","list_archive_url":null,"date":"2017-09-01T17:59:02","subject":"Re: [PATCH 13/31] timer: Remove meaningless .data/.function\n\tassignments","submitter":{"id":544,"url":"http://patchwork.ozlabs.org/api/people/544/","name":"Krzysztof Halasa","email":"khc@pm.waw.pl"},"content":"Kees Cook writes:\n\n> Several timer users needlessly reset their .function/.data fields during\n> their timer callback, but nothing else changes them. Some users do not\n> use their .data field at all. Each instance is removed here.\n\nFor *wan/hdlc*\nAcked-by: Krzysztof Halasa \n\n> --- a/drivers/net/wan/hdlc_cisco.c\n> +++ b/drivers/net/wan/hdlc_cisco.c\n> @@ -276,8 +276,6 @@ static void cisco_timer(unsigned long arg)\n> \tspin_unlock(&st->lock);\n> \n> \tst->timer.expires = jiffies + st->settings.interval * HZ;\n> -\tst->timer.function = cisco_timer;\n> -\tst->timer.data = arg;\n> \tadd_timer(&st->timer);\n> }\n> \n> diff --git a/drivers/net/wan/hdlc_fr.c b/drivers/net/wan/hdlc_fr.c\n> index de42faca076a..7da2424c28a4 100644\n> --- a/drivers/net/wan/hdlc_fr.c\n> +++ b/drivers/net/wan/hdlc_fr.c\n> @@ -644,8 +644,6 @@ static void fr_timer(unsigned long arg)\n> \t\t\tstate(hdlc)->settings.t391 * HZ;\n> \t}\n> \n> -\tstate(hdlc)->timer.function = fr_timer;\n> -\tstate(hdlc)->timer.data = arg;\n> \tadd_timer(&state(hdlc)->timer);\n> }","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkRxY6RRMz9s3w\n\tfor ;\n\tSat, 2 Sep 2017 04:05:53 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752185AbdIASFo (ORCPT );\n\tFri, 1 Sep 2017 14:05:44 -0400","from inx.pm.waw.pl ([91.202.125.194]:34618 \"EHLO inx.pm.waw.pl\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1750955AbdIASFn (ORCPT );\n\tFri, 1 Sep 2017 14:05:43 -0400","by inx.pm.waw.pl (Postfix, from userid 2530)\n\tid 50AB629934; Fri, 1 Sep 2017 19:57:47 +0200 (CEST)"],"X-Greylist":"delayed 397 seconds by postgrey-1.27 at vger.kernel.org;\n\tFri, 01 Sep 2017 14:05:42 EDT","From":"Krzysztof Halasa ","To":"Kees Cook ","Cc":"Thomas Gleixner ,\n\tAditya Shankar ,\n\tGanesh Krishna ,\n\tGreg Kroah-Hartman ,\n\tJens Axboe , netdev@vger.kernel.org,\n\tlinux-wireless@vger.kernel.org, devel@driverdev.osuosl.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH 13/31] timer: Remove meaningless .data/.function\n\tassignments","References":"<1504222183-61202-1-git-send-email-keescook@chromium.org>\n\t<1504222183-61202-14-git-send-email-keescook@chromium.org>","Date":"Fri, 01 Sep 2017 19:59:02 +0200","In-Reply-To":"<1504222183-61202-14-git-send-email-keescook@chromium.org> (Kees\n\tCook's message of \"Thu, 31 Aug 2017 16:29:25 -0700\")","Message-ID":"","MIME-Version":"1.0","Content-Type":"text/plain","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1761956,"web_url":"http://patchwork.ozlabs.org/comment/1761956/","msgid":"","list_archive_url":null,"date":"2017-09-01T20:07:32","subject":"Re: [PATCH 13/31] timer: Remove meaningless .data/.function\n\tassignments","submitter":{"id":4515,"url":"http://patchwork.ozlabs.org/api/people/4515/","name":"Jens Axboe","email":"axboe@kernel.dk"},"content":"On 08/31/2017 05:29 PM, Kees Cook wrote:\n> Several timer users needlessly reset their .function/.data fields during\n> their timer callback, but nothing else changes them. Some users do not\n> use their .data field at all. Each instance is removed here.\n\nFor amiflop:\n\nAcked-by: Jens Axboe ","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=kernel-dk.20150623.gappssmtp.com\n\theader.i=@kernel-dk.20150623.gappssmtp.com\n\theader.b=\"UAOzfD7X\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkVfJ59B5z9sPt\n\tfor ;\n\tSat, 2 Sep 2017 06:07:52 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752357AbdIAUHh (ORCPT );\n\tFri, 1 Sep 2017 16:07:37 -0400","from mail-pf0-f171.google.com ([209.85.192.171]:33075 \"EHLO\n\tmail-pf0-f171.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750955AbdIAUHf (ORCPT\n\t); Fri, 1 Sep 2017 16:07:35 -0400","by mail-pf0-f171.google.com with SMTP id n73so3330114pfj.0\n\tfor ; Fri, 01 Sep 2017 13:07:35 -0700 (PDT)","from ?IPv6:2620:10d:c081:1131::1118? ([2620:10d:c090:180::1:b5fd])\n\tby smtp.gmail.com with ESMTPSA id\n\tf80sm1327741pfk.46.2017.09.01.13.07.33\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 01 Sep 2017 13:07:33 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=kernel-dk.20150623.gappssmtp.com; s=20150623;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=8kG3+KakX6KvCIegPE4ZIK7D6pNPi6Dhz6DSEVDi8eQ=;\n\tb=UAOzfD7XMrM74TAte7qcrAfwoO8jK0kM2x9hd7On1fv3RWEq16DIL/G4CyO0xBUIxp\n\tJnSILtFWerPUuWBQ3ZIGAAVwqwUZfnkUsm6KE2BshASx20XWj+84MFcX94EX4lm9aRmH\n\tQ7+1YfMKrSKswa3smxi77OgzEPnucHiXw6ZmZcodx+uLYryS7vSpjoXmaLbbK+ahUk46\n\tmcl9xqyReO4I09FQtNS/ZEHWmdh8mzGkprNnhii7pJB8aOsEdfHWT/7ARZ3r8hijiuIB\n\tYD+vNIzNwARnRAN09W2AJjm5M5yZqmTAWeSyYTtupcsmMy/6kSPOMQXEv0x6VkCchfNr\n\tLKcw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=8kG3+KakX6KvCIegPE4ZIK7D6pNPi6Dhz6DSEVDi8eQ=;\n\tb=j3yyXXGxroNUbvhbOjf/ezkdBMUdanDvXNjpnOjLTg0WKGz5/qwv6kqlbO9tqcgpOf\n\tFaY6fyn7UQcZ9iz7MEtjCcSBBlbZwh2VFFE6r7xdl4KSOnBX3TEI5FKo0VUnjyNrqmnM\n\tsaDpfSZV2C+7g1Y5kjjnwBUmnAVmkzHToYcaV1ihx9DzC0o3pzcexC+hgPV2/JB5lTd1\n\tMg4vk8jziDWBA3P78pwKQawwX2h+ZzO0HEOZVa0rCzi3gfeeqNOf2ghPvP5Za6JlDDNX\n\tM9k3yrHS258lmDeLxr+IPsdtCiQuhv+REFuNm4Vu+slyETaILn0THzn6mYMMakbeqtS5\n\tu9YQ==","X-Gm-Message-State":"AHPjjUjsrD0cORlDnPIJy1Oupt6mkCXgtjdCxO2C7P7N7IaQzWbcpBf9\n\tUJEYS23+WDb4hWEL","X-Google-Smtp-Source":"ADKCNb4Up8Dd//yF8RzzYRXJs1WROWv+uDbz9sXIu0LoceomrU2xkqwITwDcnY9EUNL9crFNPgdwmQ==","X-Received":"by 10.99.112.20 with SMTP id l20mr3682546pgc.56.1504296455254;\n\tFri, 01 Sep 2017 13:07:35 -0700 (PDT)","Subject":"Re: [PATCH 13/31] timer: Remove meaningless .data/.function\n\tassignments","To":"Kees Cook , Thomas Gleixner ","Cc":"Krzysztof Halasa ,\n\tAditya Shankar ,\n\tGanesh Krishna ,\n\tGreg Kroah-Hartman ,\n\tnetdev@vger.kernel.org, linux-wireless@vger.kernel.org,\n\tdevel@driverdev.osuosl.org, linux-kernel@vger.kernel.org","References":"<1504222183-61202-1-git-send-email-keescook@chromium.org>\n\t<1504222183-61202-14-git-send-email-keescook@chromium.org>","From":"Jens Axboe ","Message-ID":"","Date":"Fri, 1 Sep 2017 14:07:32 -0600","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<1504222183-61202-14-git-send-email-keescook@chromium.org>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]