[{"id":1762609,"web_url":"http://patchwork.ozlabs.org/comment/1762609/","msgid":"","list_archive_url":null,"date":"2017-09-04T12:55:39","subject":"Re: [PATCH v1 1/3] dt-bindings: nvmem: add description for UniPhier\n\teFuse","submitter":{"id":65882,"url":"http://patchwork.ozlabs.org/api/people/65882/","name":"Masahiro Yamada","email":"yamada.masahiro@socionext.com"},"content":"2017-09-01 8:20 GMT+09:00 Keiji Hayashibara :\n> Add uniphier-efuse dt-bindings documentation.\n>\n> Signed-off-by: Keiji Hayashibara \n> ---\n> .../devicetree/bindings/nvmem/uniphier-efuse.txt | 45 ++++++++++++++++++++++\n> 1 file changed, 45 insertions(+)\n> create mode 100644 Documentation/devicetree/bindings/nvmem/uniphier-efuse.txt\n>\n> diff --git a/Documentation/devicetree/bindings/nvmem/uniphier-efuse.txt b/Documentation/devicetree/bindings/nvmem/uniphier-efuse.txt\n> new file mode 100644\n> index 0000000..09024a2\n> --- /dev/null\n> +++ b/Documentation/devicetree/bindings/nvmem/uniphier-efuse.txt\n> @@ -0,0 +1,45 @@\n> += UniPhier eFuse device tree bindings =\n> +\n> +This UniPhier eFuse must be under soc-glue.\n> +\n> +Required properties:\n> +- compatible: should be \"socionext,uniphier-efuse\"\n> +- reg: should contain the register base and length\n> +\n> += Data cells =\n> +Are child nodes of efuse, bindings of which as described in\n> +bindings/nvmem/nvmem.txt\n> +\n> +Example:\n> +\n> + soc-glue@5f900000 {\n> + compatible = \"socionext,uniphier-ld20-soc-glue-debug\",\n> + \"simple-mfd\";\n> + #address-cells = <1>;\n> + #size-cells = <1>;\n> + ranges = <0x0 0x5f900000 0x2000>;\n\n\nIMHO, I think an empty \"ranges;\" will clarify the code,\nbut it is up to your taste.\n\n\n> +\n> + efuse {\n> + compatible = \"socionext,uniphier-efuse\",\n> + \"syscon\";\n\n\nYou are adding a dedicated driver for \"socionext,uniphier-efuse\".\n\nThen, \"syscon\" as well?\n\n\n\n\n> + reg = <0x100 0xf00>;\n\n\nNot so many efuse registers exist on the SoC.\n\nreg = <0x100 0x200>; will be enough.\n\n\nOr if you want to be strict to the hw spec, you can write as follows:\n\n soc-glue@5f900000 {\n compatible = \"socionext,uniphier-ld20-soc-glue-debug\";\n \"simple-mfd\";\n #address-cells = <1>;\n #size-cells = <1>;\n ranges = <0x0 0x5f900000 0x2000>;\n\n efuse@100 {\n compatible = \"socionext,uniphier-efuse\";\n reg = <0x100 0x28>;\n };\n\n efuse@200 {\n compatible = \"socionext,uniphier-efuse\";\n reg = <0x200 0x68>;\n };\n };\n\n\n\n\n> + #address-cells = <1>;\n> + #size-cells = <1>;\n> +\n> + /* Data cells */\n> + usb_mon: usb_mon {\n> + reg = <0x154 0xc>;\n> + };\n\n\nThis <0x154 0xc> represents 0x5f900254 in CPU address view.\n(0x5f900000 + 0x100 + 0x154)\n\nSo many ranges conversion, and how error-prone..\n\n\n\n\n\n> + };\n> +\n> += Data consumers =\n> +Are device nodes which consume nvmem data cells.\n> +\n> +Example:\n> +\n> + usb {\n> + ...\n> + nvmem-cells = <&usb_mon>;\n> + nvmem-cell-names = \"usb_mon\";\n> + }\n> --\n> 2.7.4\n>\n> --\n> To unsubscribe from this list: send the line \"unsubscribe devicetree\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=nifty.com header.i=@nifty.com\n\theader.b=\"aqaMYLcH\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xm8xR2Gfwz9sNr\n\tfor ;\n\tMon, 4 Sep 2017 22:56:43 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753543AbdIDM4m (ORCPT\n\t);\n\tMon, 4 Sep 2017 08:56:42 -0400","from conssluserg-03.nifty.com ([210.131.2.82]:26701 \"EHLO\n\tconssluserg-03.nifty.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1753537AbdIDM4l (ORCPT\n\t); Mon, 4 Sep 2017 08:56:41 -0400","from mail-yw0-f180.google.com (mail-yw0-f180.google.com\n\t[209.85.161.180]) (authenticated)\n\tby conssluserg-03.nifty.com with ESMTP id v84CuK0v028066;\n\tMon, 4 Sep 2017 21:56:21 +0900","by mail-yw0-f180.google.com with SMTP id x144so1737115ywg.2;\n\tMon, 04 Sep 2017 05:56:21 -0700 (PDT)","by 10.37.164.225 with HTTP; Mon, 4 Sep 2017 05:55:39 -0700 (PDT)"],"DKIM-Filter":"OpenDKIM Filter v2.10.3 conssluserg-03.nifty.com v84CuK0v028066","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com;\n\ts=dec2015msa; t=1504529781;\n\tbh=zf/1SA8JJAOcer7KDUvLvx7d1sa2pEV8zkawZUkMTJY=;\n\th=In-Reply-To:References:From:Date:Subject:To:Cc:From;\n\tb=aqaMYLcHpacVgucIJuUChMklejkQG9zhzRNfC7f1Z55+TXgn4ULkeXH1gbj7ezCUe\n\tkiwUix/lu0slqVWXB9JFTcRyj3hX7ZAuA644Py5DRbp1i9aAsR2sc4197WHj2hx+zt\n\tBk2zwkeaBr/s5mgIzEBFLH0o2sgJXXMVjkho5ultNN5Aru/YUMPsBBRB+oSD1+WbmR\n\tmB5NZ2IVIyHEr5YUhiCN1YVGe8Wx1QSbDhwpbIp9A5IYr78QbS4AJcJjD3x9IP3zqo\n\tY4e2ZHnrjcAQ9jZ8oaW40fkwUamnk2E37DWFyYxscMUYj0CiY/oBlDbaCusMPBtFXq\n\tr6ehCqva10ziw==","X-Nifty-SrcIP":"[209.85.161.180]","X-Gm-Message-State":"AHPjjUjTf58j4jzL1v/4XkRH93LsKayVJeTHR0Cn/s+Njl5tVnGvz47N\n\t0lvS3XnC90MSpGpIOAhxfQ+4ef68tQ==","X-Google-Smtp-Source":"ADKCNb5PMuVhdiWfEEYuOZh8xOgjTIdYj/wcM+OKZzZ8Xg7+RSaZnVJI3+/UXp8kO/hTMuNLahwzZn1cFqiTNT3vS+I=","X-Received":"by 10.37.80.213 with SMTP id e204mr435834ybb.215.1504529780115; \n\tMon, 04 Sep 2017 05:56:20 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1504221620-358-2-git-send-email-hayashibara.keiji@socionext.com>","References":"<1504221620-358-1-git-send-email-hayashibara.keiji@socionext.com>\n\t<1504221620-358-2-git-send-email-hayashibara.keiji@socionext.com>","From":"Masahiro Yamada ","Date":"Mon, 4 Sep 2017 21:55:39 +0900","X-Gmail-Original-Message-ID":"","Message-ID":"","Subject":"Re: [PATCH v1 1/3] dt-bindings: nvmem: add description for UniPhier\n\teFuse","To":"Keiji Hayashibara ","Cc":"Srinivas Kandagatla ,\n\tRob Herring , devicetree@vger.kernel.org,\n\tlinux-arm-kernel ,\n\tLinux Kernel Mailing List ,\n\tMasami Hiramatsu ,\n\tJassi Brar ,\n\tKunihiko Hayashi ,\n\tKiyoshi Owada ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1763004,"web_url":"http://patchwork.ozlabs.org/comment/1763004/","msgid":"<000001d32615$38e1b0c0$aaa51240$@socionext.com>","list_archive_url":null,"date":"2017-09-05T07:04:31","subject":"RE: [PATCH v1 1/3] dt-bindings: nvmem: add description for UniPhier\n\teFuse","submitter":{"id":71746,"url":"http://patchwork.ozlabs.org/api/people/71746/","name":"Keiji Hayashibara","email":"hayashibara.keiji@socionext.com"},"content":"Hello Yamada-san,\n\nThank you for your comment.\n\n> From: Masahiro Yamada [mailto:yamada.masahiro@socionext.com]\n> Sent: Monday, September 4, 2017 9:56 PM\n> \n> 2017-09-01 8:20 GMT+09:00 Keiji Hayashibara\n> :\n> > Add uniphier-efuse dt-bindings documentation.\n> >\n> > Signed-off-by: Keiji Hayashibara \n> > ---\n> > .../devicetree/bindings/nvmem/uniphier-efuse.txt | 45\n> ++++++++++++++++++++++\n> > 1 file changed, 45 insertions(+)\n> > create mode 100644\n> > Documentation/devicetree/bindings/nvmem/uniphier-efuse.txt\n> >\n> > diff --git\n> > a/Documentation/devicetree/bindings/nvmem/uniphier-efuse.txt\n> > b/Documentation/devicetree/bindings/nvmem/uniphier-efuse.txt\n> > new file mode 100644\n> > index 0000000..09024a2\n> > --- /dev/null\n> > +++ b/Documentation/devicetree/bindings/nvmem/uniphier-efuse.txt\n> > @@ -0,0 +1,45 @@\n> > += UniPhier eFuse device tree bindings =\n> > +\n> > +This UniPhier eFuse must be under soc-glue.\n> > +\n> > +Required properties:\n> > +- compatible: should be \"socionext,uniphier-efuse\"\n> > +- reg: should contain the register base and length\n> > +\n> > += Data cells =\n> > +Are child nodes of efuse, bindings of which as described in\n> > +bindings/nvmem/nvmem.txt\n> > +\n> > +Example:\n> > +\n> > + soc-glue@5f900000 {\n> > + compatible = \"socionext,uniphier-ld20-soc-glue-debug\",\n> > + \"simple-mfd\";\n> > + #address-cells = <1>;\n> > + #size-cells = <1>;\n> > + ranges = <0x0 0x5f900000 0x2000>;\n> \n> \n> IMHO, I think an empty \"ranges;\" will clarify the code, but it is up to\n> your taste.\n> \n> \n> > +\n> > + efuse {\n> > + compatible = \"socionext,uniphier-efuse\",\n> > + \"syscon\";\n> \n> \n> You are adding a dedicated driver for \"socionext,uniphier-efuse\".\n> \n> Then, \"syscon\" as well?\n> \n\nSince I was using the syscon interface to implement the driver,\nI specified \"syscon\". It's interface is syscon_node_to_regmap().\n\nI will rethink this in v2.\n\n> \n> \n> > + reg = <0x100 0xf00>;\n> \n> \n> Not so many efuse registers exist on the SoC.\n> \n> reg = <0x100 0x200>; will be enough.\n> \n> \n> Or if you want to be strict to the hw spec, you can write as follows:\n> \n> soc-glue@5f900000 {\n> compatible = \"socionext,uniphier-ld20-soc-glue-debug\";\n> \"simple-mfd\";\n> #address-cells = <1>;\n> #size-cells = <1>;\n> ranges = <0x0 0x5f900000 0x2000>;\n> \n> efuse@100 {\n> compatible = \"socionext,uniphier-efuse\";\n> reg = <0x100 0x28>;\n> };\n> \n> efuse@200 {\n> compatible = \"socionext,uniphier-efuse\";\n> reg = <0x200 0x68>;\n> };\n> };\n> \n> \n> \n> \n> > + #address-cells = <1>;\n> > + #size-cells = <1>;\n> > +\n> > + /* Data cells */\n> > + usb_mon: usb_mon {\n> > + reg = <0x154 0xc>;\n> > + };\n> \n> \n> This <0x154 0xc> represents 0x5f900254 in CPU address view.\n> (0x5f900000 + 0x100 + 0x154)\n> \n> So many ranges conversion, and how error-prone..\n> \n\nYes, indeed...\nI will modify as below.\n\n soc-glue@5f900000 {\n compatible = \"socionext,uniphier-ld20-soc-glue-debug\",\n \"simple-mfd\";\n #address-cells = <1>;\n #size-cells = <1>;\n ranges;\n\n efuse@5f900100 {\n compatible = \"socionext,uniphier-efuse\";\n reg = <0x5f900100 0x28>;\n };\n\n efuse@5f900200 {\n compatible = \"socionext,uniphier-efuse\";\n reg = <0x5f900200 0x68>;\n };\n };\n\n\n> \n> \n> \n> > + };\n> > +\n> > += Data consumers =\n> > +Are device nodes which consume nvmem data cells.\n> > +\n> > +Example:\n> > +\n> > + usb {\n> > + ...\n> > + nvmem-cells = <&usb_mon>;\n> > + nvmem-cell-names = \"usb_mon\";\n> > + }\n> > --\n> > 2.7.4\n> >\n> > --\n> > To unsubscribe from this list: send the line \"unsubscribe devicetree\"\n> > in the body of a message to majordomo@vger.kernel.org More majordomo\n> > info at http://vger.kernel.org/majordomo-info.html\n> \n> \n> \n> --\n> Best Regards\n> Masahiro Yamada\n\nBest Regards,\nKeiji Hayashibara\n\n\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmd4k50tYz9sNc\n\tfor ;\n\tTue, 5 Sep 2017 17:04:38 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750704AbdIEHEh (ORCPT\n\t);\n\tTue, 5 Sep 2017 03:04:37 -0400","from mx.socionext.com ([202.248.49.38]:35826 \"EHLO\n\tmx.socionext.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751046AbdIEHEg (ORCPT );\n\tTue, 5 Sep 2017 03:04:36 -0400","from unknown (HELO iyokan-ex.css.socionext.com) ([172.31.9.54])\n\tby mx.socionext.com with ESMTP; 05 Sep 2017 16:04:34 +0900","from mail.mfilter.local (unknown [10.213.24.62])\n\tby iyokan-ex.css.socionext.com (Postfix) with ESMTP id 0E2E1610C6;\n\tTue, 5 Sep 2017 16:04:35 +0900 (JST)","from 172.31.9.53 (172.31.9.53) by m-FILTER with ESMTP;\n\tTue, 5 Sep 2017 16:04:35 +0900","from yuzu.css.socionext.com (yuzu [172.31.8.45])\n\tby iyokan.css.socionext.com (Postfix) with ESMTP id AE1FC408BD;\n\tTue, 5 Sep 2017 16:04:34 +0900 (JST)","from DESKTOP0FARE34 (unknown [10.213.134.218])\n\tby yuzu.css.socionext.com (Postfix) with ESMTP id 74855120453;\n\tTue, 5 Sep 2017 16:04:34 +0900 (JST)"],"From":"\"Keiji Hayashibara\" ","To":"\"'Masahiro Yamada'\" ","Cc":"\"Srinivas Kandagatla\" , \"Rob Herring\"\n\t, , \"linux-arm-kernel\"\n\t, \"Linux Kernel Mailing List\"\n\t, \"Masami Hiramatsu\"\n\t, \n\t\"Jassi Brar\" , =?utf-8?q?Hayashi=2C_Kunih?=\n\t=?utf-8?b?aWtvL+aelyDpgqblvaY=?= ,\n\t=?utf-8?b?T3dhZGEsIEtpeW9zaGkv5aSn?= =?utf-8?b?5ZKM55SwIOa4heW/lw==?=\n\t","References":"<1504221620-358-1-git-send-email-hayashibara.keiji@socionext.com>\n\t<1504221620-358-2-git-send-email-hayashibara.keiji@socionext.com>\n\t","In-Reply-To":"","Subject":"RE: [PATCH v1 1/3] dt-bindings: nvmem: add description for UniPhier\n\teFuse","Date":"Tue, 5 Sep 2017 16:04:31 +0900","Message-ID":"<000001d32615$38e1b0c0$aaa51240$@socionext.com>","MIME-Version":"1.0","Content-Type":"text/plain;\n charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","X-Mailer":"Microsoft Outlook 15.0","Thread-Index":"AQHTIq+404wQIKzt80GBKvEJt/m0IqKkHfiAgAGl+SA=","Content-Language":"ja","x-securitypolicycheck":"OK by SHieldMailChecker v2.5.2","x-shieldmailcheckerpolicyversion":"POLICY170302","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1767213,"web_url":"http://patchwork.ozlabs.org/comment/1767213/","msgid":"<20170912161546.q5xr5pfdxin3qujf@rob-hp-laptop>","list_archive_url":null,"date":"2017-09-12T16:15:46","subject":"Re: [PATCH v1 1/3] dt-bindings: nvmem: add description for UniPhier\n\teFuse","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Tue, Sep 05, 2017 at 04:04:31PM +0900, Keiji Hayashibara wrote:\n> Hello Yamada-san,\n> \n> Thank you for your comment.\n> \n> > From: Masahiro Yamada [mailto:yamada.masahiro@socionext.com]\n> > Sent: Monday, September 4, 2017 9:56 PM\n> > \n> > 2017-09-01 8:20 GMT+09:00 Keiji Hayashibara\n> > :\n> > > Add uniphier-efuse dt-bindings documentation.\n> > >\n> > > Signed-off-by: Keiji Hayashibara \n> > > ---\n> > > .../devicetree/bindings/nvmem/uniphier-efuse.txt | 45\n> > ++++++++++++++++++++++\n> > > 1 file changed, 45 insertions(+)\n> > > create mode 100644\n> > > Documentation/devicetree/bindings/nvmem/uniphier-efuse.txt\n\n> > > +Example:\n> > > +\n> > > + soc-glue@5f900000 {\n> > > + compatible = \"socionext,uniphier-ld20-soc-glue-debug\",\n> > > + \"simple-mfd\";\n> > > + #address-cells = <1>;\n> > > + #size-cells = <1>;\n> > > + ranges = <0x0 0x5f900000 0x2000>;\n> > \n> > \n> > IMHO, I think an empty \"ranges;\" will clarify the code, but it is up to\n> > your taste.\n> > \n> > \n> > > +\n> > > + efuse {\n> > > + compatible = \"socionext,uniphier-efuse\",\n> > > + \"syscon\";\n> > \n> > \n> > You are adding a dedicated driver for \"socionext,uniphier-efuse\".\n> > \n> > Then, \"syscon\" as well?\n> > \n> \n> Since I was using the syscon interface to implement the driver,\n> I specified \"syscon\". It's interface is syscon_node_to_regmap().\n> \n> I will rethink this in v2.\n> \n> > \n> > \n> > > + reg = <0x100 0xf00>;\n> > \n> > \n> > Not so many efuse registers exist on the SoC.\n> > \n> > reg = <0x100 0x200>; will be enough.\n> > \n> > \n> > Or if you want to be strict to the hw spec, you can write as follows:\n> > \n> > soc-glue@5f900000 {\n> > compatible = \"socionext,uniphier-ld20-soc-glue-debug\";\n> > \"simple-mfd\";\n> > #address-cells = <1>;\n> > #size-cells = <1>;\n> > ranges = <0x0 0x5f900000 0x2000>;\n> > \n> > efuse@100 {\n> > compatible = \"socionext,uniphier-efuse\";\n> > reg = <0x100 0x28>;\n> > };\n> > \n> > efuse@200 {\n> > compatible = \"socionext,uniphier-efuse\";\n> > reg = <0x200 0x68>;\n> > };\n> > };\n> > \n> > \n> > \n> > \n> > > + #address-cells = <1>;\n> > > + #size-cells = <1>;\n> > > +\n> > > + /* Data cells */\n> > > + usb_mon: usb_mon {\n> > > + reg = <0x154 0xc>;\n> > > + };\n> > \n> > \n> > This <0x154 0xc> represents 0x5f900254 in CPU address view.\n> > (0x5f900000 + 0x100 + 0x154)\n> > \n> > So many ranges conversion, and how error-prone..\n> > \n> \n> Yes, indeed...\n> I will modify as below.\n\nPlease don't. A non-empty ranges is preferred. It limits the scope and \nchance for errors (smaller range allows fewer possible values and \nlimits the chances of having address ranges duplicated in multiple \nnodes). But yes, it does add the requirement of doing addition and/or \nOR operations. I can't review whether the address ends up being correct \neither way, but having non-empty ranges helps enforce the other things.\n\nRob\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xs8zc5BJvz9s7f\n\tfor ;\n\tWed, 13 Sep 2017 02:15:56 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751501AbdILQPx (ORCPT\n\t);\n\tTue, 12 Sep 2017 12:15:53 -0400","from mail-io0-f193.google.com ([209.85.223.193]:35055 \"EHLO\n\tmail-io0-f193.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751465AbdILQPs (ORCPT\n\t); Tue, 12 Sep 2017 12:15:48 -0400","by mail-io0-f193.google.com with SMTP id d16so8105313ioj.2;\n\tTue, 12 Sep 2017 09:15:48 -0700 (PDT)","from localhost (216-188-254-6.dyn.grandenetworks.net.\n\t[216.188.254.6]) by smtp.gmail.com with ESMTPSA id\n\tt205sm11228959oig.53.2017.09.12.09.15.46\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 12 Sep 2017 09:15:47 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=HfwGpAUfOIMQ72MV8yuOO1bOB2ZxcI8RnnU3g4kLpw8=;\n\tb=KSoU6o8aQ4OyHDKq/g0Jamudti3qibzl/hi83X0AEhdt7Zv8+XpkQG+wx0J0sorfSG\n\tTqUkUt52O/T3KrGKAmgb8aRiRtQecD+5jJp2DqQDTUSkR4AOF2LaQj2vBbXDfR43gKr/\n\tpzZ/82x2NGDtePYEIBtna1EemS4X6hv+gWMRFxixews5OhezSJ+X+B4NrjJcPYDICMK4\n\tvywz2imeib8Ziqq7GKU/eJcJIc99e06b6wGe38BZP9t+EobTlqL2h7+IRQ1TvqFJs7t8\n\tpzfoCmr9dtGQa607umUZLM2xkeOQISe59zF2ES9IRorTqHSoL/JHreAVaESEC0CFtxVR\n\tuoHg==","X-Gm-Message-State":"AHPjjUjMuOi/dyuN16qB2/z+dXybMCftta/BP28e4ErNHdrUROyV6Ygk\n\ts4yD4zfbRxmxiV/QmDA=","X-Google-Smtp-Source":"AOwi7QDbAcuI34xqIaPM20/R2MaXRbWf5foFoHvcDujemlnZsiKjSEhUJ9z/qGhzWDkBkLdhCjlncw==","X-Received":"by 10.202.179.137 with SMTP id\n\tc131mr15173493oif.298.1505232947625; \n\tTue, 12 Sep 2017 09:15:47 -0700 (PDT)","Date":"Tue, 12 Sep 2017 11:15:46 -0500","From":"Rob Herring ","To":"Keiji Hayashibara ","Cc":"'Masahiro Yamada' , Srinivas Kandagatla\n\t, devicetree@vger.kernel.org,\n\tlinux-arm-kernel , \n\tLinux Kernel Mailing List , \n\tMasami Hiramatsu , \n\tJassi Brar , =?utf-8?q?Hayashi=2C_Kunihik?=\n\t=?utf-8?b?by/mnpcg6YKm5b2m?= ,\n\t=?utf-8?b?T3dhZGEsIEtpeW9zaGkv5aSn?= =?utf-8?b?5ZKM55SwIOa4heW/lw==?=\n\t","Subject":"Re: [PATCH v1 1/3] dt-bindings: nvmem: add description for UniPhier\n\teFuse","Message-ID":"<20170912161546.q5xr5pfdxin3qujf@rob-hp-laptop>","References":"<1504221620-358-1-git-send-email-hayashibara.keiji@socionext.com>\n\t<1504221620-358-2-git-send-email-hayashibara.keiji@socionext.com>\n\t\n\t<000001d32615$38e1b0c0$aaa51240$@socionext.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<000001d32615$38e1b0c0$aaa51240$@socionext.com>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1767469,"web_url":"http://patchwork.ozlabs.org/comment/1767469/","msgid":"<000301d32c38$5fe8a830$1fb9f890$@socionext.com>","list_archive_url":null,"date":"2017-09-13T02:31:16","subject":"RE: [PATCH v1 1/3] dt-bindings: nvmem: add description for UniPhier\n\teFuse","submitter":{"id":71746,"url":"http://patchwork.ozlabs.org/api/people/71746/","name":"Keiji Hayashibara","email":"hayashibara.keiji@socionext.com"},"content":"Hello Rob,\n\nThank you for your comment.\n\n> From: Rob Herring [mailto:robh@kernel.org]\n> Sent: Wednesday, September 13, 2017 1:16 AM\n> \n> On Tue, Sep 05, 2017 at 04:04:31PM +0900, Keiji Hayashibara wrote:\n> > Hello Yamada-san,\n> >\n> > Thank you for your comment.\n> >\n> > > From: Masahiro Yamada [mailto:yamada.masahiro@socionext.com]\n> > > Sent: Monday, September 4, 2017 9:56 PM\n> > >\n> > > 2017-09-01 8:20 GMT+09:00 Keiji Hayashibara\n> > > :\n> > > > Add uniphier-efuse dt-bindings documentation.\n> > > >\n> > > > Signed-off-by: Keiji Hayashibara \n> > > > ---\n> > > > .../devicetree/bindings/nvmem/uniphier-efuse.txt | 45\n> > > ++++++++++++++++++++++\n> > > > 1 file changed, 45 insertions(+)\n> > > > create mode 100644\n> > > > Documentation/devicetree/bindings/nvmem/uniphier-efuse.txt\n> \n> > > > +Example:\n> > > > +\n> > > > + soc-glue@5f900000 {\n> > > > + compatible =\n> \"socionext,uniphier-ld20-soc-glue-debug\",\n> > > > + \"simple-mfd\";\n> > > > + #address-cells = <1>;\n> > > > + #size-cells = <1>;\n> > > > + ranges = <0x0 0x5f900000 0x2000>;\n> > >\n> > >\n> > > IMHO, I think an empty \"ranges;\" will clarify the code, but it is up\n> > > to your taste.\n> > >\n> > >\n> > > > +\n> > > > + efuse {\n> > > > + compatible = \"socionext,uniphier-efuse\",\n> > > > + \"syscon\";\n> > >\n> > >\n> > > You are adding a dedicated driver for \"socionext,uniphier-efuse\".\n> > >\n> > > Then, \"syscon\" as well?\n> > >\n> >\n> > Since I was using the syscon interface to implement the driver, I\n> > specified \"syscon\". It's interface is syscon_node_to_regmap().\n> >\n> > I will rethink this in v2.\n> >\n> > >\n> > >\n> > > > + reg = <0x100 0xf00>;\n> > >\n> > >\n> > > Not so many efuse registers exist on the SoC.\n> > >\n> > > reg = <0x100 0x200>; will be enough.\n> > >\n> > >\n> > > Or if you want to be strict to the hw spec, you can write as follows:\n> > >\n> > > soc-glue@5f900000 {\n> > > compatible =\n> \"socionext,uniphier-ld20-soc-glue-debug\";\n> > > \"simple-mfd\";\n> > > #address-cells = <1>;\n> > > #size-cells = <1>;\n> > > ranges = <0x0 0x5f900000 0x2000>;\n> > >\n> > > efuse@100 {\n> > > compatible = \"socionext,uniphier-efuse\";\n> > > reg = <0x100 0x28>;\n> > > };\n> > >\n> > > efuse@200 {\n> > > compatible = \"socionext,uniphier-efuse\";\n> > > reg = <0x200 0x68>;\n> > > };\n> > > };\n> > >\n> > >\n> > >\n> > >\n> > > > + #address-cells = <1>;\n> > > > + #size-cells = <1>;\n> > > > +\n> > > > + /* Data cells */\n> > > > + usb_mon: usb_mon {\n> > > > + reg = <0x154 0xc>;\n> > > > + };\n> > >\n> > >\n> > > This <0x154 0xc> represents 0x5f900254 in CPU address view.\n> > > (0x5f900000 + 0x100 + 0x154)\n> > >\n> > > So many ranges conversion, and how error-prone..\n> > >\n> >\n> > Yes, indeed...\n> > I will modify as below.\n> \n> Please don't. A non-empty ranges is preferred. It limits the scope and\nchance\n> for errors (smaller range allows fewer possible values and limits the\n> chances of having address ranges duplicated in multiple nodes). But yes,\n> it does add the requirement of doing addition and/or OR operations. I\ncan't\n> review whether the address ends up being correct either way, but having\n> non-empty ranges helps enforce the other things.\n\nI see. \nI will proceed with implementation by non-empty ranges.\n\nBest Regards,\nKeiji Hayashibara\n\n\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xsQf73cPWz9t30\n\tfor ;\n\tWed, 13 Sep 2017 12:31:43 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751778AbdIMCba (ORCPT\n\t);\n\tTue, 12 Sep 2017 22:31:30 -0400","from mx.socionext.com ([202.248.49.38]:46373 \"EHLO\n\tmx.socionext.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751774AbdIMCb2 (ORCPT );\n\tTue, 12 Sep 2017 22:31:28 -0400","from unknown (HELO kinkan-ex.css.socionext.com) ([172.31.9.52])\n\tby mx.socionext.com with ESMTP; 13 Sep 2017 11:31:20 +0900","from mail.mfilter.local (unknown [10.213.24.62])\n\tby kinkan-ex.css.socionext.com (Postfix) with ESMTP id D442C180223;\n\tWed, 13 Sep 2017 11:31:19 +0900 (JST)","from 172.31.9.51 (172.31.9.51) by m-FILTER with ESMTP;\n\tWed, 13 Sep 2017 11:31:19 +0900","from yuzu.css.socionext.com (yuzu [172.31.8.45])\n\tby kinkan.css.socionext.com (Postfix) with ESMTP id 7A9A01A1223;\n\tWed, 13 Sep 2017 11:31:19 +0900 (JST)","from DESKTOP0FARE34 (unknown [10.213.134.218])\n\tby yuzu.css.socionext.com (Postfix) with ESMTP id 437381204AE;\n\tWed, 13 Sep 2017 11:31:19 +0900 (JST)"],"From":"\"Keiji Hayashibara\" ","To":"\"'Rob Herring'\" ","Cc":"=?iso-2022-jp?b?WWFtYWRhLCBNYXNhaGlyby8bJEI7M0VEGyhCIBskQj8/OTAbKEI=?=\n\t, \"Srinivas Kandagatla\"\n\t, ,\n\t\"linux-arm-kernel\" , \n\t\"Linux Kernel Mailing List\" , \n\t\"Masami Hiramatsu\" , \n\t\"Jassi Brar\" , =?iso-2022-jp?b?SGF5YXNo?=\n\t=?iso-2022-jp?b?aSwgS3VuaWhpa28vGyRCTlMbKEIgGyRCSy5JJxsoQg==?=\n\t, =?iso-2022-jp?b?T3dhZGEsIEtpeW9z?=\n\t=?iso-2022-jp?b?aGkvGyRCQmdPQkVEGyhCIBskQkA2O1YbKEI=?=\n\t","References":"<1504221620-358-1-git-send-email-hayashibara.keiji@socionext.com>\n\t<1504221620-358-2-git-send-email-hayashibara.keiji@socionext.com>\n\t\n\t<000001d32615$38e1b0c0$aaa51240$@socionext.com>\n\t<20170912161546.q5xr5pfdxin3qujf@rob-hp-laptop>","In-Reply-To":"<20170912161546.q5xr5pfdxin3qujf@rob-hp-laptop>","Subject":"RE: [PATCH v1 1/3] dt-bindings: nvmem: add description for UniPhier\n\teFuse","Date":"Wed, 13 Sep 2017 11:31:16 +0900","Message-ID":"<000301d32c38$5fe8a830$1fb9f890$@socionext.com>","MIME-Version":"1.0","Content-Type":"text/plain;\n charset=\"iso-2022-jp\"","Content-Transfer-Encoding":"7bit","X-Mailer":"Microsoft Outlook 15.0","Thread-Index":"AQHTIq+404wQIKzt80GBKvEJt/m0IqKkHfiAgA1hdeKAAKck0A==","Content-Language":"ja","x-securitypolicycheck":"OK by SHieldMailChecker v2.5.2","x-shieldmailcheckerpolicyversion":"POLICY170302","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]