[{"id":1761351,"web_url":"http://patchwork.ozlabs.org/comment/1761351/","msgid":"<59A88BDA.9070609@iogearbox.net>","list_archive_url":null,"date":"2017-08-31T22:21:14","subject":"Re: [PATCH v3 net-next 1/7] bpf: Add mark and priority to sock\n\toptions that can be set","submitter":{"id":65705,"url":"http://patchwork.ozlabs.org/api/people/65705/","name":"Daniel Borkmann","email":"daniel@iogearbox.net"},"content":"On 09/01/2017 12:05 AM, David Ahern wrote:\n> Add socket mark and priority to fields that can be set by\n> ebpf program when a socket is created.\n>\n> Signed-off-by: David Ahern \n> Acked-by: Alexei Starovoitov \n> ---\n> include/uapi/linux/bpf.h | 2 ++\n> net/core/filter.c | 26 ++++++++++++++++++++++++++\n> 2 files changed, 28 insertions(+)\n>\n> diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h\n> index d46cf326b95f..e9c89e20adff 100644\n> --- a/include/uapi/linux/bpf.h\n> +++ b/include/uapi/linux/bpf.h\n> @@ -758,6 +758,8 @@ struct bpf_sock {\n> \t__u32 family;\n> \t__u32 type;\n> \t__u32 protocol;\n> +\t__u32 mark;\n> +\t__u32 priority;\n> };\n>\n> #define XDP_PACKET_HEADROOM 256\n> diff --git a/net/core/filter.c b/net/core/filter.c\n> index c6a37fe0285b..f51b9690adf3 100644\n> --- a/net/core/filter.c\n> +++ b/net/core/filter.c\n> @@ -3455,6 +3455,10 @@ static bool sock_filter_is_valid_access(int off, int size,\n> \t\tswitch (off) {\n> \t\tcase offsetof(struct bpf_sock, bound_dev_if):\n> \t\t\tbreak;\n> +\t\tcase offsetof(struct bpf_sock, mark):\n> +\t\t\tbreak;\n> +\t\tcase offsetof(struct bpf_sock, priority):\n> +\t\t\tbreak;\n\nCan also be follow-up, but please do keep this consistent\nto all the other *_is_valid_access() helpers, meaning:\n\n\tswitch (off) {\n\tcase offsetof(struct bpf_sock, bound_dev_if):\n\tcase offsetof(struct bpf_sock, mark):\n\tcase offsetof(struct bpf_sock, priority):\n\t\tbreak;\n\tdefault:\n\t\treturn false;\n\t}\n\nRest:\n\nAcked-by: Daniel Borkmann ","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjxfq0NXpz9s7f\n\tfor ;\n\tFri, 1 Sep 2017 08:21:22 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751309AbdHaWVS (ORCPT );\n\tThu, 31 Aug 2017 18:21:18 -0400","from www62.your-server.de ([213.133.104.62]:44182 \"EHLO\n\twww62.your-server.de\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750925AbdHaWVS (ORCPT\n\t); Thu, 31 Aug 2017 18:21:18 -0400","from [92.105.166.74] (helo=localhost.localdomain)\n\tby www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-SHA:256)\n\t(Exim 4.85_2) (envelope-from )\n\tid 1dnXpr-0004X0-9o; Fri, 01 Sep 2017 00:21:15 +0200"],"Message-ID":"<59A88BDA.9070609@iogearbox.net>","Date":"Fri, 01 Sep 2017 00:21:14 +0200","From":"Daniel Borkmann ","User-Agent":"Mozilla/5.0 (X11; Linux x86_64;\n\trv:31.0) Gecko/20100101 Thunderbird/31.7.0","MIME-Version":"1.0","To":"David Ahern , netdev@vger.kernel.org, ast@kernel.org","Subject":"Re: [PATCH v3 net-next 1/7] bpf: Add mark and priority to sock\n\toptions that can be set","References":"<1504217150-16151-1-git-send-email-dsahern@gmail.com>\n\t<1504217150-16151-2-git-send-email-dsahern@gmail.com>","In-Reply-To":"<1504217150-16151-2-git-send-email-dsahern@gmail.com>","Content-Type":"text/plain; charset=windows-1252; format=flowed","Content-Transfer-Encoding":"7bit","X-Authenticated-Sender":"daniel@iogearbox.net","X-Virus-Scanned":"Clear (ClamAV 0.99.2/23748/Thu Aug 31 22:37:36 2017)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]