[{"id":1761327,"web_url":"http://patchwork.ozlabs.org/comment/1761327/","msgid":"","list_archive_url":null,"date":"2017-08-31T21:36:01","subject":"Re: RFC: Revert move default dialect from CIFS to to SMB3","submitter":{"id":72269,"url":"http://patchwork.ozlabs.org/api/people/72269/","name":"Thorsten Leemhuis","email":"linux@leemhuis.info"},"content":"Lo! To give a bit more background to this (the mail I reply to was the\nfirst I sent with git send-email and I missed some details): Maybe I'm\nover stretching my abilities/position as regression tracker with this\nRFC for a revert, but I hope it at least triggers a discussion if such a\nrevert should be done or not.\n\nThe problem described in below patch description is known for a few\nweeks already, but the bugzilla entry about it got ignored by the CIFS\ndevelopers; the same happened to a mail one affected user sent to\ncifs-devel.\n\nI should have send this revert RFC earlier, because I think more users\nwill be confused by the switch to SMB3, because the error messages they\nget when trying to mount a SMB1/CIFS only share are not very helpful. I\nmyself had one system which regressed and made me look closer. And I\nheard at least some widespread NAS boxes only support CIFS/SMB1 by\ndefault :-/\n\nNote: I only light-tested this revert and it worked fine for me (I still\ncould mount a CIFS/SMB1 only samba share and was still able to mount a\nsamba share on a different host with SMB3). But I'm not familiar with\nthe code I modify here. Hence someone who is (Steven?) IMHO should ACK\nthis before it gets applied.\n\nCiao, Thorsten\n\n\nOn 31.08.2017 23:01, Thorsten Leemhuis wrote:\n> This reverts commit eef914a9eb5eb83e60eb498315a491cd1edc13a1 (\n> [SMB3] Improve security, move default dialect to SMB3 from old CIFS), \n> as it confuses users: https://bugzilla.kernel.org/show_bug.cgi?id=196599\n> \n> It was a patch to improve security by switching to SMB3 by default and\n> support SMB1 (aka CIFS) only when explicitly requested, as the latter\n> is not considered secure anymore (see below for details). This is one of\n> the rare cases where regressions are unavoidable and accepted in Linux.\n> But that's bad enough already, so we at least should make it easy for\n> people to get an idea why something suddenly stopped working with a\n> newer kernel version. That's not the case, because due to eef914a9eb5e\n> a mount of a server that only supports CIFS/SMB1 with mount.cifs fails\n> with a misleading message:\n> \n>> mount error(112): Host is down > Refer to the mount.cifs(8) manual\n>> page (e.g. man mount.cifs)\n> \n> The corresponding message in the kernel log is just as unhelpful:\n> \n>> CIFS VFS: cifs_mount failed w/return code = -112\n> \n> This needs to be improved. Hence remove this for now, as the world won't\n> end suddenly if this gets delayed one or two cycles and resubmitted in\n> a way that leads to a more helpful error message.\n> \n> For completeness, here are parts from the original patch description:\n> \n>> Due to recent publicity about security vulnerabilities in the much\n>> older CIFS dialect, move the default dialect to the widely accepted\n>> (and quite secure) SMB3.0 dialect from the old default of the CIFS\n>> dialect.\n>>\n>> We do not want to be encouraging use of less secure dialects, and\n>> both Microsoft and CERT now strongly recommend not using the older\n>> CIFS dialect (SMB Security Best Practices \"recommends disabling\n>> SMBv1\").\n>>\n>> SMB3 is both secure and widely available: in Windows 8 and later,\n>> Samba and Macs.\n>>\n>> Users can still choose to explicitly mount with the less secure\n>> dialect (for old servers) by choosing \"vers=1.0\" on the cifs mount\n> \n> Signed-off-by: Thorsten Leemhuis \n> CC: Steve French \n> CC: Pavel Shilovsky \n> ---\n> fs/cifs/connect.c | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c\n> index 59647eb..6ab261cd 100644\n> --- a/fs/cifs/connect.c\n> +++ b/fs/cifs/connect.c\n> @@ -1272,9 +1272,9 @@ static int cifs_parse_security_flavors(char *value,\n> \n> \tvol->actimeo = CIFS_DEF_ACTIMEO;\n> \n> -\t/* FIXME: add autonegotiation for SMB3 or later rather than just SMB3 */\n> -\tvol->ops = &smb30_operations; /* both secure and accepted widely */\n> -\tvol->vals = &smb30_values;\n> +\t/* FIXME: add autonegotiation -- for now, SMB1 is default */\n> +\tvol->ops = &smb1_operations;\n> +\tvol->vals = &smb1_values;\n> \n> \tvol->echo_interval = SMB_ECHO_INTERVAL_DEFAULT;\n> \n> \n--\nTo unsubscribe from this list: send the line \"unsubscribe linux-cifs\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-cifs-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjwfY6hH0z9s81\n\tfor ;\n\tFri, 1 Sep 2017 07:36:05 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751227AbdHaVgE (ORCPT );\n\tThu, 31 Aug 2017 17:36:04 -0400","from wp227.webpack.hosteurope.de ([80.237.132.234]:51718 \"EHLO\n\twp227.webpack.hosteurope.de\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1751009AbdHaVgE (ORCPT\n\t);\n\tThu, 31 Aug 2017 17:36:04 -0400","from ip4d15e3ad.dynamic.kabel-deutschland.de ([77.21.227.173]\n\thelo=[192.168.66.118]); authenticated\n\tby wp227.webpack.hosteurope.de running ExIM with esmtpsa\n\t(TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n\tid 1dnX86-0007Ak-4m; Thu, 31 Aug 2017 23:36:02 +0200"],"Subject":"Re: RFC: Revert move default dialect from CIFS to to SMB3","To":"Steve French ","Cc":"Linus Torvalds ,\n\tLinux Kernel Mailing List ,\n\tlinux-cifs@vger.kernel.org, Pavel Shilovsky ","References":"<1504213298-27431-1-git-send-email-linux@leemhuis.info>","From":"Thorsten Leemhuis ","Message-ID":"","Date":"Thu, 31 Aug 2017 23:36:01 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1504213298-27431-1-git-send-email-linux@leemhuis.info>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-MW","Content-Transfer-Encoding":"8bit","X-bounce-key":"webpack.hosteurope.de; linux@leemhuis.info; 1504215364;\n\tc5e7f2c2; ","X-HE-SMSGID":"1dnX86-0007Ak-4m","Sender":"linux-cifs-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-cifs@vger.kernel.org"}},{"id":1761395,"web_url":"http://patchwork.ozlabs.org/comment/1761395/","msgid":"","list_archive_url":null,"date":"2017-09-01T00:12:09","subject":"Re: RFC: Revert move default dialect from CIFS to to SMB3","submitter":{"id":97,"url":"http://patchwork.ozlabs.org/api/people/97/","name":"Linus Torvalds","email":"torvalds@linux-foundation.org"},"content":"On Thu, Aug 31, 2017 at 2:36 PM, Thorsten Leemhuis wrote:\n> Lo! To give a bit more background to this (the mail I reply to was the\n> first I sent with git send-email and I missed some details): Maybe I'm\n> over stretching my abilities/position as regression tracker with this\n> RFC for a revert, but I hope it at least triggers a discussion if such a\n> revert should be done or not.\n\nI don't think that a revert is appropriate.\n\nBut perhaps just a single printk() or something if the user does *not*\nspecify the version explicitly? Just saying something like\n\n We used to default to 1.0, we now default to 3.0, if you want old\ndefaults, use \"vers=1.0\"\n\nOh, looking at that version parsing code, I think we also need to fix\nthat legacy \"ver=1\" thing (ver without the 's') which now silently\nignores \"ver=1\" as being the \"default\", even though it's not.\n\nI do *not* believe that \"default to version 1\" is acceptable.\n\n Linus\n--\nTo unsubscribe from this list: send the line \"unsubscribe linux-cifs\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-cifs-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"RYnqenpt\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xk06j0Jjcz9s7p\n\tfor ;\n\tFri, 1 Sep 2017 10:12:12 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751307AbdIAAML (ORCPT );\n\tThu, 31 Aug 2017 20:12:11 -0400","from mail-io0-f173.google.com ([209.85.223.173]:36826 \"EHLO\n\tmail-io0-f173.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751336AbdIAAMK (ORCPT\n\t); Thu, 31 Aug 2017 20:12:10 -0400","by mail-io0-f173.google.com with SMTP id f99so8022016ioi.3;\n\tThu, 31 Aug 2017 17:12:10 -0700 (PDT)","by 10.107.30.9 with HTTP; Thu, 31 Aug 2017 17:12:09 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=SmeoYzk6Am6pfHedwAM1YgwSrvyxmeRDESIut7HOwwI=;\n\tb=RYnqenptqZWr7uqscDu8/4oytazAd5YM1ST1+rhnWOUqHuVC6rm7PEpAP1fH3hp9hN\n\t8KYPnie8Hq/Q6AbrH8ODBTGJAVl4CJzYOyqVU50/jk2mRiXeH6Ahdssq/pgIePva6OUe\n\tWTXF+D04kYkSor3wvKr1FhnosocKJKUL/5sMHEmzgLrvQQfMgfEhkI20yNxJ6KL3YjUc\n\tP+xr60on+UEm9UpC92mWwxoMAlsElbs69JaqmqTeWkm3qZubEgxnderYj0rebyC1LUv9\n\tKpYe+J7aCbWk69ww5DyWx0hPOcDMpOWf9pD8ZhtXPHjLDer0yhTWcwoc1VrMuX+nYAjY\n\tMqSg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=SmeoYzk6Am6pfHedwAM1YgwSrvyxmeRDESIut7HOwwI=;\n\tb=FrPP3t8rQxwgiAoajkrq5xGmJRsgriCUZGfiXi2Y3qL6e4vyAueG3FCULHEQvQNd9K\n\th9oiz1WUVBiun4SSfsWBQnm7uyMPosz7d+Goxwavvvi8IEYYYETgDviukeCTDd9yzOfx\n\t3pisLuygBSeBkW/RFigIjPEjI6k+rnKbqhmpBGdnyr4fOo/2I//koofRdB4REhtP+ShM\n\tEO/ykHKolhnr2/Lt/lSjQeWKD5Og4V+lvZexE0YsbFiC7LE2CRjYhMxU9IJDJf3nkW8N\n\tOB/yj/s1tN3m3p4b0ix115ankCopWyNyj0dGD3g6afvTKBWa5+woemodLLc3pDaE44Rh\n\t78Hg==","X-Gm-Message-State":"AHPjjUgJ/klwIy0hgEcw3u/oi0vQF70SS/GkI718pXsieOxsMlXx9nLs\n\t0uBbQS5Q+baj8IdxR5lICBrRSRzrFA==","X-Google-Smtp-Source":"ADKCNb7kcuJm+fqBiE/OR8I9ezgNwvnHs447fcz0sz/fSGaodRdHVPzzJbHxyf2waevcEMJWbvyKVvJMsgJufP0CNtU=","X-Received":"by 10.107.33.141 with SMTP id h135mr159592ioh.179.1504224730218; \n\tThu, 31 Aug 2017 17:12:10 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<1504213298-27431-1-git-send-email-linux@leemhuis.info>\n\t","From":"Linus Torvalds ","Date":"Thu, 31 Aug 2017 17:12:09 -0700","X-Google-Sender-Auth":"iVzLorCwOwo0lnWLyLaUV4cb9gg","Message-ID":"","Subject":"Re: RFC: Revert move default dialect from CIFS to to SMB3","To":"Thorsten Leemhuis ","Cc":"Steve French ,\n\tLinux Kernel Mailing List ,\n\t\"linux-cifs@vger.kernel.org\" ,\n\tPavel Shilovsky ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-cifs-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-cifs@vger.kernel.org"}},{"id":1761405,"web_url":"http://patchwork.ozlabs.org/comment/1761405/","msgid":"<59A8A3E2.40804@tlinx.org>","list_archive_url":null,"date":"2017-09-01T00:03:46","subject":"Re: RFC: Revert move default dialect from CIFS to to SMB3\"","submitter":{"id":72271,"url":"http://patchwork.ozlabs.org/api/people/72271/","name":"L. A. Walsh","email":"linux-cifs@tlinx.org"},"content":"Thorsten Leemhuis wrote:\n> This reverts commit eef914a9eb5eb83e60eb498315a491cd1edc13a1 (\n> [SMB3] Improve security, move default dialect to SMB3 from old CIFS), \n> as it confuses users: https://bugzilla.kernel.org/show_bug.cgi?id=196599\n>\n> It was a patch to improve security by switching to SMB3 by default and\n> support SMB1 (aka CIFS) only when explicitly requested, as the latter\n> is not considered secure anymore (see below for details). This is one of\n> the rare cases where regressions are unavoidable and accepted in Linux.\n> \n----\n Why not SMB2.1? Win7 is still in support and getting security updates.\nMS has not issued any updates for Win7 upgrading it to SMB3.0 for any\nreason (that I'm aware of) -- including security. \n\n If there were security problems in Win7 w/SMB2.1, wouldn't MS\nissue patches -- as they did for WinXP just recently for a severe\nSMB1 bug?\n\n Seems like if they are willing to patch \"out of support\" XP, for\na serious problem, then they would be more likely to patch Win7 for\nlesser problems.\n\n Seems like jumping the default to MS's latest and greatest puts\nlinux on MS's OS-release schedule -- especially when they haven't declared\nSMB2.1 as \"bad\"... From what I understand, most of the new security\nfeatures in 3.0 when into SMB2.1 or 2.0.\n\n>> SMB3 is both secure and widely available: in Windows 8 and later,\n>> Samba and Macs.\n>> \n----\n I can't find more recent stats than last Dec, but Win7 had between\n2-3X the number of Win8 users AND Win7 had between 40-100% more uses\nthan Win10. Win 8 was pretty much a non-starter.\n(http://www.zdnet.com/article/windows-10-versus-windows-7-whose-numbers-do-you-trust/)\n\nAs of March 2017, another article showed Win7 growing w/r/t Win10:\n(https://www.theinquirer.net/inquirer/news/3005602/windows-7-market-share-rises-at-the-expense-of-windows-10)\n\n I can't say moving the default away from SMB1 seems like a bad thing \n-- especially if the error messages can be improved. Besides security, its\nnotably slower, but many home devices still use SMB1 -- which is *fine*,\nif they are not exposed to the outside net. Then again, I've never\nput a Windows machine facing the internet -- don't think they are security\nenough -- use linux for that.\n\n\n>\n> \n--\nTo unsubscribe from this list: send the line \"unsubscribe linux-cifs\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-cifs-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xk0WC67Rnz9s7c\n\tfor ;\n\tFri, 1 Sep 2017 10:29:59 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751793AbdIAA36 (ORCPT );\n\tThu, 31 Aug 2017 20:29:58 -0400","from ishtar.tlinx.org ([173.164.175.65]:37218 \"EHLO\n\tIshtar.sc.tlinx.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751776AbdIAA36 (ORCPT\n\t); Thu, 31 Aug 2017 20:29:58 -0400","from [192.168.3.12] (Athenae [192.168.3.12])\n\tby Ishtar.sc.tlinx.org (8.14.7/8.14.4/SuSE Linux 0.8) with ESMTP id\n\tv8103kGg036943; Thu, 31 Aug 2017 17:03:49 -0700"],"X-Greylist":"delayed 1561 seconds by postgrey-1.27 at vger.kernel.org;\n\tThu, 31 Aug 2017 20:29:57 EDT","Message-ID":"<59A8A3E2.40804@tlinx.org>","Date":"Thu, 31 Aug 2017 17:03:46 -0700","From":"\"L. A. Walsh\" ","User-Agent":"Thunderbird","MIME-Version":"1.0","To":"Thorsten Leemhuis ","CC":"linux-cifs@vger.kernel.org","Subject":"Re: RFC: Revert move default dialect from CIFS to to SMB3\"","References":"<1504213298-27431-1-git-send-email-linux@leemhuis.info>","In-Reply-To":"<1504213298-27431-1-git-send-email-linux@leemhuis.info>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Sender":"linux-cifs-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-cifs@vger.kernel.org"}},{"id":1761406,"web_url":"http://patchwork.ozlabs.org/comment/1761406/","msgid":"","list_archive_url":null,"date":"2017-09-01T00:29:42","subject":"Re: RFC: Revert move default dialect from CIFS to to SMB3","submitter":{"id":510,"url":"http://patchwork.ozlabs.org/api/people/510/","name":"Steve French","email":"smfrench@gmail.com"},"content":"Yes - updating the parsing slightly and printks as suggested makes sense\n\nSome additional warning messages in the userspace helper (adding Jeff\nLayton), mount.cifs can also help.\n\nI also have an experimental set of patches to allow multi-dialect\nnegotiation with at least three of the acceptable dialects\n(smb2.1/smb3/smb3.02) which will help, but complicate secure dialect\nvalidation (\"validate negotiate\") but that will have to wait till next\nrelease.\n\nOn Thu, Aug 31, 2017 at 7:12 PM, Linus Torvalds\n wrote:\n> On Thu, Aug 31, 2017 at 2:36 PM, Thorsten Leemhuis wrote:\n>> Lo! To give a bit more background to this (the mail I reply to was the\n>> first I sent with git send-email and I missed some details): Maybe I'm\n>> over stretching my abilities/position as regression tracker with this\n>> RFC for a revert, but I hope it at least triggers a discussion if such a\n>> revert should be done or not.\n>\n> I don't think that a revert is appropriate.\n>\n> But perhaps just a single printk() or something if the user does *not*\n> specify the version explicitly? Just saying something like\n>\n> We used to default to 1.0, we now default to 3.0, if you want old\n> defaults, use \"vers=1.0\"\n>\n> Oh, looking at that version parsing code, I think we also need to fix\n> that legacy \"ver=1\" thing (ver without the 's') which now silently\n> ignores \"ver=1\" as being the \"default\", even though it's not.\n>\n> I do *not* believe that \"default to version 1\" is acceptable.\n>\n> Linus","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-cifs-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"uoA8H5+x\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xk0Wb6G5yz9s7c\n\tfor ;\n\tFri, 1 Sep 2017 10:30:19 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751914AbdIAAaG (ORCPT );\n\tThu, 31 Aug 2017 20:30:06 -0400","from mail-pg0-f44.google.com ([74.125.83.44]:37403 \"EHLO\n\tmail-pg0-f44.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751787AbdIAAaD (ORCPT\n\t); Thu, 31 Aug 2017 20:30:03 -0400","by mail-pg0-f44.google.com with SMTP id 83so3407972pgb.4;\n\tThu, 31 Aug 2017 17:30:03 -0700 (PDT)","by 10.100.237.100 with HTTP; Thu, 31 Aug 2017 17:29:42 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=ekijDY/neAMSc/o/bbU1338cWKQQqFkrohBmvYWUl3s=;\n\tb=uoA8H5+xNj8aXndO34y1tSF6VJaYvKB+64kVBnpOmDqMmTLDAlaqG/DO8cNERNt9P2\n\tSLsqZLW9RLKOayO1S5Id3Dduy77fnyJXOYfa13vdFEtYOQ+ECnpM3XujzRkjCPyR73sA\n\th8baISYiA7D6ifMciyyvvmz948YXhbFpNOVVj2XJ7ioRyqsr/zWZmIrcn+ho+ODMfncq\n\t1fiisRQVBPpR7q/d+LwG4T85jh6Pmq4eWQv5P/QoPR4csCAbQLyt44jGb4vS2BQWAN8B\n\t49B4u66qKHUtbntTMnPCZ1qVPTZa58g8OADb3alC084viH1kWVrZYILSpCSQ1CpFn44P\n\tjxVw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=ekijDY/neAMSc/o/bbU1338cWKQQqFkrohBmvYWUl3s=;\n\tb=AEy+95009S4lO1dDkva1vBYKARgdPrKzFgE0e5DGnwGajxfHYsauI8CgeEEmEBkFdX\n\tvMWNdjrkLntjIAzJIqsJjatte6Rth7fybHR9ECkWxgmdxSrZEyPP8k9dMsH6Zth9cqeb\n\tezvtw6IGqW+6VeXiRNSluFiM2kKanbrlaUznHmiqPh7r0FkUbtZORxNSJEZQgniUzMmQ\n\tYWZTDUYYUug8zwOf2tcGeIXyPKhVyjGFnHpP0qF/+tVMNITW6DO0jJEOcrqTt3N1xljS\n\t592eg47AAZAHrYGJdFuSCrUE0e09ZbfeJn28iKSMjiTOcg9klUtvM2qAF89/wEpQI2et\n\tNmrA==","X-Gm-Message-State":"AHPjjUg6VzG15hOJQK45PkRePgPOZjaaBxnDtrbIJ+Cy9ZPQNyN6hdD8\n\tuIbFnROseVejIL1VMOeYsywZ1fB/rw==","X-Google-Smtp-Source":"ADKCNb4LCq0rQCE9YhxlEa5HBduvMMqyqS5Wp8DpmYYgso4VAexdqdH4qdPfavAd137sqVGRl7OpEjB9yh3zgwovBOA=","X-Received":"by 10.98.212.73 with SMTP id u9mr290027pfl.328.1504225802818;\n\tThu, 31 Aug 2017 17:30:02 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<1504213298-27431-1-git-send-email-linux@leemhuis.info>\n\t\n\t","From":"Steve French ","Date":"Thu, 31 Aug 2017 19:29:42 -0500","Message-ID":"","Subject":"Re: RFC: Revert move default dialect from CIFS to to SMB3","To":"Linus Torvalds ","Cc":"Thorsten Leemhuis ,\n\tLinux Kernel Mailing List ,\n\t\"linux-cifs@vger.kernel.org\" ,\n\tPavel Shilovsky , Jeff Layton ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-cifs-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-cifs@vger.kernel.org"}},{"id":1761441,"web_url":"http://patchwork.ozlabs.org/comment/1761441/","msgid":"","list_archive_url":null,"date":"2017-09-01T02:42:35","subject":"Re: RFC: Revert move default dialect from CIFS to to SMB3","submitter":{"id":510,"url":"http://patchwork.ozlabs.org/api/people/510/","name":"Steve French","email":"smfrench@gmail.com"},"content":"Any thoughts on this patch to add additional warnings for the user -\nlogging when using default dialects (or when server returns dialect\nnot supported), and noting the default dialect change?\n\nSee https://git.samba.org/?p=sfrench/cifs-2.6.git;a=commit;h=bb86f22eeddbb5879675b55168b8fa8990d74a21\n\nOn Thu, Aug 31, 2017 at 7:29 PM, Steve French wrote:\n> Yes - updating the parsing slightly and printks as suggested makes sense\n>\n> Some additional warning messages in the userspace helper (adding Jeff\n> Layton), mount.cifs can also help.\n>\n> I also have an experimental set of patches to allow multi-dialect\n> negotiation with at least three of the acceptable dialects\n> (smb2.1/smb3/smb3.02) which will help, but complicate secure dialect\n> validation (\"validate negotiate\") but that will have to wait till next\n> release.\n>\n> On Thu, Aug 31, 2017 at 7:12 PM, Linus Torvalds\n> wrote:\n>> On Thu, Aug 31, 2017 at 2:36 PM, Thorsten Leemhuis wrote:\n>>> Lo! To give a bit more background to this (the mail I reply to was the\n>>> first I sent with git send-email and I missed some details): Maybe I'm\n>>> over stretching my abilities/position as regression tracker with this\n>>> RFC for a revert, but I hope it at least triggers a discussion if such a\n>>> revert should be done or not.\n>>\n>> I don't think that a revert is appropriate.\n>>\n>> But perhaps just a single printk() or something if the user does *not*\n>> specify the version explicitly? Just saying something like\n>>\n>> We used to default to 1.0, we now default to 3.0, if you want old\n>> defaults, use \"vers=1.0\"\n>>\n>> Oh, looking at that version parsing code, I think we also need to fix\n>> that legacy \"ver=1\" thing (ver without the 's') which now silently\n>> ignores \"ver=1\" as being the \"default\", even though it's not.\n>>\n>> I do *not* believe that \"default to version 1\" is acceptable.\n>>\n>> Linus\n>\n>\n>\n> --\n> Thanks,\n>\n> Steve","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-cifs-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"JNJtitbz\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xk3Sg3cfBz9s83\n\tfor ;\n\tFri, 1 Sep 2017 12:42:59 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750925AbdIACm6 (ORCPT );\n\tThu, 31 Aug 2017 22:42:58 -0400","from mail-pf0-f180.google.com ([209.85.192.180]:34677 \"EHLO\n\tmail-pf0-f180.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751009AbdIACm5 (ORCPT\n\t); Thu, 31 Aug 2017 22:42:57 -0400","by mail-pf0-f180.google.com with SMTP id l87so4224565pfj.1\n\tfor ;\n\tThu, 31 Aug 2017 19:42:57 -0700 (PDT)","by 10.100.237.100 with HTTP; Thu, 31 Aug 2017 19:42:35 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=4eOWPUr97lA1r7ZjM7aXP7Vjl8aClfcZMl+q67xrtMQ=;\n\tb=JNJtitbzIL23Knp9ci3j8HJRCrPVfr+lDQD8FQfbwibbCMQXbXYtiYZdnYviz8WfCm\n\tXBG1y+uIFAQQhadl4jxl2HBZ//kthAIIah1plDvWlXP78NILmikUdGoRj4Q1V6Bh2T8F\n\tnwgDyuRPgclG4H04swSdRST/zyekhy4xWVfwW9IiVsatBRdWn5oke9Zt9aHPJfMiLJDU\n\tUwWXxVnPH3uoU9GVGxl2BiCwihLJqLrDwccIaOkNewMm9YzBJaIOzNDg1LxakvW1v8dG\n\tCBYA2nQrtbBOXQuYqntbsoI7m4kyCUwDux9rNwfI5NHD76CeFVOSKjDQvw/C8EwBUpzq\n\tiFsw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=4eOWPUr97lA1r7ZjM7aXP7Vjl8aClfcZMl+q67xrtMQ=;\n\tb=tJZ/drs7Re+RRFMIutSMIRNO8VrGVV8LWMYAk9O4CwLEK53EA9G2KzeSp3D0ZMoiqy\n\tCoJTV8wHN15VB+AhUIP1zP9YSzWQzgzar5784rgECZ2td17WTg1eIF+Tsb0xBWxWjucc\n\tTh1aN3BHAAoSbO3GrR8ITlEDNi+I/Z0xPBqSukmzHF96UqNARXufU61iXiUIGE1rvExr\n\t99DDzCeExRLtxSnThqsF7Q90fVy35/GFE4UPZNM26wTw+8hfFw21aNQnhzAljax22C3L\n\tffmd0aeQo06Aoruy4fp82p75aIKPJak+4Qn3W7jKkbMJxkbUTuyt0kxYPkcE8YfdNERu\n\tCqXw==","X-Gm-Message-State":"AHPjjUivR5uhQCL01krcQSqwu3tJQt0oyprftdd9C3ELEzct/lXFMtFI\n\thot96TBzXyiEIM7PN7H8ZOWHQKWLKQ==","X-Google-Smtp-Source":"ADKCNb5B3YLLHq3LOXdg/2i6ifKHwOQVKHcCapS5Sob0voRLfh14/H2oN9NWfipdEsTx86JPNXkUVfp6kWIULhZAwe0=","X-Received":"by 10.84.128.36 with SMTP id 33mr624801pla.212.1504233776396;\n\tThu, 31 Aug 2017 19:42:56 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<1504213298-27431-1-git-send-email-linux@leemhuis.info>\n\t\n\t\n\t","From":"Steve French ","Date":"Thu, 31 Aug 2017 21:42:35 -0500","Message-ID":"","Subject":"Re: RFC: Revert move default dialect from CIFS to to SMB3","To":"Pavel Shilovskiy ,\n\tronnie sahlberg ","Cc":"Thorsten Leemhuis ,\n\t\"linux-cifs@vger.kernel.org\" ,\n\tJeff Layton ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-cifs-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-cifs@vger.kernel.org"}},{"id":1761449,"web_url":"http://patchwork.ozlabs.org/comment/1761449/","msgid":"","list_archive_url":null,"date":"2017-09-01T03:06:45","subject":"Re: RFC: Revert move default dialect from CIFS to to SMB3","submitter":{"id":6089,"url":"http://patchwork.ozlabs.org/api/people/6089/","name":"ronnie sahlberg","email":"ronniesahlberg@gmail.com"},"content":"Two missing \\n in connect.c\n\nFix those and you can add a\nReviewed-by: Ronnie Sahlberg \n\nOn Fri, Sep 1, 2017 at 12:42 PM, Steve French wrote:\n> Any thoughts on this patch to add additional warnings for the user -\n> logging when using default dialects (or when server returns dialect\n> not supported), and noting the default dialect change?\n>\n> See https://git.samba.org/?p=sfrench/cifs-2.6.git;a=commit;h=bb86f22eeddbb5879675b55168b8fa8990d74a21\n>\n> On Thu, Aug 31, 2017 at 7:29 PM, Steve French wrote:\n>> Yes - updating the parsing slightly and printks as suggested makes sense\n>>\n>> Some additional warning messages in the userspace helper (adding Jeff\n>> Layton), mount.cifs can also help.\n>>\n>> I also have an experimental set of patches to allow multi-dialect\n>> negotiation with at least three of the acceptable dialects\n>> (smb2.1/smb3/smb3.02) which will help, but complicate secure dialect\n>> validation (\"validate negotiate\") but that will have to wait till next\n>> release.\n>>\n>> On Thu, Aug 31, 2017 at 7:12 PM, Linus Torvalds\n>> wrote:\n>>> On Thu, Aug 31, 2017 at 2:36 PM, Thorsten Leemhuis wrote:\n>>>> Lo! To give a bit more background to this (the mail I reply to was the\n>>>> first I sent with git send-email and I missed some details): Maybe I'm\n>>>> over stretching my abilities/position as regression tracker with this\n>>>> RFC for a revert, but I hope it at least triggers a discussion if such a\n>>>> revert should be done or not.\n>>>\n>>> I don't think that a revert is appropriate.\n>>>\n>>> But perhaps just a single printk() or something if the user does *not*\n>>> specify the version explicitly? Just saying something like\n>>>\n>>> We used to default to 1.0, we now default to 3.0, if you want old\n>>> defaults, use \"vers=1.0\"\n>>>\n>>> Oh, looking at that version parsing code, I think we also need to fix\n>>> that legacy \"ver=1\" thing (ver without the 's') which now silently\n>>> ignores \"ver=1\" as being the \"default\", even though it's not.\n>>>\n>>> I do *not* believe that \"default to version 1\" is acceptable.\n>>>\n>>> Linus\n>>\n>>\n>>\n>> --\n>> Thanks,\n>>\n>> Steve\n>\n>\n>\n> --\n> Thanks,\n>\n> Steve\n--\nTo unsubscribe from this list: send the line \"unsubscribe linux-cifs\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-cifs-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"QjQ5KzCJ\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xk4074kpmz9s83\n\tfor ;\n\tFri, 1 Sep 2017 13:06:47 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751086AbdIADGq (ORCPT );\n\tThu, 31 Aug 2017 23:06:46 -0400","from mail-qt0-f181.google.com ([209.85.216.181]:36924 \"EHLO\n\tmail-qt0-f181.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750925AbdIADGq (ORCPT\n\t); Thu, 31 Aug 2017 23:06:46 -0400","by mail-qt0-f181.google.com with SMTP id h15so6082532qta.4\n\tfor ;\n\tThu, 31 Aug 2017 20:06:45 -0700 (PDT)","by 10.12.181.148 with HTTP; Thu, 31 Aug 2017 20:06:45 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=ODK2xIJxI7Z5TtrFU5RcUpA7xoAz/I0TI1dm8gQG51g=;\n\tb=QjQ5KzCJblHVs/5GUxZPKsoSD3WYvFXeXwlMfpgv1TbkspXoXGD1l8f9c0qoPKYeXl\n\tj4ty6J2cTF4CRMCjeAoUgfLz53NXVYICE4tZ56KAuviP4dgBXH75egwEV+Ys+OyiHGgx\n\t47TJdvzyqPNJX0FgOc0I2ickWXICehkmStKJHo1cr9hYPUPmsOdj6Y+ZUhhDYcpsqOLH\n\tRSf7QNOKlR5/cWhPspJyoy399mQv+wQyXxjGMhUt7RfmZOJEtf2QqpPY1r4p4w1RHqRB\n\tzHWVEoy5grL61zDS6Nze9uh8hbv0VydGmuddRubAnAjZDxJ5foZ3MNBAKIPzVyCeGqid\n\tqWnw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=ODK2xIJxI7Z5TtrFU5RcUpA7xoAz/I0TI1dm8gQG51g=;\n\tb=LiO7W3NIl/5UIOaS0Y0cGjtvfrAhhqZAC9e6SzIcolc8qoTKS05WhSohWPtJoNFszK\n\tDekF4sNZgYScXDizEkGO2zfPhaEtXBzxK1ack5esLM1kDsZ5Ehf1wVLuG6J1rmbZnEbf\n\tiG1oBrW7aIRdHqLUF6gwak6yrdJx4/l6vRCdzu9yPBCWAv6C96vs7KwHLsLzf8m/ztAb\n\tz3BkBut8E76fa+tfIuV8dam8yvFKe3cWpcv2GZ0gOJZyEBQRPymqmC6rG7CzpEp6zmcR\n\topV5yywldt7OFYntKPWBEKYYIchjKf9n0KQKmIyVu8ENxitc6apWW3muGHbKMvPOvlhr\n\tNMMA==","X-Gm-Message-State":"AHPjjUgFswUw03xawlDf0CjhssYukFqCfAIu65F8qXt8b4oEsko5VPFt\n\tLej5xioTYZ2OuXqLNaa0FH2SdECpYw==","X-Google-Smtp-Source":"ADKCNb7oB57Q7SqLee1hoAvw+vIgl92CGAGxMzS/15KClb1af0IwC9kywDdSUEc2FpWNZ+SoXI+7jO0ulDppXDDKNwc=","X-Received":"by 10.200.45.37 with SMTP id n34mr704569qta.219.1504235205480;\n\tThu, 31 Aug 2017 20:06:45 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<1504213298-27431-1-git-send-email-linux@leemhuis.info>\n\t\n\t\n\t\n\t","From":"ronnie sahlberg ","Date":"Fri, 1 Sep 2017 13:06:45 +1000","Message-ID":"","Subject":"Re: RFC: Revert move default dialect from CIFS to to SMB3","To":"Steve French ","Cc":"Pavel Shilovskiy ,\n\tThorsten Leemhuis ,\n\t\"linux-cifs@vger.kernel.org\" ,\n\tJeff Layton ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-cifs-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-cifs@vger.kernel.org"}},{"id":1761455,"web_url":"http://patchwork.ozlabs.org/comment/1761455/","msgid":"<1504235519.8023.87.camel@samba.org>","list_archive_url":null,"date":"2017-09-01T03:11:59","subject":"Re: RFC: Revert move default dialect from CIFS to to SMB3\"","submitter":{"id":4270,"url":"http://patchwork.ozlabs.org/api/people/4270/","name":"Andrew Bartlett","email":"abartlet@samba.org"},"content":"On Thu, 2017-08-31 at 17:03 -0700, L. A. Walsh wrote:\n> Thorsten Leemhuis wrote:\n> > This reverts commit eef914a9eb5eb83e60eb498315a491cd1edc13a1 (\n> > [SMB3] Improve security, move default dialect to SMB3 from old\n> > CIFS), \n> > as it confuses users: https://bugzilla.kernel.org/show_bug.cgi?id=1\n> > 96599\n> > \n> > It was a patch to improve security by switching to SMB3 by default\n> > and\n> > support SMB1 (aka CIFS) only when explicitly requested, as the\n> > latter\n> > is not considered secure anymore (see below for details). This is\n> > one of\n> > the rare cases where regressions are unavoidable and accepted in\n> > Linux.\n> >   \n> \n> ----\n>     Why not SMB2.1?  Win7 is still in support and getting security\n> updates.\n> MS has not issued any updates for Win7 upgrading it to SMB3.0 for any\n> reason (that I'm aware of) -- including security. \n> \n>     If there were security problems in Win7 w/SMB2.1, wouldn't MS\n> issue patches -- as they did for WinXP just recently for a severe\n> SMB1 bug?\n\nTo be clear, the issue with SMB1 is lack of integrity protection, in\nparticular on the negotiation, where a client may come to think it had\nto use NTLM(v2) to talk to the server. \n\nThe only protection available on SMB1 is 'smb signing', which is after\nthe negotiation of the authentication protocols etc.\n\n>     Seems like if they are willing to patch \"out of support\" XP, for\n> a serious problem, then they would be more likely to patch Win7 for\n> lesser problems.\n> \n>     Seems like jumping the default to MS's latest and greatest puts\n> linux on MS's OS-release schedule -- especially when they haven't\n> declared\n> SMB2.1 as \"bad\"...  From what I understand, most of the new security\n> features in 3.0 when into SMB2.1 or 2.0.\n\nSadly 'most' turned out not to be good enough to actually secure the\nnegotiation, which is the main weakness. If a change is to be made, I\nthink it should move up to SMB3. \n\nIn terms of Windows versions, Windows 2012R2 is quite popular these\ndays, even if Windows 8.1 still wasn't a great hit. \n\nFinally, I do agree that the move from SMB1 is partly on the basis of a\nfalse premise. It appears that Microsoft's recent declaration of SMB1\nas 'bad' is as much on the basis of coding flaws in their own SMB1\nimplementation as the lack of protection. It is hoped that more modern\ncode might have less buffer-overflow style security flaws compared with\nthe 25 year old stuff.\n\nBoth however are good reasons to move off the SMB1 protocol towards\nSMB3 on the server, and this is easiest and safest to do once the\nclients also move to SMB3 by default.\n\nAndrew Bartlett","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-cifs-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tsecure) header.d=samba.org header.i=@samba.org header.b=\"CKILM+Zr\";\n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xk4TD0xpjz9sNr\n\tfor ;\n\tFri, 1 Sep 2017 13:28:32 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751264AbdIAD2b (ORCPT );\n\tThu, 31 Aug 2017 23:28:31 -0400","from hr2.samba.org ([144.76.82.148]:23866 \"EHLO hr2.samba.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1750925AbdIAD2a (ORCPT );\n\tThu, 31 Aug 2017 23:28:30 -0400","from [127.0.0.2] (localhost [127.0.0.1])\n\tby hr2.samba.org with esmtpsa\n\t(TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim)\n\tid 1dncNG-0008JX-V7; Fri, 01 Sep 2017 03:12:03 +0000"],"X-Greylist":"delayed 981 seconds by postgrey-1.27 at vger.kernel.org;\n\tThu, 31 Aug 2017 23:28:30 EDT","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=samba.org;\n\ts=42627210; h=Date:Cc:To:From:Message-ID;\n\tbh=1vXBsAlueRN9or2aIhIwtGBHgzMWYCnjArkxbqgAc8U=;\n\tb=CKILM+ZrL1pay3sfGO02SSkD6/\n\taYA4Ju4hc2rn9ub39Gp1aH14YKE3KSmX41DJlnRL+0MzSY7Kk7V5yhYPDsB0ztLR7UMuW1/qpN2Av\n\tAMv3kI5ebqPQU50gitnux+mhJv3UslmjcfNZbEVB4qLBEYL1LOdXvrBSCGDJCK8legJU=;","Message-ID":"<1504235519.8023.87.camel@samba.org>","Subject":"Re: RFC: Revert move default dialect from CIFS to to SMB3\"","From":"Andrew Bartlett ","To":"\"L. A. Walsh\" ,\n\tThorsten Leemhuis ","Cc":"linux-cifs@vger.kernel.org","Date":"Fri, 01 Sep 2017 15:11:59 +1200","In-Reply-To":"<59A8A3E2.40804@tlinx.org>","References":"<1504213298-27431-1-git-send-email-linux@leemhuis.info>\n\t<59A8A3E2.40804@tlinx.org>","Face":"iVBORw0KGgoAAAANSUhEUgAAADAAAAAwCAIAAADYYG7QAAAAA3NCSVQICAjb4U/gAAACRklEQVRYw81YS67DIAwkVe8FPRm5menJeAu3lmUCbyBGKqsmRXjwb8Y5aq3hl9Yj/Nh6Tu0upZRS+EdKiV+e5+mJqMKLiHLORBRjzDmbc/hlvb1QD2k3sG84+dhhvF6vlzymlNY8dyBJzUdLjAwyvaeU8n6/2WHpu/xDRkREJI8cOBMgfuRQxhj58JzzbBwhQDFGA07M6/efE0MQxDHGFvpdQHy6MUxqtU4yezRcH0B4GfbM44BWGqOurF6Omz140a0ASimJvdbwZT32XrpRh5yuwY1d0vPrdNkv91+T8uBRG8l1uiX+JtsHxPNIWE27ugwTctTdHCIiYXvuy4P7IDl0CxAzl2xgZTJwgw+g3kGaHwYh5g2sljyrjIVEq4pYBg2Kq3yXZ5WxjfO7zF9jRdXrnLcEmlbTRnNpcT0gvpTScUC2HlOE2ipAvPuJanMT+Xc0PC4dFzu1DEO4HgczaS5kOnZ4vM7zxNU+mtRyRVPDgqyX3cdx8AQCCrQnfkV9VzMA9Ryg3ek8Sgsg3QX+nbz03Og5l10ytp6HusQUwpjd1rnsksbHlhjuVGdBAbWzIiJu5MvEFkA6OkiwBO4uQL3ADeQ9b57t74+FBo1s47IqpVxqBDcuQ66r94QQJOH2ctnAf9oZtdbZYejpi2bQEveO0sb2JXu09OJJrnpil4SV5G2N6Y+1QjL+gHSKDApHJoJWF3hW2fInh6lutGW216OPRBZtRZscwyQvI+KuTj3rp4VP1VsAcTobxgDngukqm3LPgmL8A4m377Y5OvTKAAAAAElFTkSuQmCC","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.22.6-1 ","Mime-Version":"1.0","Content-Transfer-Encoding":"8bit","Sender":"linux-cifs-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-cifs@vger.kernel.org"}},{"id":1761593,"web_url":"http://patchwork.ozlabs.org/comment/1761593/","msgid":"<1504264063.5755.5.camel@redhat.com>","list_archive_url":null,"date":"2017-09-01T11:07:43","subject":"Re: RFC: Revert move default dialect from CIFS to to SMB3","submitter":{"id":501,"url":"http://patchwork.ozlabs.org/api/people/501/","name":"Jeff Layton","email":"jlayton@redhat.com"},"content":"On Thu, 2017-08-31 at 21:42 -0500, Steve French wrote:\n> Any thoughts on this patch to add additional warnings for the user -\n> logging when using default dialects (or when server returns dialect\n> not supported), and noting the default dialect change?\n> \n> See https://git.samba.org/?p=sfrench/cifs-2.6.git;a=commit;h=bb86f22eeddbb5879675b55168b8fa8990d74a21\n> \n\nBreaking backward compatability sucks, but I agree that there's no real\nalternative here. SMB1 is just not a safe default these days.\n\n> On Thu, Aug 31, 2017 at 7:29 PM, Steve French wrote:\n> > Yes - updating the parsing slightly and printks as suggested makes sense\n> > \n> > Some additional warning messages in the userspace helper (adding Jeff\n> > Layton), mount.cifs can also help.\n> > \n\nWhat do you suggest here?\n\n> > I also have an experimental set of patches to allow multi-dialect\n> > negotiation with at least three of the acceptable dialects\n> > (smb2.1/smb3/smb3.02) which will help, but complicate secure dialect\n> > validation (\"validate negotiate\") but that will have to wait till next\n> > release.\n> > \n\nThat seems like the best way to fix this. If you fail to negotiate any\ndialect, throw a warning then.\n\n\n> > On Thu, Aug 31, 2017 at 7:12 PM, Linus Torvalds\n> > wrote:\n> > > On Thu, Aug 31, 2017 at 2:36 PM, Thorsten Leemhuis wrote:\n> > > > Lo! To give a bit more background to this (the mail I reply to was the\n> > > > first I sent with git send-email and I missed some details): Maybe I'm\n> > > > over stretching my abilities/position as regression tracker with this\n> > > > RFC for a revert, but I hope it at least triggers a discussion if such a\n> > > > revert should be done or not.\n> > > \n> > > I don't think that a revert is appropriate.\n> > > \n> > > But perhaps just a single printk() or something if the user does *not*\n> > > specify the version explicitly? Just saying something like\n> > > \n> > > We used to default to 1.0, we now default to 3.0, if you want old\n> > > defaults, use \"vers=1.0\"\n> > > \n> > > Oh, looking at that version parsing code, I think we also need to fix\n> > > that legacy \"ver=1\" thing (ver without the 's') which now silently\n> > > ignores \"ver=1\" as being the \"default\", even though it's not.\n> > > \n> > > I do *not* believe that \"default to version 1\" is acceptable.\n> > > \n> > > Linus\n> > \n> > \n> > \n> > --\n> > Thanks,\n> > \n> > Steve\n> \n> \n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-cifs-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkGg84dC5z9s7p\n\tfor ;\n\tFri, 1 Sep 2017 21:07:48 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751856AbdIALHr (ORCPT );\n\tFri, 1 Sep 2017 07:07:47 -0400","from mail-qk0-f170.google.com ([209.85.220.170]:37258 \"EHLO\n\tmail-qk0-f170.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751743AbdIALHq (ORCPT\n\t); Fri, 1 Sep 2017 07:07:46 -0400","by mail-qk0-f170.google.com with SMTP id k126so8794987qkb.4\n\tfor ;\n\tFri, 01 Sep 2017 04:07:46 -0700 (PDT)","from tleilax.poochiereds.net (cpe-45-37-196-243.nc.res.rr.com.\n\t[45.37.196.243]) by smtp.gmail.com with ESMTPSA id\n\tj61sm1420005qte.30.2017.09.01.04.07.44\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tFri, 01 Sep 2017 04:07:45 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=230pN8w1MdapCRTNWJJqmIJ+fQ1gUQCGQsJNBKOv8Us=;\n\tb=m0YhJjPU9afn12u6EZSU9PIgBcgVJCRCyNTvQu/7E2a1FmPX7I+T7zgEY74OfLqhcF\n\tM80ZVRaqW2jM7Pnwce9JajNwA7CWxyH6s4GlWOP92Q/TxxR9L6NROottZN1YjlLjhFAX\n\twaEqmT3Jo0mlxphVE64fWcMMa8Qe+OAZ5Nh/NQi6qQ7QROpGSgbXjVMLt6+7cGJqnLlz\n\tLV7YX9TONmqKCuSodzVXtS25eqYusTlc2XOmpVuw0LsN2ZIh2YzafR8W687q7Ag2JKUJ\n\tnTHmAulApRoIvmqY+m/CUjZYArgP5XcOY2/brxpHo5gXqkqzrpTk19cBa/JBxGKsIUg9\n\tS6Mw==","X-Gm-Message-State":"AHPjjUjQRiZXjTedwKjqDrGMVrYBeXa79ukaW/n4A95ZPjekIVf483qw\n\tS9zkdTbauJGQB6y1","X-Google-Smtp-Source":"ADKCNb7wGKS+AZwimg0uitC6SHfvvtUBw4U9ZVaa1uXFXt64hT36ihRK9995Ce2wtW+2GciXLXpSGw==","X-Received":"by 10.55.71.205 with SMTP id u196mr2017354qka.163.1504264065897; \n\tFri, 01 Sep 2017 04:07:45 -0700 (PDT)","Message-ID":"<1504264063.5755.5.camel@redhat.com>","Subject":"Re: RFC: Revert move default dialect from CIFS to to SMB3","From":"Jeff Layton ","To":"Steve French ,\n\tPavel Shilovskiy ,\n\tronnie sahlberg ","Cc":"Thorsten Leemhuis ,\n\t\"linux-cifs@vger.kernel.org\" ","Date":"Fri, 01 Sep 2017 07:07:43 -0400","In-Reply-To":"","References":"<1504213298-27431-1-git-send-email-linux@leemhuis.info>\n\t\n\t\n\t\n\t","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.24.5 (3.24.5-1.fc26) ","Mime-Version":"1.0","Content-Transfer-Encoding":"7bit","Sender":"linux-cifs-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-cifs@vger.kernel.org"}},{"id":1761897,"web_url":"http://patchwork.ozlabs.org/comment/1761897/","msgid":"<59A9A59E.6040205@tlinx.org>","list_archive_url":null,"date":"2017-09-01T18:23:26","subject":"Re: RFC: Revert move default dialect from CIFS to to SMB3","submitter":{"id":72271,"url":"http://patchwork.ozlabs.org/api/people/72271/","name":"L. A. Walsh","email":"linux-cifs@tlinx.org"},"content":"Linus Torvalds wrote:\n> On Thu, Aug 31, 2017 at 2:36 PM, Thorsten Leemhuis wrote:\n> \n>> Lo! To give a bit more background to this (the mail I reply to was the\n>> first I sent with git send-email and I missed some details): Maybe I'm\n>> over stretching my abilities/position as regression tracker with this\n>> RFC for a revert, but I hope it at least triggers a discussion if such a\n>> revert should be done or not.\n>> \n>\n> I don't think that a revert is appropriate.\n>\n> But perhaps just a single printk() or something if the user does *not*\n> specify the version explicitly? Just saying something like\n>\n> We used to default to 1.0, we now default to 3.0, if you want old\n> defaults, use \"vers=1.0\"\n> \n----\n Why be incompatible with the majority of Windows installations?\nI.e. If you really want to up security from 1.0 (not adverse to that),\nthen why not go to 2.1 as used by Win7? Win7 is still in support\nfrom MS -- and they haven't indicated a need to upgrade to 3.x for\nsecurity reasons. 3.x may have new security features, no argument, but\nthat doesn't mean 2.1, is insecure.\n\n\n> I do *not* believe that \"default to version 1\" is acceptable.\n> \n---\n But does it have to jump to 3? I.e. Why not go a more middle\nroute of 2.1 -- as it is still security-supported by MS. Ideally\nMS would find some bug in 2.1 and allow 3.x to be an upgrade to Win7,\nbut until then...\n\nLinda\n--\nTo unsubscribe from this list: send the line \"unsubscribe linux-cifs\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-cifs-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkSL63KJMz9sPk\n\tfor ;\n\tSat, 2 Sep 2017 04:23:42 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752143AbdIASXl (ORCPT );\n\tFri, 1 Sep 2017 14:23:41 -0400","from ishtar.tlinx.org ([173.164.175.65]:52072 \"EHLO\n\tIshtar.sc.tlinx.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752092AbdIASXl (ORCPT\n\t); Fri, 1 Sep 2017 14:23:41 -0400","from [192.168.3.12] (Athenae [192.168.3.12])\n\tby Ishtar.sc.tlinx.org (8.14.7/8.14.4/SuSE Linux 0.8) with ESMTP id\n\tv81INQfm027407; Fri, 1 Sep 2017 11:23:28 -0700"],"Message-ID":"<59A9A59E.6040205@tlinx.org>","Date":"Fri, 01 Sep 2017 11:23:26 -0700","From":"\"L. A. Walsh\" ","User-Agent":"Thunderbird","MIME-Version":"1.0","To":"Linus Torvalds ","CC":"Thorsten Leemhuis ,\n\tSteve French ,\n\tLinux Kernel Mailing List ,\n\t\"linux-cifs@vger.kernel.org\" ,\n\tPavel Shilovsky ","Subject":"Re: RFC: Revert move default dialect from CIFS to to SMB3","References":"<1504213298-27431-1-git-send-email-linux@leemhuis.info>\n\t\n\t","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Sender":"linux-cifs-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-cifs@vger.kernel.org"}},{"id":1761952,"web_url":"http://patchwork.ozlabs.org/comment/1761952/","msgid":"","list_archive_url":null,"date":"2017-09-01T19:45:42","subject":"Re: RFC: Revert move default dialect from CIFS to to SMB3","submitter":{"id":97,"url":"http://patchwork.ozlabs.org/api/people/97/","name":"Linus Torvalds","email":"torvalds@linux-foundation.org"},"content":"On Fri, Sep 1, 2017 at 11:23 AM, L. A. Walsh wrote:\n> Why be incompatible with the majority of Windows installations?\n> I.e. If you really want to up security from 1.0 (not adverse to that),\n> then why not go to 2.1 as used by Win7? Win7 is still in support\n> from MS -- and they haven't indicated a need to upgrade to 3.x for\n> security reasons. 3.x may have new security features, no argument, but\n> that doesn't mean 2.1, is insecure.\n\nI'm certainly ok with changing the default to 2.1 if that helps people.\n\nIs that actually likely to help the people who now see problems with\nthe existing 3.0 default?\n\nI don't know the exact security issue details with cifs, but I _think_\nit was explicitly _only_ smb-1.0, right?\n\n Linus\n--\nTo unsubscribe from this list: send the line \"unsubscribe linux-cifs\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-cifs-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"fgeCvjby\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkV8n6sybz9sPt\n\tfor ;\n\tSat, 2 Sep 2017 05:45:45 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752338AbdIATpo (ORCPT );\n\tFri, 1 Sep 2017 15:45:44 -0400","from mail-it0-f48.google.com ([209.85.214.48]:36783 \"EHLO\n\tmail-it0-f48.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752312AbdIATpn (ORCPT\n\t); Fri, 1 Sep 2017 15:45:43 -0400","by mail-it0-f48.google.com with SMTP id j17so1162013iti.1;\n\tFri, 01 Sep 2017 12:45:43 -0700 (PDT)","by 10.107.15.151 with HTTP; Fri, 1 Sep 2017 12:45:42 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=UaeNrCHqSPZU9dS5mw3HZeYgnHnEkeYbp6FagJdpXkc=;\n\tb=fgeCvjby0NAtLAvOAemlrfcP0MeiBo8JQL0z76tZGHHKwELReQ+CkpBJG2zHNXbqLV\n\tvpqzO27pVpU9opYtOpECCcDD16RbqF5RpOsKpKVrxlExD+DxntFfBWJ4PyBNj6r5BIvz\n\t/KeB0tp3GWmpZ+Zagcz/Us5M7QRXDdEFJW5gMimj0mXllaM3JM5prGmAQEpOo4boa3So\n\t4PYV/Fuuc8FlfbpUHGe6XqW+Z48+S/htzOZiudzMoQ92hj6ZFvIluKLOzUL+7he5RwEj\n\t9/EuqenjMFA7Ki2vr75rBpox3OIpCCoF68curnY7iA2a1s4OzF8rBd8uy12+53EqS0QQ\n\t6/UQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=UaeNrCHqSPZU9dS5mw3HZeYgnHnEkeYbp6FagJdpXkc=;\n\tb=WuBReRQ2pafVs1Njs3n5ecsUgXHPnbaMh5VH+pzbPyEpMwjQlk7mhZ3R6B9BN7+KY+\n\t6sSH8Uc21wKSe/pmLb+0OroO6phuba0x77kMziqVCOm3bjm3gYYC2fiOYaceX2UH+Esc\n\tXVqMqNGZOJ8cqsZdpCUjCarHGjr8nFPSA6hlYJwo/JLYpIs0c8oh0BsA1EYEIsMq+o6m\n\t2n0vtGBncjCRdGYQwtql4kC0JneK5AI0K5rIYtASqElDItgoZPEq8f2IGHjW6GEsJCnj\n\tJIdDBOJDzQAf9+izKA8PMX1rGNKddxbGJTXYJCDf/8qFgDZXz6nKn2/HAwgIPHia5J8X\n\tCxgw==","X-Gm-Message-State":"AHPjjUjqNQRQZnc+o1MUDdU9PU9y3CNX27IjoODQc5O0/R3O+3kx3GPq\n\t9HhyeawquTDlZAowPmuj/NDyat6UknIf","X-Google-Smtp-Source":"ADKCNb562cOipWHjtU4hliApyqAAxzVlzDuNCROmOkTjBEgH5DCgi3ifAYknIMhhtDLIeh9iTiWPFYo3OuC1d/0mWzU=","X-Received":"by 10.36.122.69 with SMTP id a66mr465752itc.159.1504295143182;\n\tFri, 01 Sep 2017 12:45:43 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<59A9A59E.6040205@tlinx.org>","References":"<1504213298-27431-1-git-send-email-linux@leemhuis.info>\n\t\n\t\n\t<59A9A59E.6040205@tlinx.org>","From":"Linus Torvalds ","Date":"Fri, 1 Sep 2017 12:45:42 -0700","X-Google-Sender-Auth":"MAcUfyknOlwkxAvrmmKD3VgTKlM","Message-ID":"","Subject":"Re: RFC: Revert move default dialect from CIFS to to SMB3","To":"\"L. A. Walsh\" ","Cc":"Thorsten Leemhuis ,\n\tSteve French ,\n\tLinux Kernel Mailing List ,\n\t\"linux-cifs@vger.kernel.org\" ,\n\tPavel Shilovsky ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-cifs-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-cifs@vger.kernel.org"}},{"id":1762066,"web_url":"http://patchwork.ozlabs.org/comment/1762066/","msgid":"","list_archive_url":null,"date":"2017-09-02T02:16:38","subject":"Re: RFC: Revert move default dialect from CIFS to to SMB3","submitter":{"id":510,"url":"http://patchwork.ozlabs.org/api/people/510/","name":"Steve French","email":"smfrench@gmail.com"},"content":"On Fri, Sep 1, 2017 at 2:45 PM, Linus Torvalds\n wrote:\n> On Fri, Sep 1, 2017 at 11:23 AM, L. A. Walsh wrote:\n>> Why be incompatible with the majority of Windows installations?\n>> I.e. If you really want to up security from 1.0 (not adverse to that),\n>> then why not go to 2.1 as used by Win7? Win7 is still in support\n>> from MS -- and they haven't indicated a need to upgrade to 3.x for\n>> security reasons. 3.x may have new security features, no argument, but\n>> that doesn't mean 2.1, is insecure.\n>\n> I'm certainly ok with changing the default to 2.1 if that helps people.\n>\n> Is that actually likely to help the people who now see problems with\n> the existing 3.0 default?\n>\n> I don't know the exact security issue details with cifs, but I _think_\n> it was explicitly _only_ smb-1.0, right?\n\nThe default was SMB1 (CIFS) and was recently changed to SMB3.\nThe dialect still can be overridden by specifying \"vers=1.0\" or \"vers=2.1\"\netc. on mount.\n\nWe just put together a patch to better explain the default changes\n(with additional warning messages) as suggested.\n\nSMB3 is significantly better than SMB2.1 (supporting encrypted shares\nand sessions for example, and requiring support for \"secure negotiate\")\nand some servers require SMB3 minimum as a result, but it was agreed\nat the last test event to eventually support multi-dialect negotiation (for\nwhich SMB2.1 e.g. Windows 7, would be the oldest and least secure\ndialect we would support) but in this interim stage we had to pick one,\nand the improvements in SMB3 (over SMB2.1) tipped the balance.\n\nIn 4.14 we will likely have the ability to more securely do multi-dialect\nnegotiation, and this issue of SMB2.1 vs. SMB3 will be moot as the\nserver will choose its most recent dialect.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-cifs-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"ExBi2ot8\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkfrF30d4z9s7G\n\tfor ;\n\tSat, 2 Sep 2017 12:17:01 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751677AbdIBCRA (ORCPT );\n\tFri, 1 Sep 2017 22:17:00 -0400","from mail-pf0-f173.google.com ([209.85.192.173]:32948 \"EHLO\n\tmail-pf0-f173.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751493AbdIBCQ7 (ORCPT\n\t); Fri, 1 Sep 2017 22:16:59 -0400","by mail-pf0-f173.google.com with SMTP id n73so4917377pfj.0;\n\tFri, 01 Sep 2017 19:16:59 -0700 (PDT)","by 10.100.237.100 with HTTP; Fri, 1 Sep 2017 19:16:38 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=YJ62TmAckfquh27XwB+jpD5W1+lfPN2M5LYczch63ko=;\n\tb=ExBi2ot8po38jlDcvZDJ+U2kTY+7zoBOxNJ5WSj69Itx42rhhn/vdwv1bJzxxCfaQD\n\tPH+BloT39yNwRQXckqJT1vrHIXRq1weIGewCMe9gSE72AYEKS35cljFCL2uAZWipLwqY\n\t/o+Mo9a3ZpUVfu1TKJvk8SznHmOAmCYwiw/ptXkI8XS85vE8Y4CaGB7efSIYilJwTAZN\n\teQjSFSJg2vqtX++sT9+1ago72V824I0VYOgH6acLWeokTN3OF0YxYJ1EXOXdalz7LHGM\n\tuaSz70BK6q4HiAwmnmFScxt4XZsAZAfb9D156PWwcPW1uT1zo6iKIoWTA0wOE3LZfbIY\n\t79Yw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=YJ62TmAckfquh27XwB+jpD5W1+lfPN2M5LYczch63ko=;\n\tb=R+25pJVVN/ixItXGDPRZrrdduDPe5yKM0uj6SjnF8YnnLUEPt+jpmOjjMdYB5wV2sU\n\tZjayMlOHngI6cYZUH3Z+Y8ZlhZHyub7N0z6IIKWR8R0/rNAvgij6JPZspvjkm+pSguQf\n\tGO4BtX0XPA17PqaGoMKZbzkOx+9MKFzPMlij8YrLvwc4SSx7x/DI39+yy8owCQD2W8fh\n\twnzDvToR+fAY+gVqzMGYrr/OxYbW5LSn4ciyzJaxsSEZbyP19Mmw4eiE+ea4CCYg0Ulc\n\tPabxlbGkRwRL+ZY70R2i/pCZVSzRfJxaj7ykHylTVN0B/5ES5tY+hymNCO2T6Ekx2wyi\n\trtIQ==","X-Gm-Message-State":"AHPjjUimv3xgiutcRGoHT3PRHzK2Aw3nbHOmvYmUn5M9Up7Ews8/6Pf9\n\tia48bFIVgEeuQtSTwSbjp7+F1Zs48sT1","X-Google-Smtp-Source":"ADKCNb4vUJa21eHnhjJ92moRoYDPIvoqCfpPNGQZQz7Knur7vIQcanTo5xsSRqqO03ipr+z4I+f9sz9jsWhLzcFQzqk=","X-Received":"by 10.84.199.194 with SMTP id d2mr364935plh.219.1504318619211;\n\tFri, 01 Sep 2017 19:16:59 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<1504213298-27431-1-git-send-email-linux@leemhuis.info>\n\t\n\t\n\t<59A9A59E.6040205@tlinx.org>\n\t","From":"Steve French ","Date":"Fri, 1 Sep 2017 21:16:38 -0500","Message-ID":"","Subject":"Re: RFC: Revert move default dialect from CIFS to to SMB3","To":"Linus Torvalds ","Cc":"\"L. A. Walsh\" ,\n\tThorsten Leemhuis ,\n\tLinux Kernel Mailing List ,\n\t\"linux-cifs@vger.kernel.org\" ,\n\tPavel Shilovsky ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-cifs-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-cifs@vger.kernel.org"}},{"id":1762082,"web_url":"http://patchwork.ozlabs.org/comment/1762082/","msgid":"","list_archive_url":null,"date":"2017-09-02T03:56:50","subject":"Re: RFC: Revert move default dialect from CIFS to to SMB3","submitter":{"id":97,"url":"http://patchwork.ozlabs.org/api/people/97/","name":"Linus Torvalds","email":"torvalds@linux-foundation.org"},"content":"On Fri, Sep 1, 2017 at 7:16 PM, Steve French wrote:\n>\n> The default was SMB1 (CIFS) and was recently changed to SMB3.\n> The dialect still can be overridden by specifying \"vers=1.0\" or \"vers=2.1\"\n> etc. on mount.\n>\n> We just put together a patch to better explain the default changes\n> (with additional warning messages) as suggested.\n>\n> SMB3 is significantly better than SMB2.1 (supporting encrypted shares\n> and sessions for example, and requiring support for \"secure negotiate\")\n> and some servers require SMB3 minimum as a result,\n\nThe default shouldn't be about \"best and most secure\", but \"most\nconvenient, while still not actively *IN*secure\"\n\nSo \"some servers require 3.0\" may be true, but if it's also the case\nthat \"most servers still don't do 3.0 at all\", then it's a \"some\" vs\n\"most\".\n\nWhich is the most common one? That should be the default.\n\nI realize that eventually we'll have auto-negotiation, but that's\nclearly not for 4.13. So in the meantime the only issue is what the\nright default should be without auto-negotiation.\n\nSo it should be about what the failure rate is. If trying for smb3 has\na high failure rate because people simply don't have that yet, then\nmaking that the default was clearly the wrong choice.\n\nBecause being \"better\" is immaterial if it doesn't work.\n\n Linus\n--\nTo unsubscribe from this list: send the line \"unsubscribe linux-cifs\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-cifs-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"WKt488Hq\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkj3V01Pjz9s7M\n\tfor ;\n\tSat, 2 Sep 2017 13:56:53 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751337AbdIBD4w (ORCPT );\n\tFri, 1 Sep 2017 23:56:52 -0400","from mail-io0-f170.google.com ([209.85.223.170]:38677 \"EHLO\n\tmail-io0-f170.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750980AbdIBD4v (ORCPT\n\t); Fri, 1 Sep 2017 23:56:51 -0400","by mail-io0-f170.google.com with SMTP id q64so104958iod.5;\n\tFri, 01 Sep 2017 20:56:51 -0700 (PDT)","by 10.107.15.151 with HTTP; Fri, 1 Sep 2017 20:56:50 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=BIcQXIgRst47jvgDJXstCmClrEWQ6xFAZMIcar6a0y4=;\n\tb=WKt488HqXvy1BA6wf6Xa8kDm/tUr5wylZ35nVLz1cGx7Z3vIHGMAkvd0qTG71L2Ipv\n\ttJnrzlaem5Fs5aJL7QcOTPTGIS76tLAv+mIj+L+PfnBFsqEk4+P9ZjHbkV0GdR2bPFCk\n\tw2HmAdv4d6ebyysL3frWLASjJAkMLfcWj0RCF1gaXYtQdKIn/ezakpptxnhTyuFigk37\n\t8WkUmU2blMf4UQtgJA4xfEzBe22Dst3oEjAeK9wJeqcMNTPaebNg8NtWsB8BA9IZ3Dik\n\ttRkLOrSkBicK1kWO/ytUK5a4RazyPFO3Sda/4FWvdxqrmcc8tk13FDAjEsjFf9x+0+CH\n\tvhAw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=BIcQXIgRst47jvgDJXstCmClrEWQ6xFAZMIcar6a0y4=;\n\tb=o87VlD/C6ufHyZ/pmeUmOxIDwRrcBwffzsAjG1Mmz30LipCv/3qGusGrMxOZtv7hgs\n\tlCwct4XipCJLFB1hL8cVG+2Y3Tj9P1B0fmPnP4AyxOpZ5HdiJY5307bRZmT0itjpNObj\n\tH09+Uz1auvNvNeccYFZut35UWhSvazb+qMilq4KVWSM/lW6pNck/Uj2C4qwZhqZQaTBM\n\t8UBinZH0WdHzS2THel/Bn0iNa3OyGst7HfTZWzt0WwvcjIcMWLWOCFYta//3zxu/LmDp\n\tpiDyJhbtnzkB5e1lNYQMKGpgWh/KZsJfZsY2jQ3pGpK46DoSCVC8pCwmy9egCXvF0Yfy\n\ttYgg==","X-Gm-Message-State":"AHPjjUiadfHib+59YkezuaeQdf95OFwGak1laiEdT1U67MgrFhlsIOex\n\te8qUYNCycCCryligXxDoY8GdXCsCCA==","X-Google-Smtp-Source":"ADKCNb5L0gl/M8C3NEvwBpLcuW9GgS5so8E6E86z+ovbpNomszp1/pLCXXAuazV2NR/4DjI/ZJIzDl/XFts7Bzh/f6E=","X-Received":"by 10.107.41.206 with SMTP id p197mr3654737iop.142.1504324611348;\n\tFri, 01 Sep 2017 20:56:51 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<1504213298-27431-1-git-send-email-linux@leemhuis.info>\n\t\n\t\n\t<59A9A59E.6040205@tlinx.org>\n\t\n\t","From":"Linus Torvalds ","Date":"Fri, 1 Sep 2017 20:56:50 -0700","X-Google-Sender-Auth":"cWHYdQISqrTGDfcc-OnbCvUIDDU","Message-ID":"","Subject":"Re: RFC: Revert move default dialect from CIFS to to SMB3","To":"Steve French ","Cc":"\"L. A. Walsh\" ,\n\tThorsten Leemhuis ,\n\tLinux Kernel Mailing List ,\n\t\"linux-cifs@vger.kernel.org\" ,\n\tPavel Shilovsky ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-cifs-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-cifs@vger.kernel.org"}},{"id":1762087,"web_url":"http://patchwork.ozlabs.org/comment/1762087/","msgid":"<1504329770.3249.61.camel@samba.org>","list_archive_url":null,"date":"2017-09-02T05:22:50","subject":"Re: RFC: Revert move default dialect from CIFS to to SMB3","submitter":{"id":4270,"url":"http://patchwork.ozlabs.org/api/people/4270/","name":"Andrew Bartlett","email":"abartlet@samba.org"},"content":"On Fri, 2017-09-01 at 20:56 -0700, Linus Torvalds wrote:\n> On Fri, Sep 1, 2017 at 7:16 PM, Steve French wrote:\n> > \n> > The default was SMB1 (CIFS) and was recently changed to SMB3.\n> > The dialect still can be overridden by specifying \"vers=1.0\" or \"vers=2.1\"\n> > etc. on mount.\n> > \n> > We just put together a patch to better explain the default changes\n> > (with additional warning messages) as suggested.\n> > \n> > SMB3 is significantly better than SMB2.1 (supporting encrypted shares\n> > and sessions for example, and requiring support for \"secure negotiate\")\n> > and some servers require SMB3 minimum as a result,\n> \n> The default shouldn't be about \"best and most secure\", but \"most\n> convenient, while still not actively *IN*secure\"\n> \n> So \"some servers require 3.0\" may be true, but if it's also the case\n> that \"most servers still don't do 3.0 at all\", then it's a \"some\" vs\n> \"most\".\n> \n> Which is the most common one? That should be the default.\n> \n> I realize that eventually we'll have auto-negotiation, but that's\n> clearly not for 4.13. So in the meantime the only issue is what the\n> right default should be without auto-negotiation.\n> \n> So it should be about what the failure rate is. If trying for smb3 has\n> a high failure rate because people simply don't have that yet, then\n> making that the default was clearly the wrong choice.\n> \n> Because being \"better\" is immaterial if it doesn't work.\n\nMy quick research shows:\n\nSMB 2.1 but not SMB3 is on:\n Windows 7\n Windows 8\n Windows 2008\n Windows 2012\n Samba 3.6 and earlier (SMB1 only by default)\n\nSMB3 is on:\n Windows 8.1\n Windows 2012 R2\n Windows 10\n Windows 2016 \n Samba 4.0 and above (released 2012)\n\nI'm not sure exactly which Mac versions. \n\nSome breakage will be old (and quite recent) NAS and routers that use\nSMB1 and often very old Samba, but most of those only do SMB1. \n\nIn terms of 'actively *IN*secure', it really depends what you mean by\nthat. \n\nThat is, like all big changes, the movement against SMB1 has had\nmultiple motivations:\n - a desire no longer to expose really old code in Windows (recently\nexploited)\n - a desire to retire an old and complex protocol\n - SMB3 having proper secure negotiation (I'll leave it to Steve to\nexplain the difference between SMB2 and 3 in that respect, I'm not so\ncurrent on the details). \n\nI hope this help,\n\nAndrew Bartlett","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-cifs-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tsecure) header.d=samba.org header.i=@samba.org header.b=\"PVFPGdW0\";\n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkkz15468z9s76\n\tfor ;\n\tSat, 2 Sep 2017 15:23:09 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750989AbdIBFXI (ORCPT );\n\tSat, 2 Sep 2017 01:23:08 -0400","from hr2.samba.org ([144.76.82.148]:50546 \"EHLO hr2.samba.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1750946AbdIBFXH (ORCPT );\n\tSat, 2 Sep 2017 01:23:07 -0400","from [127.0.0.2] (localhost [127.0.0.1])\n\tby hr2.samba.org with esmtpsa\n\t(TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim)\n\tid 1do0tX-0005tH-Hs; Sat, 02 Sep 2017 05:23:00 +0000"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=samba.org;\n\ts=42627210; h=Date:Cc:To:From:Message-ID;\n\tbh=PGcmLnWSA+vJjqA7WeANNOBrdebgaMxm2dWbETmY9Js=;\n\tb=PVFPGdW06u8hsV4Wy34AX6lac5\n\tNzr4N04YRzK8H4XKUqwcbAFH+0ZFl1hcFglV6IdmMa6Y4l77b8IikPVwzlsldNZZbknMvP7f/NPTs\n\tCk0kcMv95V2OvssIlEFP4j+EFNuB2uhHLmi4hoHAuvl21DjESl/FmtzujCNXfQoWfTsE=;","Message-ID":"<1504329770.3249.61.camel@samba.org>","Subject":"Re: RFC: Revert move default dialect from CIFS to to SMB3","From":"Andrew Bartlett ","To":"Linus Torvalds ,\n\tSteve French ","Cc":"\"L. A. Walsh\" ,\n\tThorsten Leemhuis ,\n\tLinux Kernel Mailing List ,\n\t\"linux-cifs@vger.kernel.org\" ,\n\tPavel Shilovsky ","Date":"Sat, 02 Sep 2017 17:22:50 +1200","In-Reply-To":"","References":"<1504213298-27431-1-git-send-email-linux@leemhuis.info>\n\t\n\t\n\t<59A9A59E.6040205@tlinx.org>\n\t\n\t\n\t","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.22.6 (3.22.6-2.fc25) ","Mime-Version":"1.0","Content-Transfer-Encoding":"7bit","Sender":"linux-cifs-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-cifs@vger.kernel.org"}},{"id":1762128,"web_url":"http://patchwork.ozlabs.org/comment/1762128/","msgid":"","list_archive_url":null,"date":"2017-09-02T14:25:59","subject":"Re: RFC: Revert move default dialect from CIFS to to SMB3","submitter":{"id":72269,"url":"http://patchwork.ozlabs.org/api/people/72269/","name":"Thorsten Leemhuis","email":"linux@leemhuis.info"},"content":"Hi! Just a quick feedback from my side.\n\nAfter reading Andrew explanation in this thread about the \"movement\nagainst SMB1\" I kind of think \"maybe the proposed revert for 4.13 and\ndoing it properly in 4.14 would really have been a good fit\". But\nwhatever, doesn't bother me much any more:\n\nSteve French wrote on 01.09.2017 04:42:\n> Any thoughts on this patch to add additional warnings for the user -\n> logging when using default dialects (or when server returns dialect\n> not supported), and noting the default dialect change?\n> See https://git.samba.org/?p=sfrench/cifs-2.6.git;a=commit;h=bb86f22eeddbb5879675b55168b8fa8990d74a21\n\nI noticed Linus committed a sightly updated variant earlier today\n(https://git.kernel.org/torvalds/c/7e682f766f28 ). I just gave it a\nquick try and it worked well. I can still mount smb3 shares. For\ncifs/smb1 shares mount.cifs obviously still fails with the confusing\nerror message. But at least one gets a better explanation in dmesg now.\n\nMany thx for this! Ciao, Thorsten.\n\nP.S.: For the curious reader (and search engines!), this is the\nconfusing mount message you'll get when trying to access a CIFS/SMB1\nonly share with Linux master currently:\n\nmount error(112): Host is down\nRefer to the mount.cifs(8) manual page (e.g. man mount.cifs)\"\n\nAnd this is the warning you see in dmesg now when not specifying\n\"vers=1.0\" as option (-o) to mount/mount.cifs:\n\nNo dialect specified on mount. Default has changed to a\nmore secure dialect, SMB3 (vers=3.0), from CIFS (SMB1). To use the less\nsecure SMB1 dialect to access old servers which do not support SMB3\nspecify vers=1.0 on mount. For somewhat newer servers such as Windows 7\ntry vers=2.1.\nCIFS VFS: cifs_mount failed w/return code = -112\n\n\n> On Thu, Aug 31, 2017 at 7:29 PM, Steve French wrote:\n>> Yes - updating the parsing slightly and printks as suggested makes sense\n>>\n>> Some additional warning messages in the userspace helper (adding Jeff\n>> Layton), mount.cifs can also help.\n>>\n>> I also have an experimental set of patches to allow multi-dialect\n>> negotiation with at least three of the acceptable dialects\n>> (smb2.1/smb3/smb3.02) which will help, but complicate secure dialect\n>> validation (\"validate negotiate\") but that will have to wait till next\n>> release.\n>>\n>> On Thu, Aug 31, 2017 at 7:12 PM, Linus Torvalds\n>> wrote:\n>>> On Thu, Aug 31, 2017 at 2:36 PM, Thorsten Leemhuis wrote:\n>>>> Lo! To give a bit more background to this (the mail I reply to was the\n>>>> first I sent with git send-email and I missed some details): Maybe I'm\n>>>> over stretching my abilities/position as regression tracker with this\n>>>> RFC for a revert, but I hope it at least triggers a discussion if such a\n>>>> revert should be done or not.\n>>>\n>>> I don't think that a revert is appropriate.\n>>>\n>>> But perhaps just a single printk() or something if the user does *not*\n>>> specify the version explicitly? Just saying something like\n>>>\n>>> We used to default to 1.0, we now default to 3.0, if you want old\n>>> defaults, use \"vers=1.0\"\n>>>\n>>> Oh, looking at that version parsing code, I think we also need to fix\n>>> that legacy \"ver=1\" thing (ver without the 's') which now silently\n>>> ignores \"ver=1\" as being the \"default\", even though it's not.\n>>>\n>>> I do *not* believe that \"default to version 1\" is acceptable.\n>>>\n>>> Linus\n--\nTo unsubscribe from this list: send the line \"unsubscribe linux-cifs\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-cifs-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkz1S3K6Fz9sNr\n\tfor ;\n\tSun, 3 Sep 2017 00:26:04 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752697AbdIBO0D (ORCPT );\n\tSat, 2 Sep 2017 10:26:03 -0400","from wp227.webpack.hosteurope.de ([80.237.132.234]:47428 \"EHLO\n\twp227.webpack.hosteurope.de\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1752649AbdIBO0C (ORCPT\n\t); Sat, 2 Sep 2017 10:26:02 -0400","from [2a00:e68:14:16:d63d:7eff:fe2e:40ee] (helo=thl.ct.heise.de);\n\tauthenticated\n\tby wp227.webpack.hosteurope.de running ExIM with esmtpsa\n\t(TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n\tid 1do9N1-0006q7-TQ; Sat, 02 Sep 2017 16:25:59 +0200"],"Subject":"Re: RFC: Revert move default dialect from CIFS to to SMB3","To":"Steve French ,\n\tPavel Shilovskiy ,\n\tronnie sahlberg ","Cc":"\"linux-cifs@vger.kernel.org\" ,\n\tJeff Layton ","References":"<1504213298-27431-1-git-send-email-linux@leemhuis.info>\n\t\n\t\n\t\n\t","From":"Thorsten Leemhuis ","Message-ID":"","Date":"Sat, 2 Sep 2017 16:25:59 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","X-bounce-key":"webpack.hosteurope.de; linux@leemhuis.info; 1504362362;\n\t1e145105; ","X-HE-SMSGID":"1do9N1-0006q7-TQ","Sender":"linux-cifs-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-cifs@vger.kernel.org"}},{"id":1762166,"web_url":"http://patchwork.ozlabs.org/comment/1762166/","msgid":"","list_archive_url":null,"date":"2017-09-02T17:09:42","subject":"Re: RFC: Revert move default dialect from CIFS to to SMB3","submitter":{"id":97,"url":"http://patchwork.ozlabs.org/api/people/97/","name":"Linus Torvalds","email":"torvalds@linux-foundation.org"},"content":"On Fri, Sep 1, 2017 at 10:22 PM, Andrew Bartlett wrote:\n>\n> My quick research shows:\n>\n> SMB 2.1 but not SMB3 is on:\n> Windows 7\n> Windows 8\n> Windows 2008\n> Windows 2012\n> Samba 3.6 and earlier (SMB1 only by default)\n>\n> SMB3 is on:\n> Windows 8.1\n> Windows 2012 R2\n> Windows 10\n> Windows 2016\n> Samba 4.0 and above (released 2012)\n\nBut most, if not all, of those SMB3 cases _also_ support SMB2.1,\nright? So the \"3.0 _only_\" case ends up being a fairly rare case\nwhere things have been explicitly limited, and any previous Linux use\nmust have had that explicit \"vers=3.0\" flag anyway?\n\nNo?\n\nAnyway, we can't avoid *some* breakage (ie the places that literally\nonly support 1.0 will have to add the explicit \"vers=1.0\" to get the\nmount).\n\nAnd I merged the code to add better error reporting yesterday, so\nhopefully regardless of the default we choose the breakage is not\nnearly as confusing to people any more.\n\n Linus\n--\nTo unsubscribe from this list: send the line \"unsubscribe linux-cifs\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-cifs-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"EgFrJN6X\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xl2fK2w7Cz9t0F\n\tfor ;\n\tSun, 3 Sep 2017 03:09:45 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752767AbdIBRJo (ORCPT );\n\tSat, 2 Sep 2017 13:09:44 -0400","from mail-io0-f175.google.com ([209.85.223.175]:36342 \"EHLO\n\tmail-io0-f175.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752732AbdIBRJn (ORCPT\n\t); Sat, 2 Sep 2017 13:09:43 -0400","by mail-io0-f175.google.com with SMTP id f99so10470994ioi.3;\n\tSat, 02 Sep 2017 10:09:43 -0700 (PDT)","by 10.107.15.151 with HTTP; Sat, 2 Sep 2017 10:09:42 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=1y21i2kwUiJJ/SkUDoN64Ex0N0cBy3Exgi5rKzaXB6Y=;\n\tb=EgFrJN6XmaSsSilqj4wDkjhB5LlV9nGyaDmd/G24WrFHRgnZqHk4pg9CCNnAmQVydb\n\tK5og89HfCV9LYAwi8bs838bOQyn044N/2idNTsvVMDb8elyMsYqp38Em2IGVyQsArFbt\n\twhqcUdAmI/J2LS6zU2Kkr0nfGZB0miyv8ppUSY/4xSnBM2v3MYeD7ouzrZVXOH598JmO\n\t3dkdRJ2QiswlzRDNg2X32cwRuuQx+8bSYFrrkcuCMDyCuXRCqird8itMHmCjCaPElkTi\n\t23yZnoLNt23cgvBvC+x0ai4xa9yhbJ57NBzmCrZpv31pjNqW2utYCQEUbnZRBP0VaMXG\n\tXitw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=1y21i2kwUiJJ/SkUDoN64Ex0N0cBy3Exgi5rKzaXB6Y=;\n\tb=uiQ5HrUrKwdv7JW9wqSYYh0vobxmJo6v31EevZ0c5xLqe75PZ7hzixTVY8UglPukVF\n\tnVwt9X4cF0F2ohZ0HbTKeXuij0/Tf0CppXHGwEbO5/ko10MQO0WuWT2cIr8RIIA1FaeK\n\tUQEUiuvSt8pvNqA0OvLyGddOeBWpasKI6w4WUcWcrx/CFYFoMKE40Nyzj2ePCDeqLbzV\n\twVtA6mBQXdFybApXBiexQDvjcQVlIgJSRpqlZjvi//FZ03M5Nz1dvMK+aOG+Rp9/B+g6\n\tmyXUXpxWFl50u38dyvDIiqPjtjO/dzCdQk+H0+W6o6J0SheOd+N+l0O0uEFYVmm0XGnF\n\t9GvQ==","X-Gm-Message-State":"AHPjjUg0iCinotKhoPZ27UC2a8QXaGZi6icnrSKXjTAcNqKgJH6p5Twu\n\tyRX01uCLrx6sF9LhdeNn1U9XMAoRTw==","X-Google-Smtp-Source":"ADKCNb5iidSC6XPUEKBFBr9cjDD13rSmaTqJaUsWTk6gK9bp06lEtxpoOfy+XjCy0OxLS4Q8AFXvEDlkRkOZ4s6tcPk=","X-Received":"by 10.107.41.206 with SMTP id p197mr5085363iop.142.1504372182822;\n\tSat, 02 Sep 2017 10:09:42 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1504329770.3249.61.camel@samba.org>","References":"<1504213298-27431-1-git-send-email-linux@leemhuis.info>\n\t\n\t\n\t<59A9A59E.6040205@tlinx.org>\n\t\n\t\n\t\n\t<1504329770.3249.61.camel@samba.org>","From":"Linus Torvalds ","Date":"Sat, 2 Sep 2017 10:09:42 -0700","X-Google-Sender-Auth":"18mHt_KJuYZ-nrXM-4BKgO3BkO0","Message-ID":"","Subject":"Re: RFC: Revert move default dialect from CIFS to to SMB3","To":"Andrew Bartlett ","Cc":"Steve French , \"L. A. Walsh\" ,\n\tThorsten Leemhuis ,\n\tLinux Kernel Mailing List ,\n\t\"linux-cifs@vger.kernel.org\" ,\n\tPavel Shilovsky ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-cifs-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-cifs@vger.kernel.org"}}]