[{"id":1761331,"web_url":"http://patchwork.ozlabs.org/comment/1761331/","msgid":"<CA+0q_Pjiy4c8i-NxeGBg4LBPK4DGTDOFVoxr7qHO8KNLZ8NhNg@mail.gmail.com>","list_archive_url":null,"date":"2017-08-31T21:37:59","subject":"Re: [ovs-dev] [branch-2.8 1/2] Revert \"ofproto-dpif: Mark packets\n\tas \"untracked\" after call to ct().\"","submitter":{"id":67631,"url":"http://patchwork.ozlabs.org/api/people/67631/","name":"Russell Bryant","email":"russell@ovn.org"},"content":"On Thu, Aug 31, 2017 at 4:04 PM, Justin Pettit <jpettit@ovn.org> wrote:\n> This reverts commit 8473cf69d25c4682cc6f6857b86b490a8c27cbd4.\n>\n> This commit introduced a change in the conntrack API.  This affected\n> some existing applications, so we will delay introducing the change\n> until the next major release.\n>\n> Signed-off-by: Justin Pettit <jpettit@ovn.org>\n> Requested-by: Flavio Leitner <fbl@sysclose.org>\n> ---\n>  NEWS                         |  4 ----\n>  lib/ofp-actions.c            | 27 ++++++++++++++-------------\n>  ofproto/ofproto-dpif-xlate.c | 21 ++++++++++++++-------\n>  tests/ofproto-dpif.at        | 10 +++++-----\n>  tests/system-traffic.at      |  4 ++--\n>  utilities/ovs-ofctl.8.in     | 10 ++++------\n>  6 files changed, 39 insertions(+), 37 deletions(-)\n\nAcked-by: Russell Bryant <russell@ovn.org>","headers":{"Return-Path":"<ovs-dev-bounces@openvswitch.org>","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=<UNKNOWN>)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjwjJ27Xrz9s81\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri,  1 Sep 2017 07:38:28 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 9C783A84;\n\tThu, 31 Aug 2017 21:38:24 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id F09C07A8\n\tfor <dev@openvswitch.org>; Thu, 31 Aug 2017 21:38:23 +0000 (UTC)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id E503B350\n\tfor <dev@openvswitch.org>; Thu, 31 Aug 2017 21:38:22 +0000 (UTC)","from mail-qt0-f172.google.com (mail-qt0-f172.google.com\n\t[209.85.216.172]) (Authenticated sender: russell@ovn.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 44403FB8B6\n\tfor <dev@openvswitch.org>; Thu, 31 Aug 2017 23:38:21 +0200 (CEST)","by mail-qt0-f172.google.com with SMTP id e2so4193945qta.0\n\tfor <dev@openvswitch.org>; Thu, 31 Aug 2017 14:38:21 -0700 (PDT)","by 10.140.93.164 with HTTP; Thu, 31 Aug 2017 14:37:59 -0700 (PDT)"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-Originating-IP":"209.85.216.172","X-Gm-Message-State":"AHYfb5j2H09mq0h/zpkqSd1QW4LinpuHYa3SZhyxMe8y75YDEr2rZarB\n\t7ewIQGrLBvcY9g1OIQq5729ophbqCA==","X-Google-Smtp-Source":"ADKCNb7ETSiuApF9c4exzdTQNDurlKoZCxQmAewcoFJFB2tuHzVbjEjZT8jbgzX7+lS5QKrqvxGKhl2w2ytbX+DjHeg=","X-Received":"by 10.200.45.37 with SMTP id n34mr8810363qta.219.1504215500065; \n\tThu, 31 Aug 2017 14:38:20 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1504209851-28202-1-git-send-email-jpettit@ovn.org>","References":"<1504209851-28202-1-git-send-email-jpettit@ovn.org>","From":"Russell Bryant <russell@ovn.org>","Date":"Thu, 31 Aug 2017 17:37:59 -0400","X-Gmail-Original-Message-ID":"<CA+0q_Pjiy4c8i-NxeGBg4LBPK4DGTDOFVoxr7qHO8KNLZ8NhNg@mail.gmail.com>","Message-ID":"<CA+0q_Pjiy4c8i-NxeGBg4LBPK4DGTDOFVoxr7qHO8KNLZ8NhNg@mail.gmail.com>","To":"Justin Pettit <jpettit@ovn.org>","X-Spam-Status":"No, score=-0.2 required=5.0 tests=RCVD_IN_DNSWL_LOW,\n\tRCVD_IN_SORBS_SPAM autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"ovs dev <dev@openvswitch.org>","Subject":"Re: [ovs-dev] [branch-2.8 1/2] Revert \"ofproto-dpif: Mark packets\n\tas \"untracked\" after call to ct().\"","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"<ovs-dev.openvswitch.org>","List-Unsubscribe":"<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>","List-Archive":"<http://mail.openvswitch.org/pipermail/ovs-dev/>","List-Post":"<mailto:ovs-dev@openvswitch.org>","List-Help":"<mailto:ovs-dev-request@openvswitch.org?subject=help>","List-Subscribe":"<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1761348,"web_url":"http://patchwork.ozlabs.org/comment/1761348/","msgid":"<20170831191638.475f21af@plex.home>","list_archive_url":null,"date":"2017-08-31T22:16:38","subject":"Re: [ovs-dev] [branch-2.8 1/2] Revert \"ofproto-dpif: Mark packets\n\tas \"untracked\" after call to ct().\"","submitter":{"id":3387,"url":"http://patchwork.ozlabs.org/api/people/3387/","name":"Flavio Leitner","email":"fbl@sysclose.org"},"content":"On Thu, 31 Aug 2017 13:04:10 -0700\nJustin Pettit <jpettit@ovn.org> wrote:\n\n> This reverts commit 8473cf69d25c4682cc6f6857b86b490a8c27cbd4.\n> \n> This commit introduced a change in the conntrack API.  This affected\n> some existing applications, so we will delay introducing the change\n> until the next major release.\n> \n> Signed-off-by: Justin Pettit <jpettit@ovn.org>\n> Requested-by: Flavio Leitner <fbl@sysclose.org>\n> ---\n\nLGTM, thanks!\nfbl\n\n\n\n\n>  NEWS                         |  4 ----\n>  lib/ofp-actions.c            | 27 ++++++++++++++-------------\n>  ofproto/ofproto-dpif-xlate.c | 21 ++++++++++++++-------\n>  tests/ofproto-dpif.at        | 10 +++++-----\n>  tests/system-traffic.at      |  4 ++--\n>  utilities/ovs-ofctl.8.in     | 10 ++++------\n>  6 files changed, 39 insertions(+), 37 deletions(-)\n> \n> diff --git a/NEWS b/NEWS\n> index 8e6fb79d38ca..ecb32c4df80c 100644\n> --- a/NEWS\n> +++ b/NEWS\n> @@ -74,10 +74,6 @@ v2.8.0 - xx xxx xxxx\n>         Used generic encap and decap actions to implement encapsulation and\n>         decapsulation of NSH header.\n>         IETF NSH draft - https://datatracker.ietf.org/doc/draft-ietf-sfc-nsh/\n> -     * Conntrack state is only available to the processing path that\n> -       follows the \"recirc_table\" argument of the ct() action.  Starting\n> -       in OVS 2.8, this state is now cleared for the current processing\n> -       path whenever ct() is called.\n>     - Fedora Packaging:\n>       * OVN services are no longer restarted automatically after upgrade.\n>       * ovs-vswitchd and ovsdb-server run as non-root users by default.\n> diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c\n> index 71eb70c3c239..bfc8a805ffd5 100644\n> --- a/lib/ofp-actions.c\n> +++ b/lib/ofp-actions.c\n> @@ -5858,19 +5858,20 @@ format_DEBUG_RECIRC(const struct ofpact_null *a OVS_UNUSED,\n>   *\n>   *   - Packet State:\n>   *\n> - *      Untracked packets have an unknown connection state.  In most\n> - *      cases, packets entering the OpenFlow pipeline will initially be\n> - *      in the untracked state. Untracked packets may become tracked by\n> - *      executing NXAST_CT with a \"recirc_table\" specified. This makes\n> - *      various aspects about the connection available, in particular\n> - *      the connection state.\n> - *\n> - *      An NXAST_CT action always puts the packet into an untracked\n> - *      state for the current processing path.  If \"recirc_table\" is\n> - *      set, execution is forked and the packet passes through the\n> - *      connection tracker.  The specified table's processing path is\n> - *      able to match on Connection state until the end of the OpenFlow\n> - *      pipeline or NXAST_CT is called again.\n> + *      Untracked packets have not yet passed through the connection tracker,\n> + *      and the connection state for such packets is unknown. In most cases,\n> + *      packets entering the OpenFlow pipeline will initially be in the\n> + *      untracked state. Untracked packets may become tracked by executing\n> + *      NXAST_CT with a \"recirc_table\" specified. This makes various aspects\n> + *      about the connection available, in particular the connection state.\n> + *\n> + *      Tracked packets have previously passed through the connection tracker.\n> + *      These packets will remain tracked through until the end of the OpenFlow\n> + *      pipeline. Tracked packets which have NXAST_CT executed with a\n> + *      \"recirc_table\" specified will return to the tracked state.\n> + *\n> + *      The packet state is only significant for the duration of packet\n> + *      processing within the OpenFlow pipeline.\n>   *\n>   *   - Connection State:\n>   *\n> diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c\n> index 9e1f837cb23e..973e760547fa 100644\n> --- a/ofproto/ofproto-dpif-xlate.c\n> +++ b/ofproto/ofproto-dpif-xlate.c\n> @@ -5721,7 +5721,9 @@ put_ct_nat(struct xlate_ctx *ctx)\n>  static void\n>  compose_conntrack_action(struct xlate_ctx *ctx, struct ofpact_conntrack *ofc)\n>  {\n> +    ovs_u128 old_ct_label = ctx->xin->flow.ct_label;\n>      ovs_u128 old_ct_label_mask = ctx->wc->masks.ct_label;\n> +    uint32_t old_ct_mark = ctx->xin->flow.ct_mark;\n>      uint32_t old_ct_mark_mask = ctx->wc->masks.ct_mark;\n>      size_t ct_offset;\n>      uint16_t zone;\n> @@ -5733,7 +5735,7 @@ compose_conntrack_action(struct xlate_ctx *ctx, struct ofpact_conntrack *ofc)\n>      /* Process nested actions first, to populate the key. */\n>      ctx->ct_nat_action = NULL;\n>      ctx->wc->masks.ct_mark = 0;\n> -    ctx->wc->masks.ct_label = OVS_U128_ZERO;\n> +    ctx->wc->masks.ct_label.u64.hi = ctx->wc->masks.ct_label.u64.lo = 0;\n>      do_xlate_actions(ofc->actions, ofpact_ct_get_action_len(ofc), ctx);\n>  \n>      if (ofc->zone_src.field) {\n> @@ -5759,18 +5761,23 @@ compose_conntrack_action(struct xlate_ctx *ctx, struct ofpact_conntrack *ofc)\n>      ctx->ct_nat_action = NULL;\n>      nl_msg_end_nested(ctx->odp_actions, ct_offset);\n>  \n> +    /* Restore the original ct fields in the key. These should only be exposed\n> +     * after recirculation to another table. */\n> +    ctx->xin->flow.ct_mark = old_ct_mark;\n>      ctx->wc->masks.ct_mark = old_ct_mark_mask;\n> +    ctx->xin->flow.ct_label = old_ct_label;\n>      ctx->wc->masks.ct_label = old_ct_label_mask;\n>  \n> -    if (ofc->recirc_table != NX_CT_RECIRC_NONE) {\n> +    if (ofc->recirc_table == NX_CT_RECIRC_NONE) {\n> +        /* If we do not recirculate as part of this action, hide the results of\n> +         * connection tracking from subsequent recirculations. */\n> +        ctx->conntracked = false;\n> +    } else {\n> +        /* Use ct_* fields from datapath during recirculation upcall. */\n>          ctx->conntracked = true;\n>          compose_recirculate_and_fork(ctx, ofc->recirc_table);\n> +        ctx->conntracked = false;\n>      }\n> -\n> -    /* The ct_* fields are only available in the scope of the 'recirc_table'\n> -     * call chain. */\n> -    flow_clear_conntrack(&ctx->xin->flow);\n> -    ctx->conntracked = false;\n>  }\n>  \n>  static void\n> diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at\n> index 28a7e827cac2..284a65ec6524 100644\n> --- a/tests/ofproto-dpif.at\n> +++ b/tests/ofproto-dpif.at\n> @@ -8949,7 +8949,7 @@ OVS_WAIT_UNTIL([ovs-appctl -t ovs-ofctl exit])\n>  \n>  dnl Check this output. We only see the latter two packets, not the first.\n>  AT_CHECK([cat ofctl_monitor.log], [0], [dnl\n> -NXT_PACKET_IN (xid=0x0): table_id=6 cookie=0x0 total_len=42 reg0=0x1,reg1=0x4d2,reg2=0x1,reg3=0x1,reg4=0x1,in_port=1 (via action) data_len=42 (unbuffered)\n> +NXT_PACKET_IN (xid=0x0): table_id=6 cookie=0x0 total_len=42 ct_state=new|trk,ct_zone=1,ct_nw_src=10.1.1.1,ct_nw_dst=10.1.1.2,ct_nw_proto=17,ct_tp_src=1,ct_tp_dst=2,reg0=0x1,reg1=0x4d2,reg2=0x1,reg3=0x1,reg4=0x1,in_port=1 (via action) data_len=42 (unbuffered)\n>  udp,vlan_tci=0x0000,dl_src=50:54:00:00:00:09,dl_dst=50:54:00:00:00:0a,nw_src=10.1.1.1,nw_dst=10.1.1.2,nw_tos=0,nw_ecn=0,nw_ttl=64,tp_src=1,tp_dst=2 udp_csum:e9d6\n>  dnl\n>  NXT_PACKET_IN (xid=0x0): table_id=6 cookie=0x0 total_len=42 ct_state=est|rpl|trk,ct_zone=1,ct_mark=0x1,ct_label=0x4d2000000000000000000000000,ct_nw_src=10.1.1.1,ct_nw_dst=10.1.1.2,ct_nw_proto=17,ct_tp_src=1,ct_tp_dst=2,reg0=0x1,reg1=0x4d2,reg2=0x1,reg3=0x2,reg4=0x1,in_port=2 (via action) data_len=42 (unbuffered)\n> @@ -8970,7 +8970,7 @@ OVS_WAIT_UNTIL([ovs-appctl -t ovs-ofctl exit])\n>  \n>  dnl Check this output. We should see both packets\n>  AT_CHECK([cat ofctl_monitor.log], [0], [dnl\n> -NXT_PACKET_IN (xid=0x0): table_id=6 cookie=0x0 total_len=42 reg0=0x1,reg1=0x4d2,reg2=0x1,reg3=0x1,reg4=0x1,in_port=1 (via action) data_len=42 (unbuffered)\n> +NXT_PACKET_IN (xid=0x0): table_id=6 cookie=0x0 total_len=42 ct_state=new|trk,ct_zone=1,ct_nw_src=10.1.1.1,ct_nw_dst=10.1.1.2,ct_nw_proto=17,ct_tp_src=3,ct_tp_dst=2,reg0=0x1,reg1=0x4d2,reg2=0x1,reg3=0x1,reg4=0x1,in_port=1 (via action) data_len=42 (unbuffered)\n>  udp,vlan_tci=0x0000,dl_src=50:54:00:00:00:09,dl_dst=50:54:00:00:00:0a,nw_src=10.1.1.1,nw_dst=10.1.1.2,nw_tos=0,nw_ecn=0,nw_ttl=64,tp_src=3,tp_dst=2 udp_csum:e9d4\n>  dnl\n>  NXT_PACKET_IN (xid=0x0): table_id=6 cookie=0x0 total_len=42 ct_state=est|rpl|trk,ct_zone=1,ct_mark=0x1,ct_label=0x4d2000000000000000000000000,ct_nw_src=10.1.1.1,ct_nw_dst=10.1.1.2,ct_nw_proto=17,ct_tp_src=3,ct_tp_dst=2,reg0=0x1,reg1=0x4d2,reg2=0x1,reg3=0x2,reg4=0x1,in_port=2 (via action) data_len=42 (unbuffered)\n> @@ -9025,7 +9025,7 @@ AT_CHECK([cat ofctl_monitor.log], [0], [dnl\n>  NXT_PACKET_IN (xid=0x0): cookie=0x0 total_len=42 in_port=1 (via action) data_len=42 (unbuffered)\n>  udp,vlan_tci=0x0000,dl_src=50:54:00:00:00:09,dl_dst=50:54:00:00:00:0a,nw_src=10.1.1.1,nw_dst=10.1.1.2,nw_tos=0,nw_ecn=0,nw_ttl=64,tp_src=1,tp_dst=2 udp_csum:e9d6\n>  dnl\n> -NXT_PACKET_IN (xid=0x0): table_id=1 cookie=0x0 total_len=42 in_port=2 (via action) data_len=42 (unbuffered)\n> +NXT_PACKET_IN (xid=0x0): table_id=1 cookie=0x0 total_len=42 ct_state=est|rpl|trk,ct_nw_src=10.1.1.1,ct_nw_dst=10.1.1.2,ct_nw_proto=17,ct_tp_src=1,ct_tp_dst=2,in_port=2 (via action) data_len=42 (unbuffered)\n>  udp,vlan_tci=0x0000,dl_src=50:54:00:00:00:0a,dl_dst=50:54:00:00:00:09,nw_src=10.1.1.2,nw_dst=10.1.1.1,nw_tos=0,nw_ecn=0,nw_ttl=64,tp_src=2,tp_dst=1 udp_csum:e9d6\n>  ])\n>  \n> @@ -9047,7 +9047,7 @@ AT_CHECK([cat ofctl_monitor.log], [0], [dnl\n>  NXT_PACKET_IN (xid=0x0): cookie=0x0 total_len=42 in_port=1 (via action) data_len=42 (unbuffered)\n>  udp,vlan_tci=0x0000,dl_src=50:54:00:00:00:09,dl_dst=50:54:00:00:00:0a,nw_src=10.1.1.1,nw_dst=10.1.1.2,nw_tos=0,nw_ecn=0,nw_ttl=64,tp_src=3,tp_dst=4 udp_csum:e9d2\n>  dnl\n> -NXT_PACKET_IN (xid=0x0): table_id=1 cookie=0x0 total_len=42 in_port=2 (via action) data_len=42 (unbuffered)\n> +NXT_PACKET_IN (xid=0x0): table_id=1 cookie=0x0 total_len=42 ct_state=est|rpl|trk,ct_nw_src=10.1.1.1,ct_nw_dst=10.1.1.2,ct_nw_proto=17,ct_tp_src=3,ct_tp_dst=4,in_port=2 (via action) data_len=42 (unbuffered)\n>  udp,vlan_tci=0x0000,dl_src=50:54:00:00:00:0a,dl_dst=50:54:00:00:00:09,nw_src=10.1.1.2,nw_dst=10.1.1.1,nw_tos=0,nw_ecn=0,nw_ttl=64,tp_src=4,tp_dst=3 udp_csum:e9d2\n>  ])\n>  \n> @@ -9362,7 +9362,7 @@ OVS_WAIT_UNTIL([ovs-appctl -t ovs-ofctl exit])\n>  \n>  dnl Check this output. We only see the latter two packets, not the first.\n>  AT_CHECK([cat ofctl_monitor.log], [0], [dnl\n> -NXT_PACKET_IN (xid=0x0): table_id=1 cookie=0x0 total_len=42 in_port=1 (via action) data_len=42 (unbuffered)\n> +NXT_PACKET_IN (xid=0x0): table_id=1 cookie=0x0 total_len=42 ct_state=new|trk,ct_nw_src=10.1.1.1,ct_nw_dst=10.1.1.2,ct_nw_proto=17,ct_tp_src=1,ct_tp_dst=2,in_port=1 (via action) data_len=42 (unbuffered)\n>  udp,vlan_tci=0x0000,dl_src=50:54:00:00:00:09,dl_dst=50:54:00:00:00:0a,nw_src=10.1.1.1,nw_dst=10.1.1.2,nw_tos=0,nw_ecn=0,nw_ttl=64,tp_src=1,tp_dst=2 udp_csum:e9d6\n>  dnl\n>  NXT_PACKET_IN (xid=0x0): table_id=1 cookie=0x0 total_len=42 ct_state=est|rpl|trk,ct_nw_src=10.1.1.1,ct_nw_dst=10.1.1.2,ct_nw_proto=17,ct_tp_src=1,ct_tp_dst=2,in_port=2 (via action) data_len=42 (unbuffered)\n> diff --git a/tests/system-traffic.at b/tests/system-traffic.at\n> index 522eaa615834..798dd2cbd2c2 100644\n> --- a/tests/system-traffic.at\n> +++ b/tests/system-traffic.at\n> @@ -2287,7 +2287,7 @@ dnl Ingress pipeline\n>  dnl - Allow all connections from LOCAL port (commit and proceed to egress)\n>  dnl - All other connections go through conntracker using the input port as\n>  dnl   a connection tracking zone.\n> -table=1,priority=150,in_port=LOCAL,ip,ct_state=+trk+new,action=ct(commit,table=2,zone=OXM_OF_IN_PORT[[0..15]])\n> +table=1,priority=150,in_port=LOCAL,ip,ct_state=+trk+new,action=ct(commit,zone=OXM_OF_IN_PORT[[0..15]]),goto_table:2\n>  table=1,priority=100,ip,action=ct(table=2,zone=OXM_OF_IN_PORT[[0..15]])\n>  table=1,priority=1,action=drop\n>  \n> @@ -2295,7 +2295,7 @@ dnl Egress pipeline\n>  dnl - Allow all connections from LOCAL port (commit and skip to output)\n>  dnl - Allow other established connections to go through conntracker using\n>  dnl   output port as a connection tracking zone.\n> -table=2,priority=150,in_port=LOCAL,ip,ct_state=+trk+new,action=ct(commit,table=4,zone=NXM_NX_REG0[[0..15]])\n> +table=2,priority=150,in_port=LOCAL,ip,ct_state=+trk+new,action=ct(commit,zone=NXM_NX_REG0[[0..15]]),goto_table:4\n>  table=2,priority=100,ip,ct_state=+trk+est,action=ct(table=3,zone=NXM_NX_REG0[[0..15]])\n>  table=2,priority=1,action=drop\n>  \n> diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.8.in\n> index c65de97f5e2e..f6bd90374a18 100644\n> --- a/utilities/ovs-ofctl.8.in\n> +++ b/utilities/ovs-ofctl.8.in\n> @@ -1031,13 +1031,11 @@ Restores the queue to the value it was before any \\fBset_queue\\fR\n>  actions were applied.\n>  .\n>  .IP \\fBct\\fR\n> -.IQ \\fBct(\\fR[\\fIargument\\fR][\\fB,\\fIargument\\fR...]\\fB)\n> +.IQ \\fBct\\fB(\\fR[\\fIargument\\fR][\\fB,\\fIargument\\fR...]\\fB)\n>  Send the packet through the connection tracker.  Refer to the \\fBct_state\\fR\n> -documentation above for possible packet and connection states. A \\fBct\\fR\n> -action always sets the packet to an untracked state and clears out the\n> -\\fBct_state\\fR fields for the current processing path.  Those fields are\n> -only available for the processing path pointed to by the \\fBtable\\fR\n> -argument.  The following arguments are supported:\n> +documentation above for possible packet and connection states. The following\n> +arguments are supported:\n> +\n>  .RS\n>  .IP \\fBcommit\\fR\n>  .RS","headers":{"Return-Path":"<ovs-dev-bounces@openvswitch.org>","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=sysclose.org header.i=fbl@sysclose.org\n\theader.b=\"UkMKbIGf\"; dkim-atps=neutral"],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjxYZ210bz9s81\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri,  1 Sep 2017 08:16:50 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 16619D56;\n\tThu, 31 Aug 2017 22:16:48 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 0E581D4F\n\tfor <dev@openvswitch.org>; Thu, 31 Aug 2017 22:16:47 +0000 (UTC)","from sender-of-o52.zoho.com (sender-of-o52.zoho.com\n\t[135.84.80.217])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id AF64FF6\n\tfor <dev@openvswitch.org>; Thu, 31 Aug 2017 22:16:45 +0000 (UTC)","from plex.home (187.95.127.252 [187.95.127.252]) by mx.zohomail.com\n\twith SMTPS id 1504217802562568.8574221147013;\n\tThu, 31 Aug 2017 15:16:42 -0700 (PDT)"],"X-Greylist":"from auto-whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1504217802;\n\ts=zoho; d=sysclose.org; i=fbl@sysclose.org;\n\th=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding;\n\tl=13024; bh=n4sdhVHak4n3mYEuUxDv8440TLSSyMMW97YR5WRsxp8=;\n\tb=UkMKbIGfInB24W8PeKrqiW4pSEJrcEjgCmrXCtTb+5/PPIGzos1I2VFB/9kw+1Q0\n\tBrKMlAiVe7/snR8Bs2hK2c7BRJ7Vm5aOD98K7477dc4RraZc+ctXmO+PzIhTAB6M+2d\n\tiPn5M0mc9gtxFg84wbOPDPSiJJC7UBJeF0J9zjTo=","Date":"Thu, 31 Aug 2017 19:16:38 -0300","From":"Flavio Leitner <fbl@sysclose.org>","To":"Justin Pettit <jpettit@ovn.org>","Message-ID":"<20170831191638.475f21af@plex.home>","In-Reply-To":"<1504209851-28202-1-git-send-email-jpettit@ovn.org>","References":"<1504209851-28202-1-git-send-email-jpettit@ovn.org>","X-Mailer":"Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu)","MIME-Version":"1.0","X-ZohoMailClient":"External","X-Spam-Status":"No, score=-0.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,RCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"dev@openvswitch.org","Subject":"Re: [ovs-dev] [branch-2.8 1/2] Revert \"ofproto-dpif: Mark packets\n\tas \"untracked\" after call to ct().\"","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"<ovs-dev.openvswitch.org>","List-Unsubscribe":"<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>","List-Archive":"<http://mail.openvswitch.org/pipermail/ovs-dev/>","List-Post":"<mailto:ovs-dev@openvswitch.org>","List-Help":"<mailto:ovs-dev-request@openvswitch.org?subject=help>","List-Subscribe":"<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}}]