[{"id":1762140,"web_url":"http://patchwork.ozlabs.org/comment/1762140/","msgid":"<20170902153435.GB21003@lunn.ch>","list_archive_url":null,"date":"2017-09-02T15:34:35","subject":"Re: [PATCH net-next 4/4] net: dsa: assign a master to slave ports","submitter":{"id":13608,"url":"http://patchwork.ozlabs.org/api/people/13608/","name":"Andrew Lunn","email":"andrew@lunn.ch"},"content":"On Thu, Aug 31, 2017 at 02:37:46PM -0400, Vivien Didelot wrote:\n> Because each DSA slave port may use a different DSA master port, add a\n> pointer to a master in the slave structure. This is a preparatory patch\n> for multiple CPU ports.\n> \n> Signed-off-by: Vivien Didelot \n> ---\n> net/dsa/dsa_priv.h | 7 ++-----\n> net/dsa/slave.c | 33 ++++++++++++++++++---------------\n> 2 files changed, 20 insertions(+), 20 deletions(-)\n> \n> diff --git a/net/dsa/dsa_priv.h b/net/dsa/dsa_priv.h\n> index 59f155cbbe87..a8cd6cbe4061 100644\n> --- a/net/dsa/dsa_priv.h\n> +++ b/net/dsa/dsa_priv.h\n> @@ -66,6 +66,8 @@ struct dsa_notifier_vlan_info {\n> };\n> \n> struct dsa_slave_priv {\n> +\tstruct dsa_master *master;\n> +\n> \t/* Copy of the master xmit tagging op for faster access in hot path */\n> \tstruct sk_buff *\t(*xmit)(struct sk_buff *skb,\n> \t\t\t\t\tstruct net_device *dev);\n> @@ -179,9 +181,4 @@ extern const struct dsa_device_ops qca_netdev_ops;\n> /* tag_trailer.c */\n> extern const struct dsa_device_ops trailer_netdev_ops;\n> \n> -static inline struct net_device *dsa_master_netdev(struct dsa_slave_priv *p)\n> -{\n> -\treturn p->dp->ds->dst->master->netdev;\n> -}\n> -\n\nHi Vivien\n\nWhy remove this helper, when it could become p->master->netdev ?\n\n Andrew","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xl0Xp54kmz9sRY\n\tfor ;\n\tSun, 3 Sep 2017 01:34:50 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752711AbdIBPei (ORCPT );\n\tSat, 2 Sep 2017 11:34:38 -0400","from vps0.lunn.ch ([178.209.37.122]:54447 \"EHLO vps0.lunn.ch\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1752683AbdIBPeh (ORCPT );\n\tSat, 2 Sep 2017 11:34:37 -0400","from andrew by vps0.lunn.ch with local (Exim 4.84_2)\n\t(envelope-from )\n\tid 1doARP-00019l-A4; Sat, 02 Sep 2017 17:34:35 +0200"],"Date":"Sat, 2 Sep 2017 17:34:35 +0200","From":"Andrew Lunn ","To":"Vivien Didelot ","Cc":"netdev@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tkernel@savoirfairelinux.com, \"David S. Miller\" ,\n\tFlorian Fainelli ","Subject":"Re: [PATCH net-next 4/4] net: dsa: assign a master to slave ports","Message-ID":"<20170902153435.GB21003@lunn.ch>","References":"<20170831183746.2109-1-vivien.didelot@savoirfairelinux.com>\n\t<20170831183746.2109-5-vivien.didelot@savoirfairelinux.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170831183746.2109-5-vivien.didelot@savoirfairelinux.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1762157,"web_url":"http://patchwork.ozlabs.org/comment/1762157/","msgid":"<153b5e2d-f904-3836-4eeb-0ef9698f7090@gmail.com>","list_archive_url":null,"date":"2017-09-02T16:29:06","subject":"Re: [PATCH net-next 4/4] net: dsa: assign a master to slave ports","submitter":{"id":2800,"url":"http://patchwork.ozlabs.org/api/people/2800/","name":"Florian Fainelli","email":"f.fainelli@gmail.com"},"content":"On 09/02/2017 08:34 AM, Andrew Lunn wrote:\n> On Thu, Aug 31, 2017 at 02:37:46PM -0400, Vivien Didelot wrote:\n>> Because each DSA slave port may use a different DSA master port, add a\n>> pointer to a master in the slave structure. This is a preparatory patch\n>> for multiple CPU ports.\n>>\n>> Signed-off-by: Vivien Didelot \n>> ---\n>> net/dsa/dsa_priv.h | 7 ++-----\n>> net/dsa/slave.c | 33 ++++++++++++++++++---------------\n>> 2 files changed, 20 insertions(+), 20 deletions(-)\n>>\n>> diff --git a/net/dsa/dsa_priv.h b/net/dsa/dsa_priv.h\n>> index 59f155cbbe87..a8cd6cbe4061 100644\n>> --- a/net/dsa/dsa_priv.h\n>> +++ b/net/dsa/dsa_priv.h\n>> @@ -66,6 +66,8 @@ struct dsa_notifier_vlan_info {\n>> };\n>> \n>> struct dsa_slave_priv {\n>> +\tstruct dsa_master *master;\n>> +\n>> \t/* Copy of the master xmit tagging op for faster access in hot path */\n>> \tstruct sk_buff *\t(*xmit)(struct sk_buff *skb,\n>> \t\t\t\t\tstruct net_device *dev);\n>> @@ -179,9 +181,4 @@ extern const struct dsa_device_ops qca_netdev_ops;\n>> /* tag_trailer.c */\n>> extern const struct dsa_device_ops trailer_netdev_ops;\n>> \n>> -static inline struct net_device *dsa_master_netdev(struct dsa_slave_priv *p)\n>> -{\n>> -\treturn p->dp->ds->dst->master->netdev;\n>> -}\n>> -\n> \n> Hi Vivien\n> \n> Why remove this helper, when it could become p->master->netdev ?\n\nAgreed, I would keep the helper at this point to minimize the delta, it\nshould really identical in terms of code generated.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"E6hQufhv\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xl1ln49znz9t16\n\tfor ;\n\tSun, 3 Sep 2017 02:29:25 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752739AbdIBQ3L (ORCPT );\n\tSat, 2 Sep 2017 12:29:11 -0400","from mail-oi0-f66.google.com ([209.85.218.66]:34940 \"EHLO\n\tmail-oi0-f66.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752697AbdIBQ3K (ORCPT\n\t); Sat, 2 Sep 2017 12:29:10 -0400","by mail-oi0-f66.google.com with SMTP id n18so2300487oig.2;\n\tSat, 02 Sep 2017 09:29:10 -0700 (PDT)","from ?IPv6:2001:470:d:73f:c96d:ffbc:6d05:de5c?\n\t([2001:470:d:73f:c96d:ffbc:6d05:de5c])\n\tby smtp.gmail.com with ESMTPSA id\n\tx139sm3932418oia.14.2017.09.02.09.29.08\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSat, 02 Sep 2017 09:29:08 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=ONBivtEUYT3Fd/4DbJApxS1FeBu4mg2ip0uMM43x1tg=;\n\tb=E6hQufhvjABIhIptQfGmVPh5Fkbi3nrXOBhAlHwG/dev0jtIr3l3r2StRX1ACYJ7W7\n\tGBC/lcSCiVO6pU0uuGJLGVpBVHrsPBXRfHvy0OAMPBRLqaopRjsi+TTPXc8YQ7hz7uER\n\ttjDfb0yn8uNi21M0iKyM1hsk/8y5eANO4e/OWqaVpNA8xg+fAn7k+4PfKpcl3BpYNNU4\n\txaZGEZqmpcGa4U+ajLQzdHmSfzfLUAOtqOJcwZhww3bfuIywIc9qSZZmy9+Mwd26oFTG\n\toKD1FFB9+t4LBHNVFbuuFfdnqk1TPrDwM4UvjodgXncoPFBQgtWgbDtBvnTr+fBbBEp7\n\twcEQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=ONBivtEUYT3Fd/4DbJApxS1FeBu4mg2ip0uMM43x1tg=;\n\tb=F+CwAYlpFxRGNO2xYmfCn6LYq1L7+GlSRSi/9drxrjejtzkkjEuhEadlVBOWEKmqrc\n\tjAfcrc7VJnuW7cqvaGEy7azebakCOAsTuwwYHdF4YQzeLYFc1SrqxSubPxYmsn9NiKfS\n\tn94zeWQTW1JQQjaotRWu/rVWT8D5/m7luSk8+TD31pPCRpmBf8VMmmtTaqxZKIBGVcZD\n\tSEaOv8qdxwM1YMhZIOcdrJpS2pPMN1MDnXe7pv5q4mKuVErSl3u3PwGr1A7rz2mhtbCl\n\tNidMNnOoNrlC1/SPyqy34Iv/op4My3aDpJcECoFoRNXRuIw9H47/etBzMOKcp26zE1EG\n\tYINw==","X-Gm-Message-State":"AHPjjUisZ3ehIDxIhQ9uRvNM3GWZbRhiLOPSPuY5TX/3i9zTc2irHGQL\n\tymDvirmnrYgXDQ==","X-Google-Smtp-Source":"ADKCNb6WsnYjxFX0sNquS0VebPGic9RlZekFLa6psQ6dsU1cybNokoCqqyM5FYe9OWNamCyT/68KQw==","X-Received":"by 10.202.98.7 with SMTP id w7mr4724213oib.262.1504369749832;\n\tSat, 02 Sep 2017 09:29:09 -0700 (PDT)","Subject":"Re: [PATCH net-next 4/4] net: dsa: assign a master to slave ports","To":"Andrew Lunn ,\n\tVivien Didelot ","Cc":"netdev@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tkernel@savoirfairelinux.com, \"David S. Miller\" ","References":"<20170831183746.2109-1-vivien.didelot@savoirfairelinux.com>\n\t<20170831183746.2109-5-vivien.didelot@savoirfairelinux.com>\n\t<20170902153435.GB21003@lunn.ch>","From":"Florian Fainelli ","Message-ID":"<153b5e2d-f904-3836-4eeb-0ef9698f7090@gmail.com>","Date":"Sat, 2 Sep 2017 09:29:06 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170902153435.GB21003@lunn.ch>","Content-Type":"text/plain; charset=windows-1252","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]