[{"id":1761675,"web_url":"http://patchwork.ozlabs.org/comment/1761675/","msgid":"<000001d32324$b5466280$1fd32780$@gmail.com>","list_archive_url":null,"date":"2017-09-01T13:17:48","subject":"Re: [PATCH 01/10] PCI: exynos: Fix platform_get_irq() error handling","submitter":{"id":66657,"url":"http://patchwork.ozlabs.org/api/people/66657/","name":"Han Jingoo","email":"jingoohan1@gmail.com"},"content":"(CC'ed Joao Pinto)\n\nOn Thursday, August 31, 2017 1:52 PM, Fabio Estevam wrote:\n> \n> platform_get_irq() returns a negative number on failure, so\n> adjust the logic to detect such condition and propagate\n> the real error value on failure.\n> \n> Cc: Jingoo Han \n> Reported-by: Bjorn Helgaas \n> Signed-off-by: Fabio Estevam \n\nAcked-by: Jingoo Han \n\nBest regards,\nJingoo Han\n\n> ---\n> drivers/pci/dwc/pci-exynos.c | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/drivers/pci/dwc/pci-exynos.c b/drivers/pci/dwc/pci-exynos.c\n> index f77f872..5596fde 100644\n> --- a/drivers/pci/dwc/pci-exynos.c\n> +++ b/drivers/pci/dwc/pci-exynos.c\n> @@ -607,9 +607,9 @@ static int __init exynos_add_pcie_port(struct\n> exynos_pcie *ep,\n> \tint ret;\n> \n> \tpp->irq = platform_get_irq(pdev, 1);\n> -\tif (!pp->irq) {\n> +\tif (pp->irq < 0) {\n> \t\tdev_err(dev, \"failed to get irq\\n\");\n> -\t\treturn -ENODEV;\n> +\t\treturn pp->irq;\n> \t}\n> \tret = devm_request_irq(dev, pp->irq, exynos_pcie_irq_handler,\n> \t\t\t\tIRQF_SHARED, \"exynos-pcie\", ep);\n> @@ -620,9 +620,9 @@ static int __init exynos_add_pcie_port(struct\n> exynos_pcie *ep,\n> \n> \tif (IS_ENABLED(CONFIG_PCI_MSI)) {\n> \t\tpp->msi_irq = platform_get_irq(pdev, 0);\n> -\t\tif (!pp->msi_irq) {\n> +\t\tif (pp->msi_irq < 0) {\n> \t\t\tdev_err(dev, \"failed to get msi irq\\n\");\n> -\t\t\treturn -ENODEV;\n> +\t\t\treturn pp->msi_irq;\n> \t\t}\n> \n> \t\tret = devm_request_irq(dev, pp->msi_irq,\n> --\n> 2.7.4","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"UPdkS77N\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkKYK6pDWz9t1t\n\tfor ;\n\tFri, 1 Sep 2017 23:17:57 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752008AbdIANRy (ORCPT );\n\tFri, 1 Sep 2017 09:17:54 -0400","from mail-qk0-f194.google.com ([209.85.220.194]:33755 \"EHLO\n\tmail-qk0-f194.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751715AbdIANRv (ORCPT\n\t); Fri, 1 Sep 2017 09:17:51 -0400","by mail-qk0-f194.google.com with SMTP id k126so154248qkb.0\n\tfor ; Fri, 01 Sep 2017 06:17:50 -0700 (PDT)","from DESKTOP3JAHB13 (c-98-244-106-188.hsd1.va.comcast.net.\n\t[98.244.106.188]) by smtp.gmail.com with ESMTPSA id\n\tv17sm118063qtg.2.2017.09.01.06.17.48\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 01 Sep 2017 06:17:49 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:references:in-reply-to:subject:date:message-id\n\t:mime-version:content-transfer-encoding:thread-index\n\t:content-language;\n\tbh=ThQydoGOYDcQyIpSqhcUF5l9oK1svGK8+t1M66qi2Pk=;\n\tb=UPdkS77N8AKj7hKH+pzDefU5xZ4FKvDHdgrNJhOvYjR3H8wQKZcWwZEupzZUJCP0q0\n\tLmGLI0KScQmPwtGXKns4osGyHe1YVTIDtnmzF0zV8ndMjhKlL/uaBYwIVItrVESnLxke\n\ttkMLVTaPUt73jNt4MXzMtGWPaiLZLEIwNLfO0Mjn4dsNiSUW1ys9WUGkwtkTu94xUnMx\n\t35lV9OOK0euu/1uTRkk4zpzPHzSeQO/v8JXq0qyJhZl2qdKXShB0Ms+QRZRs+HswgdM1\n\t0e870KKM0l9KHWBnkjfkfV+UztnxE6qStvoJzUBX/a1jcrQnCv69NEeUi8kRnBxAmjiy\n\tTMyg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:references:in-reply-to:subject:date\n\t:message-id:mime-version:content-transfer-encoding:thread-index\n\t:content-language;\n\tbh=ThQydoGOYDcQyIpSqhcUF5l9oK1svGK8+t1M66qi2Pk=;\n\tb=WhYhxfcH9S45u+SWWLTWgoTipvJNA8vUibVq9RDj9LA+P0jI/Xo6Tfs2izOgD/kc21\n\t697zhV0udeSWJxrm0iWcpZ3iroJxWpF4k9DLb0OxLMnf5ILcEIkIG0FJM76mKuDfw+fa\n\tFLKl5PW4bWhYaAwKcQHEwSAydJsLqIHYpdArBE1WzoDN0/176GgEAjfQHWgd5nd96rvl\n\tG1bjASJBMx61mH6WZNVaTIRXoLwu/UZmMVVJPQH/2NENwfekkh9TaaqmR33NHS6noxo0\n\tTVkrnsZQ/wx699fu8KUo6Wvg36/hSvZGFGRzWz2e3Lna+9oTbTqSnWcKiQ68S+1AxV7m\n\tfBiw==","X-Gm-Message-State":"AHPjjUiqHhzVR30i2LaFzEYiexBhY94LOQFPQ1mXymtUwzUUEMPTlBgN\n\tr3ABBT1Pyf4IDQ==","X-Google-Smtp-Source":"ADKCNb5ba6JsSNOeCCWVXrPHgH4TbnuQrTmCF1sNNewcEWYLR+odClKh79WDwoecGqG3P+R2yHrMKA==","X-Received":"by 10.55.121.130 with SMTP id u124mr2616723qkc.13.1504271870289; \n\tFri, 01 Sep 2017 06:17:50 -0700 (PDT)","From":"\"Jingoo Han\" ","To":"\"'Fabio Estevam'\" , ","Cc":"","References":"<1504201930-3617-1-git-send-email-fabio.estevam@nxp.com>","In-Reply-To":"<1504201930-3617-1-git-send-email-fabio.estevam@nxp.com>","Subject":"Re: [PATCH 01/10] PCI: exynos: Fix platform_get_irq() error handling","Date":"Fri, 1 Sep 2017 09:17:48 -0400","Message-ID":"<000001d32324$b5466280$1fd32780$@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain;\n charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","X-Mailer":"Microsoft Outlook 16.0","Thread-Index":"AQI6hmo6MsqKtiDkQNGIf6fuGD9D2KHRPCgA","Content-Language":"en-us","Sender":"linux-pci-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pci@vger.kernel.org"}},{"id":1763568,"web_url":"http://patchwork.ozlabs.org/comment/1763568/","msgid":"<20170905184623.GC14367@bhelgaas-glaptop.roam.corp.google.com>","list_archive_url":null,"date":"2017-09-05T18:46:23","subject":"Re: [PATCH 01/10] PCI: exynos: Fix platform_get_irq() error handling","submitter":{"id":67298,"url":"http://patchwork.ozlabs.org/api/people/67298/","name":"Bjorn Helgaas","email":"helgaas@kernel.org"},"content":"On Thu, Aug 31, 2017 at 02:52:01PM -0300, Fabio Estevam wrote:\n> platform_get_irq() returns a negative number on failure, so\n> adjust the logic to detect such condition and propagate\n> the real error value on failure.\n> \n> Cc: Jingoo Han \n> Reported-by: Bjorn Helgaas \n> Signed-off-by: Fabio Estevam \n\nThanks, Fabio. I applied all these on their respective branches for v4.14,\nwith the acks received so far.\n\n> ---\n> drivers/pci/dwc/pci-exynos.c | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/drivers/pci/dwc/pci-exynos.c b/drivers/pci/dwc/pci-exynos.c\n> index f77f872..5596fde 100644\n> --- a/drivers/pci/dwc/pci-exynos.c\n> +++ b/drivers/pci/dwc/pci-exynos.c\n> @@ -607,9 +607,9 @@ static int __init exynos_add_pcie_port(struct exynos_pcie *ep,\n> \tint ret;\n> \n> \tpp->irq = platform_get_irq(pdev, 1);\n> -\tif (!pp->irq) {\n> +\tif (pp->irq < 0) {\n> \t\tdev_err(dev, \"failed to get irq\\n\");\n> -\t\treturn -ENODEV;\n> +\t\treturn pp->irq;\n> \t}\n> \tret = devm_request_irq(dev, pp->irq, exynos_pcie_irq_handler,\n> \t\t\t\tIRQF_SHARED, \"exynos-pcie\", ep);\n> @@ -620,9 +620,9 @@ static int __init exynos_add_pcie_port(struct exynos_pcie *ep,\n> \n> \tif (IS_ENABLED(CONFIG_PCI_MSI)) {\n> \t\tpp->msi_irq = platform_get_irq(pdev, 0);\n> -\t\tif (!pp->msi_irq) {\n> +\t\tif (pp->msi_irq < 0) {\n> \t\t\tdev_err(dev, \"failed to get msi irq\\n\");\n> -\t\t\treturn -ENODEV;\n> +\t\t\treturn pp->msi_irq;\n> \t\t}\n> \n> \t\tret = devm_request_irq(dev, pp->msi_irq,\n> -- \n> 2.7.4\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=)","mail.kernel.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.org","mail.kernel.org;\n\tspf=none smtp.mailfrom=helgaas@kernel.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmwfX16qtz9s8J\n\tfor ;\n\tWed, 6 Sep 2017 04:46:28 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752597AbdIESq0 (ORCPT );\n\tTue, 5 Sep 2017 14:46:26 -0400","from mail.kernel.org ([198.145.29.99]:60658 \"EHLO mail.kernel.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751863AbdIESq0 (ORCPT );\n\tTue, 5 Sep 2017 14:46:26 -0400","from localhost (unknown [69.71.4.159])\n\t(using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits))\n\t(No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id ACA6321E92;\n\tTue, 5 Sep 2017 18:46:25 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mail.kernel.org ACA6321E92","Date":"Tue, 5 Sep 2017 13:46:23 -0500","From":"Bjorn Helgaas ","To":"Fabio Estevam ","Cc":"bhelgaas@google.com, linux-pci@vger.kernel.org,\n\tJingoo Han ","Subject":"Re: [PATCH 01/10] PCI: exynos: Fix platform_get_irq() error handling","Message-ID":"<20170905184623.GC14367@bhelgaas-glaptop.roam.corp.google.com>","References":"<1504201930-3617-1-git-send-email-fabio.estevam@nxp.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<1504201930-3617-1-git-send-email-fabio.estevam@nxp.com>","User-Agent":"Mutt/1.5.21 (2010-09-15)","Sender":"linux-pci-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pci@vger.kernel.org"}}]