[{"id":1761485,"web_url":"http://patchwork.ozlabs.org/comment/1761485/","msgid":"<640d0339-0263-4026-e16f-e4fbc68f1e7e@ti.com>","list_archive_url":null,"date":"2017-09-01T06:43:34","subject":"Re: [PATCH 02/10] PCI: dra7xx: Fix platform_get_irq() error handling","submitter":{"id":14965,"url":"http://patchwork.ozlabs.org/api/people/14965/","name":"Kishon Vijay Abraham I","email":"kishon@ti.com"},"content":"On Thursday 31 August 2017 11:22 PM, Fabio Estevam wrote:\n> When platform_get_irq() fails we should propagate the real error\n> value instead of always returning -EINVAL.\n> \n> Cc: Kishon Vijay Abraham I \n> Signed-off-by: Fabio Estevam \n\nAcked-by: Kishon Vijay Abraham I \n> ---\n> drivers/pci/dwc/pci-dra7xx.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c\n> index e0dd98d..1e2aaed 100644\n> --- a/drivers/pci/dwc/pci-dra7xx.c\n> +++ b/drivers/pci/dwc/pci-dra7xx.c\n> @@ -450,7 +450,7 @@ static int __init dra7xx_add_pcie_port(struct dra7xx_pcie *dra7xx,\n> \tpp->irq = platform_get_irq(pdev, 1);\n> \tif (pp->irq < 0) {\n> \t\tdev_err(dev, \"missing IRQ resource\\n\");\n> -\t\treturn -EINVAL;\n> +\t\treturn pp->irq;\n> \t}\n> \n> \tret = devm_request_irq(dev, pp->irq, dra7xx_pcie_msi_irq_handler,\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=ti.com header.i=@ti.com header.b=\"mBq97a4X\";\n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xk8qB1lmRz9s83\n\tfor ;\n\tFri, 1 Sep 2017 16:44:22 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751413AbdIAGoT (ORCPT );\n\tFri, 1 Sep 2017 02:44:19 -0400","from fllnx209.ext.ti.com ([198.47.19.16]:53540 \"EHLO\n\tfllnx209.ext.ti.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751022AbdIAGoS (ORCPT\n\t); Fri, 1 Sep 2017 02:44:18 -0400","from dflxv15.itg.ti.com ([128.247.5.124])\n\tby fllnx209.ext.ti.com (8.15.1/8.15.1) with ESMTP id v816hhV5003701; \n\tFri, 1 Sep 2017 01:43:43 -0500","from DLEE104.ent.ti.com (dlee104.ent.ti.com [157.170.170.34])\n\tby dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id v816hcJ8013025;\n\tFri, 1 Sep 2017 01:43:38 -0500","from DLEE111.ent.ti.com (157.170.170.22) by DLEE104.ent.ti.com\n\t(157.170.170.34) with Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.845.34;\n\tFri, 1 Sep 2017 01:43:37 -0500","from dflp33.itg.ti.com (10.64.6.16) by DLEE111.ent.ti.com\n\t(157.170.170.22) with Microsoft SMTP Server (version=TLS1_0,\n\tcipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.845.34 via Frontend\n\tTransport; Fri, 1 Sep 2017 01:43:37 -0500","from [172.24.190.233] (ileax41-snat.itg.ti.com [10.172.224.153])\n\tby dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id v816hYU0010399;\n\tFri, 1 Sep 2017 01:43:35 -0500"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com;\n\ts=ti-com-17Q1; t=1504248223;\n\tbh=uuBYT3dCVIksa+/JKqzlNdG0/ZNdJOj9hY3VPz8oX3g=;\n\th=Subject:To:References:CC:From:Date:In-Reply-To;\n\tb=mBq97a4XvWbh2+U31hmi0vDVVfgncKRHneYu5EAQTyjQYwt8o7RGVjoyfMtcRY8yw\n\tF4/hZAeBehm6OIbv4C04Us31dwelg884Mxb0dk1OCCzxjGPReakNgsF5dLVF5xpvNk\n\tSJs/hXG1e4zsaI31aeatMbMWMoeIjUQ6dppirZmQ=","Subject":"Re: [PATCH 02/10] PCI: dra7xx: Fix platform_get_irq() error handling","To":"Fabio Estevam , ","References":"<1504201930-3617-1-git-send-email-fabio.estevam@nxp.com>\n\t<1504201930-3617-2-git-send-email-fabio.estevam@nxp.com>","CC":"","From":"Kishon Vijay Abraham I ","Message-ID":"<640d0339-0263-4026-e16f-e4fbc68f1e7e@ti.com>","Date":"Fri, 1 Sep 2017 12:13:34 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tThunderbird/45.7.0","MIME-Version":"1.0","In-Reply-To":"<1504201930-3617-2-git-send-email-fabio.estevam@nxp.com>","Content-Type":"text/plain; charset=\"windows-1252\"","Content-Transfer-Encoding":"7bit","X-EXCLAIMER-MD-CONFIG":"e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180","Sender":"linux-pci-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pci@vger.kernel.org"}}]