[{"id":1762712,"web_url":"http://patchwork.ozlabs.org/comment/1762712/","msgid":"<5ab39f9a-fc8d-9e58-db7b-6ebb06151417@axis.com>","list_archive_url":null,"date":"2017-09-04T14:56:11","subject":"Re: [PATCH 04/10] PCI: artpec6: Fix platform_get_irq() error\n\thandling","submitter":{"id":65580,"url":"http://patchwork.ozlabs.org/api/people/65580/","name":"Niklas Cassel","email":"niklas.cassel@axis.com"},"content":"Acked-by: Niklas Cassel \n\nOn 08/31/2017 07:52 PM, Fabio Estevam wrote:\n> platform_get_irq() returns a negative number on failure, so\n> adjust the logic to detect such condition and propagate\n> the real error value on failure.\n> \n> Cc: Niklas Cassel \n> Signed-off-by: Fabio Estevam \n> ---\n> drivers/pci/dwc/pcie-artpec6.c | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/drivers/pci/dwc/pcie-artpec6.c b/drivers/pci/dwc/pcie-artpec6.c\n> index 5d81f1d..83d6ee0 100644\n> --- a/drivers/pci/dwc/pcie-artpec6.c\n> +++ b/drivers/pci/dwc/pcie-artpec6.c\n> @@ -209,9 +209,9 @@ static int artpec6_add_pcie_port(struct artpec6_pcie *artpec6_pcie,\n> \n> \tif (IS_ENABLED(CONFIG_PCI_MSI)) {\n> \t\tpp->msi_irq = platform_get_irq_byname(pdev, \"msi\");\n> -\t\tif (pp->msi_irq <= 0) {\n> +\t\tif (pp->msi_irq < 0) {\n> \t\t\tdev_err(dev, \"failed to get MSI irq\\n\");\n> -\t\t\treturn -ENODEV;\n> +\t\t\treturn pp->msi_irq;\n> \t\t}\n> \n> \t\tret = devm_request_irq(dev, pp->msi_irq,\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmCbW3lJkz9t2R\n\tfor ;\n\tTue, 5 Sep 2017 00:56:23 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753799AbdIDO4S (ORCPT );\n\tMon, 4 Sep 2017 10:56:18 -0400","from bastet.se.axis.com ([195.60.68.11]:56094 \"EHLO\n\tbastet.se.axis.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1753789AbdIDO4Q (ORCPT\n\t); Mon, 4 Sep 2017 10:56:16 -0400","from localhost (localhost [127.0.0.1])\n\tby bastet.se.axis.com (Postfix) with ESMTP id 45B9D1841E;\n\tMon, 4 Sep 2017 16:56:15 +0200 (CEST)","from bastet.se.axis.com ([IPv6:::ffff:127.0.0.1])\n\tby localhost (bastet.se.axis.com [::ffff:127.0.0.1]) (amavisd-new,\n\tport 10024)\n\twith LMTP id 2b93ybiLl209; Mon, 4 Sep 2017 16:56:13 +0200 (CEST)","from boulder02.se.axis.com (boulder02.se.axis.com [10.0.8.16])\n\tby bastet.se.axis.com (Postfix) with ESMTPS id E736C1841D;\n\tMon, 4 Sep 2017 16:56:12 +0200 (CEST)","from boulder02.se.axis.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id D21951A06F;\n\tMon, 4 Sep 2017 16:56:12 +0200 (CEST)","from boulder02.se.axis.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id C726F1A067;\n\tMon, 4 Sep 2017 16:56:12 +0200 (CEST)","from seth.se.axis.com (unknown [10.0.2.172])\n\tby boulder02.se.axis.com (Postfix) with ESMTP;\n\tMon, 4 Sep 2017 16:56:12 +0200 (CEST)","from XBOX02.axis.com (xbox02.axis.com [10.0.5.16])\n\tby seth.se.axis.com (Postfix) with ESMTP id BBA6D26D4;\n\tMon, 4 Sep 2017 16:56:12 +0200 (CEST)","from [10.88.4.10] (10.0.5.60) by XBOX02.axis.com (10.0.5.16) with\n\tMicrosoft SMTP Server (TLS) id 15.0.1263.5;\n\tMon, 4 Sep 2017 16:56:12 +0200"],"X-Virus-Scanned":"Debian amavisd-new at bastet.se.axis.com","Subject":"Re: [PATCH 04/10] PCI: artpec6: Fix platform_get_irq() error\n\thandling","To":"Fabio Estevam , ","CC":"","References":"<1504201930-3617-1-git-send-email-fabio.estevam@nxp.com>\n\t<1504201930-3617-4-git-send-email-fabio.estevam@nxp.com>","From":"Niklas Cassel ","Message-ID":"<5ab39f9a-fc8d-9e58-db7b-6ebb06151417@axis.com>","Date":"Mon, 4 Sep 2017 16:56:11 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1504201930-3617-4-git-send-email-fabio.estevam@nxp.com>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Originating-IP":"[10.0.5.60]","X-ClientProxiedBy":"XBOX02.axis.com (10.0.5.16) To XBOX02.axis.com (10.0.5.16)","X-TM-AS-GCONF":"00","Sender":"linux-pci-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pci@vger.kernel.org"}}]