[{"id":1761221,"web_url":"http://patchwork.ozlabs.org/comment/1761221/","msgid":"<20170831174617.GD1111@makrotopia.org>","list_archive_url":null,"date":"2017-08-31T17:46:17","subject":"Re: [LEDE-DEV] RFC [PATCH] odhcpd: don't enable server mode on dhcp\n\tlan","submitter":{"id":64091,"url":"http://patchwork.ozlabs.org/api/people/64091/","name":"Daniel Golle","email":"daniel@makrotopia.org"},"content":"Hi Karl,\n\nOn Thu, Aug 31, 2017 at 05:17:38PM +0000, Karl Palsson wrote:\n> Instead of blindly enabling the odhcpd v6 server and RA server on the\n> lan port, only do that if the lan port isn't set to DHCP.\n> \n> This prevents the unhelpful case of a device being a dhcpv4 client and\n> v6 server on the same ethernet port.\n\nGenerating UCI from presumingly already generated UCI has proven to be\na bad practise in the past. See inline for an alternative approach.\n\n> \n> Signed-off-by: Karl Palsson \n> -- \n> \n> Should other protocols be excluded? The list on https://lede-project.org/docs/user-guide/network_configuration\n> is rather long. Are there other modes worth considering?\n> \n> ---\n> package/network/services/odhcpd/files/odhcpd.defaults | 14 ++++++++++++--\n> 1 file changed, 12 insertions(+), 2 deletions(-)\n> \n> diff --git a/package/network/services/odhcpd/files/odhcpd.defaults b/package/network/services/odhcpd/files/odhcpd.defaults\n> index e184da90acbb..152e63dd18b6 100644\n> --- a/package/network/services/odhcpd/files/odhcpd.defaults\n> +++ b/package/network/services/odhcpd/files/odhcpd.defaults\n> @@ -2,13 +2,23 @@\n> uci -q get dhcp.odhcpd && exit 0\n> touch /etc/config/dhcp\n> \n> +LANPROTO=$(uci -q get network.lan.proto)\n\nImho it'd be nicer to read this via\n```\n. /usr/share/libubox/jshn.sh\n\njson_load \"$(cat /etc/board.json)\"\njson_select network\njson_select lan\njson_get_vars protocol\njson_select ..\njson_select ..\n```\n\n\n> +MODE=server\n> +\n> +case \"$LANPROTO\" in\n> +\"dhcp\")\n> +\techo \"odhcpd: Not enabling server mode on a dhcp lan!\" > /dev/kmsg\n> +\tMODE=disabled\n> +\t;;\n> +esac\n> +\n> uci batch < set dhcp.odhcpd=odhcpd\n> set dhcp.odhcpd.maindhcp=0\n> set dhcp.odhcpd.leasefile=/tmp/hosts/odhcpd\n> set dhcp.odhcpd.leasetrigger=/usr/sbin/odhcpd-update\n> set dhcp.odhcpd.loglevel=4\n> -set dhcp.lan.dhcpv6=server\n> -set dhcp.lan.ra=server\n> +set dhcp.lan.dhcpv6=$MODE\n> +set dhcp.lan.ra=$MODE\n> commit dhcp\n> EOF\n> -- \n> 2.4.11\n> \n> \n> _______________________________________________\n> Lede-dev mailing list\n> Lede-dev@lists.infradead.org\n> http://lists.infradead.org/mailman/listinfo/lede-dev","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"eR/bpXhJ\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjqZQ6gDMz9s7c\n\tfor ;\n\tFri, 1 Sep 2017 03:47:10 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dnTYR-0004id-9F; Thu, 31 Aug 2017 17:46:59 +0000","from fudo.makrotopia.org ([2a07:2ec0:3002::71])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dnTYC-0004Oe-Jd\n\tfor lede-dev@lists.infradead.org; Thu, 31 Aug 2017 17:46:54 +0000","from local by fudo.makrotopia.org with esmtpsa\n\t(TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256)\n\t(Exim 4.88) (envelope-from )\n\tid 1dnTXn-0004Ok-67; Thu, 31 Aug 2017 19:46:19 +0200"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:Subject:In-Reply-To:MIME-Version:\n\tReferences:Message-ID:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=AMJf8xZxVrrK9Jj/IZhXJVEIe2JZRlN42xBB1ZzHK0s=;\n\tb=eR/bpXhJM4ydzr\n\tqkUzq7aWKO2jOF7vPCnNKrszp+iI2jXpqc0E2qByDMO552dqperYVNPMwi6o12Toq93Cdtsy1qX7q\n\tSJyD9krUd/4WxJrD+wIsuMCBn3Pk6LUU/K8nGe0zAoOKyY4MWjqqdKdewVP4tD3ObSG8VTpa3pkA9\n\tGVW/7ICMQv20qQaGRSWg/LWXMrthWlyXbXfj53SlR9XYU7x94Oj5nuAjqEcM2gqS6/RgBKBy5VpEh\n\tpR7aFJEC+ItS4rAIuadX/+5fWIdMEqSQ0BUTzOs0qn03IEEoJ6cRmjaA7Wq/MoMg15S23G7bWn8lZ\n\tRG6vBj+FRNHh1aZBwj1w==;","Date":"Thu, 31 Aug 2017 19:46:17 +0200","From":"Daniel Golle ","To":"Karl Palsson ","Message-ID":"<20170831174617.GD1111@makrotopia.org>","References":"<1504199858-7889-1-git-send-email-karlp@etactica.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<1504199858-7889-1-git-send-email-karlp@etactica.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170831_104645_627919_4C5959CE ","X-CRM114-Status":"GOOD ( 12.70 )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","Subject":"Re: [LEDE-DEV] RFC [PATCH] odhcpd: don't enable server mode on dhcp\n\tlan","X-BeenThere":"lede-dev@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"lede-dev@lists.infradead.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"Lede-dev\" ","Errors-To":"lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":1761329,"web_url":"http://patchwork.ozlabs.org/comment/1761329/","msgid":"","list_archive_url":null,"date":"2017-08-31T21:35:55","subject":"Re: [LEDE-DEV] RFC [PATCH] odhcpd: don't enable server mode on dhcp\n\tlan","submitter":{"id":65315,"url":"http://patchwork.ozlabs.org/api/people/65315/","name":"Karl Palsson","email":"karlp@tweak.net.au"},"content":"Daniel Golle wrote:\n> Hi Karl,\n> \n> On Thu, Aug 31, 2017 at 05:17:38PM +0000, Karl Palsson wrote:\n> > Instead of blindly enabling the odhcpd v6 server and RA server on the\n> > lan port, only do that if the lan port isn't set to DHCP.\n> > \n> > This prevents the unhelpful case of a device being a dhcpv4 client and\n> > v6 server on the same ethernet port.\n> \n> Generating UCI from presumingly already generated UCI has\n> proven to be a bad practise in the past. See inline for an\n> alternative approach.\n\nCool with me, the json_load approach is..... kinda opaque still\nat the moment, but if that's the future and meant to be magically\nmore stable, awesome. (This file was _already_ looking at \"uci -q\nget dhcp.odhcpd\" not using any json loading, so... I just\nfollowed the course)\n\nBut the general concept? Is that ok? That's more interesting to\nme :)\n\nSincerely,\nKarl Palsson\n\n> > uci -q get dhcp.odhcpd && exit 0\n> > touch /etc/config/dhcp\n> > \n> > +LANPROTO=$(uci -q get network.lan.proto)\n> \n> Imho it'd be nicer to read this via\n> ```\n> . /usr/share/libubox/jshn.sh\n> \n> json_load \"$(cat /etc/board.json)\"\n> json_select network\n> json_select lan\n> json_get_vars protocol\n> json_select ..\n> json_select ..\n> ```\n> \n> \n> > +MODE=server\n> > +\n> > +case \"$LANPROTO\" in\n> > +\"dhcp\")\n> > +\techo \"odhcpd: Not enabling server mode on a dhcp lan!\" > /dev/kmsg\n> > +\tMODE=disabled\n> > +\t;;\n> > +esac\n> > +\n> > uci batch < > set dhcp.odhcpd=odhcpd\n> > set dhcp.odhcpd.maindhcp=0\n> > set dhcp.odhcpd.leasefile=/tmp/hosts/odhcpd\n> > set dhcp.odhcpd.leasetrigger=/usr/sbin/odhcpd-update\n> > set dhcp.odhcpd.loglevel=4\n> > -set dhcp.lan.dhcpv6=server\n> > -set dhcp.lan.ra=server\n> > +set dhcp.lan.dhcpv6=$MODE\n> > +set dhcp.lan.ra=$MODE\n> > commit dhcp\n> > EOF\n> > -- \n> > 2.4.11\n> > \n> > \n> > _______________________________________________\n> > Lede-dev mailing list\n> > Lede-dev@lists.infradead.org\n> > http://lists.infradead.org/mailman/listinfo/lede-dev\n> \n> _______________________________________________\n> Lede-dev mailing list\n> Lede-dev@lists.infradead.org\n> http://lists.infradead.org/mailman/listinfo/lede-dev","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"FQ9u0SF3\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjwh96CQGz9s81\n\tfor ;\n\tFri, 1 Sep 2017 07:37:29 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dnX9K-00080l-Dw; Thu, 31 Aug 2017 21:37:18 +0000","from palmtree.beeroclock.net ([178.79.160.154])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dnX9G-0007wl-3e\n\tfor lede-dev@lists.infradead.org; Thu, 31 Aug 2017 21:37:16 +0000","from mailpile.local (palmtree.beeroclock.net\n\t[IPv6:2a01:7e00::f03c:91ff:fe93:f66c])\n\t(using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))\n\t(No client certificate requested) (Authenticated sender: karlp)\n\tby palmtree.beeroclock.net (Postfix) with ESMTPSA id 894FA10180;\n\tThu, 31 Aug 2017 21:36:17 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc:\n\tList-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:\n\tSubject:Date:Message-Id:References:In-Reply-To:To:From:MIME-Version:Reply-To:\n\tContent-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=cib/+PJ/QKRB0wSDPHWLHUwPge9YllLlrazaH6NYNZw=;\n\tb=FQ9u0SF3+mhRe+waspAkkcgHD\n\t7aW4pj6DAPB0FMXQU/i48x+lhbqLBoE0aWRMUmqw3YtZHa2rTyy6YTpmei6eI7wxbBCgQcnnh7Efe\n\tIrrm3qhdKv7MfriLnMQQY/VaIHzrUsVjnwjxlLlUHL6HPhiMX9TrbzeQbLoVQZgrGlhxsa9yN/ZI7\n\tE75KDUOT3aKDNt5LaX22UFf6/o0/Pci3ck5xs7f87rWydyFjevQXA4HzkHMylZ4wQQd+b+KYt3868\n\tgoD/Drr71PZKGsRdEcygKuitPayA9HVuqw5ZIUr4WbdmAwrYjdzGWhzmlY3k4K26GXFGjh365fNC8\n\tB9AsJD38g==;","MIME-Version":"1.0","From":"Karl Palsson ","To":"\"Daniel Golle\" ","In-Reply-To":"<20170831174617.GD1111@makrotopia.org>","References":"<20170831174617.GD1111@makrotopia.org>","User-Agent":"Mailpile","Message-Id":"","Date":"Thu, 31 Aug 2017 21:35:55 -0000","OpenPGP":"id=9F020B9C40DA5E6F2CAF63B319A8B50FD4D5CAF6; preference=signencrypt","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170831_143714_484807_22E4D67F ","X-CRM114-Status":"GOOD ( 15.24 )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t0.0 T_HTML_ATTACH HTML attachment to bypass scanning?","Subject":"Re: [LEDE-DEV] RFC [PATCH] odhcpd: don't enable server mode on dhcp\n\tlan","X-BeenThere":"lede-dev@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"lede-dev@lists.infradead.org, Karl Palsson ","Content-Type":"multipart/mixed;\n\tboundary=\"===============4274699026206408255==\"","Sender":"\"Lede-dev\" ","Errors-To":"lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":1761480,"web_url":"http://patchwork.ozlabs.org/comment/1761480/","msgid":"<4e1eadcf-af97-e76a-4eb6-a3c63d3bee1e@createc.ro>","list_archive_url":null,"date":"2017-09-01T06:10:28","subject":"Re: [LEDE-DEV] RFC [PATCH] odhcpd: don't enable server mode on dhcp\n\tlan","submitter":{"id":67579,"url":"http://patchwork.ozlabs.org/api/people/67579/","name":"Lucian Cristian","email":"luci@createc.ro"},"content":"On 01.09.2017 00:35, Karl Palsson wrote:\n> Daniel Golle wrote:\n>> Hi Karl,\n>>\n>> On Thu, Aug 31, 2017 at 05:17:38PM +0000, Karl Palsson wrote:\n>>> Instead of blindly enabling the odhcpd v6 server and RA server on the\n>>> lan port, only do that if the lan port isn't set to DHCP.\n>>>\n>>> This prevents the unhelpful case of a device being a dhcpv4 client and\n>>> v6 server on the same ethernet port.\n>> Generating UCI from presumingly already generated UCI has\n>> proven to be a bad practise in the past. See inline for an\n>> alternative approach.\n> Cool with me, the json_load approach is..... kinda opaque still\n> at the moment, but if that's the future and meant to be magically\n> more stable, awesome. (This file was _already_ looking at \"uci -q\n> get dhcp.odhcpd\" not using any json loading, so... I just\n> followed the course)\n>\n> But the general concept? Is that ok? That's more interesting to\n> me :)\n>\n> Sincerely,\n> Karl Palsson\n>\n>>> uci -q get dhcp.odhcpd && exit 0\n>>> touch /etc/config/dhcp\n>>> \n>>> +LANPROTO=$(uci -q get network.lan.proto)\n>> Imho it'd be nicer to read this via\n>> ```\n>> . /usr/share/libubox/jshn.sh\n>>\n>> json_load \"$(cat /etc/board.json)\"\n>> json_select network\n>> json_select lan\n>> json_get_vars protocol\n>> json_select ..\n>> json_select ..\n>> ```\n>>\n>>\n>>> +MODE=server\n>>> +\n>>> +case \"$LANPROTO\" in\n>>> +\"dhcp\")\n>>> +\techo \"odhcpd: Not enabling server mode on a dhcp lan!\" > /dev/kmsg\n>>> +\tMODE=disabled\n>>> +\t;;\n>>> +esac\n>>> +\n>>> uci batch <>> set dhcp.odhcpd=odhcpd\n>>> set dhcp.odhcpd.maindhcp=0\n>>> set dhcp.odhcpd.leasefile=/tmp/hosts/odhcpd\n>>> set dhcp.odhcpd.leasetrigger=/usr/sbin/odhcpd-update\n>>> set dhcp.odhcpd.loglevel=4\n>>> -set dhcp.lan.dhcpv6=server\n>>> -set dhcp.lan.ra=server\n>>> +set dhcp.lan.dhcpv6=$MODE\n>>> +set dhcp.lan.ra=$MODE\n>>> commit dhcp\n>>> EOF\n>>> -- \n>>> 2.4.11\n>>>\n>>>\n>>> _______________________________________________\n>>> Lede-dev mailing list\n>>> Lede-dev@lists.infradead.org\n>>> http://lists.infradead.org/mailman/listinfo/lede-dev\n>> _______________________________________________\n>> Lede-dev mailing list\n>> Lede-dev@lists.infradead.org\n>> http://lists.infradead.org/mailman/listinfo/lede-dev\n>>\n>>\n>> _______________________________________________\n>> Lede-dev mailing list\n>> Lede-dev@lists.infradead.org\n>> http://lists.infradead.org/mailman/listinfo/lede-dev\n\nI personally would like something like that because there are times when \nI forget to disable the server mode and it may confuse the users","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"fwR5RCDu\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xk8572mKxz9s8J\n\tfor ;\n\tFri, 1 Sep 2017 16:11:23 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dnfAd-000230-Qc; Fri, 01 Sep 2017 06:11:11 +0000","from mail.crimel.ro ([5.2.196.145])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dnfAZ-0001yi-2j\n\tfor lede-dev@lists.infradead.org; Fri, 01 Sep 2017 06:11:09 +0000","(qmail 20539 invoked by uid 89); 1 Sep 2017 06:10:39 -0000","by simscan 1.4.0 ppid: 20530, pid: 20533, t: 12.0940s\n\tscanners: attach: 1.4.0 clamav: 0.99.2/m:58/d:23750","from unknown (HELO ?192.168.123.118?)\n\t(root@crimel.ro@188.24.96.108)\n\tby mail-01.crimel.ro with ESMTPA; 1 Sep 2017 06:10:27 -0000"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:\n\tContent-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive:\n\tList-Unsubscribe:List-Id:Subject:In-Reply-To:MIME-Version:Date:Message-ID:\n\tFrom:References:To:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=nmomgyxsuHUMrmpXx45I5Y93XDiyPt7seGGEI4DW/+M=;\n\tb=fwR5RCDuz5Sx7YlYcNLQYqjjP\n\tFC1S7sMYCxiFhajITG35k9p6BqifncFx0zBET3TaH1JJHlXHZqUZjiYwHf8EXEHcfEvvoBXarRy5U\n\te4LRkS1WcGpEYomIRwjD2vZOVmVrS4cyPk2KH2QDb7xgUPm5uj+I4d/a4OL+GByxpraqaKDn6TGPo\n\t0b/UHeRIHvONq8BnKlHLiIL3g18W/hWunxc1mqPaPy2sCptcxuB1aRuVmJvOpbmEWqB3tI5vFUznX\n\tU77VLxqTIlkfxkaDJwj6mtm26qopXpSgBydqrFQkTqZ1QX/lOytOJLnt4CTgvtRW3yGVeeTOl5vLe\n\tavA7sqtmg==;","To":"lede-dev@lists.infradead.org","References":"<20170831174617.GD1111@makrotopia.org>\n\t","From":"Lucian Cristian ","Message-ID":"<4e1eadcf-af97-e76a-4eb6-a3c63d3bee1e@createc.ro>","Date":"Fri, 1 Sep 2017 09:10:28 +0300","User-Agent":"Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-US","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170831_231107_486204_4C53CAF9 ","X-CRM114-Status":"UNSURE ( 6.53 )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","Subject":"Re: [LEDE-DEV] RFC [PATCH] odhcpd: don't enable server mode on dhcp\n\tlan","X-BeenThere":"lede-dev@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Sender":"\"Lede-dev\" ","Errors-To":"lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":1761505,"web_url":"http://patchwork.ozlabs.org/comment/1761505/","msgid":"","list_archive_url":null,"date":"2017-09-01T07:45:45","subject":"Re: [LEDE-DEV] RFC [PATCH] odhcpd: don't enable server mode on dhcp\n\tlan","submitter":{"id":65331,"url":"http://patchwork.ozlabs.org/api/people/65331/","name":"Hans Dedecker","email":"dedeckeh@gmail.com"},"content":"On Thu, Aug 31, 2017 at 11:35 PM, Karl Palsson wrote:\n>\n> Daniel Golle wrote:\n>> Hi Karl,\n>>\n>> On Thu, Aug 31, 2017 at 05:17:38PM +0000, Karl Palsson wrote:\n>> > Instead of blindly enabling the odhcpd v6 server and RA server on the\n>> > lan port, only do that if the lan port isn't set to DHCP.\n>> >\n>> > This prevents the unhelpful case of a device being a dhcpv4 client and\n>> > v6 server on the same ethernet port.\n>>\n>> Generating UCI from presumingly already generated UCI has\n>> proven to be a bad practise in the past. See inline for an\n>> alternative approach.\n>\n> Cool with me, the json_load approach is..... kinda opaque still\n> at the moment, but if that's the future and meant to be magically\n> more stable, awesome. (This file was _already_ looking at \"uci -q\n> get dhcp.odhcpd\" not using any json loading, so... I just\n> followed the course)\n>\n> But the general concept? Is that ok? That's more interesting to\n> me :)\nI like the idea\nI wonder if enabling DHCPv6 and RA as server on interfaces having a\nnon static protocol is usefull; so can we just check for the protocol\nbeing static to enable DHCPv6 and RA as server ?\n\nHans\n>\n> Sincerely,\n> Karl Palsson\n>\n>> > uci -q get dhcp.odhcpd && exit 0\n>> > touch /etc/config/dhcp\n>> >\n>> > +LANPROTO=$(uci -q get network.lan.proto)\n>>\n>> Imho it'd be nicer to read this via\n>> ```\n>> . /usr/share/libubox/jshn.sh\n>>\n>> json_load \"$(cat /etc/board.json)\"\n>> json_select network\n>> json_select lan\n>> json_get_vars protocol\n>> json_select ..\n>> json_select ..\n>> ```\n>>\n>>\n>> > +MODE=server\n>> > +\n>> > +case \"$LANPROTO\" in\n>> > +\"dhcp\")\n>> > + echo \"odhcpd: Not enabling server mode on a dhcp lan!\" > /dev/kmsg\n>> > + MODE=disabled\n>> > + ;;\n>> > +esac\n>> > +\n>> > uci batch <> > set dhcp.odhcpd=odhcpd\n>> > set dhcp.odhcpd.maindhcp=0\n>> > set dhcp.odhcpd.leasefile=/tmp/hosts/odhcpd\n>> > set dhcp.odhcpd.leasetrigger=/usr/sbin/odhcpd-update\n>> > set dhcp.odhcpd.loglevel=4\n>> > -set dhcp.lan.dhcpv6=server\n>> > -set dhcp.lan.ra=server\n>> > +set dhcp.lan.dhcpv6=$MODE\n>> > +set dhcp.lan.ra=$MODE\n>> > commit dhcp\n>> > EOF\n>> > --\n>> > 2.4.11\n>> >\n>> >\n>> > _______________________________________________\n>> > Lede-dev mailing list\n>> > Lede-dev@lists.infradead.org\n>> > http://lists.infradead.org/mailman/listinfo/lede-dev\n>>\n>> _______________________________________________\n>> Lede-dev mailing list\n>> Lede-dev@lists.infradead.org\n>> http://lists.infradead.org/mailman/listinfo/lede-dev\n>\n> _______________________________________________\n> Lede-dev mailing list\n> Lede-dev@lists.infradead.org\n> http://lists.infradead.org/mailman/listinfo/lede-dev\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"YOHNg8yX\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"K5FXcAbI\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkBBr66SWz9s83\n\tfor ;\n\tFri, 1 Sep 2017 17:46:28 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dngea-0005mW-49; Fri, 01 Sep 2017 07:46:12 +0000","from mail-pg0-x231.google.com ([2607:f8b0:400e:c05::231])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dngeW-0005k4-0H\n\tfor lede-dev@lists.infradead.org; Fri, 01 Sep 2017 07:46:10 +0000","by mail-pg0-x231.google.com with SMTP id 63so6028290pgc.2\n\tfor ;\n\tFri, 01 Sep 2017 00:45:46 -0700 (PDT)","by 10.100.154.66 with HTTP; Fri, 1 Sep 2017 00:45:45 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:Subject:To:Message-ID:Date:From:\n\tReferences:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=jGwedcm3wKNTQfqrxv1VGw6/p0V4eGkKdstYg85zQK8=;\n\tb=YOHNg8yXqH/r9p\n\t5cFfgPFmrVBUvLA/oiF9P2M+SDK7sXsI8pG9KJebXoxCunjk1XZtSy88PHTuEa8dykIY/suAPI8y4\n\taYdaRddTx5WrsU6cnKnjPK2Goz9qNOyzx7A85HY4OiiQ6HWI+vWzxkiShU/QMslDggRvSsnJY4hFC\n\tBud9aWyR1khG6SVmbQH231ihZRubSHzMg8kfPXVFLqN/+iYzkIXzGrmfq3IVAAMAxeJphc1OWb5zK\n\t1Tu9eUFTrc4HFhIK2eK86PMHhKHcdZAVBvGR8zR9/e9qNE3Zk6wm+BqHP0Nk9vAronbyHacQ+G0+l\n\tQ5SVYg7LcWy2sNlot7Yg==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=sANUFBTKWgMhoThgT3VSB9ncr+fobdV57incdOFQqZc=;\n\tb=K5FXcAbIlMN6aGM14+TJFdkbusY/TZbnSm03iHcV1u1vH/uvxfUfKSse+fAH3qpNjs\n\tOFutjFDQ9oKka8hNS1JPE/sNeo0p69qFIMJUAnPd2u5nwMzFfOQO1eVc5KMyLEEdQVLH\n\t+2LfSa4HgkPokByONnwh+AHAQQ9mNQ1IQZXgl7SZ645WVgi9bBseN4N7K6GNhcl5SlCa\n\txDIoTBKjxYKfpjQ5x2FSIpG2qdiCZ6IXhqZyx0R54NsdpVAcWZUa/9ZIrVpEL/aZ9AA8\n\tKAln+wf5mMrUlmWLVLHkrTVR2CXmLksUJtckSd1eG/BnzDKpsx138sE8b8Av5gs+HLBh\n\tvLCA=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=sANUFBTKWgMhoThgT3VSB9ncr+fobdV57incdOFQqZc=;\n\tb=PP2cWmfB6tWWE1BKvjXBxkXoh8MTd00Toi3LImOljXqy7H0+2kZKx0XCMLbcIFs6+V\n\tk8zZbYmdqbAuJFbqaroZ8Lq4lBL5GZe9uzvlkMFvUR641SoyDYoLepyVpYd1n8lk/P7w\n\tGHi72DqoXAZUqx2B2gEh6qEvbQwp8SL8pl9ATUgnql7QEUDRK4R+2IhVkCluDxj5CKgf\n\tkSZhAru/uWBu9GBj80u9i+m5hx5cnq7Yl4HstrbNyWNjCYYVKpf8kFyKeu1nVSYVPjSq\n\trUZhS8mIj2gzRyQfNNaqYrhofjeinjo1qWv3gE+WeDcKfjJQc+IQl5Nl3GwBnp0n7Bwb\n\tePNQ==","X-Gm-Message-State":"AHPjjUgxcdgAfB/idM16MIt6ByTDjIBrCHrRS1enjiQuhhs8QVysXJIe\n\tuXPBKVlPUuCAOgaQyaw/TF0mXcAJtg==","X-Google-Smtp-Source":"ADKCNb71P/EFJsy9rPKXfo4UqR3SY6s/WqPzpZzemlKtD/z38MVfLldNpW70s9CEaS0aBgBBx9uJXFTqe0eIF1itaQY=","X-Received":"by 10.84.241.1 with SMTP id a1mr1357221pll.425.1504251946056;\n\tFri, 01 Sep 2017 00:45:46 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<20170831174617.GD1111@makrotopia.org>\n\t","From":"Hans Dedecker ","Date":"Fri, 1 Sep 2017 09:45:45 +0200","Message-ID":"","To":"Karl Palsson ","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170901_004608_076785_298DE3A2 ","X-CRM114-Status":"GOOD ( 13.54 )","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2607:f8b0:400e:c05:0:0:0:231 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (dedeckeh[at]gmail.com)\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","Subject":"Re: [LEDE-DEV] RFC [PATCH] odhcpd: don't enable server mode on dhcp\n\tlan","X-BeenThere":"lede-dev@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"LEDE Development List ,\n\tDaniel Golle , Karl Palsson ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"Lede-dev\" ","Errors-To":"lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}}]