[{"id":1762223,"web_url":"http://patchwork.ozlabs.org/comment/1762223/","msgid":"","list_archive_url":null,"date":"2017-09-03T07:28:04","subject":"Re: [PATCH][next] net/mlx4_core: fix incorrect size allocation for\n\tdev->caps.spec_qps","submitter":{"id":68926,"url":"http://patchwork.ozlabs.org/api/people/68926/","name":"Tariq Toukan","email":"tariqt@mellanox.com"},"content":"On 31/08/2017 8:07 PM, Colin King wrote:\n> From: Colin Ian King \n> \n> The current allocation for dev->caps.spec_qps is for the size of the\n> pointer and not the size of the actual mlx4_spec_qps structure. Fix\n> this by using the correct size. Also splint allocation over a few\n> lines to make it cppcheck clean on overly wide lines.\n> \n> Detected by CoverityScan, CID#1455222 (\"Wrong sizeof argument\")\n> \n> Fixes: c73c8b1e47ca (\"net/mlx4_core: Dynamically allocate structs at mlx4_slave_cap\")\n> Signed-off-by: Colin Ian King \n> ---\n> drivers/net/ethernet/mellanox/mlx4/qp.c | 5 +++--\n> 1 file changed, 3 insertions(+), 2 deletions(-)\n> \n> diff --git a/drivers/net/ethernet/mellanox/mlx4/qp.c b/drivers/net/ethernet/mellanox/mlx4/qp.c\n> index b16fc441609e..728a2fb1f5c0 100644\n> --- a/drivers/net/ethernet/mellanox/mlx4/qp.c\n> +++ b/drivers/net/ethernet/mellanox/mlx4/qp.c\n> @@ -845,8 +845,9 @@ int mlx4_init_qp_table(struct mlx4_dev *dev)\n> \n> \t\t/* In mfunc, calculate proxy and tunnel qp offsets for the PF here,\n> \t\t * since the PF does not call mlx4_slave_caps */\n> -\t\tdev->caps.spec_qps = kcalloc(dev->caps.num_ports, sizeof(dev->caps.spec_qps), GFP_KERNEL);\n> -\n> +\t\tdev->caps.spec_qps = kcalloc(dev->caps.num_ports,\n> +\t\t\t\t\t sizeof(*dev->caps.spec_qps),\n> +\t\t\t\t\t GFP_KERNEL);\n> \t\tif (!dev->caps.spec_qps) {\n> \t\t\terr = -ENOMEM;\n> \t\t\tgoto err_mem;\n> \n\nAcked-by: Tariq Toukan \n\nThanks!","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=Mellanox.com header.i=@Mellanox.com\n\theader.b=\"P/6c1UBO\"; dkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=tariqt@mellanox.com; "],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xlPjN2Xm0z9rxl\n\tfor ;\n\tSun, 3 Sep 2017 17:28:40 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751517AbdICH2R (ORCPT );\n\tSun, 3 Sep 2017 03:28:17 -0400","from mail-eopbgr40072.outbound.protection.outlook.com\n\t([40.107.4.72]:5201\n\t\"EHLO EUR03-DB5-obe.outbound.protection.outlook.com\"\n\trhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP\n\tid S1751119AbdICH2O (ORCPT );\n\tSun, 3 Sep 2017 03:28:14 -0400","from [10.8.2.253] (193.47.165.251) by\n\tHE1PR05MB1801.eurprd05.prod.outlook.com (2a01:111:e400:7a28::15) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.13.10;\n\tSun, 3 Sep 2017 07:28:08 +0000"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n\ts=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=M+3zluQj0ng7wDugwqhS/7D0VW8EwAadp4RmCoukcSg=;\n\tb=P/6c1UBOR/DG4gX3UCZzKuVxv+hJdgvesFChFxWMwHiq41HbQIs0w8+QXXZwIcHIQSTQmjmj7v+4bkGarQLGv7Le6pRIiLEToNgwRqO66kSnK412IKOKf2vNYoFVBc/QXGCSQJMaXZLfAchmOnfOk95YLwjF0Myz4lJRyv7imUo=","Subject":"Re: [PATCH][next] net/mlx4_core: fix incorrect size allocation for\n\tdev->caps.spec_qps","To":"Colin King ,\n\tTariq Toukan , netdev@vger.kernel.org,\n\tlinux-rdma@vger.kernel.org","Cc":"kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org","References":"<20170831170724.3747-1-colin.king@canonical.com>","From":"Tariq Toukan ","Message-ID":"","Date":"Sun, 3 Sep 2017 10:28:04 +0300","User-Agent":"Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170831170724.3747-1-colin.king@canonical.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Originating-IP":"[193.47.165.251]","X-ClientProxiedBy":"DB6PR0801CA0045.eurprd08.prod.outlook.com\n\t(2603:10a6:4:2b::13) To HE1PR05MB1801.eurprd05.prod.outlook.com\n\t(2a01:111:e400:7a28::15)","X-MS-PublicTrafficType":"Email","X-MS-Office365-Filtering-Correlation-Id":"f37804f6-f6a7-4b20-2b05-08d4f29d53a9","X-MS-Office365-Filtering-HT":"Tenant","X-Microsoft-Antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(48565401081)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:HE1PR05MB1801; ","X-Microsoft-Exchange-Diagnostics":["1; HE1PR05MB1801;\n\t3:/iPFnMrcUjFUhfOQ/kTQGGwZhHdXfuZq1+VvCEkXkf37WndmnMXV1YXD+3+0S6N4/9fTWgba5DZHBYyZz7eGQ+hoT9WJlXuW6ywv+p3llAjKWTm53l/c7JUXKERnjrtmvXcbK43Edgkfr2Sj8x8U0dujBzWCulmLPdC2sRMdtrbxBU1L5GD/X5HyA0xmIiYvt9YBRHObxLBT10zEXvnLSGJtZgRh/50hS3iDEPzQ4rum7pFPSX0Dutt4x/8vwLdm;\n\t25:GZYwVqJOQw/irrHQjRy7OzfqswYJT2+WQ++yyfwFMutE7aQdSsLUz+pRSrANK0mIyGmIT5U7xQzmqfSu0EgiXIuMl4e8bbhWz68Z7b4ZmcosWBnwBD5hvdIgsieP9L3gMbFexFiym2Q8R+ukX3hSDYWYNDd5IDXVVO3IeGv9adDDdZ8O/FSSaSpiUf/zXwjGfFQCdTsY+84pXc51tAq2k8IONY136ZZiiaP9GhZMBlifJ7z+Cbgl9zYbY8nWUwLGmtV+j5FYwecM9c2izmth4XYe/7Ju0RZnR2vAuSRuTwiFebfTIIz2fV+ykUcgBH70JabQF4NA8sCuJ0fN856sUw==;\n\t31:WQ9pD2/hnXpJCZCnASi1x+8E4+u+TlrJ4yeDy52tzzovpDLDvYUxY86Du9t5ulT3rzkV+AnEGtFH4kyh/DDueo0PYcmeYvWFza2JzM45uSkg7KEXIZ0MrAGCEzORFjXUHQYGD7ryMJERfpOqUYeCOL8bhhlnyLxAm3GLcPlIn4T2aO1XI2f1/EtNk5CcwY4wmpdwty369/KUMTjfc4PcB/Bl2Hf7nY3HobJBgrkBmy0=","1; HE1PR05MB1801;\n\t20:WKpITTTflikXTLrrmKPCtGaEoDqZZ+VJrixAx0QCzpLSrWLXbzvuqUAHw2azfOYedvS5f/tID4sSW5ug4BCWdjclLH4fll6TgU277420dVvARHAJN+OgMU4AGmREuQNaE2b/WzbBUXSoezmz9NxjH1muIlLFf7fmFJ5vkOhgbMhsAvXcszGroxw/ROrGGhYAc7w9d2mbYMr+ymuTbyLazvroCS869Bsk37veiiCStBnpTXCJm79gWwj0BRS9Msz8uPuU36QCdIAffmPgO9YJzoC/qKefXqjoANlCrqp00bAa71efqYiw2y/UmZ1yo59tnoWBIhwEEqwYHyHMPubwR3gwjUTQgc7rXDMFVXjwkqOOjOB78sAUiX9hrEVJXmiyvkhCeKcEb7QKsj8ExuXjkSgUiWgkgA059CYbqAJK+ELWNYr/QoAydCkVEgEMlWSe8BzzlBAVarNHTYdVLRUgpJMte82Ve21gAiMXc1foiEYorMQplBpT/n3n+1scdQIJ;\n\t4:CTiJ/rVetM2R15a7draxMW5PzKLHep2hrhHr0mFfhTBXubM7PHF65byYgE5KNy8YZO2NWA2PFYVYTaconlHLMPJzzT+p5DEJkLDzmHoKVvjMCI99TwEOYaGZ6wzbLFnIolyWOD9V3nJW5UvpuV94Auk4xqbOK+/UvoCAKn2forJEnBGIrrk2eAu+Phg1dM7ys3/YOzF05Rv0oaNPfdIRyiU4/r3w1iOokM3NV4AClhgH9yPYNQOg0ET91fxLuKxUCPPWjq+bQ97h52aP3sTjwFyKtO0jBS9Kw6z/ljPa/dw=","=?utf-8?q?1=3BHE1PR05MB1801=3B23=3A3dis?=\n\t=?utf-8?q?rVBuORTSvTwwANwY9CRZpNvKSHNuWbDzVO8Q5Ojys1qZVpl1HxUI/AsW?=\n\t=?utf-8?q?J2lvrwHXQ0qUiAaCGeAN5hUpMIYKjfZhtysMgboV9SYV58HC09hEV7ki?=\n\t=?utf-8?q?Ud3P5e0yfsLB7fWcHjv1XbF6LrCn3xlzcfvEGq0RfJf5AMHrjENqimRZ?=\n\t=?utf-8?q?D8Nd2YSbEl4T1E9Ygg2xb0XYrWVGdAmj5KPyH5EminGol7Anlra0e2Ra?=\n\t=?utf-8?q?BO6+xwTgsU9D3fCFK/t9SylfcUZBD3wLUYhzA+HKH+RgZ+yZZcKNgCjH?=\n\t=?utf-8?q?gjbAvFzx8DjWEGzomh0VJdiimsFBXl2fkHLkm2trkGBi81374D5KrzB0?=\n\t=?utf-8?q?ttrQXNCDfOiS0jkuFjFzgal0BnATQymRWnnEk5KJ78R+PFL8CoRV5eeb?=\n\t=?utf-8?q?cQSS2lxU52SJNOqCZA9eljVES05c/zLaUuzOvdFWPk8wKFtBjihnbJD2?=\n\t=?utf-8?q?OfCzwbm/FupUCKrB9imLU4KUMqicPHaJc0ITvlQPFPxHmkfDkUOA/jXh?=\n\t=?utf-8?q?7EOjT3h5tHQZmKx/U1Z416Cah2ydfu8nANdibnKByWIHOjmVSRGQILn1?=\n\t=?utf-8?q?CyzXSWaQnuUb2qY8XifKCbn2oktX1zIMOnVvMET5Dk57BWmdBxW8FU/3?=\n\t=?utf-8?q?0RDsc/HOuqNtKzL+8BaIf8GuVs/5VHbGup+1+pr+lrGQjqxfi1WaD27w?=\n\t=?utf-8?q?OLkIY2RZgd4js13NvxBoexuP4sWg59GlQ6AE/RBWSn6eBkRnvcer78hm?=\n\t=?utf-8?q?zbru2AwPNbO0lp9fzVyzvaZoXMO2VtyzMcunFIdUaVYejsLHvNLfBH/7?=\n\t=?utf-8?q?4K/QTHtWkEkao/W0VhsgKWeQ/CdPJH/wmDVnsN6NHSKRs43yzoEqEkvz?=\n\t=?utf-8?q?iDWDkAGVHOzubc1D0EO73Neqb5N03Uy+taml/MpC+aZzmIcEWrd87oS+?=\n\t=?utf-8?q?ZRyORdNjArZW0u2VqHWzdeOuX15UAOT9g/meCk0gwP61JEdmLM8nfCLe?=\n\t=?utf-8?q?1rM57v2MhiPjcolepz1DkUiZtVRk4sFRt5rpJAdGCBujMupAbvCmFi28?=\n\t=?utf-8?q?oQDqahdUWH9Q/f7B+F2UPFTM5sJvti+NcC+cw8TVMpaq5Pcpb4pwMB54?=\n\t=?utf-8?q?Ocyorlf8HjdMBcSZ/JyisXk6KeGsBSpEce6R4X6kLD4JzBU6H+3ssh8k?=\n\t=?utf-8?q?sItP+t86wjBZkMRiYqGopBYL/jaT6wT+Eh1O9fqawp2us8Q8P8Bz39ei?=\n\t=?utf-8?q?QwkcBwxr+kmEV/GxlEH7uKtFKq1lJ7shFWW4rcxLf9erBwsMXOTGAvqO?=\n\t=?utf-8?q?66XUz83B3uQKtmVdLAGvIjCGxrORzpR/pgcC31hJr2Acgu155DVHjrTP?=\n\t=?utf-8?q?CP7fsGCSpykUdAb8Km8YtQGYH4fNv1O51X/5wQEXXkX1D8jtFs9quvdt?=\n\t=?utf-8?q?1lWtauVEOrutsg82rQ=3D=3D?=","1; HE1PR05MB1801;\n\t6:COj/YXOLUZsKqg7MgtKGYcsSl7I655uX5vDQ99fmSeJwNaEV9XNHRaZzm50NXRFGfpWeruzLlTH1o1KkKDpH2a1SJxB5HV0NPdmvvewyDxutzntGrR4aD0P4HIt+pWq9RdoLq4jphwzychgQKQB7D0aG+/VC8DcQccIhT7lTfsw1G8qq8C1qEFnbUb2mbosElrV6vAeiRDJbNIv4PGS6gCcslHa5oQuFr0IHD88tpyKZ6NLLKqCRk0bgq6iz3VYQkgxP1KBM++Pu3pk8dTRb6vbgZfxGQLIP1eX1z8zIZRUj8fB8xe/X9JG/BGxjGn/CYVF/5T0u0Ml0RLIJQLDrUw==;\n\t5:w8agv/jkJDScNdvBP7uo0RChKzjr5fucTZiPl4ei3X8af8N+xuMtUQ8AStWyDox8GKVibz3OYuE2TqPw356m4C2ZeUTDLANTOM40YqIFAQ/7syW4ILILNMxiX4c6sAYy2d0Tl6OAJtcVQAAwNJyCBQ==;\n\t24:0nmRZHvnFiwKtmNRcIpPg3sUk9G8k/vMqp/8lV7+pf0Q3KaxHD3u4AWqVeWN6WGNGzs7Gjx/YqOJX2PAXaLHI4yRkqmL+zPZm70bPsHfxTY=;\n\t7:SeoCQWocObDmBIbjxD2DHpWQ7Bhq4GekaVPYIYB0lT+Wg3xB8FVzAVm3d+ygeNtoYDEDx1DOVL5H3n0Nu1vhXaCBVRggbiWVZIJq7t8boW9l9aP7dXw93Y8uz+XPveI0SSyPJf6LTmHpTo1M6TUD7l9W0pUxOxcOGbqt06D+g1+vdczKfq6ZbnwqgO9tytO10WMCOGOTGGCJKlK7JpFGWlEXHyB3tty+IVtcViThUpM="],"X-MS-TrafficTypeDiagnostic":"HE1PR05MB1801:","X-Exchange-Antispam-Report-Test":"UriScan:(198206253151910);","X-Microsoft-Antispam-PRVS":"","X-Exchange-Antispam-Report-CFA-Test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(3002001)(6055026)(6041248)(20161123555025)(20161123560025)(20161123562025)(20161123564025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:HE1PR05MB1801; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:HE1PR05MB1801; ","X-Forefront-PRVS":"041963B986","X-Forefront-Antispam-Report":"SFV:NSPM;\n\tSFS:(10009020)(7370300001)(4630300001)(6049001)(6009001)(39860400002)(189002)(24454002)(199003)(377454003)(65826007)(7736002)(478600001)(83506001)(7350300001)(5660300001)(229853002)(53546010)(65806001)(66066001)(31686004)(65956001)(25786009)(6246003)(68736007)(64126003)(53936002)(2906002)(86362001)(54356999)(31696002)(50986999)(4326008)(305945005)(50466002)(76176999)(105586002)(42186005)(230700001)(8676002)(81166006)(81156014)(23676002)(189998001)(3846002)(36756003)(4001350100001)(97736004)(6666003)(6486002)(77096006)(47776003)(33646002)(106356001)(101416001)(6116002)(2950100002);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR05MB1801; H:[10.8.2.253];\n\tFPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; ","Received-SPF":"None (protection.outlook.com: mellanox.com does not designate\n\tpermitted sender hosts)","SpamDiagnosticOutput":"1:99","SpamDiagnosticMetadata":"NSPM","X-OriginatorOrg":"Mellanox.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"03 Sep 2017 07:28:08.3465\n\t(UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"HE1PR05MB1801","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1762314,"web_url":"http://patchwork.ozlabs.org/comment/1762314/","msgid":"<20170903.105738.1741058008003610763.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-03T17:57:38","subject":"Re: [PATCH][next] net/mlx4_core: fix incorrect size allocation for\n\tdev->caps.spec_qps","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Colin King \nDate: Thu, 31 Aug 2017 18:07:24 +0100\n\n> From: Colin Ian King \n> \n> The current allocation for dev->caps.spec_qps is for the size of the\n> pointer and not the size of the actual mlx4_spec_qps structure. Fix\n> this by using the correct size. Also splint allocation over a few\n> lines to make it cppcheck clean on overly wide lines.\n> \n> Detected by CoverityScan, CID#1455222 (\"Wrong sizeof argument\")\n> \n> Fixes: c73c8b1e47ca (\"net/mlx4_core: Dynamically allocate structs at mlx4_slave_cap\")\n> Signed-off-by: Colin Ian King \n\nApplied.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xlggP4wvtz9t43\n\tfor ;\n\tMon, 4 Sep 2017 03:57:53 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753225AbdICR5m (ORCPT );\n\tSun, 3 Sep 2017 13:57:42 -0400","from shards.monkeyblade.net ([184.105.139.130]:56380 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1753099AbdICR5i (ORCPT\n\t); Sun, 3 Sep 2017 13:57:38 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 63B8211E3FF10;\n\tSun, 3 Sep 2017 10:57:38 -0700 (PDT)"],"Date":"Sun, 03 Sep 2017 10:57:38 -0700 (PDT)","Message-Id":"<20170903.105738.1741058008003610763.davem@davemloft.net>","To":"colin.king@canonical.com","Cc":"tariqt@mellanox.com, netdev@vger.kernel.org,\n\tlinux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH][next] net/mlx4_core: fix incorrect size allocation for\n\tdev->caps.spec_qps","From":"David Miller ","In-Reply-To":"<20170831170724.3747-1-colin.king@canonical.com>","References":"<20170831170724.3747-1-colin.king@canonical.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Sun, 03 Sep 2017 10:57:38 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]