[{"id":1767890,"web_url":"http://patchwork.ozlabs.org/comment/1767890/","msgid":"<20170913133618.lclorawve7364xxi@localhost>","list_archive_url":null,"date":"2017-09-13T13:36:18","subject":"Re: [PATCH v2 09/28] arm64/sve: Signal frame and context structure\n\tdefinition","submitter":{"id":938,"url":"http://patchwork.ozlabs.org/api/people/938/","name":"Catalin Marinas","email":"catalin.marinas@arm.com"},"content":"On Thu, Aug 31, 2017 at 06:00:41PM +0100, Dave P Martin wrote:\n> +/*\n> + * The SVE architecture leaves space for future expansion of the\n> + * vector length beyond its initial architectural limit of 2048 bits\n> + * (16 quadwords).\n> + */\n> +#define SVE_VQ_BYTES\t\t0x10\t/* number of bytes per quadword */\n> +\n> +#define SVE_VQ_MIN\t\t1\n> +#define SVE_VQ_MAX\t\t0x200\n\nJust a nitpick (up to you): could you use 16 and 512 here instead of\nhex? I usually associate hex numbers with some bit fields.","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"DAB5pDEw\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsjPW5YS0z9sNV\n\tfor ;\n\tWed, 13 Sep 2017 23:36:47 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1ds7qO-0003E8-OQ; Wed, 13 Sep 2017 13:36:44 +0000","from foss.arm.com ([217.140.101.70])\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1ds7qK-0003Ba-Rn for linux-arm-kernel@lists.infradead.org;\n\tWed, 13 Sep 2017 13:36:42 +0000","from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249])\n\tby usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AA2731596;\n\tWed, 13 Sep 2017 06:36:20 -0700 (PDT)","from localhost (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70])\n\tby usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id\n\t985383F58C; Wed, 13 Sep 2017 06:36:20 -0700 (PDT)","from cmarinas by localhost with local (Exim 4.89)\n\t(envelope-from )\n\tid 1ds7py-0005cL-At; Wed, 13 Sep 2017 06:36:18 -0700"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=AvU2bzac4y1GPO23DhhBoYqdw8zuzbvRBM8IFRg/rs0=;\n\tb=DAB5pDEw36sLD4\n\tKbJvWSb/ZnvtwS+rQ4QqikvOvHXblqSC6aE+VFDk3pjBK3ojZUg6Yjh2sAzUwMVrslpSVkTA8mYe8\n\tGoPSYzennt/4lNaLH4QGsAfxBFzoa5y0pixf7j3GtCra6755cNGCPthSKRN3vItsJAdVYrn3re+vx\n\tZEj25SpPY9yNLWq8pE/EuRYkh+iEj4cERDOpd7N6Y/F92fOPpCvLSttH2sBJKXZNRAcYN7vWJsy+L\n\tCNw9w+8IKlwRUCW9ohtYZgFZdVl9HgQyT4r1vxj39Sg/ld7cLn4XJEunqnCK0oN6wdiyEulK4Ek9O\n\tTnxWAbuREdjI66XEY+Lw==;","Date":"Wed, 13 Sep 2017 06:36:18 -0700","From":"Catalin Marinas ","To":"Dave Martin ","Subject":"Re: [PATCH v2 09/28] arm64/sve: Signal frame and context structure\n\tdefinition","Message-ID":"<20170913133618.lclorawve7364xxi@localhost>","References":"<1504198860-12951-1-git-send-email-Dave.Martin@arm.com>\n\t<1504198860-12951-10-git-send-email-Dave.Martin@arm.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<1504198860-12951-10-git-send-email-Dave.Martin@arm.com>","User-Agent":"NeoMutt/20170113 (1.7.2)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170913_063641_008380_80709D21 ","X-CRM114-Status":"UNSURE ( 7.66 )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-6.9 (------)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-6.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/,\n\thigh trust [217.140.101.70 listed in list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"linux-arch@vger.kernel.org, libc-alpha@sourceware.org, Ard Biesheuvel\n\t, Szabolcs Nagy ,\n\tgdb@sourceware.org, Yao Qi ,\n\tWill Deacon , Richard Sandiford\n\t, Alan Hayward , Alex\n\t=?iso-8859-1?q?Benn=E9e?= ,\n\tkvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1768204,"web_url":"http://patchwork.ozlabs.org/comment/1768204/","msgid":"<20170913213307.GF23415@e103592.cambridge.arm.com>","list_archive_url":null,"date":"2017-09-13T21:33:08","subject":"Re: [PATCH v2 09/28] arm64/sve: Signal frame and context structure\n\tdefinition","submitter":{"id":26612,"url":"http://patchwork.ozlabs.org/api/people/26612/","name":"Dave Martin","email":"Dave.Martin@arm.com"},"content":"On Wed, Sep 13, 2017 at 06:36:18AM -0700, Catalin Marinas wrote:\n> On Thu, Aug 31, 2017 at 06:00:41PM +0100, Dave P Martin wrote:\n> > +/*\n> > + * The SVE architecture leaves space for future expansion of the\n> > + * vector length beyond its initial architectural limit of 2048 bits\n> > + * (16 quadwords).\n> > + */\n> > +#define SVE_VQ_BYTES\t\t0x10\t/* number of bytes per quadword */\n> > +\n> > +#define SVE_VQ_MIN\t\t1\n> > +#define SVE_VQ_MAX\t\t0x200\n> \n> Just a nitpick (up to you): could you use 16 and 512 here instead of\n> hex? I usually associate hex numbers with some bit fields.\n\nI have no strong opinion other than a desire to make these constants\ntypo-proof.\n\nThere's no particular reason why these shouldn't be in decimal, so I can\nchange them if you like, provided you promise to notice if I misspell\n512 as 521...\n\n(git grep 131027)\n\nCheers\n---Dave","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"ouUhSHjT\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsvzm1Vyqz9s81\n\tfor ;\n\tThu, 14 Sep 2017 07:33:40 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dsFHs-0007OR-U5; Wed, 13 Sep 2017 21:33:36 +0000","from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]\n\thelo=foss.arm.com)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dsFHp-0007LI-NK for linux-arm-kernel@lists.infradead.org;\n\tWed, 13 Sep 2017 21:33:35 +0000","from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249])\n\tby usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 05E6D1529;\n\tWed, 13 Sep 2017 14:33:13 -0700 (PDT)","from e103592.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com\n\t[10.72.51.249])\n\tby usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id\n\tBD4233F578; Wed, 13 Sep 2017 14:33:10 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=yo2slMDP139oSYGkLuvZUM/MRi1oYdXNyXxB9sNqlrc=;\n\tb=ouUhSHjTzKgzXj\n\t9PsCxabjan5Wnys5J15cNUa9IHrQB6M979lEzQKohEIrlXh/PO8yGBNLBupzhxyuAZ2FNsaTvssmq\n\tnI5t+1DSUBctveHKIy0Q4+0TwHIQoWfm49y0McMafnz8jCcq5H/ZgZKvAfCT0wGUMd+ArsBK9vu2p\n\tIph9NlC/WJHhgnoJXAEip6U6Vn2NRTLMABJyPFFa1/umgTwUfgrlREmsaDhygesJUZVXYeXAslYH4\n\tZXONe3/0NURLfCfelyp70vWI/0mV7IsndngIMLtu4QSt+nicKbwd76X3HzEukIYIf80BpGampSyq0\n\tYhWZpfeuwUpybmm2X/7Q==;","Date":"Wed, 13 Sep 2017 22:33:08 +0100","From":"Dave Martin ","To":"Catalin Marinas ","Subject":"Re: [PATCH v2 09/28] arm64/sve: Signal frame and context structure\n\tdefinition","Message-ID":"<20170913213307.GF23415@e103592.cambridge.arm.com>","References":"<1504198860-12951-1-git-send-email-Dave.Martin@arm.com>\n\t<1504198860-12951-10-git-send-email-Dave.Martin@arm.com>\n\t<20170913133618.lclorawve7364xxi@localhost>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20170913133618.lclorawve7364xxi@localhost>","User-Agent":"Mutt/1.5.23 (2014-03-12)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170913_143333_777377_BCBAD449 ","X-CRM114-Status":"UNSURE ( 9.98 )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-6.9 (------)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-6.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/,\n\thigh trust [217.140.101.70 listed in list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"linux-arch@vger.kernel.org, libc-alpha@sourceware.org, Ard Biesheuvel\n\t, Szabolcs Nagy ,\n\tgdb@sourceware.org, Yao Qi ,\n\tAlan Hayward , Will Deacon , \n\tRichard Sandiford , Alex\n\t=?iso-8859-1?q?Benn=E9e?= ,\n\tkvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}}]